[
https://issues.apache.org/jira/browse/FLINK-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423367#comment-16423367
]
Triones Deng edited comment on FLINK-9087 at 4/3/18 1:59 AM:
-------------------------------------------------------------
[~yuzhih...@gmail.com] I notice that RecordWriter.broadcastEvent() is called
in StreamTask., RecordWriterOutput ,IterationIntermediateTask and
IterationHeadTaskbroadcastEvent, also notice that no one make use of the
BufferConsumer returned by broadcastEvent(), so i think the better way to close
the return value in RecordWriter. change the method signature from
BufferConsumer to void， and close the BufferConsumer in the end. does this make
sense? what's you idea?
was (Author: triones):
[~yuzhih...@gmail.com] notice that RecordWriter.broadcastEvent() is called in
StreamTask., RecordWriterOutput ,IterationIntermediateTask and
IterationHeadTaskbroadcastEvent, also notice that no one make use of the
BufferConsumer returned by broadcastEvent(), so i think the better way to close
the return value in RecordWriter. change the method signature from
BufferConsumer to void， and close the BufferConsumer in the end. does this make
sense? what's you idea?
> Return value of broadcastEvent should be closed in
> StreamTask#performCheckpoint
> -------------------------------------------------------------------------------
>
> Key: FLINK-9087
> URL: https://issues.apache.org/jira/browse/FLINK-9087
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> for (StreamRecordWriter<SerializationDelegate<StreamRecord<OUT>>>
> streamRecordWriter : streamRecordWriters) {
> try {
> streamRecordWriter.broadcastEvent(message);
> {code}
> The BufferConsumer returned by broadcastEvent() should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
