[ 
https://issues.apache.org/jira/browse/FLINK-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922478#comment-16922478
 ] 

Leonard Xu commented on FLINK-13382:
------------------------------------

[~jark]I am glad to fix this

> Port DecimalITCase to unit tests
> --------------------------------
>
>                 Key: FLINK-13382
>                 URL: https://issues.apache.org/jira/browse/FLINK-13382
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Jark Wu
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> There are 81 query tests in 
> {{org.apache.flink.table.runtime.batch.sql.DecimalITCase}} and 67 query tests 
> in {{org.apache.flink.table.runtime.batch.table.DecimalITCase}}. 
> Note that each query will be executed on a MiniCluster which will consume a 
> lot of testing time. However, decimals can be tested as unit tests similar to 
> other Scalar functions tests.
> So I would suggest to move Decimal IT cases to unit tests 
> {{org.apache.flink.table.expressions.DecimalTypeTest}}. This should save much 
> testing time. 
> In the meanwhile, IMO, this is not required by 1.9 release. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to