[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-09 Thread Jeff Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992116#comment-16992116 ] Jeff Zhang commented on FLINK-15129: Return JobClient directly make more sense for me. > Return

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-09 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991774#comment-16991774 ] Aljoscha Krettek commented on FLINK-15129: -- Ok, I didn't see that, there's too many PRs by now.

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-09 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991733#comment-16991733 ] Zili Chen commented on FLINK-15129: --- As in the pull request of {{JobListener}} I agree that we return

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-09 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991705#comment-16991705 ] Aljoscha Krettek commented on FLINK-15129: -- This raises the interesting point, that it is a bit

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-09 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991601#comment-16991601 ] Aljoscha Krettek commented on FLINK-15129: -- I noticed one problem, if we return a Future and

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-08 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990806#comment-16990806 ] Aljoscha Krettek commented on FLINK-15129: -- You're right, I forgot about that. I'm also

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-08 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990794#comment-16990794 ] Zili Chen commented on FLINK-15129: --- "but currently we always return an already completed future that

[jira] [Commented] (FLINK-15129) Return JobClient instead of JobClient Future from executeAsync()

2019-12-08 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990773#comment-16990773 ] Aljoscha Krettek commented on FLINK-15129: -- cc [~kkloudas] [~tison] [~zjffdu] What do you think