[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-06-14 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135378#comment-17135378 ] Yun Wang commented on FLINK-17623: -- Cheers  > Elasticsearch sink should support user resource cleanup

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-06-11 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133819#comment-17133819 ] Yun Wang commented on FLINK-17623: -- PR created: [https://github.com/apache/flink/pull/12619]. >

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-06-11 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133561#comment-17133561 ] Yun Wang commented on FLINK-17623: -- I'm okay with only exposing the default {{close()}} method for now.

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-06-10 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132840#comment-17132840 ] Jark Wu commented on FLINK-17623: - +1 to expose a default {{close()}} method. I think it maybe not good

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-06-10 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132829#comment-17132829 ] Leonard Xu commented on FLINK-17623: I'm fine with this improvement and expose a default `close`

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-06-10 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132781#comment-17132781 ] Yun Wang commented on FLINK-17623: -- Any update on this issue? I can work on it if you don't have cycles

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-18 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110770#comment-17110770 ] Yangze Guo commented on FLINK-17623: Sorry for the belated response. In this case, I would choose

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-15 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108771#comment-17108771 ] Yun Wang commented on FLINK-17623: -- The more I think about it, my preferred solution would be: make the 

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-12 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105837#comment-17105837 ] Yun Wang commented on FLINK-17623: -- [~Leonard Xu] Sure! What I'm trying to achieve is: make synchronous

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-12 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105161#comment-17105161 ] Leonard Xu commented on FLINK-17623: Hi [~yunw]        I got your point, currently

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105082#comment-17105082 ] Yangze Guo commented on FLINK-17623: I think it could be a valid demand. Not sure does it make sense

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-11 Thread Yun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105055#comment-17105055 ] Yun Wang commented on FLINK-17623: -- [~karmagyz] Ah I was using {{RestHighLevelClient}} as an example,

[jira] [Commented] (FLINK-17623) Elasticsearch sink should support user resource cleanup

2020-05-11 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105003#comment-17105003 ] Yangze Guo commented on FLINK-17623: It seems the {{RestHighLevelClient}} is closed by