[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-16 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138115#comment-17138115 ] godfrey he commented on FLINK-18070: we need to materialize time attribute only in sink-block. >

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-16 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138114#comment-17138114 ] godfrey he commented on FLINK-18070: [~liuyufei] Thanks for reporting this. the simple approach to

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138087#comment-17138087 ] Jark Wu commented on FLINK-18070: - cc [~godfreyhe] > Time attribute been materialized after sub graph

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-05 Thread YufeiLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126599#comment-17126599 ] YufeiLiu commented on FLINK-18070: -- I still didn't get it, could you give me a example about this

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126322#comment-17126322 ] Benchao Li commented on FLINK-18070: As you can see, we only convert the time attributes from the

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-04 Thread YufeiLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125952#comment-17125952 ] YufeiLiu commented on FLINK-18070: -- [~libenchao] process time have already been materialized at

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125873#comment-17125873 ] Benchao Li commented on FLINK-18070: [~liuyufei] we need to materialize the proctime time if we need

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-04 Thread YufeiLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125587#comment-17125587 ] YufeiLiu commented on FLINK-18070: -- [~libenchao] I feel uncertain about why we need "_materialize

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-03 Thread YufeiLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124894#comment-17124894 ] YufeiLiu commented on FLINK-18070: -- [~libenchao] Sure, I'd love to contribute. Please assign this issue

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-03 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124763#comment-17124763 ] Benchao Li commented on FLINK-18070: [~liuyufei] Do you want to contribute to this issue? If you

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-03 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124735#comment-17124735 ] Jark Wu commented on FLINK-18070: - Yes, I think this is a bug in CommonSubGraphBasedOptimizer. > Time

[jira] [Commented] (FLINK-18070) Time attribute been materialized after sub graph optimize

2020-06-03 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124713#comment-17124713 ] Benchao Li commented on FLINK-18070: [~liuyufei] Thanks for reporting this issue, I also verified