[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-15 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700564#comment-17700564 ] luoyuxia commented on FLINK-31368: -- [~jark] I have created FLINK-31464 for `SqlToOperationConverter`.

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700500#comment-17700500 ] Jark Wu commented on FLINK-31368: - [~luoyuxia], you are right. I think we can create another issue for

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-14 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700458#comment-17700458 ] luoyuxia commented on FLINK-31368: -- [~jark] Also noticed `SqlToOperationConverter` has a similiar

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700056#comment-17700056 ] Jark Wu commented on FLINK-31368: - Thank you all. I will create sub-tasks and work on it. > Move

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-13 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699627#comment-17699627 ] Timo Walther commented on FLINK-31368: -- I like the {{ExecutableOperation}} interface. However, a

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-09 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698429#comment-17698429 ] Jark Wu commented on FLINK-31368: - [~twalthr], thank you for your idea. Another idea is colocating the

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-09 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698281#comment-17698281 ] Timo Walther commented on FLINK-31368: -- Big +1 on this. We cleaned TableEnvironment during the

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697868#comment-17697868 ] lincoln lee commented on FLINK-31368: - [~jark] +1 for this refactoring, it will prevent the

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-08 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697820#comment-17697820 ] Jark Wu commented on FLINK-31368: - Hi [~zjureel], this is another topic. I think if an Operation can be

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-08 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697814#comment-17697814 ] Shammon commented on FLINK-31368: - Hi [~jark] +1 for this proposal. In fact, there are similar problems

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-08 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697797#comment-17697797 ] Jark Wu commented on FLINK-31368: - cc [~lincoln.86xy] [~twalthr], what do you think about this? > Move