[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779150#comment-17779150 ] Jing Ge commented on FLINK-33301: - The value(my intention) is to fail faster before maven is called,

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779122#comment-17779122 ] Matthias Pohl commented on FLINK-33301: --- {quote} Yes, using pom to control the versions centrally

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779101#comment-17779101 ] Jing Ge commented on FLINK-33301: - Thanks for sharing your thoughts. I am trying to share my experience

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779085#comment-17779085 ] Matthias Pohl commented on FLINK-33301: --- I see where you're coming from. I feel like the check has

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779076#comment-17779076 ] Jing Ge commented on FLINK-33301: - Commonly speaking, as a release manager, I'd like to literally know

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-24 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779070#comment-17779070 ] Jing Ge commented on FLINK-33301: - I didn't read through all the source code, but from the naming used,

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778692#comment-17778692 ] Matthias Pohl commented on FLINK-33301: --- Aren't those the ones that were created and deployed with

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778591#comment-17778591 ] Jing Ge commented on FLINK-33301: - There are some pre-built jars. Let me copy the reply from [~yunta] :

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1817#comment-1817 ] Matthias Pohl commented on FLINK-33301: ---

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-19 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1107#comment-1107 ] Jing Ge commented on FLINK-33301: - Afaik, create_source_release.sh (and better deploy_staging_jars.sh,

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776670#comment-17776670 ] Matthias Pohl commented on FLINK-33301: --- {{-Prelease}} is also activated when building the

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776640#comment-17776640 ] Jing Ge commented on FLINK-33301: - The document said -Prelease was one optional step. For folks who did

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776613#comment-17776613 ] Matthias Pohl commented on FLINK-33301: --- On another note: Shouldn't the Fix Version only be

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-18 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776611#comment-17776611 ] Matthias Pohl commented on FLINK-33301: --- Isn't this only required when building the artifacts? The