[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448497#comment-15448497 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg closed the pull request at:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448498#comment-15448498 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448459#comment-15448459 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439249#comment-15439249 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438770#comment-15438770 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391952#comment-15391952 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391934#comment-15391934 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391842#comment-15391842 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391765#comment-15391765 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391760#comment-15391760 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391647#comment-15391647 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391621#comment-15391621 ] ASF GitHub Bot commented on FLINK-4190: --- Github user joshfg commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387961#comment-15387961 ] Josh Forman-Gornall commented on FLINK-4190: Thanks! Oh nice, this looks like a better

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387767#comment-15387767 ] ASF GitHub Bot commented on FLINK-4190: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384302#comment-15384302 ] Josh Forman-Gornall commented on FLINK-4190: Hmm it is showing up here for me as a "links

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384249#comment-15384249 ] Aljoscha Krettek commented on FLINK-4190: - Did you open the PR with the correct FLINK-4190 tag?

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384250#comment-15384250 ] Aljoscha Krettek commented on FLINK-4190: - Did you open the PR with the correct FLINK-4190 tag?

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384206#comment-15384206 ] Josh Forman-Gornall commented on FLINK-4190: Ok cool, thanks! I've just submitted a pull

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382297#comment-15382297 ] Aljoscha Krettek commented on FLINK-4190: - I think checking in invoke is the right thing to do.

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374589#comment-15374589 ] Josh Forman-Gornall commented on FLINK-4190: Ok I'll do that. Can you see any issues with the

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374568#comment-15374568 ] Aljoscha Krettek commented on FLINK-4190: - What you could also do is create a new package and put

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372902#comment-15372902 ] Josh Forman-Gornall commented on FLINK-4190: I've made those changes to my branch - I also

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372649#comment-15372649 ] Josh Forman-Gornall commented on FLINK-4190: Ah yeah that's a good point! I'll add the

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371342#comment-15371342 ] Aljoscha Krettek commented on FLINK-4190: - I'm very happy you're working on this! What I would

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370921#comment-15370921 ] Josh Forman-Gornall commented on FLINK-4190: I needed this feature and already have a working

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370596#comment-15370596 ] Josh Forman-Gornall commented on FLINK-4190: I needed this feature and already have a working