[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831800#comment-15831800 ] ASF GitHub Bot commented on FLINK-5386: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831768#comment-15831768 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831354#comment-15831354 ] ASF GitHub Bot commented on FLINK-5386: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1582#comment-1582 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830002#comment-15830002 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1583#comment-1583 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829997#comment-15829997 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829998#comment-15829998 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830001#comment-15830001 ] ASF GitHub Bot commented on FLINK-5386: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-18 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828474#comment-15828474 ] sunjincheng commented on FLINK-5386: Hi [~fhueske] sorry for the delayed reply According to our

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827654#comment-15827654 ] Fabian Hueske commented on FLINK-5386: -- I think it would be good to get a fix for this soon to

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-17 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826380#comment-15826380 ] Shaoxuan Wang commented on FLINK-5386: -- Yes [~fhueske], we should not support groupby() without keys

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-17 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826155#comment-15826155 ] sunjincheng commented on FLINK-5386: The first approach +1 > Refactoring Window Clause >

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826006#comment-15826006 ] Fabian Hueske commented on FLINK-5386: -- Yes, that's what I would propose. {{GroupedTable}} has an

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-17 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825955#comment-15825955 ] sunjincheng commented on FLINK-5386: Hi [~fhueske] Thank you for the detailed explanation!!! If I

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825660#comment-15825660 ] Fabian Hueske commented on FLINK-5386: -- Hi [~sunjincheng121], thanks for the reply. My concerns are

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825546#comment-15825546 ] sunjincheng commented on FLINK-5386: Hi [~fhueske] [~shaoxuan] thanks for the reply . [~fhueske] You

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-16 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824844#comment-15824844 ] Shaoxuan Wang commented on FLINK-5386: -- [~sunjincheng121], thanks for the updates. Hi [~fhueske],

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-10 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814699#comment-15814699 ] Fabian Hueske commented on FLINK-5386: -- Hi, sorry for the delayed reply. I like the idea of making

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814273#comment-15814273 ] ASF GitHub Bot commented on FLINK-5386: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812931#comment-15812931 ] ASF GitHub Bot commented on FLINK-5386: --- Github user shaoxuan-wang commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812507#comment-15812507 ] ASF GitHub Bot commented on FLINK-5386: --- Github user shaoxuan-wang commented on a diff in the pull

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2016-12-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779639#comment-15779639 ] ASF GitHub Bot commented on FLINK-5386: --- GitHub user sunjincheng121 opened a pull request: