[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146024#comment-16146024
]
ASF GitHub Bot commented on FLINK-7398:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145393#comment-16145393
]
ASF GitHub Bot commented on FLINK-7398:
---
Github user fhueske commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139145#comment-16139145
]
ASF GitHub Bot commented on FLINK-7398:
---
GitHub user haohui opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137250#comment-16137250
]
Jacob Park commented on FLINK-7398:
---
+1 for the checkstyle rule.
> Table API operators/UDFs must not
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136280#comment-16136280
]
Haohui Mai commented on FLINK-7398:
---
+1 on logging trait. I'll submit a PR.
Adding a checkstyle rule is
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136140#comment-16136140
]
Jark Wu commented on FLINK-7398:
+1 Logging trait.
BTW, I think to avoid the misusage of {{LOG}} by
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121753#comment-16121753
]
Fabian Hueske commented on FLINK-7398:
--
+1 [~jark], if we decide to port the runtime code, we can do
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121545#comment-16121545
]
Jark Wu commented on FLINK-7398:
Porting to Java is not related to this issue. I have the idea for a long
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121265#comment-16121265
]
Haohui Mai commented on FLINK-7398:
---
Putting in a companion object is an viable option. My worry,
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121259#comment-16121259
]
Aljoscha Krettek commented on FLINK-7398:
-
I agree with both [~fhueske] and [~jark]. In Java, this
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121234#comment-16121234
]
Fabian Hueske commented on FLINK-7398:
--
In Scala you can make the field {{transient}} and initialize
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121219#comment-16121219
]
Jark Wu commented on FLINK-7398:
[~fhueske] in Java, we will set the Logger as static final which will not
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121204#comment-16121204
]
Fabian Hueske commented on FLINK-7398:
--
This issue would happen with Java as well. It is not related
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120928#comment-16120928
]
Jark Wu commented on FLINK-7398:
[~wheat9] how do you want to fix it?
> Table API operators/UDFs must
[
https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120536#comment-16120536
]
Haohui Mai commented on FLINK-7398:
---
Good catch!
I think we can fix it for once but I'm more worried
15 matches
Mail list logo
