masteryhx closed pull request #21635: [FLINK-30613] Improve resolving schema
compatibility -- Milestone one
URL: https://github.com/apache/flink/pull/21635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1884161683
Thanks all for the detailed review.
Please let me know if any other comments.
I will merge it if no other comments beyond two days from now on.
--
This is an automated message
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879978170
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195427714。
想了解更多与开发相关主题的信息，请访问
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879977820
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195426596。
想了解更多与开发相关主题的信息，请访问
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879977455
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195425319。
想了解更多与开发相关主题的信息，请访问
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879977057
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195424272。
想了解更多与开发相关主题的信息，请访问
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879976379
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195422930。
想了解更多与开发相关主题的信息，请访问
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879975977
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195421822。
想了解更多与开发相关主题的信息，请访问
llkj1 commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879975416
感谢您与我们联系。(Thank you for contacting us.)
我们收到了您的请求，并会在一至两个工作日内给您回复。您的案例编号是 102195420550。
想了解更多与开发相关主题的信息，请访问
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879974970
@1996fanrui @Zakelly Thanks for the review. I have updated remaining minor
comments.
The failed CI about python occurs from yesterday (see other [failed
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1879934580
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1427799403
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java:
##
@@ -124,11 +124,40 @@ void readSnapshot(int readVersion,
1996fanrui commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1427798414
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java:
##
@@ -124,11 +124,40 @@ void readSnapshot(int readVersion,
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1857189693
> Hi @masteryhx , sorry for the late reply!
>
> After reading your PR, I finally figured out why the default
implementation of old method and new method should call each other. I
masteryhx commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1427497404
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java:
##
@@ -124,11 +124,40 @@ void readSnapshot(int readVersion,
1996fanrui commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1427479694
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java:
##
@@ -124,11 +124,40 @@ void readSnapshot(int readVersion,
Zakelly commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1856242365
Hi @masteryhx , sorry for the late reply!
After reading your PR, I finally figured out why the default implementation
of old method and new method should call each other. I think
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1855044542
> Hi @masteryhx , thanks for the contribution and update!
>
> I have reviewed this PR and left some comments. Please take a look in your
free time, thanks~
>
> Also, `The
masteryhx commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1426111500
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java:
##
@@ -1244,8 +1244,8 @@ void
masteryhx commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1426110489
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java:
##
@@ -124,11 +124,40 @@ void readSnapshot(int readVersion,
masteryhx commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1426108037
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java:
##
@@ -124,11 +124,40 @@ void readSnapshot(int readVersion,
1996fanrui commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1422192659
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java:
##
@@ -1244,8 +1244,8 @@ void
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1827061892
> Thanks @masteryhx for the contribution!
>
> I didn't finish the review, and left some minor comments. Please take a
look in your free time, thanks~
Thanks a lot for your
masteryhx commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1405573786
##
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerUtil.java:
##
@@ -34,21 +34,21 @@ public class CompositeTypeSerializerUtil {
1996fanrui commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1402925601
##
docs/content.zh/docs/dev/datastream/fault-tolerance/serialization/custom_serialization.md:
##
@@ -442,4 +445,23 @@ migrate from the old abstractions. The steps
masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1803157270
rebased.
@Zakelly Could you also help to take a look ? Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
26 matches
Mail list logo
