zhuzhurk closed pull request #24475: [FLINK-32513][core] Add predecessor caching
URL: https://github.com/apache/flink/pull/24475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jeyhunkarimov commented on PR #24475:
URL: https://github.com/apache/flink/pull/24475#issuecomment-2014868333
> Looks good to me. Thanks for addressing all the comments! @jeyhunkarimov
Would you squash the last two commits and rebase the changes onto the latest
Flink master branch?
zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1533318682
##
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/transformations/GetTransitivePredecessorsTest.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the
jeyhunkarimov commented on PR #24475:
URL: https://github.com/apache/flink/pull/24475#issuecomment-2002153186
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jeyhunkarimov commented on PR #24475:
URL: https://github.com/apache/flink/pull/24475#issuecomment-2002135965
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jeyhunkarimov commented on PR #24475:
URL: https://github.com/apache/flink/pull/24475#issuecomment-2002128082
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1524777467
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/AbstractMultipleInputTransformation.java:
##
@@ -76,10 +78,10 @@ public
zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1524746682
##
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java:
##
@@ -125,19 +145,34 @@ public void
zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1524742606
##
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java:
##
@@ -42,10 +43,21 @@
public class TransformationTest extends TestLogger {
zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1524746682
##
flink-core/src/test/java/org/apache/flink/api/dag/TransformationTest.java:
##
@@ -125,19 +145,34 @@ public void
jeyhunkarimov commented on PR #24475:
URL: https://github.com/apache/flink/pull/24475#issuecomment-1990782761
Thanks @zhuzhurk for the review. I addressed them. Could you please check
again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
zhuzhurk commented on code in PR #24475:
URL: https://github.com/apache/flink/pull/24475#discussion_r1519708804
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/AbstractMultipleInputTransformation.java:
##
@@ -76,7 +76,7 @@ public
jeyhunkarimov commented on PR #24475:
URL: https://github.com/apache/flink/pull/24475#issuecomment-1987359390
Hi @zhuzhurk could you please review the PR in you available time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
13 matches
Mail list logo
