LadyForest merged PR #23668:
URL: https://github.com/apache/flink/pull/23668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
LadyForest merged PR #23669:
URL: https://github.com/apache/flink/pull/23669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on PR #23669:
URL: https://github.com/apache/flink/pull/23669#issuecomment-1794180188
## CI report:
* 2779239ff7d889f0a15dd837609dbb900b9bc693 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
flinkbot commented on PR #23668:
URL: https://github.com/apache/flink/pull/23668#issuecomment-1794179424
## CI report:
* 8cf6ef0c8e877dfc01984cef744382ad6d68ea97 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1794179250
> Hi @fengjiajie, could you pick the fix to branch release-1.18 and
release-1.17 as well?
Hi @LadyForest , thank you for moving this forward. cherry-picks to 1.17 and
1.18:
LadyForest commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1794159224
Hi @fengjiajie, could you pick the fix to branch release-1.18 and
release-1.17 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message,
LadyForest merged PR #23478:
URL: https://github.com/apache/flink/pull/23478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
LadyForest commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1793681676
> @lincoln-lil @LadyForest When you have time, please take a look if any
further modifications are needed, thanks.
I'm sorry for the late reply; I'll take a look as soon as
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1792143248
@lincoln-lil @LadyForest When you have time, please take a look if any
further modifications are needed, thanks.
--
This is an automated message from the Apache Git Service.
To
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1776952523
@LadyForest Thank you for helping troubleshoot the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
LadyForest commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1369833456
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -403,47 +445,71 @@ object
LadyForest commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1368880765
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -345,44 +345,86 @@ object
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1775428180
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1775246263
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1774955380
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
LadyForest commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1774684679
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1771947970
> Thanks for the update, looks good to me in general, and I just left some
minor comments.
Thank you for the suggestion. It has been modified.
--
This is an automated message
LadyForest commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1365165868
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##
@@ -345,44 +345,83 @@ object
LadyForest commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1770498589
> newRelDataType
> > @lincoln-lil Thank you for your review. Are the 5 datatypes you
mentioned referring to DATE, TIME_WITHOUT_TIME_ZONE,
TIMESTAMP_WITHOUT_TIME_ZONE,
LadyForest commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1767854974
> > 1. When constructing "non-comparable types," there is no problem with
`testSqlApi("NULL = f30", "NULL")`, but `testSqlApi("NULL = f30", "NULL")`
throws an exception:
> >
lincoln-lil commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1766456638
> 1. When constructing "non-comparable types," there is no problem with
`testSqlApi("NULL = f30", "NULL")`, but `testSqlApi("NULL = f30", "NULL")`
throws an exception:
>
fengjiajie commented on PR #23478:
URL: https://github.com/apache/flink/pull/23478#issuecomment-1764364941
1. When constructing "non-comparable types," there is no problem with
`testSqlApi("NULL = f30", "NULL")`, but `testSqlApi("NULL = f30", "NULL")`
throws an exception:
```Caused
22 matches
Mail list logo
