Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-06 Thread via GitHub
1996fanrui merged PR #24257: URL: https://github.com/apache/flink/pull/24257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-06 Thread via GitHub
1996fanrui commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1931352108 The master branch has been cut to 1.20, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-03 Thread via GitHub
caicancai commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925552439 Thank you for your review and patient reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-03 Thread via GitHub
1996fanrui commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925301702 > org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerConfigurationBuilder I saw that some classes are used, are you sure to delete them? It seems my IDEA doesn't

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-03 Thread via GitHub
caicancai commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925300907 > After I check, I think there are other classes can be removed as well, such as: > > * TaskManagerRegistration > > * Note: It's

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-02 Thread via GitHub
caicancai commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925163414 @RocMarshal @1996fanrui If you have time, can you help me review it? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-02 Thread via GitHub
caicancai commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925162917 related to https://issues.apache.org/jira/browse/FLINK-31449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-02 Thread via GitHub
flinkbot commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925162848 ## CI report: * 38fe004b350cad98d065f0619409fcf120de8c69 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`