KarmaGYZ merged PR #24325:
URL: https://github.com/apache/flink/pull/24325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
KarmaGYZ commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494398967
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +202,58 @@ void
KarmaGYZ commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494398967
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +202,58 @@ void
XComp commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494349521
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +202,58 @@ void
XComp commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494349521
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +202,58 @@ void
KarmaGYZ commented on PR #24325:
URL: https://github.com/apache/flink/pull/24325#issuecomment-1952101142
@XComp Thanks for the review. PR updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
KarmaGYZ commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494278123
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +216,65 @@ void
KarmaGYZ commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494278123
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +216,65 @@ void
XComp commented on code in PR #24325:
URL: https://github.com/apache/flink/pull/24325#discussion_r1494179385
##
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java:
##
@@ -216,6 +216,65 @@ void
KarmaGYZ commented on PR #24325:
URL: https://github.com/apache/flink/pull/24325#issuecomment-1951924419
@XComp testAllocationUpdatesIgnoredIfSlotRemoved added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
XComp commented on PR #24325:
URL: https://github.com/apache/flink/pull/24325#issuecomment-1951906354
Thanks, @KarmaGYZ . Would it make sense to add a test case for this
scenario? This code path doesn't seem to be covered, yet. :thinking:
--
This is an automated message from the Apache
flinkbot commented on PR #24325:
URL: https://github.com/apache/flink/pull/24325#issuecomment-1951607706
## CI report:
* ea75f2c6dedfdebef152e55eb0313a4489f4338e UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
12 matches
Mail list logo
