[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60825706 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60825742 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60825740 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60825677 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60825678 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60825532 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60828180 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1911#discussion_r60828156 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request: [FLINK-3777] Managed closeInputFormat()

2016-04-23 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/1903#discussion_r60828060 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/InputFormatVertex.java --- @@ -82,9 +82,6 @@ public void

[GitHub] flink pull request: [FLINK-3229] Flink streaming consumer for AWS ...

2016-04-23 Thread tzulitai
Github user tzulitai commented on the pull request: https://github.com/apache/flink/pull/1911#issuecomment-213736435 @rmetzger I've addressed your comments with the latest commits. Thanks in advance for your help on reviewing them :) Please let me know if there is anything else to