Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399389
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399431
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348274#comment-15348274
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348279#comment-15348279
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399467
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68400596
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68403594
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348327#comment-15348327
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68404148
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348335#comment-15348335
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user zentol commented on the issue:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68406562
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/Utils.java
---
@@ -0,0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68406625
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
Greg Hogan created FLINK-4117:
-
Summary: Wait for CuratorFramework connection to be established
Key: FLINK-4117
URL: https://issues.apache.org/jira/browse/FLINK-4117
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348364#comment-15348364
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68396189
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue() {
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348255#comment-15348255
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68397478
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348280#comment-15348280
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348295#comment-15348295
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348293#comment-15348293
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68400657
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68403918
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348350#comment-15348350
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348353#comment-15348353
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2128
I wanted to avoid this bit of duplication, but I have no strong preferences
for that. Will remove this static method.
---
If your project is set up for it, you can reply to this email and have
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68406896
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68408173
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348243#comment-15348243
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348281#comment-15348281
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399454
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas reopened FLINK-4075:
---
It reappeared here:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/139523725/log.txt
>
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348323#comment-15348323
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2145
@tillrohrmann I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348342#comment-15348342
]
Chesnay Schepler commented on FLINK-4113:
-
under which circumstances can this occur and why is it
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348349#comment-15348349
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348356#comment-15348356
]
Greg Hogan commented on FLINK-4113:
---
I experienced the problem when verifying the
[
https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348283#comment-15348283
]
ramkrishna.s.vasudevan commented on FLINK-3397:
---
I checked this JIRA and the one prior to
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348310#comment-15348310
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68402254
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348318#comment-15348318
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348354#comment-15348354
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348158#comment-15348158
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348040#comment-15348040
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2105
@tillrohrmann Addressed all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'll review your change now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2109
Hello @mushketyk and sorry for the late response.
Great that you are working on that also for the Batch API!
Recently we introduced in the Streaming API (not batch) the notion of
[
https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348193#comment-15348193
]
ASF GitHub Bot commented on FLINK-3677:
---
Github user kl0u commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348210#comment-15348210
]
ASF GitHub Bot commented on FLINK-3942:
---
GitHub user wuchong opened a pull request:
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2159
[FLINK-3942] [tableAPI] Add support for INTERSECT
Internally, I translate INTERSECT into a Join on all fields and then a
distinct for removing duplicate records.
As Calcite SQL Parser
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2071#discussion_r68386857
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java
---
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348168#comment-15348168
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348231#comment-15348231
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2159
I think you need to update documentation for this page:
https://ci.apache.org/projects/flink/flink-docs-master/apis/table.html
regarding newly added operations.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/FLINK-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348022#comment-15348022
]
Chesnay Schepler commented on FLINK-3962:
-
this can easily happen for streaming jobs. The current
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2158
[FLINK-4116] Metrics documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink metrics_docs
Alternatively you can review and
Chesnay Schepler created FLINK-4116:
---
Summary: Document metrics
Key: FLINK-4116
URL: https://issues.apache.org/jira/browse/FLINK-4116
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-3834:
Assignee: (was: Chesnay Schepler)
> flink-statebackend-rocksdb
>
[
https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348094#comment-15348094
]
ASF GitHub Bot commented on FLINK-4116:
---
GitHub user zentol opened a pull request:
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409807
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68412025
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68413466
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348412#comment-15348412
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68414043
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348376#comment-15348376
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348395#comment-15348395
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348404#comment-15348404
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348407#comment-15348407
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68412669
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
[
https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347577#comment-15347577
]
Geoffrey Mon edited comment on FLINK-4098 at 6/24/16 3:34 PM:
--
Thanks for the
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348477#comment-15348477
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348383#comment-15348383
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409331
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409932
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348387#comment-15348387
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348386#comment-15348386
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68408986
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68410216
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348389#comment-15348389
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68411242
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348419#comment-15348419
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user mjsax commented on the issue:
https://github.com/apache/flink/pull/1813
Please address last comment. Otherwise, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348422#comment-15348422
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user mjsax commented on the issue:
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2071#discussion_r68420387
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2071
Thank you for reviewing this @rmetzger. Should I address your comment after
the rework in https://github.com/apache/flink/pull/2131 is merged, and rebase
this PR on that?
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348482#comment-15348482
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user tzulitai commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
Okay, sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348522#comment-15348522
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2071
Yes, I would suggest to do this PR after the big one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348516#comment-15348516
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on the issue:
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger Thank you! No problem, I can wait and address the current
comments meanwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348529#comment-15348529
]
Chesnay Schepler commented on FLINK-4098:
-
huh. As far as i can tell, every call to next() in
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm not done with the review yet. I hope I find some time over the weekend
to continue with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348503#comment-15348503
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348502#comment-15348502
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user rmetzger commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user subhankarb commented on the issue:
https://github.com/apache/flink/pull/1813
done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
1 - 100 of 151 matches
Mail list logo
