[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377124#comment-15377124 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70827999 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377127#comment-15377127 ] ASF GitHub Bot commented on FLINK-4186: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70828069 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70827977 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java ---

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377131#comment-15377131 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377134#comment-15377134 ] ASF GitHub Bot commented on FLINK-4186: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-4204) Clean up gelly-examples

2016-07-14 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376917#comment-15376917 ] Greg Hogan commented on FLINK-4204: --- Like Steve Jobs' iPods, I think Gelly should ship with charged

[jira] [Commented] (FLINK-4196) Remove "recoveryTimestamp"

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376929#comment-15376929 ] ASF GitHub Bot commented on FLINK-4196: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377036#comment-15377036 ] ASF GitHub Bot commented on FLINK-4035: --- Github user radekg commented on the issue:

[jira] [Commented] (FLINK-4216) WordWithCount example with Java has wrong generics type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377116#comment-15377116 ] ASF GitHub Bot commented on FLINK-4216: --- Github user serhiy commented on the issue:

[jira] [Created] (FLINK-4217) Gelly drivers should read CSV values as strings

2016-07-14 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4217: - Summary: Gelly drivers should read CSV values as strings Key: FLINK-4217 URL: https://issues.apache.org/jira/browse/FLINK-4217 Project: Flink Issue Type:

[jira] [Commented] (FLINK-4067) Add version header to savepoints

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376926#comment-15376926 ] ASF GitHub Bot commented on FLINK-4067: --- Github user uce commented on the issue:

[GitHub] flink issue #2243: [FLINK-4196] [runtime] Remove recovery timestamp from che...

2016-07-14 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2243 Changes look good. Travis build failure is unrelated in two jobs of the build. +1 to merge, commit c738fcd has a typo in the commit message though (missing `e` at the end of `[runtim]`) ---

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70828017 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70828051 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377130#comment-15377130 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377128#comment-15377128 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377132#comment-15377132 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[jira] [Created] (FLINK-4218) Sporadic "java.lang.RuntimeException: Error triggering a checkpoint..." causes task restarting

2016-07-14 Thread Sergii Koshel (JIRA)
Sergii Koshel created FLINK-4218: Summary: Sporadic "java.lang.RuntimeException: Error triggering a checkpoint..." causes task restarting Key: FLINK-4218 URL: https://issues.apache.org/jira/browse/FLINK-4218

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2236 I fixed the failing build and addressed all comments so far ;) (I was working on the code while you've reviewed it ) --- If your project is set up for it, you can reply to this email and have your

[jira] [Updated] (FLINK-4218) Sporadic "java.lang.RuntimeException: Error triggering a checkpoint..." causes task restarting

2016-07-14 Thread Sergii Koshel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergii Koshel updated FLINK-4218: - Description: Sporadically see exception as below. And restart of task because of it.

[GitHub] flink issue #2194: [FLINK-4067] [runtime] Add savepoint headers

2016-07-14 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2194 After talking with @tillrohrmann and @StephanEwen, we discovered some obvious cases where restoring from 1.0 savepoints won't work in 1.1, for example if window state is involved, which is serialized in

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70827198 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@

[GitHub] flink issue #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0...

2016-07-14 Thread radekg
Github user radekg commented on the issue: https://github.com/apache/flink/pull/2231 Sure, the problems are the following: - https://github.com/apache/flink/pull/2231/commits/06936d7c5acc0897348019161c9ced4596a0a4dd#diff-aba21cf86694f3f2cd85e2e5e9b04972R305 in 0.9,

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70827769 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/metrics/KafkaMetricGetter.java

[jira] [Updated] (FLINK-4218) Sporadic "java.lang.RuntimeException: Error triggering a checkpoint..." causes task restarting

2016-07-14 Thread Sergii Koshel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergii Koshel updated FLINK-4218: - Affects Version/s: (was: 1.0.3) 1.1.0 > Sporadic

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377115#comment-15377115 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #2247: FLINK-4216

2016-07-14 Thread serhiy
Github user serhiy commented on the issue: https://github.com/apache/flink/pull/2247 Damn I was a little bit late :D! You guys are fast :D! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Updated] (FLINK-4212) Lock PID file when starting daemons

2016-07-14 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-4212: -- Summary: Lock PID file when starting daemons (was: Lock on pid file when starting daemons) > Lock PID

[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377304#comment-15377304 ] ASF GitHub Bot commented on FLINK-4184: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #2220: [FLINK-4184] [metrics] Replace invalid characters in Sche...

2016-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2220 only one comment left, otherwise +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377314#comment-15377314 ] ASF GitHub Bot commented on FLINK-4184: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4213) Provide CombineHint in Gelly algorithms

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377224#comment-15377224 ] ASF GitHub Bot commented on FLINK-4213: --- GitHub user greghogan opened a pull request:

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377282#comment-15377282 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2236#discussion_r70843655 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java --- @@

[GitHub] flink pull request #2239: [FLINK-4208] Support Running Flink processes in fo...

2016-07-14 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2239#discussion_r70844709 --- Diff: flink-dist/src/main/flink-bin/bin/flink-daemon.sh --- @@ -77,31 +77,36 @@ if [[ ${JAVA_VERSION} =~ ${IS_NUMBER} ]]; then fi case

[jira] [Created] (FLINK-4219) Quote PDSH opts in start-cluster.sh

2016-07-14 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4219: - Summary: Quote PDSH opts in start-cluster.sh Key: FLINK-4219 URL: https://issues.apache.org/jira/browse/FLINK-4219 Project: Flink Issue Type: Bug

[GitHub] flink pull request #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly ...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2248 [FLINK-4213] [gelly] Provide CombineHint in Gelly algorithms `VertexDegrees` has changed from using a `ReduceFunction` to using a `GroupReduceFunction` as in directed `TriangleListing`. You can

[jira] [Commented] (FLINK-3985) A metric with the name * was already registered

2016-07-14 Thread Joshua Griffith (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377240#comment-15377240 ] Joshua Griffith commented on FLINK-3985: I'm also seeing around 3000 lines of this error

[jira] [Commented] (FLINK-4218) Sporadic "java.lang.RuntimeException: Error triggering a checkpoint..." causes task restarting

2016-07-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377211#comment-15377211 ] Robert Metzger commented on FLINK-4218: --- I think this an artifact of S3's consistency model.

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/2249 4166 zookeeper namespaces Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of

[GitHub] flink pull request #2220: [FLINK-4184] [metrics] Replace invalid characters ...

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2220#discussion_r70845241 --- Diff: flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java --- @@ -74,6 +75,15 @@ protected

[jira] [Commented] (FLINK-4186) Expose Kafka metrics through Flink metrics

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377290#comment-15377290 ] ASF GitHub Bot commented on FLINK-4186: --- Github user zentol commented on the issue:

[GitHub] flink issue #2236: [FLINK-4186] Use Flink metrics to report Kafka metrics

2016-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2236 couldn't find any problem, +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-4208) Support Running Flink processes in foreground mode

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377297#comment-15377297 ] ASF GitHub Bot commented on FLINK-4208: --- Github user greghogan commented on a diff in the pull

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-14 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2239 What if instead of changing how we start the daemon (so continue to always start as a background process), we instead add a `wait` after the PID file has been updated when starting a foreground

[GitHub] flink pull request #2250: [FLINK-4217] [gelly] Gelly drivers should read CSV...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2250 [FLINK-4217] [gelly] Gelly drivers should read CSV values as strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[jira] [Commented] (FLINK-4217) Gelly drivers should read CSV values as strings

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378145#comment-15378145 ] ASF GitHub Bot commented on FLINK-4217: --- GitHub user greghogan opened a pull request:

[jira] [Commented] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378166#comment-15378166 ] ASF GitHub Bot commented on FLINK-4214: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-3666) Remove Nephele references

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378214#comment-15378214 ] ASF GitHub Bot commented on FLINK-3666: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2241: [FLINK-3666] Remove all remaining Nephele references

2016-07-14 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2241 Good catch! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-07-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r70870120 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/AvroSerializationSchemaTest.java ---

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378226#comment-15378226 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378225#comment-15378225 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-4212) Lock PID file when starting daemons

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378248#comment-15378248 ] ASF GitHub Bot commented on FLINK-4212: --- GitHub user greghogan opened a pull request:

[jira] [Resolved] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4214. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed via 91d5c63a717d8786506c2d791bb4683838f699d8

[jira] [Closed] (FLINK-4216) WordWithCount example with Java has wrong generics type

2016-07-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4216. --- > WordWithCount example with Java has wrong generics type >

[jira] [Resolved] (FLINK-4216) WordWithCount example with Java has wrong generics type

2016-07-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4216. - Resolution: Fixed Assignee: Matthias J. Sax Fix Version/s: 1.1.0 Fixed via

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378331#comment-15378331 ] ASF GitHub Bot commented on FLINK-2125: --- Github user zentol commented on the issue:

[jira] [Closed] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4214. --- > JobExceptionsHandler will return all exceptions > --- > >

[jira] [Commented] (FLINK-4208) Support Running Flink processes in foreground mode

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378354#comment-15378354 ] ASF GitHub Bot commented on FLINK-4208: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-14 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2239 Using `wait $mypid` or just `wait` works for me if I `./bin/jobmanager.sh start cluster` (jobmanager starts in foreground), then in another terminal `./bin/jobmanager.sh stop` and both terminals

[jira] [Commented] (FLINK-4210) Move close()/isClosed() out of MetricGroup interface

2016-07-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378352#comment-15378352 ] Chesnay Schepler commented on FLINK-4210: - This is actually wrong. Let's say a user calls close()

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70882042 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java --- @@ -428,6 +429,12 @@ private static Configuration

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70881905 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -475,23 +484,23 @@ public YarnClusterClient retrieveCluster(

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70883081 --- Diff: docs/setup/jobmanager_high_availability.md --- @@ -74,11 +74,15 @@ In order to start an HA-cluster add the following configuration keys to `conf/fl

[jira] [Commented] (FLINK-3163) Configure Flink for NUMA systems

2016-07-14 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378192#comment-15378192 ] Greg Hogan commented on FLINK-3163: --- I think we can achieve "good enough" without changing the format of

[jira] [Commented] (FLINK-4029) Multi-field "sum" function just like "keyBy"

2016-07-14 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378271#comment-15378271 ] Ivan Mushketyk commented on FLINK-4029: --- Gabor, This should be very helpful! Thank you for your

[jira] [Commented] (FLINK-4208) Support Running Flink processes in foreground mode

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378305#comment-15378305 ] ASF GitHub Bot commented on FLINK-4208: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #2247: FLINK-4216

2016-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2246: [hotfix] [doc] fixed example

2016-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2233: [FLINK-2125][streaming] Delimiter change from char to str...

2016-07-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2233 @StephanEwen The socketTextStream methods are already marked as `@PublicEvolving`, i thought changing those was allowed? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #:

2016-07-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/2477161352e12e75e2f0f85b5833ad04dc6d31f2#commitcomment-18252297 In flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTaskState.java: In

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70883320 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -545,6 +551,19 @@ protected YarnClusterClient

[GitHub] flink pull request #2239: [FLINK-4208] Support Running Flink processes in fo...

2016-07-14 Thread iemejia
Github user iemejia commented on a diff in the pull request: https://github.com/apache/flink/pull/2239#discussion_r70873347 --- Diff: flink-dist/src/main/flink-bin/bin/flink-daemon.sh --- @@ -77,31 +77,36 @@ if [[ ${JAVA_VERSION} =~ ${IS_NUMBER} ]]; then fi case

[jira] [Commented] (FLINK-4029) Multi-field "sum" function just like "keyBy"

2016-07-14 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378269#comment-15378269 ] Ivan Mushketyk commented on FLINK-4029: --- Rami, Thank you for your reply, it is clear now. >

[jira] [Commented] (FLINK-4208) Support Running Flink processes in foreground mode

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378263#comment-15378263 ] ASF GitHub Bot commented on FLINK-4208: --- Github user iemejia commented on a diff in the pull

[jira] [Assigned] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-07-14 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-3874: - Assignee: Ivan Mushketyk > Add a Kafka TableSink with JSON serialization >

[GitHub] flink pull request #:

2016-07-14 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/2477161352e12e75e2f0f85b5833ad04dc6d31f2#commitcomment-18251972 In flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTaskState.java: In

[GitHub] flink pull request #:

2016-07-14 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/2477161352e12e75e2f0f85b5833ad04dc6d31f2#commitcomment-18252310 In flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTaskState.java: In

[GitHub] flink pull request #2252: [FLINK-3466] [runtime] Cancel state handled on sta...

2016-07-14 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/2252 [FLINK-3466] [runtime] Cancel state handled on state restore This pull request fixes the issue that state restore operations can get stuck when tasks are cancelled during state restore. That

[GitHub] flink issue #2246: [hotfix] [doc] fixed example

2016-07-14 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2246 Thanks, merging this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378227#comment-15378227 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on the issue:

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378219#comment-15378219 ] ASF GitHub Bot commented on FLINK-2125: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2233: [FLINK-2125][streaming] Delimiter change from char to str...

2016-07-14 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2233 Because this breaks the public API, it would be good to do the following: Add a new method to the `StreamExecutionEnvironment`, rather than changing the old method. Tag that new method

[jira] [Commented] (FLINK-4210) Move close()/isClosed() out of MetricGroup interface

2016-07-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378189#comment-15378189 ] Stephan Ewen commented on FLINK-4210: - I don't think that is too bad. Worst thing that can happen is

[jira] [Commented] (FLINK-4208) Support Running Flink processes in foreground mode

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378301#comment-15378301 ] ASF GitHub Bot commented on FLINK-4208: --- Github user iemejia commented on the issue:

[GitHub] flink pull request #2239: [FLINK-4208] Support Running Flink processes in fo...

2016-07-14 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2239#discussion_r70877433 --- Diff: flink-dist/src/main/flink-bin/bin/flink-daemon.sh --- @@ -77,31 +77,36 @@ if [[ ${JAVA_VERSION} =~ ${IS_NUMBER} ]]; then fi case

[GitHub] flink pull request #2242: [FLINK-4214] ExceptionHandler keep count of except...

2016-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4214) JobExceptionsHandler will return all exceptions

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378320#comment-15378320 ] ASF GitHub Bot commented on FLINK-4214: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4216) WordWithCount example with Java has wrong generics type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378321#comment-15378321 ] ASF GitHub Bot commented on FLINK-4216: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2251: [FLINK-4212] [scripts] Lock PID file when starting...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2251 [FLINK-4212] [scripts] Lock PID file when starting daemons You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-07-14 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2244 I've update the PR according to the PR and fixed the build (I was using a method from JDK8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70876628 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -285,6 +291,18 @@ public static ZooKeeperCheckpointIDCounter

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70876542 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -164,6 +169,7 @@ public static ZooKeeperLeaderElectionService

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-14 Thread iemejia
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/2239 I tried not to change the current daemon behavior, that's the reason why I took the decision to add an additional option. I am not sure if using wait may work for what I want but if it does,

[jira] [Commented] (FLINK-3466) Job might get stuck in restoreState() from HDFS due to interrupt

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378350#comment-15378350 ] ASF GitHub Bot commented on FLINK-3466: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request #2249: 4166 zookeeper namespaces

2016-07-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r70883754 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -545,6 +551,19 @@ protected YarnClusterClient

[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376824#comment-15376824 ] ASF GitHub Bot commented on FLINK-4184: --- Github user tillrohrmann commented on the issue:

  1   2   >