[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r112002707 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSlideWindowAggReduceGroupFunction.scala --- @@ -18,111

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111991399 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -407,32 +513,56 @@ class CodeGenerator(

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973411#comment-15973411 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973419#comment-15973419 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111993502 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala --- @@ -64,38 +68,22 @@ class

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111994938 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala --- @@ -64,38 +68,22 @@ class

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111992686 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala --- @@ -21,44 +21,48 @@ import

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111994200 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala --- @@ -64,38 +68,22 @@ class

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111999493 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetSessionWindowAggregatePreProcessor.scala --- @@

[jira] [Commented] (FLINK-5991) Expose Broadcast Operator State through public APIs

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973390#comment-15973390 ] ASF GitHub Bot commented on FLINK-5991: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3508: [FLINK-5991] [state-backend, streaming] Expose Broadcast ...

2017-04-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3508 Merging after Travis turns green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973388#comment-15973388 ] ASF GitHub Bot commented on FLINK-6013: --- GitHub user bowenli86 opened a pull request:

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-18 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3736 [Flink-6013][metrics] Add Datadog HTTP metrics reporter I'm adding a DatadogHttpReporter for Flink metrics system. The implementation, including making parameters in Flink's metrics as

[jira] [Commented] (FLINK-2184) Cannot get last element with maxBy/minBy

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973386#comment-15973386 ] ASF GitHub Bot commented on FLINK-2184: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-18 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3110 There were, but only in my head. Maybe we should open an issue or discuss on the ML. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-6321) RocksDB state backend Checkpointing is not working with KeydCEP.

2017-04-18 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973369#comment-15973369 ] Stefan Richter commented on FLINK-6321: --- The reported exception is probably not showing the root

[GitHub] flink issue #3586: [FLINK-1984] initial commit of hard constraint evaluator

2017-04-18 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3586 Thanks for this contribution, I'm glad to see Flink take advantage of Fenzo's considerable power. Please open a new bug for this, since FLINK-1984 is closed, assign it to yourself, and

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973298#comment-15973298 ] ASF GitHub Bot commented on FLINK-1984: --- Github user EronWright commented on the issue:

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973293#comment-15973293 ] ASF GitHub Bot commented on FLINK-1984: --- Github user EronWright commented on a diff in the pull

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973292#comment-15973292 ] ASF GitHub Bot commented on FLINK-1984: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #3586: [FLINK-1984] initial commit of hard constraint eva...

2017-04-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/3586#discussion_r112036109 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -166,7 +191,36 @@ public

[GitHub] flink pull request #3586: [FLINK-1984] initial commit of hard constraint eva...

2017-04-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/3586#discussion_r112036914 --- Diff: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java --- @@ -0,0 +1,95 @@ +/*

[jira] [Commented] (FLINK-5991) Expose Broadcast Operator State through public APIs

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973111#comment-15973111 ] ASF GitHub Bot commented on FLINK-5991: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3508: [FLINK-5991] [state-backend, streaming] Expose Broadcast ...

2017-04-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3508 I'd say lets keep the naming as is, since in general all of us agree on that already. I'll try to do some more work on the docs and Javadocs to make sure that at least the documentation

[jira] [Commented] (FLINK-6307) Refactor JDBC tests

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973047#comment-15973047 ] ASF GitHub Bot commented on FLINK-6307: --- Github user zentol commented on the issue:

[GitHub] flink issue #3723: [FLINK-6307] [jdbc] Refactor JDBC tests

2017-04-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3723 Will merge this and address the comment on the way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973040#comment-15973040 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973044#comment-15973044 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973043#comment-15973043 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973041#comment-15973041 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973042#comment-15973042 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973037#comment-15973037 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973035#comment-15973035 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973038#comment-15973038 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973039#comment-15973039 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973036#comment-15973036 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112003041 --- Diff: flink-dist/src/test/java/org/apache/flink/dist/TaskManagerHeapSizeCalculationJavaBashTest.java --- @@ -0,0 +1,306 @@ +/* + * Licensed to

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112001266 --- Diff: flink-dist/src/test/java/org/apache/flink/dist/TaskManagerHeapSizeCalculationJavaBashTest.java --- @@ -0,0 +1,306 @@ +/* + * Licensed to

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112000380 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java --- @@ -450,7 +450,7 @@ public FileBaseStatistics

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111994207 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -376,6 +392,169 @@ private static

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112000165 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesTest.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112002748 --- Diff: flink-dist/src/test/java/org/apache/flink/dist/TaskManagerHeapSizeCalculationJavaBashTest.java --- @@ -0,0 +1,306 @@ +/* + * Licensed to

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111997260 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesTest.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111992933 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesTest.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111983754 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -410,24 +410,47 @@ private static

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111975142 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -398,3 +428,106 @@ readSlaves() { useOffHeapMemory() { [[ "`echo

[jira] [Commented] (FLINK-6322) Mesos task labels

2017-04-18 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973018#comment-15973018 ] Patrick Lucas commented on FLINK-6322: -- This could likely be modeled similarly to `yarn.tags`. >

[jira] [Commented] (FLINK-5808) Missing verification for setParallelism and setMaxParallelism

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972981#comment-15972981 ] ASF GitHub Bot commented on FLINK-5808: --- Github user aljoscha closed the pull request at:

[GitHub] flink pull request #3670: [FLINK-5808] Revert changes

2017-04-18 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/3670 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (FLINK-6323) Add new Sink interface with access to more meta data

2017-04-18 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6323: --- Summary: Add new Sink interface with access to more meta data Key: FLINK-6323 URL: https://issues.apache.org/jira/browse/FLINK-6323 Project: Flink

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972943#comment-15972943 ] ASF GitHub Bot commented on FLINK-6295: --- Github user zentol commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3709 eh... in charge? Whenever *anything* related to a job is requested from the web-ui the EGHolder is accessed. Suppose you have the job info page (/jobs/:jobid) open in a browser or

[jira] [Commented] (FLINK-5904) jobmanager.heap.mb and taskmanager.heap.mb not work in YARN mode

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972929#comment-15972929 ] ASF GitHub Bot commented on FLINK-5904: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3414: [FLINK-5904][YARN]make jobmanager.heap.mb and taskmanager...

2017-04-18 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3414 Thanks. I've resolved conflicts. enjoy :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972920#comment-15972920 ] ASF GitHub Bot commented on FLINK-6242: --- Github user shaoxuan-wang commented on a diff in the pull

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111986331 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -36,6 +36,15 @@

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972908#comment-15972908 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111984555 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala --- @@ -97,12 +94,7 @@ class

[jira] [Created] (FLINK-6322) Mesos task labels

2017-04-18 Thread Eron Wright (JIRA)
Eron Wright created FLINK-6322: --- Summary: Mesos task labels Key: FLINK-6322 URL: https://issues.apache.org/jira/browse/FLINK-6322 Project: Flink Issue Type: Improvement Components:

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972905#comment-15972905 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111983678 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala --- @@ -68,23 +72,16 @@ class

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972901#comment-15972901 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111983391 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala --- @@ -68,23 +72,16 @@ class

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972896#comment-15972896 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111982297 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -36,6 +36,15 @@ abstract

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972894#comment-15972894 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-18 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 I mean who's in charge of updating EGHolder? EGHolder itself or JobManager? EGHolder don't sense status changing of jobs until it queries from JobManager periodically. If JobManager

[jira] [Comment Edited] (FLINK-6306) Sink for eventually consistent file systems

2017-04-18 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971397#comment-15971397 ] Seth Wiesman edited comment on FLINK-6306 at 4/18/17 3:16 PM: -- The idea is

[jira] [Commented] (FLINK-5904) jobmanager.heap.mb and taskmanager.heap.mb not work in YARN mode

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972885#comment-15972885 ] ASF GitHub Bot commented on FLINK-5904: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3414: [FLINK-5904][YARN]make jobmanager.heap.mb and taskmanager...

2017-04-18 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3414 Thanks for your contribution @WangTaoTheTonic. LGTM. Merging the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972872#comment-15972872 ] ASF GitHub Bot commented on FLINK-6295: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972869#comment-15972869 ] ASF GitHub Bot commented on FLINK-6242: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3709 @WangTaoTheTonic Because *everyone* uses guava which results again and again in dependency conflicts. What do you mean with "how long it should be"? We remove the job from the cache and

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111978489 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -36,6 +36,15 @@ abstract

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972841#comment-15972841 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-18 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 In my opinion EGHolder is simply a cache which should not be assigned too complicated task. If we add the check logic, how long it should be? Will other events afftects status of

[jira] [Closed] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6300. - Resolution: Fixed 1.3.0: 9d3f127e4f0ddd15ae7af393e0c5b0d3dd81d812 1.2.2:

[jira] [Updated] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6300: -- Fix Version/s: 1.2.2 1.3.0 > PID1 of docker images does not behave correctly >

[jira] [Closed] (FLINK-6195) Move gelly-examples jar from opt to examples

2017-04-18 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6195. - Resolution: Implemented Implemented in 568e64282eaa2671b4e46655e1fa773f9bb1e492 > Move gelly-examples

[jira] [Commented] (FLINK-6195) Move gelly-examples jar from opt to examples

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972828#comment-15972828 ] ASF GitHub Bot commented on FLINK-6195: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6300) PID1 of docker images does not behave correctly

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972829#comment-15972829 ] ASF GitHub Bot commented on FLINK-6300: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3691: [FLINK-6195] [build] Move gelly-examples jar from ...

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6307) Refactor JDBC tests

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972814#comment-15972814 ] ASF GitHub Bot commented on FLINK-6307: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3723: [FLINK-6307] [jdbc] Refactor JDBC tests

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3723#discussion_r111971942 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -272,63 +209,61 @@ public void

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972803#comment-15972803 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111969982 --- Diff: docs/setup/config.md --- @@ -602,26 +612,66 @@ You have to configure `jobmanager.archive.fs.dir` in order to archive terminated ##

[jira] [Commented] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-04-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972787#comment-15972787 ] Aljoscha Krettek commented on FLINK-6294: - Yes, it can only happen if not properly initialised.

[jira] [Closed] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Zohar Mizrahi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zohar Mizrahi closed FLINK-6283. Resolution: Won't Do > Enable to clear a given file cache path >

[jira] [Commented] (FLINK-6283) Enable to clear a given file cache path

2017-04-18 Thread Zohar Mizrahi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972776#comment-15972776 ] Zohar Mizrahi commented on FLINK-6283: -- Yes, this is how I implemented it. In addition I added a

[jira] [Commented] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972775#comment-15972775 ] Aljoscha Krettek commented on FLINK-6319: - I think [~StephanEwen] had some thought's on why we

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972771#comment-15972771 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in the pull request:

[jira] [Comment Edited] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-18 Thread Stefano Bortoli (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972574#comment-15972574 ] Stefano Bortoli edited comment on FLINK-6250 at 4/18/17 2:22 PM: - Hi

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r111966911 --- Diff: docs/setup/config.md --- @@ -602,26 +612,66 @@ You have to configure `jobmanager.archive.fs.dir` in order to archive terminated ##

[jira] [Commented] (FLINK-6307) Refactor JDBC tests

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972759#comment-15972759 ] ASF GitHub Bot commented on FLINK-6307: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3723: [FLINK-6307] [jdbc] Refactor JDBC tests

2017-04-18 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3723#discussion_r111966195 --- Diff: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java --- @@ -272,63 +209,61 @@ public void

[jira] [Commented] (FLINK-6294) BucketingSink throws NPE while cancelling job

2017-04-18 Thread Andrey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972752#comment-15972752 ] Andrey commented on FLINK-6294: --- I have the same version. Maybe this issue happens when BuckingSink is not

[jira] [Commented] (FLINK-4973) Flakey Yarn tests due to recently added latency marker

2017-04-18 Thread Andrey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972750#comment-15972750 ] Andrey commented on FLINK-4973: --- Proper handling InterruptedException will make it possible to clean and

[jira] [Comment Edited] (FLINK-6130) Consider calling resourceManager#getTerminationFuture() with lock held

2017-04-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972736#comment-15972736 ] mingleizhang edited comment on FLINK-6130 at 4/18/17 2:10 PM: --

[jira] [Commented] (FLINK-6149) add additional flink logical relation nodes

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972745#comment-15972745 ] ASF GitHub Bot commented on FLINK-6149: --- Github user fhueske commented on the issue:

<    1   2   3   4   5   >