[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985015#comment-15985015 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on the issue:

[jira] [Created] (FLINK-6388) Add support for DISTINCT into Code Generated Aggregations

2017-04-26 Thread Stefano Bortoli (JIRA)
Stefano Bortoli created FLINK-6388: -- Summary: Add support for DISTINCT into Code Generated Aggregations Key: FLINK-6388 URL: https://issues.apache.org/jira/browse/FLINK-6388 Project: Flink

[GitHub] flink issue #3771: [FLINK-6250] Distinct procTime with Rows boundaries

2017-04-26 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3771 @fhueske @haohui I have no problem removing the DIST() part, it is just not possible to test it without. Shall I push just the code generation and aggregates util changes? --- If your project

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984929#comment-15984929 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on the issue:

[GitHub] flink pull request #3771: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-26 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3771#discussion_r113472166 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRowsOver.scala --- @@ -72,7 +73,15 @@

[jira] [Commented] (FLINK-6048) Asynchronous snapshots for heap-based operator state backends

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984935#comment-15984935 ] ASF GitHub Bot commented on FLINK-6048: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984939#comment-15984939 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on a diff in the pull

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113482845 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -21,519 +21,897 @@ import

[jira] [Commented] (FLINK-5892) Recover job state at the granularity of operator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984990#comment-15984990 ] ASF GitHub Bot commented on FLINK-5892: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984989#comment-15984989 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3770: [FLINK-5892] Restore state on the operator level

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3770#discussion_r113482975 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java --- @@ -133,11 +142,15 @@ public JobVertex(String name, JobVertexID

[GitHub] flink pull request #3770: [FLINK-5892] Restore state on the operator level

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3770#discussion_r113482888 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java --- @@ -133,11 +142,15 @@ public JobVertex(String name, JobVertexID

[jira] [Commented] (FLINK-5892) Recover job state at the granularity of operator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984988#comment-15984988 ] ASF GitHub Bot commented on FLINK-5892: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113479420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/TaskManagerSlot.java --- @@ -18,15 +18,17 @@ package

[GitHub] flink pull request #3770: [FLINK-5892] Restore state on the operator level

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3770#discussion_r113482738 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java --- @@ -125,6 +132,8 @@ public JobVertex(String name) { public

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985002#comment-15985002 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985003#comment-15985003 ] ASF GitHub Bot commented on FLINK-6250: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985019#comment-15985019 ] ASF GitHub Bot commented on FLINK-6247: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3666: [FLINK-6247][table] Build a jar-with-dependencies for fli...

2017-04-26 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3666 Hi @fhueske Thanks for your Reviewing. And sorry for late reply. I have updated the PR. Please take a look. Thanks a lot. Thanks, SunJincheng --- If your project is set up for

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985138#comment-15985138 ] ASF GitHub Bot commented on FLINK-6288: --- Github user gyfora commented on the issue:

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3782#discussion_r113507485 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/hooks/MasterHooks.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to the

[GitHub] flink issue #3782: [FLINK-6390] [checkpoints] Add API for checkpoints that a...

2017-04-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3782 Thanks a lot for the fast review. Agree with both issues raised. Will address them while merging... --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985157#comment-15985157 ] ASF GitHub Bot commented on FLINK-6390: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #3783: [FLINK-6338] Add support for DISTINCT into Code Ge...

2017-04-26 Thread huawei-flink
GitHub user huawei-flink opened a pull request: https://github.com/apache/flink/pull/3783 [FLINK-6338] Add support for DISTINCT into Code Generated Aggregations Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #2628: [FLINK-3722] [runtime] Don't / and % when sorting

2017-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985203#comment-15985203 ] ASF GitHub Bot commented on FLINK-3722: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3722: -- Fix Version/s: 1.3.0 > The divisions in the InMemorySorters' swap/compare methods hurt performance >

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985208#comment-15985208 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on the issue:

[GitHub] flink issue #3771: [FLINK-6250] Distinct procTime with Rows boundaries

2017-04-26 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3771 @fhueske I have created #3783 with just the code generation part. At least the GROUP BY distinct can move ahead. I will close this PR and wait for the merging of the Calcite fix. --- If your

[jira] [Closed] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-3722. - Resolution: Implemented Implemented in 336b95d4eedc23e5ce37d1739165157e127c65f8 > The divisions in the

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3511 @heytitle please remove the old FLINK-3722 commits and rebase to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985213#comment-15985213 ] ASF GitHub Bot commented on FLINK-3722: --- Github user greghogan commented on the issue:

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113519219 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-6048) Asynchronous snapshots for heap-based operator state backends

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985265#comment-15985265 ] ASF GitHub Bot commented on FLINK-6048: --- Github user StefanRRichter closed the pull request at:

[GitHub] flink pull request #3536: [FLINK-6048] Asynchronous snapshots for heap-based...

2017-04-26 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/3536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6175) HistoryServerTest.testFullArchiveLifecycle fails

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985286#comment-15985286 ] ASF GitHub Bot commented on FLINK-6175: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5752) Support push down projections for HBaseTableSource

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985287#comment-15985287 ] ASF GitHub Bot commented on FLINK-5752: --- Github user ramkrish86 commented on the issue:

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-26 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 I checked the recent failure. `Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.417 sec <<< FAILURE! - in org.apache.flink.runtime.jobmanager.JobManagerRegistrationTest`

[GitHub] flink issue #3655: [FLINK-6175] Harden HistoryServerTest#testFullArchiveLife...

2017-04-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3655 While at hardening: The test seems to work with a fix port. That is bound to cause failures due to conflicts (for example 8082 is common to be used if you have a local HA Flink for testing).

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985073#comment-15985073 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113497111 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -21,519 +21,897 @@ import

[GitHub] flink pull request #3748: [FLINK-6225] [Cassandra Connector] add CassandraTa...

2017-04-26 Thread PangZhi
Github user PangZhi commented on a diff in the pull request: https://github.com/apache/flink/pull/3748#discussion_r113505564 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985117#comment-15985117 ] ASF GitHub Bot commented on FLINK-6225: --- Github user PangZhi commented on a diff in the pull

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985122#comment-15985122 ] Gyula Fora commented on FLINK-6390: --- we could call it completeCheckpoint for example > Add Trigger

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113495941 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/TaskManagerRegistration.java --- @@ -0,0 +1,89 @@ +/*

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985065#comment-15985065 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985079#comment-15985079 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113497948 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -21,519 +21,897 @@ import

[GitHub] flink issue #3718: [FLINK-6112] Support Calcite 1.12's new numerical functio...

2017-04-26 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3718 Thanks for the PR @mtunique. I quickly looked through the changes, it looks very good. I will review it in the next days, I think we can include it in the 1.3 release. --- If your project is set

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985103#comment-15985103 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113502388 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -21,519 +21,897 @@ import

[GitHub] flink pull request #3394: [FLINK-5810] [flip6] Introduce a hardened slot man...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3394#discussion_r113502203 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -21,519 +21,897 @@ import

[GitHub] flink issue #3394: [FLINK-5810] [flip6] Introduce a hardened slot manager

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3394 Thanks for the thorough review @StephanEwen. I'll will pull in your commit with the improvements. Concerning the other points you've raised: - I think you're right. The

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985113#comment-15985113 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985119#comment-15985119 ] Gyula Fora commented on FLINK-6390: --- Hi Stephan, This looks pretty useful. One thing that came to my

[jira] [Commented] (FLINK-6112) Support Calcite 1.12's new numerical functions

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985077#comment-15985077 ] ASF GitHub Bot commented on FLINK-6112: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-5810) Harden SlotManager

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985104#comment-15985104 ] ASF GitHub Bot commented on FLINK-5810: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Created] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-6390: --- Summary: Add Trigger Hooks to the Checkpoint Coordinator Key: FLINK-6390 URL: https://issues.apache.org/jira/browse/FLINK-6390 Project: Flink Issue Type: New

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985108#comment-15985108 ] ASF GitHub Bot commented on FLINK-6390: --- GitHub user StephanEwen opened a pull request:

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/3782 [FLINK-6390] [checkpoints] Add API for checkpoints that are triggered via external systems Some source systems require to be notified prior to starting a checkpoint, in order to do preparatory

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-04-26 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3766 I think this is reasonable as the current implementation doesnt work for dynamic new topics. (we should also deprecate the current one) But let's hear what others say :) --- If your project

[GitHub] flink issue #3733: [FLINK-6091] [table] Implement and turn on retraction for...

2017-04-26 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/3733 hi @fhueske , thanks a lot for your review and help. I have addressed all your comments and updated the PR. All changes have been checked before my latest update. Thanks, Hequn --- If your

[jira] [Commented] (FLINK-5125) ContinuousFileProcessingCheckpointITCase is Flaky

2017-04-26 Thread Till Rohrmann (JIRA)
-ci.org/jobs/225722717/log.txt?X-Amz-Expires=30=20170426T085518Z=AWS4-HMAC-SHA256=AKIAJRYRXRSVGNKPKO5A/20170426/us-east-1/s3/aws4_request=host=d502c485e7a39a10f4d4face65252b541cca7e6af6c147b519943a753e677c7c > ContinuousFileProcessingCheckpointITCase is Fl

[jira] [Commented] (FLINK-5974) Support Mesos DNS

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984422#comment-15984422 ] ASF GitHub Bot commented on FLINK-5974: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984431#comment-15984431 ] ASF GitHub Bot commented on FLINK-6376: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3776: [FLINK-6376]when deploy flink cluster on the yarn, it is ...

2017-04-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3776 Looks like a good fix. I think it would be good to add secure yarn tests (IT Cases) that test this behavior. Otherwise it may soon be accidentally broken again... --- If your project

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-04-26 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3766 How would this new API map to the current one in terms of backwards compatibility? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Closed] (FLINK-5695) Optimize table type systems based on database semantics

2017-04-26 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-5695. -- Resolution: Won't Fix > Optimize table type systems based on database semantics >

[jira] [Commented] (FLINK-5695) Optimize table type systems based on database semantics

2017-04-26 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984510#comment-15984510 ] sunjincheng commented on FLINK-5695: After we had finished the OVER window TableAPI. I think I can

[GitHub] flink issue #3761: [FLINK-6356] Make optional available to all patterns/time...

2017-04-26 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3761 @kl0u I don't have any more comments, so for me it LGTM. I've also rebased the skip-till-next on top of this one, so would be nice to merge it and start reviewing #3698 --- If your

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984518#comment-15984518 ] ASF GitHub Bot commented on FLINK-6281: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984521#comment-15984521 ] ASF GitHub Bot commented on FLINK-6281: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985155#comment-15985155 ] ASF GitHub Bot commented on FLINK-6390: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985154#comment-15985154 ] ASF GitHub Bot commented on FLINK-6390: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3782#discussion_r113504901 --- Diff: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializer.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985159#comment-15985159 ] ASF GitHub Bot commented on FLINK-6013: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113510125 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113512176 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,199 @@ +/* +

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985190#comment-15985190 ] ASF GitHub Bot commented on FLINK-6013: --- Github user bowenli86 commented on a diff in the pull

[jira] [Commented] (FLINK-6338) SimpleStringUtils should be called StringValueUtils

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985197#comment-15985197 ] ASF GitHub Bot commented on FLINK-6338: --- GitHub user huawei-flink opened a pull request:

[jira] [Commented] (FLINK-6338) SimpleStringUtils should be called StringValueUtils

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985198#comment-15985198 ] ASF GitHub Bot commented on FLINK-6338: --- Github user huawei-flink commented on the issue:

[GitHub] flink issue #3783: [FLINK-6338] Add support for DISTINCT into Code Generated...

2017-04-26 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3783 @fhueske please have a look at this PR, it contains just the code generation part with optional distinct. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Updated] (FLINK-6357) ParameterTool get unrequested parameters

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6357: -- Summary: ParameterTool get unrequested parameters (was: Parametertool get unrequested parameters) >

[GitHub] flink pull request #3771: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-26 Thread stefanobortoli
Github user stefanobortoli closed the pull request at: https://github.com/apache/flink/pull/3771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985209#comment-15985209 ] ASF GitHub Bot commented on FLINK-6250: --- Github user stefanobortoli closed the pull request at:

[jira] [Commented] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985221#comment-15985221 ] Stephan Ewen commented on FLINK-6107: - I would like to make a suggestion for an adjustment to the

[GitHub] flink issue #3536: [FLINK-6048] Asynchronous snapshots for heap-based Operat...

2017-04-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3536 Thanks for the review @tillrohrmann. I addressed your comments concerning unregistration of streams. Will merge this now. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-6048) Asynchronous snapshots for heap-based operator state backends

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985237#comment-15985237 ] ASF GitHub Bot commented on FLINK-6048: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-6338) SimpleStringUtils should be called StringValueUtils

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985245#comment-15985245 ] ASF GitHub Bot commented on FLINK-6338: --- Github user zentol commented on the issue:

[GitHub] flink issue #3783: [FLINK-6338] Add support for DISTINCT into Code Generated...

2017-04-26 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3783 Please fix the PR title, you are referencing the wrong JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985247#comment-15985247 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[jira] [Resolved] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-6390. - Resolution: Fixed Implemented in 90ca438106e63c5032ee2ad27e54e9f573eac386 > Add Trigger Hooks to

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985621#comment-15985621 ] ASF GitHub Bot commented on FLINK-6390: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3748: [FLINK-6225] [Cassandra Connector] add CassandraTa...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3748#discussion_r113541703 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@

[jira] [Commented] (FLINK-6293) Flakey JobManagerITCase

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985432#comment-15985432 ] Stephan Ewen commented on FLINK-6293: - Hitting this frequently on local builds as well: {code} Tests

[jira] [Commented] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985578#comment-15985578 ] Greg Hogan commented on FLINK-6107: --- [~StephanEwen], I think there was a perception that import order

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985380#comment-15985380 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985376#comment-15985376 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985377#comment-15985377 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

<    1   2   3   4   >