[GitHub] flink issue #5409: [FLINK-8555][TableAPI & SQL] Fix TableFunction varargs le...

2018-02-05 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5409 Thanks for the PR @Xpray. The changes look good. I will make sure that the `SqlOperandTypeChecker` is also used for the other function types. ---

[jira] [Commented] (FLINK-8555) Fix TableFunction varargs length exceeds 254 for SQL

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353528#comment-16353528 ] ASF GitHub Bot commented on FLINK-8555: --- Github user twalthr commented on the issue:

[jira] [Updated] (FLINK-8563) Support consecutive DOT operators

2018-02-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-8563: Issue Type: Sub-task (was: Improvement) Parent: FLINK-8507 > Support consecutive DOT operat

[GitHub] flink issue #5374: [FLINK-8101][flink-connectors] Elasticsearch 5.3+ (Transp...

2018-02-05 Thread cjolif
Github user cjolif commented on the issue: https://github.com/apache/flink/pull/5374 @tzulitai did you have a chance to look at this? If you have any question please let me know? ---

[jira] [Commented] (FLINK-8101) Elasticsearch 6.x support

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353511#comment-16353511 ] ASF GitHub Bot commented on FLINK-8101: --- Github user cjolif commented on the issue:

[jira] [Created] (FLINK-8563) Support consecutive DOT operators

2018-02-05 Thread Timo Walther (JIRA)
Timo Walther created FLINK-8563: --- Summary: Support consecutive DOT operators Key: FLINK-8563 URL: https://issues.apache.org/jira/browse/FLINK-8563 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353508#comment-16353508 ] Xingcan Cui commented on FLINK-8538: Thanks for your reply, [~fhueske]. I'll think it

[jira] [Comment Edited] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353506#comment-16353506 ] Timo Walther edited comment on FLINK-7923 at 2/6/18 7:32 AM: -

[jira] [Commented] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353507#comment-16353507 ] ASF GitHub Bot commented on FLINK-7923: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-7923. - Resolution: Fixed Fixed in 91b7d011022fc1211aebe9114dfa6b497da49553. > Support accessing subfield

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5367 ---

[jira] [Commented] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353486#comment-16353486 ] ASF GitHub Bot commented on FLINK-7923: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-05 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5367 Btw I will remove the null tests because fields of tuples and case classes are not allowed to be null. The serializers would throw an exception. ---

[jira] [Commented] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353479#comment-16353479 ] ASF GitHub Bot commented on FLINK-7923: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-05 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5367 Thanks for the update @suez1224. The changes look good. I will merge this... ---

[jira] [Updated] (FLINK-8562) Fix YARNSessionFIFOSecuredITCase

2018-02-05 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen updated FLINK-8562: -- Description: Currently, YARNSessionFIFOSecuredITCase will not fail even if the current Flink YARN Kerber

[jira] [Created] (FLINK-8562) Fix YARNSessionFIFOSecuredITCase

2018-02-05 Thread Shuyi Chen (JIRA)
Shuyi Chen created FLINK-8562: - Summary: Fix YARNSessionFIFOSecuredITCase Key: FLINK-8562 URL: https://issues.apache.org/jira/browse/FLINK-8562 Project: Flink Issue Type: Bug Components

[jira] [Assigned] (FLINK-6469) Configure Memory Sizes with units

2018-02-05 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-6469: --- Assignee: vinoyang > Configure Memory Sizes with units > - > >

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353271#comment-16353271 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r166175837 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamInputProcessor.java --- @@ -131,10 +131,14 @@ public StreamInputP

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353265#comment-16353265 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r166174743 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CreditBasedBarrierBuffer.java --- @@ -0,0 +1,529 @@ +/* + * Lic

[jira] [Commented] (FLINK-8552) CliFrontend don't exit normal after job has been submitted with 'bin/flink run some_jar_ball'

2018-02-05 Thread Lynch Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353191#comment-16353191 ] Lynch Lee commented on FLINK-8552: -- OK. Thanks ! > CliFrontend don't exit normal after j

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352692#comment-16352692 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose commented on the issu

[GitHub] flink pull request #5295: [FLINK-8384] [streaming] Session Window Assigner w...

2018-02-05 Thread dyanarose
Github user dyanarose closed the pull request at: https://github.com/apache/flink/pull/5295 ---

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-02-05 Thread dyanarose
Github user dyanarose commented on the issue: https://github.com/apache/flink/pull/5295 I can see it's gone through Travis and is now in master, so closing as requested ---

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352693#comment-16352693 ] ASF GitHub Bot commented on FLINK-8384: --- Github user dyanarose closed the pull reque

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352657#comment-16352657 ] Fabian Hueske commented on FLINK-8538: -- Hi [~xccui], please see my comments: # Yes,

[jira] [Closed] (FLINK-8561) SharedBuffer line 573 uses == to compare BufferEntries instead of .equals.

2018-02-05 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8561. - Resolution: Fixed > SharedBuffer line 573 uses == to compare BufferEntries instead of .equals. > -

[jira] [Commented] (FLINK-8561) SharedBuffer line 573 uses == to compare BufferEntries instead of .equals.

2018-02-05 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352646#comment-16352646 ] Kostas Kloudas commented on FLINK-8561: --- Merged on master 3d323ba10171da6e6416efca83

[jira] [Updated] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen updated FLINK-7923: -- Fix Version/s: 1.5.0 > Support accessing subfields of a Composite element in an Object Array type > col

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-05 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352634#comment-16352634 ] Xingcan Cui commented on FLINK-8538: Thanks for the explanation [~twalthr]. I've glanc

[GitHub] flink pull request #5415: Multipath merged

2018-02-05 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/5415 Multipath merged ## What is the purpose of the change * Add support to `FileInputFormat` to read from multiple paths. At the moment only a single path is supported that can be recursively r

[jira] [Updated] (FLINK-7923) Support accessing subfields of a Composite element in an Object Array type column

2018-02-05 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen updated FLINK-7923: -- Issue Type: New Feature (was: Bug) Summary: Support accessing subfields of a Composite element in

[jira] [Closed] (FLINK-8243) OrcTableSource should recursively read all files in nested directories of the input path.

2018-02-05 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-8243. Resolution: Fixed Implemented for 1.4.1 with e5c1261919765876b3ad873abbd9f21bee2fe12b Implemented fo

[jira] [Closed] (FLINK-8242) ClassCastException in OrcTableSource.toOrcPredicate

2018-02-05 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-8242. Resolution: Fixed Fixed for 1.4.1 with 19fcd5ebadabdebc4d56716920937f229f06f5d3 Fixed for 1.5.0 with

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5414 ---

[jira] [Commented] (FLINK-8243) OrcTableSource should recursively read all files in nested directories of the input path.

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352600#comment-16352600 ] ASF GitHub Bot commented on FLINK-8243: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8242) ClassCastException in OrcTableSource.toOrcPredicate

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352601#comment-16352601 ] ASF GitHub Bot commented on FLINK-8242: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5345: [FLINK-8242] [orc] Fix predicate push-down of OrcT...

2018-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5345 ---

[GitHub] flink pull request #5344: [FLINK-8243] [orc] OrcTableSource reads input path...

2018-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5344 ---

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5414#discussion_r166021070 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -519,8 +498,9 @@ public int hashCode() { pr

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5414#discussion_r166018249 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -609,22 +580,27 @@ public String toString() {

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5414#discussion_r166020117 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -542,15 +542,12 @@ public void addEdge(SharedBufferEdge

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5414#discussion_r166017493 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -437,72 +425,63 @@ public void add(final ValueTimeWrapp

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5414#discussion_r166017932 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -519,8 +498,9 @@ public int hashCode() {

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5414#discussion_r166018025 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -578,14 +555,8 @@ private void removeEdges(final List>

[jira] [Resolved] (FLINK-7797) Add support for windowed outer joins for streaming tables

2018-02-05 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui resolved FLINK-7797. Resolution: Fixed Fix Version/s: 1.5.0 > Add support for windowed outer joins for streaming t

[GitHub] flink pull request #5414: Cep inv

2018-02-05 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5414 Cep inv R @aljoscha You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-inv Alternatively you can review and apply these changes as the

[jira] [Commented] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352575#comment-16352575 ] ASF GitHub Bot commented on FLINK-8384: --- Github user aljoscha commented on the issue

[GitHub] flink issue #5295: [FLINK-8384] [streaming] Session Window Assigner with Dyn...

2018-02-05 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5295 Thanks a lot for working on this and iterating so quickly! 👍 I merged this but could you please close the PR if it doesn't close automatically? ---

[jira] [Assigned] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-8384: --- Assignee: Dyana Rose > Session Window Assigner with Dynamic Gaps > --

[jira] [Closed] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8384. --- Resolution: Fixed Implemented on master in ede4c0751b630503605248e8d22f29977f58624a > Session

[jira] [Updated] (FLINK-8384) Session Window Assigner with Dynamic Gaps

2018-02-05 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8384: Fix Version/s: 1.5.0 > Session Window Assigner with Dynamic Gaps > -

[jira] [Commented] (FLINK-7803) Update savepoint Documentation

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352541#comment-16352541 ] ASF GitHub Bot commented on FLINK-7803: --- Github user uce commented on a diff in the

[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...

2018-02-05 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4809#discussion_r166008336 --- Diff: docs/ops/state/savepoints.md --- @@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel If yo

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352526#comment-16352526 ] ASF GitHub Bot commented on FLINK-8516: --- Github user tweise commented on the issue:

[GitHub] flink issue #5393: [FLINK-8516] Allow for custom hash function for shard to ...

2018-02-05 Thread tweise
Github user tweise commented on the issue: https://github.com/apache/flink/pull/5393 @tzulitai please see changes and couple questions. ---

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352520#comment-16352520 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on the issu

[jira] [Commented] (FLINK-7803) Update savepoint Documentation

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352524#comment-16352524 ] ASF GitHub Bot commented on FLINK-7803: --- Github user GJL commented on a diff in the

[GitHub] flink issue #5400: [FLINK-8547][network] Implement CheckpointBarrierHandler ...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5400 @pnowojski , thanks for reviews! I understand your concerns and I should deduplicate some common utils in these tests. I will do that tomorrow together with other comments! ---

[GitHub] flink pull request #4809: [FLINK-7803][Documentation] Add missing savepoint ...

2018-02-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4809#discussion_r166001086 --- Diff: docs/ops/state/savepoints.md --- @@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job with ID `:jobid` and cancel If yo

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352509#comment-16352509 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r165998584 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamInputProcessor.java --- @@ -131,10 +131,14 @@ public StreamInputP

[jira] [Updated] (FLINK-8020) Deadlock found in Async I/O operator

2018-02-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8020: Priority: Critical (was: Blocker) > Deadlock found in Async I/O operator >

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352505#comment-16352505 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r165997853 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CreditBasedBarrierBuffer.java --- @@ -0,0 +1,529 @@ +/* + * Lic

[GitHub] flink pull request #5413: [hotfix][table][tests] Set @Ignore description for...

2018-02-05 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5413 [hotfix][table][tests] Set @Ignore description for RowCsvInputFormatT… Trivial change that moves the reasoning for `@Ignore` from a comment into the annotation itself. You can merge this pull requ

[jira] [Commented] (FLINK-8471) Add Flip-6 configuration switch

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352489#comment-16352489 ] ASF GitHub Bot commented on FLINK-8471: --- Github user GJL commented on the issue:

[GitHub] flink issue #5334: [FLINK-8471] [flip6] Introduce configuration switch for F...

2018-02-05 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5334 I have a usability concern. It's possible to run ``` FLINK_MODE=flip6 bin/start-cluster.sh ``` This will start a cluster in flilp6 mode. However, ``` FLINK_MODE=flip6 b

[jira] [Commented] (FLINK-8534) if insert too much BucketEntry into one bucket in join of iteration will cause a error (Caused : java.io.FileNotFoundException release file error)

2018-02-05 Thread zhu.qing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352487#comment-16352487 ] zhu.qing commented on FLINK-8534: - Do I need provide more information? -- -- Best

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352461#comment-16352461 ] ASF GitHub Bot commented on FLINK-7758: --- Github user yew1eb closed the pull request

[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352458#comment-16352458 ] ASF GitHub Bot commented on FLINK-7984: --- Github user yew1eb closed the pull request

[GitHub] flink pull request #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher...

2018-02-05 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/4769 ---

[GitHub] flink pull request #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2018-02-05 Thread yew1eb
Github user yew1eb closed the pull request at: https://github.com/apache/flink/pull/5072 ---

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352441#comment-16352441 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352438#comment-16352438 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r165983607 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CreditBasedBarrierBuffer.java --- @@ -0,0 +1,529 @@ +/* + * Lic

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r165983714 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CreditBasedBarrierBuffer.java --- @@ -0,0 +1,529 @@ +/* + * Lic

[jira] [Commented] (FLINK-8547) Implement CheckpointBarrierHandler not to spill data for exactly-once based on credit-based flow control

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352436#comment-16352436 ] ASF GitHub Bot commented on FLINK-8547: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #5400: [FLINK-8547][network] Implement CheckpointBarrierH...

2018-02-05 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5400#discussion_r165983496 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -184,6 +184,18 @@ key("taskmanage

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352418#comment-16352418 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8559) Exceptions in RocksDBIncrementalSnapshotOperation#takeSnapshot cause job to get stuck

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352419#comment-16352419 ] ASF GitHub Bot commented on FLINK-8559: --- Github user zentol commented on the issue:

[GitHub] flink issue #5161: [FLINK-7608][metric] Refactor latency statistics metric

2018-02-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5161 merging. ---

[GitHub] flink issue #5412: [FLINK-8559][RocksDB] Release resources if snapshot opera...

2018-02-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5412 merging. ---

[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352409#comment-16352409 ] ASF GitHub Bot commented on FLINK-7984: --- Github user zentol commented on the issue:

[GitHub] flink issue #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2018-02-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5072 @yew1eb Could you close the PR? The issue was addressed in f1e4d25c11a678688064492d50ffad38c39ea877. ---

[jira] [Closed] (FLINK-7984) Bump snappy-java to 1.1.4

2018-02-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7984. --- Resolution: Fixed master: f1e4d25c11a678688064492d50ffad38c39ea877 > Bump snappy-java to 1.1.

[jira] [Commented] (FLINK-8503) Port TaskManagerLogHandler to new REST endpoint

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352385#comment-16352385 ] ASF GitHub Bot commented on FLINK-8503: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5353: [FLINK-8503] [flip6] Display TaskExecutor logs and...

2018-02-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5353#discussion_r165972923 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/AbstractTaskManagerFileHandler.java --- @@ -0,0 +1,236 @@ +/* +

[jira] [Commented] (FLINK-8172) Remove unnecessary synchronisation in RecordSerializer

2018-02-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352373#comment-16352373 ] Chesnay Schepler commented on FLINK-8172: - [~pnowojski] Was this issue subsumed by

[jira] [Updated] (FLINK-8561) SharedBuffer line 573 uses == to compare BufferEntries instead of .equals.

2018-02-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8561: Affects Version/s: 1.5.0 > SharedBuffer line 573 uses == to compare BufferEntries instead of

[jira] [Updated] (FLINK-8561) SharedBuffer line 573 uses == to compare BufferEntries instead of .equals.

2018-02-05 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8561: Fix Version/s: 1.5.0 > SharedBuffer line 573 uses == to compare BufferEntries instead of .eq

[jira] [Created] (FLINK-8561) SharedBuffer line 573 uses == to compare BufferEntries instead of .equals.

2018-02-05 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-8561: - Summary: SharedBuffer line 573 uses == to compare BufferEntries instead of .equals. Key: FLINK-8561 URL: https://issues.apache.org/jira/browse/FLINK-8561 Project: F

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352365#comment-16352365 ] ASF GitHub Bot commented on FLINK-5544: --- Github user orsher commented on the issue:

[GitHub] flink issue #3359: [FLINK-5544][streaming] Add InternalTimerService implemen...

2018-02-05 Thread orsher
Github user orsher commented on the issue: https://github.com/apache/flink/pull/3359 Hi, Is there any progress here? This feature will made our life much easier! ---

[jira] [Commented] (FLINK-8559) Exceptions in RocksDBIncrementalSnapshotOperation#takeSnapshot cause job to get stuck

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352354#comment-16352354 ] ASF GitHub Bot commented on FLINK-8559: --- Github user StefanRRichter commented on the

[GitHub] flink issue #5412: [FLINK-8559][RocksDB] Release resources if snapshot opera...

2018-02-05 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5412 LGTM ---

[jira] [Commented] (FLINK-8559) Exceptions in RocksDBIncrementalSnapshotOperation#takeSnapshot cause job to get stuck

2018-02-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352344#comment-16352344 ] ASF GitHub Bot commented on FLINK-8559: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #5412: [FLINK-8559][RocksDB] Release resources if snapsho...

2018-02-05 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5412 [FLINK-8559][RocksDB] Release resources if snapshot operation fails ## What is the purpose of the change This PR ensures that RocksDB resources are released if `RocksDBIncrementalSnapshotOpe

  1   2   >