[jira] [Commented] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

2018-02-23 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375179#comment-16375179 ] Elias Levy commented on FLINK-7641: --- I mean that if you have a standalone cluster in HA mode with

[jira] [Commented] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

2018-02-23 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375201#comment-16375201 ] vinoyang commented on FLINK-7641: - yes [~elevy] you are right, our implementation go further than your 

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375378#comment-16375378 ] ASF GitHub Bot commented on FLINK-8756: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

2018-02-23 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/5573 [FLINK-8756][Client] Support ClusterClient.getAccumulators() in RestClusterClient ## What is the purpose of the change This PR Support ClusterClient.getAccumulators() in RestClusterClient.

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170313695 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -1156,6 +1213,26 @@ private void

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374692#comment-16374692 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170314219 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -289,7 +290,7 @@ public void invoke() throws

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170314325 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java --- @@ -0,0 +1,42 @@ +/* + *

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374693#comment-16374693 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374695#comment-16374695 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink issue #5559: [FLINK-8725] Separate state from NFA in CEP library

2018-02-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5559 R: @kl0u ---

[jira] [Commented] (FLINK-8694) Make notifyDataAvailable call reliable

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374496#comment-16374496 ] ASF GitHub Bot commented on FLINK-8694: --- GitHub user pnowojski opened a pull request:

[GitHub] flink pull request #5572: [FLINK-8694][runtime] Fix notifyDataAvailable race...

2018-02-23 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5572 [FLINK-8694][runtime] Fix notifyDataAvailable race condition This fixes two bugs in network stack: https://issues.apache.org/jira/browse/FLINK-8760

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170272030 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -67,14 +92,188 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170297941 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170229924 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -89,37 +105,58 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230028 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -155,6 +199,28 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170273904 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/CsvTest.scala --- @@ -47,53 +79,18 @@ class CsvTest extends

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170274382 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170298004 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala --- @@ -18,37 +18,85 @@ package

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170232160 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -246,13 +394,93 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256878 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256006 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256141 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374573#comment-16374573 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374571#comment-16374571 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374696#comment-16374696 ] ASF GitHub Bot commented on FLINK-8746: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170314390 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -534,42 +536,94 @@ public void postStop() throws

[jira] [Commented] (FLINK-7428) avoid one additional buffer copy when receiving messages

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374081#comment-16374081 ] ASF GitHub Bot commented on FLINK-7428: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4529: [FLINK-7428][network] avoid buffer copies when receiving ...

2018-02-23 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4529 Hey @NicoK , would this PR be covered in FLINK-1.5? We experienced the netty direct memory out of memory sometimes in production cased by `extractFrame`, so we expect this improvement. :) ---

[jira] [Assigned] (FLINK-8754) TaskManagerInfo is not serializable

2018-02-23 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8754: --- Assignee: Gary Yao > TaskManagerInfo is not serializable > --- > >

[jira] [Commented] (FLINK-8745) Reduce travis usage

2018-02-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374064#comment-16374064 ] Stephan Ewen commented on FLINK-8745: - Staged builds sound promising. I am somewhat unsure about

[GitHub] flink issue #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint in Rest...

2018-02-23 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5565 Hi @tillrohrmann would you please review this PR, Thanks. ---

[jira] [Commented] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

2018-02-23 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374083#comment-16374083 ] vinoyang commented on FLINK-7641: - Hi [~StephanEwen] , about this issue, we implemented a feature : In

[jira] [Commented] (FLINK-8459) Implement cancelWithSavepoint in RestClusterClient

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374085#comment-16374085 ] ASF GitHub Bot commented on FLINK-8459: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-8725) Separate NFA-state from NFA in CEP library

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374471#comment-16374471 ] ASF GitHub Bot commented on FLINK-8725: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5559: [FLINK-8725] Separate state from NFA in CEP library

2018-02-23 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5559 @aljoscha I will have a look today. ---

[GitHub] flink pull request #5571: [FLINK-8759][network] preparations for the update ...

2018-02-23 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5571 [FLINK-8759][network] preparations for the update of netty to version 4.0.56 ## What is the purpose of the change Based on the changes from #5570, this PR prepares a netty version bump by

[jira] [Commented] (FLINK-8759) Bump Netty to 4.0.56

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374480#comment-16374480 ] ASF GitHub Bot commented on FLINK-8759: --- GitHub user NicoK opened a pull request:

[jira] [Commented] (FLINK-8751) Canceling a job results in a InterruptedException in the TM

2018-02-23 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374551#comment-16374551 ] Stephan Ewen commented on FLINK-8751: - Yes, that makes sense. The reason here is that when Flink

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170291034 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala --- @@ -18,48 +18,67 @@ package

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374593#comment-16374593 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374594#comment-16374594 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230962 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -178,46 +244,128 @@ class

[jira] [Created] (FLINK-8771) Upgrade scalastyle to 1.0.0

2018-02-23 Thread Ted Yu (JIRA)
Ted Yu created FLINK-8771: - Summary: Upgrade scalastyle to 1.0.0 Key: FLINK-8771 URL: https://issues.apache.org/jira/browse/FLINK-8771 Project: Flink Issue Type: Improvement Components:

[jira] [Updated] (FLINK-8751) Canceling a job results in a InterruptedException in the TM

2018-02-23 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elias Levy updated FLINK-8751: -- Description: Canceling a job results in the following exception reported by the TM:  {code:java} ERROR

[jira] [Updated] (FLINK-8737) Creating a union of UnionGate instances will fail with UnsupportedOperationException when retrieving buffers

2018-02-23 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8737: --- Priority: Blocker (was: Major) > Creating a union of UnionGate instances will fail with >

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374578#comment-16374578 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170256851 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374589#comment-16374589 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170224845 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java --- @@ -83,10

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170229569 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -128,6 +165,13 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230912 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -178,46 +244,128 @@ class

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374586#comment-16374586 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374574#comment-16374574 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374575#comment-16374575 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170230041 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala --- @@ -178,46 +244,128 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170271213 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Schema.scala --- @@ -32,11 +32,36 @@ import

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374577#comment-16374577 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374587#comment-16374587 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374581#comment-16374581 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170257053 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170296912 --- Diff: flink-formats/flink-json/src/main/java/org/apache/flink/table/descriptors/JsonValidator.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374576#comment-16374576 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374582#comment-16374582 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374585#comment-16374585 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374590#comment-16374590 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374583#comment-16374583 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374588#comment-16374588 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374592#comment-16374592 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374591#comment-16374591 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374572#comment-16374572 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374595#comment-16374595 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170257084 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala --- @@ -77,58 +73,113 @@ class

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170273135 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala --- @@ -41,10 +41,10 @@ trait

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5564#discussion_r170290993 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala --- @@ -18,48 +18,67 @@ package

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374579#comment-16374579 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374584#comment-16374584 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374580#comment-16374580 ] ASF GitHub Bot commented on FLINK-8538: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170300254 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -534,42 +536,94 @@ public void postStop() throws Exception {

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374603#comment-16374603 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374600#comment-16374600 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374601#comment-16374601 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374604#comment-16374604 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374602#comment-16374602 ] ASF GitHub Bot commented on FLINK-8746: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170296168 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170279814 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -1156,6 +1213,26 @@ private void disposeSavepoint(String

[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...

2018-02-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5560#discussion_r170296322 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374620#comment-16374620 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on a diff in the pull

[jira] [Updated] (FLINK-8759) Bump Netty to 4.0.56

2018-02-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8759: - Priority: Blocker (was: Major) > Bump Netty to 4.0.56 > > >

[jira] [Updated] (FLINK-8759) Bump Netty to 4.0.56

2018-02-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8759: - Affects Version/s: 1.5.0 > Bump Netty to 4.0.56 > > > Key:

[jira] [Commented] (FLINK-8751) Canceling a job results in a InterruptedException in the TM

2018-02-23 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374525#comment-16374525 ] Elias Levy commented on FLINK-8751: --- Apologies.  I meant TM.  It was a long day.  I've amended the

[jira] [Updated] (FLINK-8755) SpilledSubpartitionView wrongly relys on the backlog for determining whether more data is available

2018-02-23 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8755: --- Priority: Blocker (was: Major) > SpilledSubpartitionView wrongly relys on the backlog for

[jira] [Updated] (FLINK-8736) Memory segment offsets for slices of slices are wrong

2018-02-23 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8736: --- Priority: Critical (was: Major) > Memory segment offsets for slices of slices are wrong >

[GitHub] flink pull request #5570: [FLINK-8768][network] Let NettyMessageDecoder inhe...

2018-02-23 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5570 [FLINK-8768][network] Let NettyMessageDecoder inherit from LengthFieldBasedFrameDecoder ## What is the purpose of the change Instead of being two steps in the channel pipeline,

[jira] [Commented] (FLINK-8768) Change NettyMessageDecoder to inherit from LengthFieldBasedFrameDecoder

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374464#comment-16374464 ] ASF GitHub Bot commented on FLINK-8768: --- GitHub user NicoK opened a pull request:

[jira] [Commented] (FLINK-8725) Separate NFA-state from NFA in CEP library

2018-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374474#comment-16374474 ] ASF GitHub Bot commented on FLINK-8725: --- Github user kl0u commented on the issue:

[jira] [Updated] (FLINK-8694) Make notifyDataAvailable call reliable

2018-02-23 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8694: -- Priority: Blocker (was: Major) > Make notifyDataAvailable call reliable >

[jira] [Updated] (FLINK-8760) Correctly set `moreAvailable` flag in SingleInputGate and UnionInputGate

2018-02-23 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8760: -- Priority: Blocker (was: Major) > Correctly set `moreAvailable` flag in SingleInputGate and

  1   2   3   4   >