[GitHub] [flink] flinkbot commented on issue #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscription' option for Flink Kafka connector

2019-08-05 Thread GitBox
flinkbot commented on issue #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscription' option for Flink Kafka connector URL: https://github.com/apache/flink/pull/9356#issuecomment-518115797 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[GitHub] [flink] zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on third-party maven repositories

2019-08-05 Thread GitBox
zjuwangg commented on issue #9337: [FLINK-13475][hive]Reduce dependency on third-party maven repositories URL: https://github.com/apache/flink/pull/9337#issuecomment-518115991 @bowenli86 @wuchong @xuefuz Could you have a review when you have time?

[jira] [Updated] (FLINK-13340) Add more Kafka topic option of flink-connector-kafka

2019-08-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13340: --- Labels: features pull-request-available (was: features) > Add more Kafka topic option of

[jira] [Commented] (FLINK-13199) ARM support for Flink

2019-08-05 Thread wangxiyuan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899835#comment-16899835 ] wangxiyuan commented on FLINK-13199: yeah, this ticket can be marked as duplicated as 

[GitHub] [flink] KurtYoung commented on issue #9264: [FLINK-13192][hive] Add tests for different Hive table formats

2019-08-05 Thread GitBox
KurtYoung commented on issue #9264: [FLINK-13192][hive] Add tests for different Hive table formats URL: https://github.com/apache/flink/pull/9264#issuecomment-518119852 sure, I will take a look soon. This is an automated

[jira] [Commented] (FLINK-13489) Heavy deployment end-to-end test fails on Travis with TM heartbeat timeout

2019-08-05 Thread Yingjie Cao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899860#comment-16899860 ] Yingjie Cao commented on FLINK-13489: - [~carp84] Thanks for reminding, I have marked the status as

[jira] [Commented] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899861#comment-16899861 ] Jark Wu commented on FLINK-13578: - cc [~lzljs3620320] > Blink throws exception when using

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310465537 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310478255 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310463189 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310476137 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310461362 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310478222 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310464259 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310469247 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310477310 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310465666 ## File path:

[GitHub] [flink] ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations.

2019-08-05 Thread GitBox
ex00 commented on a change in pull request #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#discussion_r310473823 ## File path:

[GitHub] [flink] twalthr commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-08-05 Thread GitBox
twalthr commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-518147572 @wuchong if this PR is in a good shape from your side. I would volunteer to merge it and add some more introductory words and fix a

[jira] [Commented] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899919#comment-16899919 ] Till Rohrmann commented on FLINK-13579: --- I think we should fix the problem by moving the

[jira] [Commented] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899918#comment-16899918 ] Till Rohrmann commented on FLINK-13579: --- The problem is that we always try to update the

[GitHub] [flink] wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation

2019-08-05 Thread GitBox
wuchong commented on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-518150476 Yes. It looks good from my side. Thanks for the help @twalthr .

[GitHub] [flink] GJL commented on issue #9291: [FLINK-13508][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-05 Thread GitBox
GJL commented on issue #9291: [FLINK-13508][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9291#issuecomment-518150215 Merged. This is an

[GitHub] [flink] GJL closed pull request #9291: [FLINK-13508][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-05 Thread GitBox
GJL closed pull request #9291: [FLINK-13508][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9291 This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-516712727 ## CI report: *

[jira] [Comment Edited] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899948#comment-16899948 ] Wei Zhong edited comment on FLINK-13578 at 8/5/19 9:49 AM: --- I guess one of the

[jira] [Commented] (FLINK-13489) Heavy deployment end-to-end test fails on Travis with TM heartbeat timeout

2019-08-05 Thread Yingjie Cao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899957#comment-16899957 ] Yingjie Cao commented on FLINK-13489: - The GC time is still high after I Increased the heap size of

[jira] [Comment Edited] (FLINK-13489) Heavy deployment end-to-end test fails on Travis with TM heartbeat timeout

2019-08-05 Thread Yingjie Cao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899957#comment-16899957 ] Yingjie Cao edited comment on FLINK-13489 at 8/5/19 9:50 AM: - The GC time is

[GitHub] [flink] flinkbot edited a comment on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate …

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate … URL: https://github.com/apache/flink/pull/9355#issuecomment-518089359 ## CI report: * f8f3792f7ce55735f05200c90431b20b99a42d18 : FAILURE

[GitHub] [flink] flinkbot commented on issue #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscription' option for Flink Kafka connector

2019-08-05 Thread GitBox
flinkbot commented on issue #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscription' option for Flink Kafka connector URL: https://github.com/apache/flink/pull/9356#issuecomment-518117192 ## CI report: * 994378a936cb3d0e91dd78607e81229c4680e7d6 : PENDING

[jira] [Created] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread Wei Zhong (JIRA)
Wei Zhong created FLINK-13578: - Summary: Blink throws exception when using Types.INTERVAL_MILLIS in TableSource Key: FLINK-13578 URL: https://issues.apache.org/jira/browse/FLINK-13578 Project: Flink

[jira] [Commented] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899881#comment-16899881 ] TisonKun commented on FLINK-13579: -- [~xintongsong] are there any more details? From the title it's hard

[jira] [Commented] (FLINK-13497) Checkpoints can complete after CheckpointFailureManager fails job

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899896#comment-16899896 ] Till Rohrmann commented on FLINK-13497: --- [~pnowojski] I think this issue would benefit from your

[jira] [Commented] (FLINK-13527) Instable KafkaProducerExactlyOnceITCase due to CheckpointFailureManager

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899898#comment-16899898 ] Till Rohrmann commented on FLINK-13527: --- [~pnowojski] I think this issue would benefit from your

[jira] [Commented] (FLINK-9845) Make InternalTimerService's timer processing interruptible/abortable

2019-08-05 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899895#comment-16899895 ] Biao Liu commented on FLINK-9845: - I think this issue should be reconsidered through mailbox thread

[GitHub] [flink] twalthr commented on issue #9334: [FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently

2019-08-05 Thread GitBox
twalthr commented on issue #9334: [FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently URL: https://github.com/apache/flink/pull/9334#issuecomment-518143534 Thanks @dawidwys. Merging... This

[GitHub] [flink] twalthr commented on a change in pull request #9334: [FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently

2019-08-05 Thread GitBox
twalthr commented on a change in pull request #9334: [FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently URL: https://github.com/apache/flink/pull/9334#discussion_r310496320 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9024: [FLINK-13119] add blink table config to documentation

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#issuecomment-512084139 ## CI report: * 1e4a2e9a584232fd8f5b441567190e1149b6f72f : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs URL: https://github.com/apache/flink/pull/9007#issuecomment-513724290 ## CI report: *

[GitHub] [flink] flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-511466573 ## CI report: * b2e38d5e9dabd95409899c56a3064e75378fdba3 : SUCCESS

[GitHub] [flink] dubin555 opened a new pull request #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscription' option for Flink Kafka connector

2019-08-05 Thread GitBox
dubin555 opened a new pull request #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscription' option for Flink Kafka connector URL: https://github.com/apache/flink/pull/9356 ## What is the purpose of the change This pull request enable Flink Kafka table enable more topic option:

[jira] [Assigned] (FLINK-13532) Broken links in documentation

2019-08-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13532: --- Assignee: Biao Liu > Broken links in documentation > - > >

[GitHub] [flink] pnowojski commented on a change in pull request #9340: [FLINK-13384][runtime] Fix back pressure sampling for SourceStreamTask

2019-08-05 Thread GitBox
pnowojski commented on a change in pull request #9340: [FLINK-13384][runtime] Fix back pressure sampling for SourceStreamTask URL: https://github.com/apache/flink/pull/9340#discussion_r310471128 ## File path:

[GitHub] [flink] docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-08-05 Thread GitBox
docete commented on a change in pull request #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#discussion_r310482247 ## File path: flink-end-to-end-tests/run-pre-commit-tests.sh ## @@ -60,6 +60,7 @@ run_test

[jira] [Commented] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899882#comment-16899882 ] sunjincheng commented on FLINK-13578: - This is better to fix in 1.9, so that user ban be using

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899883#comment-16899883 ] Jark Wu commented on FLINK-13569: - Hive and Spark also use string literal for keys. But identifier is

[jira] [Updated] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread Xintong Song (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-13579: - Labels: test-stability (was: ) > Failed launching standalone cluster due to improper

[GitHub] [flink] flinkbot edited a comment on issue #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscriptionPattern' option for Flink Kafka connector

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9356: [FLINK-13340][kafka][table] Add 'topics' and 'subscriptionPattern' option for Flink Kafka connector URL: https://github.com/apache/flink/pull/9356#issuecomment-518117192 ## CI report: * 994378a936cb3d0e91dd78607e81229c4680e7d6 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#issuecomment-510762700 ## CI report: * fb347fe30a5e894e388837ed2de4f9b60513d7b1 : FAILURE

[GitHub] [flink] GJL commented on issue #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask

2019-08-05 Thread GitBox
GJL commented on issue #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask URL: https://github.com/apache/flink/pull/9271#issuecomment-518162754 Merged This is an automated message from the

[GitHub] [flink] GJL closed pull request #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask

2019-08-05 Thread GitBox
GJL closed pull request #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask URL: https://github.com/apache/flink/pull/9271 This is an automated message from the Apache Git Service. To respond

[jira] [Comment Edited] (FLINK-13489) Heavy deployment end-to-end test fails on Travis with TM heartbeat timeout

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899343#comment-16899343 ] Till Rohrmann edited comment on FLINK-13489 at 8/5/19 9:50 AM: ---

[jira] [Updated] (FLINK-13567) Avro Confluent Schema Registry nightly end-to-end test failed on Travis

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-13567: -- Fix Version/s: 1.9.0 > Avro Confluent Schema Registry nightly end-to-end test failed on

[jira] [Commented] (FLINK-13558) Include table examples in flink-dist

2019-08-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899836#comment-16899836 ] Dawid Wysakowicz commented on FLINK-13558: -- [~sjwiesman] My intention for this ticket was just

[jira] [Commented] (FLINK-13527) Instable KafkaProducerExactlyOnceITCase due to CheckpointFailureManager

2019-08-05 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899850#comment-16899850 ] Yu Li commented on FLINK-13527: --- [~yanghua] Mind clarify whether this JIRA is blocked by FLINK-13497?

[GitHub] [flink] zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors

2019-08-05 Thread GitBox
zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors URL: https://github.com/apache/flink/pull/9342#discussion_r310472230 ## File path:

[GitHub] [flink] zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors

2019-08-05 Thread GitBox
zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors URL: https://github.com/apache/flink/pull/9342#discussion_r310473582 ## File path:

[GitHub] [flink] zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors

2019-08-05 Thread GitBox
zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors URL: https://github.com/apache/flink/pull/9342#discussion_r310471870 ## File path:

[GitHub] [flink] zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors

2019-08-05 Thread GitBox
zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors URL: https://github.com/apache/flink/pull/9342#discussion_r310475347 ## File path:

[GitHub] [flink] beyond1920 commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-08-05 Thread GitBox
beyond1920 commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-518130431 @wuchong , Ok

[jira] [Commented] (FLINK-13450) Adjust tests to tolerate arithmetic differences between x86 and ARM

2019-08-05 Thread wangxiyuan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899865#comment-16899865 ] wangxiyuan commented on FLINK-13450: @Robert, yeah, there is a ticket and  PR for spark already:

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899889#comment-16899889 ] Timo Walther commented on FLINK-13569: -- But what are the implications of using identifier? Can

[jira] [Comment Edited] (FLINK-12481) Make processing time timer trigger run via the mailbox

2019-08-05 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899901#comment-16899901 ] Biao Liu edited comment on FLINK-12481 at 8/5/19 8:34 AM: -- Hi [~srichter], I'm

[jira] [Commented] (FLINK-13450) Adjust tests to tolerate arithmetic differences between x86 and ARM

2019-08-05 Thread wangxiyuan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899908#comment-16899908 ] wangxiyuan commented on FLINK-13450: There is an openjdk bug for StrictMath performance: 

[jira] [Commented] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899944#comment-16899944 ] Jingsong Lee commented on FLINK-13578: -- This should be fixed in 

[GitHub] [flink] flinkbot edited a comment on issue #9274: [FLINK-13495][table-planner-blink] blink-planner should support varchar/char/decimal precision to connector

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9274: [FLINK-13495][table-planner-blink] blink-planner should support varchar/char/decimal precision to connector URL: https://github.com/apache/flink/pull/9274#issuecomment-516352701 ## CI report: * 6e259d68552bf14b3c0f593706d2c879d32b294e :

[GitHub] [flink] zjuwangg commented on issue #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors

2019-08-05 Thread GitBox
zjuwangg commented on issue #9342: [FLINK-13438][hive] Fix DataTypes.DATE/TIME/TIMESTAMP support for hive connectors URL: https://github.com/apache/flink/pull/9342#issuecomment-518117631 cc @xuefuz @lirui-apache This is an

[GitHub] [flink] YngwieWang commented on issue #9350: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-08-05 Thread GitBox
YngwieWang commented on issue #9350: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese URL: https://github.com/apache/flink/pull/9350#issuecomment-518125127 > > Hi, @AT-Fieldless , Thanks for your contribution. I left some suggestions. I hope

[GitHub] [flink] asfgit closed pull request #9344: [FLINK-13532][docs] Fix broken links of zh docs

2019-08-05 Thread GitBox
asfgit closed pull request #9344: [FLINK-13532][docs] Fix broken links of zh docs URL: https://github.com/apache/flink/pull/9344 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (FLINK-13532) Broken links in documentation

2019-08-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13532. - Resolution: Fixed Fix Version/s: 1.10.0 Fixed in 1.10.0:

[GitHub] [flink] flinkbot edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-516712727 ## CI report: *

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899873#comment-16899873 ] Timo Walther commented on FLINK-13569: -- I would also vote for string instead of identifier because

[GitHub] [flink] beyond1920 commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-05 Thread GitBox
beyond1920 commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310482801 ## File path:

[jira] [Commented] (FLINK-13567) Avro Confluent Schema Registry nightly end-to-end test failed on Travis

2019-08-05 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899887#comment-16899887 ] Dawid Wysakowicz commented on FLINK-13567: -- I just checked that this a transient problem with

[jira] [Commented] (FLINK-13450) Adjust tests to tolerate arithmetic differences between x86 and ARM

2019-08-05 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899885#comment-16899885 ] Stephan Ewen commented on FLINK-13450: -- How big is the performance difference in practice? Unless

[GitHub] [flink] asfgit merged pull request #9343: [FLINK-13508][1.8][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-05 Thread GitBox
asfgit merged pull request #9343: [FLINK-13508][1.8][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9343 This is an automated message from the

[jira] [Closed] (FLINK-13463) SQL VALUES might fail for Blink planner

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13463. Resolution: Fixed [FLINK-13463][table-planner-blink] Add test case for VALUES with char literal

[GitHub] [flink] wuchong commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-08-05 Thread GitBox
wuchong commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-518100107 I agree with you @beyond1920 , however, I

[jira] [Created] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread Xintong Song (JIRA)
Xintong Song created FLINK-13579: Summary: Failed launching standalone cluster due to improper configured irrelevant config options for active mode. Key: FLINK-13579 URL:

[GitHub] [flink] flinkbot edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-516712727 ## CI report: *

[jira] [Updated] (FLINK-13567) Avro Confluent Schema Registry nightly end-to-end test failed on Travis

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-13567: -- Priority: Major (was: Blocker) > Avro Confluent Schema Registry nightly end-to-end test

[jira] [Comment Edited] (FLINK-13578) Blink throws exception when using Types.INTERVAL_MILLIS in TableSource

2019-08-05 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899882#comment-16899882 ] sunjincheng edited comment on FLINK-13578 at 8/5/19 8:22 AM: - This is better

[jira] [Assigned] (FLINK-13579) Failed launching standalone cluster due to improper configured irrelevant config options for active mode.

2019-08-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-13579: - Assignee: Xintong Song > Failed launching standalone cluster due to improper

[GitHub] [flink] JingsongLi commented on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-05 Thread GitBox
JingsongLi commented on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#issuecomment-518151605 @wuchong I ignored this cases and created JIRA: https://issues.apache.org/jira/browse/FLINK-13580 I think

[jira] [Created] (FLINK-13580) Add overload support for user defined function to blink-planner

2019-08-05 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13580: Summary: Add overload support for user defined function to blink-planner Key: FLINK-13580 URL: https://issues.apache.org/jira/browse/FLINK-13580 Project: Flink

[jira] [Commented] (FLINK-13449) Add ARM architecture to MemoryArchitecture

2019-08-05 Thread wangxiyuan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899923#comment-16899923 ] wangxiyuan commented on FLINK-13449: Take

[jira] [Updated] (FLINK-13159) java.lang.ClassNotFoundException when restore job

2019-08-05 Thread kring (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kring updated FLINK-13159: -- Attachment: image-2019-08-05-17-32-44-988.png > java.lang.ClassNotFoundException when restore job >

[jira] [Created] (FLINK-13582) Improve the implementation of LISTAGG in Blink planner to remove delimiter from state

2019-08-05 Thread Jing Zhang (JIRA)
Jing Zhang created FLINK-13582: -- Summary: Improve the implementation of LISTAGG in Blink planner to remove delimiter from state Key: FLINK-13582 URL: https://issues.apache.org/jira/browse/FLINK-13582

[jira] [Commented] (FLINK-13449) Add ARM architecture to MemoryArchitecture

2019-08-05 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899952#comment-16899952 ] Stephan Ewen commented on FLINK-13449: -- This seems an issue in the test, though, that the test

[GitHub] [flink] flinkbot edited a comment on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data …

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data … URL: https://github.com/apache/flink/pull/9354#issuecomment-518083679 ## CI report: * 754c52de984cb476ae0442c6704219b64c68441e : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-08-05 Thread GitBox
flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-511466573 ## CI report: * b2e38d5e9dabd95409899c56a3064e75378fdba3 : SUCCESS

[jira] [Commented] (FLINK-13489) Heavy deployment end-to-end test fails on Travis with TM heartbeat timeout

2019-08-05 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899854#comment-16899854 ] Yu Li commented on FLINK-13489: --- Please mark the status as "In-Progress" since you've already started

[GitHub] [flink] dawidwys commented on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner

2019-08-05 Thread GitBox
dawidwys commented on issue #9276: [FLINK-13439] Run Streaming SQL e2e test with blink planner URL: https://github.com/apache/flink/pull/9276#issuecomment-518126428 Hi @docete Would you like to update this PR, or should I do it, while merging?

[jira] [Updated] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13569: Component/s: Table SQL / API > DDL table property key is defined as indentifier but should be string

[jira] [Updated] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-13569: Fix Version/s: 1.10.0 1.9.0 > DDL table property key is defined as indentifier but

[jira] [Commented] (FLINK-10407) Reactive container mode

2019-08-05 Thread Antonio Verardi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899879#comment-16899879 ] Antonio Verardi commented on FLINK-10407: - This feature/re-architecture looks really cool! The

[GitHub] [flink] asfgit closed pull request #9334: [FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently

2019-08-05 Thread GitBox
asfgit closed pull request #9334: [FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently URL: https://github.com/apache/flink/pull/9334 This is an automated message from the Apache Git Service.

[GitHub] [flink] dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/

2019-08-05 Thread GitBox
dawidwys commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r310503698 ## File path:

[jira] [Closed] (FLINK-13508) CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-05 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao closed FLINK-13508. > CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time >

[jira] [Resolved] (FLINK-13508) CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-05 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao resolved FLINK-13508. -- Resolution: Fixed 1.8: a0d236fba7c6abdabb461aa504b1e088a3982c31 1.9:

  1   2   3   4   >