[GitHub] [flink] carp84 commented on pull request #12736: [FLINK-17800][rocksdb] Ensure total order seek to avoid user misuse

2020-06-23 Thread GitBox
carp84 commented on pull request #12736: URL: https://github.com/apache/flink/pull/12736#issuecomment-648026402 @Myasuka Since Robert is on vacation, please help do the manual check and post the result here. Thanks. This is

[jira] [Updated] (FLINK-17800) RocksDB optimizeForPointLookup results in missing time windows

2020-06-23 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated FLINK-17800: -- Priority: Critical (was: Blocker) Downgrade to Critical after some offline discussion, will try best to make

[GitHub] [flink] rkhachatryan commented on pull request #12686: [FLINK-18336][checkpointing] CheckpointFailureManager fixes (WIP)

2020-06-23 Thread GitBox
rkhachatryan commented on pull request #12686: URL: https://github.com/apache/flink/pull/12686#issuecomment-648024815 Breaking this PR into smaller pieces (1st - #12751) This is an automated message from the Apache Git

[GitHub] [flink] rkhachatryan closed pull request #12686: [FLINK-18336][checkpointing] CheckpointFailureManager fixes (WIP)

2020-06-23 Thread GitBox
rkhachatryan closed pull request #12686: URL: https://github.com/apache/flink/pull/12686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] rkhachatryan opened a new pull request #12751: [FLINK-18336][checkpointing] Ignore failures of past checkpoints in CheckpointFailureManager

2020-06-23 Thread GitBox
rkhachatryan opened a new pull request #12751: URL: https://github.com/apache/flink/pull/12751 ## What is the purpose of the change Currently, if failureManager is notified about a failure that it has already seen after a successful checkpoint, it will count it again. This PR

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444089370 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java ## @@ -145,28 +168,55 @@ public void

[GitHub] [flink] godfreyhe edited a comment on pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe edited a comment on pull request #12728: URL: https://github.com/apache/flink/pull/12728#issuecomment-648020411 > They are rather confused about having no output by default. agree with you, for 1.11, we throw an exception if checkpoint is not enabled for streaming query.

[jira] [Closed] (FLINK-18313) Update Hive dialect doc about VIEW

2020-06-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-18313. --- Resolution: Fixed - master (1.12.0): da6867347cd243479de558eed0d8949b5d2e2e48 - 1.11.0:

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444047393 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -705,7 +705,7 @@

[GitHub] [flink] wuchong merged pull request #12666: [FLINK-18313][doc] Update Hive dialect doc about VIEW

2020-06-23 Thread GitBox
wuchong merged pull request #12666: URL: https://github.com/apache/flink/pull/12666 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] godfreyhe commented on pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on pull request #12728: URL: https://github.com/apache/flink/pull/12728#issuecomment-648020411 > They are rather confused about having no output by default. agree with you, for 1.11, we throw an exception if checkpoint is not enabled for streaming query.

[jira] [Commented] (FLINK-18371) NPE of "org.apache.flink.table.data.util.DataFormatConverters$BigDecimalConverter.toExternalImpl(DataFormatConverters.java:680)"

2020-06-23 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142784#comment-17142784 ] Leonard Xu commented on FLINK-18371: Hi, [~caoshaokan] The release-1.11.0-rc1 has been canceled,

[GitHub] [flink] godfreyhe commented on a change in pull request #12750: [FLINK-18413][streaming] CollectResultIterator should throw exception if user does not enable checkpointing in streaming mode

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12750: URL: https://github.com/apache/flink/pull/12750#discussion_r444081509 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala ## @@ -71,9 +75,23 @@ class

[jira] [Commented] (FLINK-18211) Dynamic properties setting 'pipeline.jars' will be overwritten

2020-06-23 Thread Echo Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142776#comment-17142776 ] Echo Lee commented on FLINK-18211: -- We can see the BlobLibraryCacheManager#createUserCodeClassLoader

[jira] [Closed] (FLINK-18380) Add a table source example

2020-06-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-18380. Fix Version/s: 1.12.0 Resolution: Fixed Fixed in 1.12.0:

[jira] [Assigned] (FLINK-18360) Flink History Server doesn't show correctly table of Completed jobs when there are no archived jobs are in the archive directory

2020-06-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-18360: Assignee: Jindrich Vimr > Flink History Server doesn't show correctly table of

[jira] [Updated] (FLINK-18360) Flink History Server doesn't show correctly table of Completed jobs when there are no archived jobs are in the archive directory

2020-06-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-18360: - Fix Version/s: 1.12.0 > Flink History Server doesn't show correctly table of Completed

[jira] [Commented] (FLINK-18066) Add documentation for how to develop a new table source/sink

2020-06-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142773#comment-17142773 ] Timo Walther commented on FLINK-18066: -- [~wangsong] feel free to open an issue for translating the

[jira] [Closed] (FLINK-18360) Flink History Server doesn't show correctly table of Completed jobs when there are no archived jobs are in the archive directory

2020-06-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-18360. Resolution: Fixed master: efcc5434dd744ad547999e970c00142a9b20e914 > Flink History

[GitHub] [flink] zentol merged pull request #12704: [FLINK-18360][runtime/web-frontend/HS] fix no jobs/overview.json file created for HS when no archived jobs present

2020-06-23 Thread GitBox
zentol merged pull request #12704: URL: https://github.com/apache/flink/pull/12704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-18066) Add documentation for how to develop a new table source/sink

2020-06-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-18066. Fix Version/s: 1.11.0 Resolution: Fixed Fixed in 1.12.0:

[jira] [Updated] (FLINK-18360) Flink History Server doesn't show correctly table of Completed jobs when there are no archived jobs are in the archive directory

2020-06-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-18360: - Component/s: (was: Runtime / Web Frontend) Runtime / REST > Flink

[GitHub] [flink] flinkbot edited a comment on pull request #12737: [FLINK-17639][docs] Document which FileSystems are supported by the Streami…

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12737: URL: https://github.com/apache/flink/pull/12737#issuecomment-647407770 ## CI report: * cccbc2294423fce32765002c73acbb06b5ed40a4 UNKNOWN * f009270ba46fafe795a77626ed0acbb50389d4c2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * fa86190a4d00a4fab6bc9ed0fe9d592b0aa56745 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12728: URL: https://github.com/apache/flink/pull/12728#issuecomment-647015309 ## CI report: * 70dd97ae9379c3de39d32abdbd7bda496f214d53 Azure:

[GitHub] [flink] wuchong commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
wuchong commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444075896 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java ## @@ -145,28 +168,55 @@ public void

[GitHub] [flink] wuchong commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
wuchong commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444075896 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java ## @@ -145,28 +168,55 @@ public void

[GitHub] [flink] wuchong commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
wuchong commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444075896 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java ## @@ -145,28 +168,55 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #11245: URL: https://github.com/apache/flink/pull/11245#issuecomment-592002512 ## CI report: * f1d4f9163a2cd60daa02fe6b7af5a459cee9660c UNKNOWN * df986b59c3a09633325d042b41de679c846bdc0d Azure:

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444047393 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -705,7 +705,7 @@

[GitHub] [flink] godfreyhe commented on pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on pull request #12728: URL: https://github.com/apache/flink/pull/12728#issuecomment-648005788 @wuchong @twalthr Thanks for the suggestions, I have updated the pr based on comments, please take another look

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444066174 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java ## @@ -145,28 +168,55 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #12746: [FLINK-15416][task][network] Retry connection to the upstream

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12746: URL: https://github.com/apache/flink/pull/12746#issuecomment-647660048 ## CI report: * 66a9dfae43e2a1f30799e72978ce392a53448ab8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12747: [FLINK-17327] Fix Kafka Producer Resource Leaks (backport to Flink 1.10)

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12747: URL: https://github.com/apache/flink/pull/12747#issuecomment-647739041 ## CI report: * be402f7f12b23c919db336b6a519a95ebd8c8b3d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/172618855) Bot

[GitHub] [flink] flinkbot edited a comment on pull request #12666: [FLINK-18313][doc] Update Hive dialect doc about VIEW

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12666: URL: https://github.com/apache/flink/pull/12666#issuecomment-644563760 ## CI report: * 551400b669fcaca487d7e25f33fccd09e2d0fca0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #11245: URL: https://github.com/apache/flink/pull/11245#issuecomment-592002512 ## CI report: * f1d4f9163a2cd60daa02fe6b7af5a459cee9660c UNKNOWN * df986b59c3a09633325d042b41de679c846bdc0d Azure:

[jira] [Commented] (FLINK-18371) NPE of "org.apache.flink.table.data.util.DataFormatConverters$BigDecimalConverter.toExternalImpl(DataFormatConverters.java:680)"

2020-06-23 Thread shaokan cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142738#comment-17142738 ] shaokan cao commented on FLINK-18371: - [~Leonard Xu] i compile release-1.11.0-rc1,and when i run sql

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444052314 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableResult.java ## @@ -131,14 +131,27 @@ *

[jira] [Commented] (FLINK-18211) Dynamic properties setting 'pipeline.jars' will be overwritten

2020-06-23 Thread Echo Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142724#comment-17142724 ] Echo Lee commented on FLINK-18211: -- [~fly_in_gis] I just verified it in standalone mode, It seems that

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444047821 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableResult.java ## @@ -131,14 +131,27 @@ *

[GitHub] [flink] godfreyhe commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
godfreyhe commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444047393 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -705,7 +705,7 @@

[jira] [Updated] (FLINK-5601) Window operator does not checkpoint watermarks

2020-06-23 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao updated FLINK-5601: -- Affects Version/s: 1.11.0 1.10.0 > Window operator does not checkpoint

[GitHub] [flink] flinkbot edited a comment on pull request #12746: [FLINK-15416][task][network] Retry connection to the upstream

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12746: URL: https://github.com/apache/flink/pull/12746#issuecomment-647660048 ## CI report: * 66a9dfae43e2a1f30799e72978ce392a53448ab8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12666: [FLINK-18313][doc] Update Hive dialect doc about VIEW

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12666: URL: https://github.com/apache/flink/pull/12666#issuecomment-644563760 ## CI report: * 551400b669fcaca487d7e25f33fccd09e2d0fca0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12054: [FLINK-17579] Allow user to set the prefix of TaskManager's ResourceID in standalone mode

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12054: URL: https://github.com/apache/flink/pull/12054#issuecomment-626143079 ## CI report: * 311c21707305392d6bde18038bb1d8413867419b UNKNOWN * e6338bad0847a8842e66a928e48f98083b63cff9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #11245: URL: https://github.com/apache/flink/pull/11245#issuecomment-592002512 ## CI report: * f1d4f9163a2cd60daa02fe6b7af5a459cee9660c UNKNOWN * df986b59c3a09633325d042b41de679c846bdc0d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #9648: [FLINK-13872] [docs-zh] Translate Operations Playground to Chinese

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #9648: URL: https://github.com/apache/flink/pull/9648#issuecomment-529346361 ## CI report: * 11e3046934f53154f23d229d7418493570afda97 Azure:

[GitHub] [flink] nielsbasjes commented on a change in pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version

2020-06-23 Thread GitBox
nielsbasjes commented on a change in pull request #11245: URL: https://github.com/apache/flink/pull/11245#discussion_r444033798 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java ## @@ -137,11 +138,17 @@

[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks

2020-06-23 Thread GitBox
aljoscha commented on pull request #12589: URL: https://github.com/apache/flink/pull/12589#issuecomment-647974387 This was fixed, yes: https://issues.apache.org/jira/browse/FLINK-18311. I don't know how it happened, I had green builds on my private Azure before I merged. Something must

[GitHub] [flink] twalthr closed pull request #12724: [FLINK-18006][FLINK-18380][docs][examples] Add documentation for new table sources and sinks

2020-06-23 Thread GitBox
twalthr closed pull request #12724: URL: https://github.com/apache/flink/pull/12724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-16835) Replace TableConfig with Configuration

2020-06-23 Thread Fabian Hueske (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-16835: -- Description: In order to allow reading and writing of configuration from a file or

[jira] [Commented] (FLINK-18373) Drop performance unit tests in RocksDB state backend module

2020-06-23 Thread MinWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142701#comment-17142701 ] MinWang commented on FLINK-18373: - Great! I will pick another issue to work on. Thank you for the reply.

[jira] [Commented] (FLINK-15693) Stop receiving incoming RPC messages when RpcEndpoint is closing

2020-06-23 Thread MinWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142700#comment-17142700 ] MinWang commented on FLINK-15693: - [~trohrmann] Thanks for the quick reply. I think it only needs to

[GitHub] [flink] flinkbot edited a comment on pull request #12747: [FLINK-17327] Fix Kafka Producer Resource Leaks (backport to Flink 1.10)

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12747: URL: https://github.com/apache/flink/pull/12747#issuecomment-647739041 ## CI report: * b2916ff151653f8d2a952ab8acd52e8fce031055 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/172554306) *

[GitHub] [flink] flinkbot edited a comment on pull request #12748: [FLINK-18324][docs-zh] Translate updated data type into Chinese

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12748: URL: https://github.com/apache/flink/pull/12748#issuecomment-647889022 ## CI report: * 2a146962687424a20b253ed3fcc42700e416375d Azure:

[jira] [Updated] (FLINK-16835) Replace TableConfig with Configuration

2020-06-23 Thread Fabian Hueske (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-16835: -- Description: In order to allow reading and writing of configuration from a file or

[jira] [Updated] (FLINK-16835) Replace TableConfig with Configuration

2020-06-23 Thread Fabian Hueske (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-16835: -- Description: In order to allow reading and writing of configuration from a file or

[GitHub] [flink] twalthr commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
twalthr commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444016557 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java ## @@ -66,70 +77,102 @@ public static void

[jira] [Commented] (FLINK-16835) Replace TableConfig with Configuration

2020-06-23 Thread Fabian Hueske (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142699#comment-17142699 ] Fabian Hueske commented on FLINK-16835: --- I think we have consensus. I'll copy the result of our

[jira] [Commented] (FLINK-16835) Replace TableConfig with Configuration

2020-06-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142696#comment-17142696 ] Jark Wu commented on FLINK-16835: - +1 > Replace TableConfig with Configuration >

[GitHub] [flink] RocMarshal commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-23 Thread GitBox
RocMarshal commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r444019317 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,156 @@ under the License. ## State Backends -The keyed state managed by

[jira] [Commented] (FLINK-16835) Replace TableConfig with Configuration

2020-06-23 Thread Fabian Hueske (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142693#comment-17142693 ] Fabian Hueske commented on FLINK-16835: --- Thanks for the feedback [~twalthr]. So the options are

[GitHub] [flink] RocMarshal commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-23 Thread GitBox
RocMarshal commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r444017808 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,156 @@ under the License. ## State Backends -The keyed state managed by

[GitHub] [flink] wuchong commented on a change in pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
wuchong commented on a change in pull request #12728: URL: https://github.com/apache/flink/pull/12728#discussion_r444005803 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableResult.java ## @@ -131,14 +131,27 @@ * it...

[jira] [Commented] (FLINK-5601) Window operator does not checkpoint watermarks

2020-06-23 Thread Congxian Qiu(klion26) (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142686#comment-17142686 ] Congxian Qiu(klion26) commented on FLINK-5601: -- Seems another affected user(user-zh mail

[jira] [Commented] (FLINK-18211) Dynamic properties setting 'pipeline.jars' will be overwritten

2020-06-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142684#comment-17142684 ] Yang Wang commented on FLINK-18211: --- [~Echo Lee] Do you have verified that {{flink run

[jira] [Closed] (FLINK-18353) [1.11.0] maybe document jobmanager behavior change regarding -XX:MaxDirectMemorySize

2020-06-23 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-18353. - Fix Version/s: 1.11.0 Resolution: Fixed Fixed via master:

[GitHub] [flink] flinkbot edited a comment on pull request #12747: [FLINK-17327] Fix Kafka Producer Resource Leaks (backport to Flink 1.10)

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12747: URL: https://github.com/apache/flink/pull/12747#issuecomment-647739041 ## CI report: * b2916ff151653f8d2a952ab8acd52e8fce031055 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/172554306) *

[GitHub] [flink] flinkbot edited a comment on pull request #12742: [FLINK-18407][runtime] Harden SlotPoolImpl#maybeRemapOrphanedAllocation

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12742: URL: https://github.com/apache/flink/pull/12742#issuecomment-647480026 ## CI report: * 62e7974d623dbda1cdff2def52324973f4ec22fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12054: [FLINK-17579] Allow user to set the prefix of TaskManager's ResourceID in standalone mode

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12054: URL: https://github.com/apache/flink/pull/12054#issuecomment-626143079 ## CI report: * 311c21707305392d6bde18038bb1d8413867419b UNKNOWN * e85a3c626720f035ff0379e849e36ea6e8db7249 Azure:

[jira] [Commented] (FLINK-11401) Allow compression on ParquetBulkWriter

2020-06-23 Thread Ryo Okubo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142678#comment-17142678 ] Ryo Okubo commented on FLINK-11401: --- Any progress on this issue? The pullreq seems to be mostly done.

[jira] [Commented] (FLINK-18409) The FilterJoinRule.FILTER_ON_JOIN optimizer rule cause 'Join With a Temporal Table' not working properly

2020-06-23 Thread Yuhao Zhao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142673#comment-17142673 ] Yuhao Zhao commented on FLINK-18409: cc [~jark]。Hi, Jark Wu What do you think about the problem? >

[jira] [Comment Edited] (FLINK-18371) NPE of "org.apache.flink.table.data.util.DataFormatConverters$BigDecimalConverter.toExternalImpl(DataFormatConverters.java:680)"

2020-06-23 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142672#comment-17142672 ] Leonard Xu edited comment on FLINK-18371 at 6/23/20, 6:59 AM: -- I test this

[jira] [Commented] (FLINK-18371) NPE of "org.apache.flink.table.data.util.DataFormatConverters$BigDecimalConverter.toExternalImpl(DataFormatConverters.java:680)"

2020-06-23 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142672#comment-17142672 ] Leonard Xu commented on FLINK-18371: I test this case use filesystem connector in latest

[jira] [Created] (FLINK-18415) Support TableResult#collect in the Python Table API to align with the Java Table API

2020-06-23 Thread Dian Fu (Jira)
Dian Fu created FLINK-18415: --- Summary: Support TableResult#collect in the Python Table API to align with the Java Table API Key: FLINK-18415 URL: https://issues.apache.org/jira/browse/FLINK-18415 Project:

[GitHub] [flink] flinkbot edited a comment on pull request #12742: [FLINK-18407][runtime] Harden SlotPoolImpl#maybeRemapOrphanedAllocation

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12742: URL: https://github.com/apache/flink/pull/12742#issuecomment-647480026 ## CI report: * 62e7974d623dbda1cdff2def52324973f4ec22fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12747: [FLINK-17327] Fix Kafka Producer Resource Leaks (backport to Flink 1.10)

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12747: URL: https://github.com/apache/flink/pull/12747#issuecomment-647739041 ## CI report: * b2916ff151653f8d2a952ab8acd52e8fce031055 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/172554306) Bot

[jira] [Closed] (FLINK-18411) CollectionExecutorTest failed to compiled in release-1.11

2020-06-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-18411. --- Resolution: Fixed Fixed in 1.11.0: 83d78134d2497266f8d864b2667c10a955384b94 This problem not exists in

[GitHub] [flink] wuchong commented on pull request #12749: [FLINK-18411][tests] Fix CollectionExecutorTest failed to compiled in release-1.11

2020-06-23 Thread GitBox
wuchong commented on pull request #12749: URL: https://github.com/apache/flink/pull/12749#issuecomment-647943193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] wuchong merged pull request #12749: [FLINK-18411][tests] Fix CollectionExecutorTest failed to compiled in release-1.11

2020-06-23 Thread GitBox
wuchong merged pull request #12749: URL: https://github.com/apache/flink/pull/12749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] aljoscha commented on pull request #12747: [FLINK-17327] Fix Kafka Producer Resource Leaks (backport to Flink 1.10)

2020-06-23 Thread GitBox
aljoscha commented on pull request #12747: URL: https://github.com/apache/flink/pull/12747#issuecomment-647939692 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-18352) org.apache.flink.core.execution.DefaultExecutorServiceLoader not thread safe

2020-06-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142656#comment-17142656 ] Piotr Nowojski commented on FLINK-18352: This caused

[GitHub] [flink] flinkbot edited a comment on pull request #12728: [FLINK-18399] [table-api-java] fix TableResult#print can not print the result of unbounded stream query

2020-06-23 Thread GitBox
flinkbot edited a comment on pull request #12728: URL: https://github.com/apache/flink/pull/12728#issuecomment-647015309 ## CI report: * 70dd97ae9379c3de39d32abdbd7bda496f214d53 Azure:

[jira] [Commented] (FLINK-18406) Annotate DualKeyLinkedMap with @Nullable annotation

2020-06-23 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142651#comment-17142651 ] Zhu Zhu commented on FLINK-18406: - Well I see that @Nullable annotations are still good to have,

[jira] [Updated] (FLINK-18187) CheckPubSubEmulatorTest failed on azure

2020-06-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-18187: --- Priority: Critical (was: Major) > CheckPubSubEmulatorTest failed on azure >

[jira] [Commented] (FLINK-18187) CheckPubSubEmulatorTest failed on azure

2020-06-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142650#comment-17142650 ] Piotr Nowojski commented on FLINK-18187: another instance on 1.11 branch:

[jira] [Updated] (FLINK-18371) NPE of "org.apache.flink.table.data.util.DataFormatConverters$BigDecimalConverter.toExternalImpl(DataFormatConverters.java:680)"

2020-06-23 Thread xiaojin.wy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojin.wy updated FLINK-18371: --- Environment: I use the sql-gateway to run this sql. The environment is streaming. *The sql is:*

[jira] [Commented] (FLINK-18406) Annotate DualKeyLinkedMap with @Nullable annotation

2020-06-23 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142644#comment-17142644 ] Zhu Zhu commented on FLINK-18406: - Would it make sense to forbid null keys in DualKeyLinkedMap? Or even

[GitHub] [flink] tillrohrmann closed pull request #12745: [FLINK-18353] Make enabling of the JVM Direct Memory limit configurable for JM

2020-06-23 Thread GitBox
tillrohrmann closed pull request #12745: URL: https://github.com/apache/flink/pull/12745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] klion26 commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-23 Thread GitBox
klion26 commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r443971994 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,156 @@ under the License. ## State Backends -The keyed state managed by Flink

<    1   2   3   4