[GitHub] [flink] flinkbot edited a comment on pull request #13346: [FLINK-18832][datastream] Add compatible check for blocking partition with buffer timeout

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13346: URL: https://github.com/apache/flink/pull/13346#issuecomment-688586355 ## CI report: * 53aec1bb47cdda488aa255ce353caf9efb636d7c Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/183266593) *

[jira] [Comment Edited] (FLINK-16595) Support extra hadoop filesystem URLs for which to request delegation tokens

2020-09-08 Thread Husky Zeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191505#comment-17191505 ] Husky Zeng edited comment on FLINK-16595 at 9/8/20, 6:46 AM: - Hi chesnay, I

[jira] [Commented] (FLINK-15587) Flink image does not run on OpenShift

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191983#comment-17191983 ] Robert Metzger commented on FLINK-15587: As far as I understood, OpenShift requires non-root

[GitHub] [flink] flinkbot edited a comment on pull request #13044: [FLINK-18641][checkpointing] Fix CheckpointCoordinator to work with ExternallyInducedSource

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13044: URL: https://github.com/apache/flink/pull/13044#issuecomment-667693350 ## CI report: * 7569871bac8e6dd6d9ac272f94e0fcb30b810e51 Azure:

[GitHub] [flink] azagrebin commented on a change in pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
azagrebin commented on a change in pull request #13181: URL: https://github.com/apache/flink/pull/13181#discussion_r484706282 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SharedSlotTest.java ## @@ -234,6 +236,45 @@ public void

[jira] [Commented] (FLINK-18842) e2e test failed to download "localhost:9999/flink.tgz" in "Wordcount on Docker test"

2020-09-08 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192012#comment-17192012 ] Matthias commented on FLINK-18842: -- All three builds reached the upper limit of 260mins (4 hours 20

[GitHub] [flink] flinkbot edited a comment on pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13181: URL: https://github.com/apache/flink/pull/13181#issuecomment-675091412 ## CI report: * e7553689356882de1ffe606400d1255d1d757bc4 UNKNOWN * d01d63a8d22b82b6b8168d3abed0505191d655e6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13228: URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456 ## CI report: * d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN * 4af565f8d262b2ed2ebfb7614e0f24494eb22186 Azure:

[GitHub] [flink] aljoscha commented on a change in pull request #13343: [FLINK-19083] Remove deprecated DataStream#split

2020-09-08 Thread GitBox
aljoscha commented on a change in pull request #13343: URL: https://github.com/apache/flink/pull/13343#discussion_r484693324 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java ## @@ -138,138 +132,6 @@ public

[GitHub] [flink] azagrebin commented on a change in pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
azagrebin commented on a change in pull request #13181: URL: https://github.com/apache/flink/pull/13181#discussion_r484711637 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackendBuilder.java

[jira] [Updated] (FLINK-19141) Flink Job Submitted on Yarn Does not Assign Task Manager

2020-09-08 Thread Yunhui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhui updated FLINK-19141: --- Description: 1. Create a flink cluster on yarn 2. Submit my job 3. The job manager print logs with

[jira] [Commented] (FLINK-19054) KafkaTableITCase.testKafkaSourceSink hangs

2020-09-08 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192027#comment-17192027 ] Jiangjie Qin commented on FLINK-19054: -- [~rmetzger] The test has two steps. # Write some records

[GitHub] [flink] flinkbot edited a comment on pull request #13343: [FLINK-19083] Remove deprecated DataStream#split

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13343: URL: https://github.com/apache/flink/pull/13343#issuecomment-68843 ## CI report: * 0bafb7b2bc74859d5ebf06c29e583735b7774677 Azure:

[jira] [Created] (FLINK-19163) Add building py38 wheel package of PyFlink in Azure CI

2020-09-08 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-19163: Summary: Add building py38 wheel package of PyFlink in Azure CI Key: FLINK-19163 URL: https://issues.apache.org/jira/browse/FLINK-19163 Project: Flink Issue

[GitHub] [flink-statefun] tzulitai commented on pull request #142: [FLINK-19130] [core] Expose metrics for backpressure

2020-09-08 Thread GitBox
tzulitai commented on pull request #142: URL: https://github.com/apache/flink-statefun/pull/142#issuecomment-688648375 Update: After another offline discussion with @igalshilman, we decided to still add metrics for backlog monitoring, per function type. It's a rather low-hanging

[GitHub] [flink] flinkbot edited a comment on pull request #13216: [FLINK-18999][table-planner-blink][hive] Temporary generic table does…

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13216: URL: https://github.com/apache/flink/pull/13216#issuecomment-678268420 ## CI report: * 167e78ad9d9f8fdb79ce5b2483feed7f120456a3 Azure:

[GitHub] [flink] sujun1020 commented on a change in pull request #13306: [FLINK-17779][Connectors/ORC]Orc file format support filter push down

2020-09-08 Thread GitBox
sujun1020 commented on a change in pull request #13306: URL: https://github.com/apache/flink/pull/13306#discussion_r484742049 ## File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcFilters.java ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] stoiev opened a new pull request #13350: [hotfix] [docs] remove inexistent memory unit reference from javadoc

2020-09-08 Thread GitBox
stoiev opened a new pull request #13350: URL: https://github.com/apache/flink/pull/13350 There is no "q" unit on [`MemoryUnit`](https://github.com/apache/flink/compare/master...stoiev:patch-1#diff-3bda0b396119817325513063c8ec060dL362) enum

[jira] [Commented] (FLINK-19124) Some JobClient methods are not ergonomic, require ClassLoader argument

2020-09-08 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192055#comment-17192055 ] Aljoscha Krettek commented on FLINK-19124: -- Btw, this recent change added a {{ClassLoader}}

[GitHub] [flink] becketqin commented on pull request #13044: [FLINK-18641][checkpointing] Fix CheckpointCoordinator to work with ExternallyInducedSource

2020-09-08 Thread GitBox
becketqin commented on pull request #13044: URL: https://github.com/apache/flink/pull/13044#issuecomment-688646137 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-16595) Support extra hadoop filesystem URLs for which to request delegation tokens

2020-09-08 Thread Husky Zeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192007#comment-17192007 ] Husky Zeng commented on FLINK-16595: Hi Robert , I hava solved this problem in my production

[GitHub] [flink] zhuzhurk commented on a change in pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
zhuzhurk commented on a change in pull request #13181: URL: https://github.com/apache/flink/pull/13181#discussion_r484708915 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackendBuilder.java

[GitHub] [flink] flinkbot edited a comment on pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13181: URL: https://github.com/apache/flink/pull/13181#issuecomment-675091412 ## CI report: * e7553689356882de1ffe606400d1255d1d757bc4 UNKNOWN * d01d63a8d22b82b6b8168d3abed0505191d655e6 Azure:

[jira] [Comment Edited] (FLINK-18842) e2e test failed to download "localhost:9999/flink.tgz" in "Wordcount on Docker test"

2020-09-08 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192012#comment-17192012 ] Matthias edited comment on FLINK-18842 at 9/8/20, 7:55 AM: --- All three builds

[jira] [Comment Edited] (FLINK-18832) BoundedBlockingSubpartition does not work with StreamTask

2020-09-08 Thread Zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191748#comment-17191748 ] Zhijiang edited comment on FLINK-18832 at 9/8/20, 8:10 AM: --- Merged in master:

[GitHub] [flink] xintongsong commented on a change in pull request #13311: [FLINK-18721] Migrate YarnResourceManager to the new YarnResourceManagerDriver

2020-09-08 Thread GitBox
xintongsong commented on a change in pull request #13311: URL: https://github.com/apache/flink/pull/13311#discussion_r484622514 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/TaskExecutorProcessSpecContainerResourceAdapter.java ## @@ -86,21 +81,21 @@

[GitHub] [flink] flinkbot edited a comment on pull request #13346: [FLINK-18832][datastream] Add compatible check for blocking partition with buffer timeout

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13346: URL: https://github.com/apache/flink/pull/13346#issuecomment-688586355 ## CI report: * 53aec1bb47cdda488aa255ce353caf9efb636d7c Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/183266593) *

[GitHub] [flink] zhuzhurk commented on pull request #13321: [FLINK-14870] Remove nullable assumption of task slot sharing group

2020-09-08 Thread GitBox
zhuzhurk commented on pull request #13321: URL: https://github.com/apache/flink/pull/13321#issuecomment-688646723 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] leonardBang commented on a change in pull request #13294: [FLINK-19002][canal][json] Support to only read changelogs of specific database and table for canal-json format

2020-09-08 Thread GitBox
leonardBang commented on a change in pull request #13294: URL: https://github.com/apache/flink/pull/13294#discussion_r484702198 ## File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/canal/CanalJsonFormatFactoryTest.java ## @@ -64,44 +64,50 @@

[GitHub] [flink] leonardBang commented on a change in pull request #13275: [FLINK-19064][hbase] HBaseRowDataInputFormat is leaking resources

2020-09-08 Thread GitBox
leonardBang commented on a change in pull request #13275: URL: https://github.com/apache/flink/pull/13275#discussion_r484722000 ## File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseTableInputFormatTest.java ## @@ -0,0 +1,58

[GitHub] [flink] zhijiangW merged pull request #13346: [FLINK-18832][datastream] Add compatible check for blocking partition with buffer timeout

2020-09-08 Thread GitBox
zhijiangW merged pull request #13346: URL: https://github.com/apache/flink/pull/13346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #13321: [FLINK-14870] Remove nullable assumption of task slot sharing group

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13321: URL: https://github.com/apache/flink/pull/13321#issuecomment-686567896 ## CI report: * d79f152fa91b8bc555af6fb2a00a8d62b184be5a UNKNOWN * 96e983d10c7095847b404461abd01b4d1ebb0aac Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13044: [FLINK-18641][checkpointing] Fix CheckpointCoordinator to work with ExternallyInducedSource

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13044: URL: https://github.com/apache/flink/pull/13044#issuecomment-667693350 ## CI report: * 7569871bac8e6dd6d9ac272f94e0fcb30b810e51 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13275: [FLINK-19064][hbase] HBaseRowDataInputFormat is leaking resources

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13275: URL: https://github.com/apache/flink/pull/13275#issuecomment-682391096 ## CI report: * 74ac3764e017be069dd2eae07e893a0c8cad40e4 Azure:

[jira] [Closed] (FLINK-19090) Translate "Local Cluster" of "Clusters & Depolyment" page into Chinese

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-19090. -- Fix Version/s: 1.12.0 Resolution: Fixed Merged to master in

[GitHub] [flink] rmetzger commented on pull request #13279: [FLINK-19090][docs-zh] Translate "Local Cluster" of "Clusters & Depolyment" page into Chinese

2020-09-08 Thread GitBox
rmetzger commented on pull request #13279: URL: https://github.com/apache/flink/pull/13279#issuecomment-688655891 Thanks for the contribution & review. Merging ... This is an automated message from the Apache Git Service. To

[GitHub] [flink] rmetzger closed pull request #13279: [FLINK-19090][docs-zh] Translate "Local Cluster" of "Clusters & Depolyment" page into Chinese

2020-09-08 Thread GitBox
rmetzger closed pull request #13279: URL: https://github.com/apache/flink/pull/13279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] azagrebin commented on a change in pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
azagrebin commented on a change in pull request #13181: URL: https://github.com/apache/flink/pull/13181#discussion_r484706282 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SharedSlotTest.java ## @@ -234,6 +236,45 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #13343: [FLINK-19083] Remove deprecated DataStream#split

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13343: URL: https://github.com/apache/flink/pull/13343#issuecomment-68843 ## CI report: * 0bafb7b2bc74859d5ebf06c29e583735b7774677 Azure:

[jira] [Commented] (FLINK-19054) KafkaTableITCase.testKafkaSourceSink hangs

2020-09-08 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192033#comment-17192033 ] Jark Wu commented on FLINK-19054: - I agree with [~becket_qin], we should first to make sure which step

[jira] [Commented] (FLINK-18842) e2e test failed to download "localhost:9999/flink.tgz" in "Wordcount on Docker test"

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192040#comment-17192040 ] Robert Metzger commented on FLINK-18842: But the problem is that we are stuck in this test for 3

[jira] [Commented] (FLINK-17329) Quickstarts Scala nightly e2e test failed on travis

2020-09-08 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191975#comment-17191975 ] Zhu Zhu commented on FLINK-17329: - Another instance:

[jira] [Commented] (FLINK-18335) NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted time outs

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191974#comment-17191974 ] Robert Metzger commented on FLINK-18335: Okay, that's even better. Thanks. >

[GitHub] [flink] rmetzger commented on a change in pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase

2020-09-08 Thread GitBox
rmetzger commented on a change in pull request #13349: URL: https://github.com/apache/flink/pull/13349#discussion_r484676380 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/NotifyCheckpointAbortedITCase.java ## @@ -97,8 +99,10 @@ */

[GitHub] [flink] zhijiangW merged pull request #13345: [FLINK-18832][datastream] Add compatible check for blocking partition with buffer timeout

2020-09-08 Thread GitBox
zhijiangW merged pull request #13345: URL: https://github.com/apache/flink/pull/13345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #13321: [FLINK-14870] Remove nullable assumption of task slot sharing group

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13321: URL: https://github.com/apache/flink/pull/13321#issuecomment-686567896 ## CI report: * d79f152fa91b8bc555af6fb2a00a8d62b184be5a UNKNOWN * 96e983d10c7095847b404461abd01b4d1ebb0aac Azure:

[GitHub] [flink] azagrebin commented on a change in pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
azagrebin commented on a change in pull request #13181: URL: https://github.com/apache/flink/pull/13181#discussion_r484706282 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SharedSlotTest.java ## @@ -234,6 +236,45 @@ public void

[jira] [Closed] (FLINK-17637) HadoopS3RecoverableWriterITCase fails with Expected exception: java.io.FileNotFoundException

2020-09-08 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17637. Resolution: Fixed master: 390926e61aeb69837c70a024ad6e7ff02eccdf2d >

[GitHub] [flink] pnowojski commented on pull request #13109: [FLINK-18808][runtime/metrics] Include side outputs in numRecordsOut metric.

2020-09-08 Thread GitBox
pnowojski commented on pull request #13109: URL: https://github.com/apache/flink/pull/13109#issuecomment-688690309 @liming30 I have a good news and a bad news. Good news, there is no problem with `OutputSelector`. Bad news, is that we have wasted quite a bit of time trying to fix/address

[GitHub] [flink] aljoscha merged pull request #12631: [FLINK-17637][connector] Fix the unstable case HadoopS3RecoverableWriterITCase#testCleanupRecoverableState

2020-09-08 Thread GitBox
aljoscha merged pull request #12631: URL: https://github.com/apache/flink/pull/12631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13181: URL: https://github.com/apache/flink/pull/13181#issuecomment-675091412 ## CI report: * e7553689356882de1ffe606400d1255d1d757bc4 UNKNOWN * d01d63a8d22b82b6b8168d3abed0505191d655e6 Azure:

[GitHub] [flink] flinkbot commented on pull request #13350: [hotfix] [docs] remove inexistent memory unit reference from javadoc

2020-09-08 Thread GitBox
flinkbot commented on pull request #13350: URL: https://github.com/apache/flink/pull/13350#issuecomment-688728434 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-18989) Write input and output channel state to separate files

2020-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18989: --- Labels: pull-request-available (was: ) > Write input and output channel state to separate

[GitHub] [flink] rkhachatryan opened a new pull request #13351: [FLINK-18989][task] Read channel state sequentially

2020-09-08 Thread GitBox
rkhachatryan opened a new pull request #13351: URL: https://github.com/apache/flink/pull/13351 ## What is the purpose of the change This is a *draft* PR to implement sequential reading of channel state. There are still some unknowns: - whether we want sequential read (as it

[GitHub] [flink] flinkbot commented on pull request #13350: [hotfix] [docs] remove inexistent memory unit reference from javadoc

2020-09-08 Thread GitBox
flinkbot commented on pull request #13350: URL: https://github.com/apache/flink/pull/13350#issuecomment-688731508 ## CI report: * 4b51553120480a1755e5f325b9ed7962beda47a7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13345: [FLINK-18832][datastream] Add compatible check for blocking partition with buffer timeout

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13345: URL: https://github.com/apache/flink/pull/13345#issuecomment-688586280 ## CI report: * ef7be4cb05c3f25d1a0837fa22a65b92c4817d1d Azure:

[jira] [Commented] (FLINK-19151) Flink does not normalize container resource with correct configurations when Yarn FairScheduler is used

2020-09-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191985#comment-17191985 ] Yang Wang commented on FLINK-19151: --- [~xintongsong] Thanks for the explanation. I agree with you that

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13283: URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514 ## CI report: * abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13216: [FLINK-18999][table-planner-blink][hive] Temporary generic table does…

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13216: URL: https://github.com/apache/flink/pull/13216#issuecomment-678268420 ## CI report: * 167e78ad9d9f8fdb79ce5b2483feed7f120456a3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13347: [FLINK-19151][yarn]Fix the unit value according to different yarn scheduler

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13347: URL: https://github.com/apache/flink/pull/13347#issuecomment-688594190 ## CI report: * 08cde36b22f34a53c41f7a864f50ef6cd33ca9fe Azure:

[GitHub] [flink] leonardBang commented on a change in pull request #13275: [FLINK-19064][hbase] HBaseRowDataInputFormat is leaking resources

2020-09-08 Thread GitBox
leonardBang commented on a change in pull request #13275: URL: https://github.com/apache/flink/pull/13275#discussion_r484722504 ## File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseTableInputFormatTest.java ## @@ -0,0 +1,58

[GitHub] [flink] JingsongLi commented on a change in pull request #13306: [FLINK-17779][Connectors/ORC]Orc file format support filter push down

2020-09-08 Thread GitBox
JingsongLi commented on a change in pull request #13306: URL: https://github.com/apache/flink/pull/13306#discussion_r484744588 ## File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/OrcFilters.java ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on pull request #13181: [FLINK-18957] Implement logical request bulk tracking in SlotSharingExecutionSlotAllocator

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13181: URL: https://github.com/apache/flink/pull/13181#issuecomment-675091412 ## CI report: * e7553689356882de1ffe606400d1255d1d757bc4 UNKNOWN * d01d63a8d22b82b6b8168d3abed0505191d655e6 Azure:

[jira] [Commented] (FLINK-19124) Some JobClient methods are not ergonomic, require ClassLoader argument

2020-09-08 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192052#comment-17192052 ] Aljoscha Krettek commented on FLINK-19124: -- I'm sorry but I'm almost never reachable on

[GitHub] [flink] flinkbot edited a comment on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13349: URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994 ## CI report: * 77c43f984f9a66201cf8b80b18ac94e836bc81ca Azure:

[GitHub] [flink] flinkbot commented on pull request #13351: [FLINK-18989][task] Read channel state sequentially

2020-09-08 Thread GitBox
flinkbot commented on pull request #13351: URL: https://github.com/apache/flink/pull/13351#issuecomment-688730494 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #13350: [hotfix] [docs] remove inexistent memory unit reference from javadoc

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13350: URL: https://github.com/apache/flink/pull/13350#issuecomment-688731508 ## CI report: * 4b51553120480a1755e5f325b9ed7962beda47a7 Azure:

[GitHub] [flink] alpinegizmo commented on pull request #13342: (1.10) [FLINK-19109][task] Emit watermarks when FileReader is closing

2020-09-08 Thread GitBox
alpinegizmo commented on pull request #13342: URL: https://github.com/apache/flink/pull/13342#issuecomment-688819973 @rkhachatryan I was mistaken: I have multiple 1.10-SNAPSHOT builds, and I tested against the wrong one. This PR does work correctly for this use case.

[GitHub] [flink] flinkbot edited a comment on pull request #13344: [FLINK-10740] FLIP-27 File Source and various Updates on the Split Reader API

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13344: URL: https://github.com/apache/flink/pull/13344#issuecomment-688495541 ## CI report: * 15a81e82a4a42cd255baad4ffd3e7e20343b5389 UNKNOWN * 08bee6eb21289629dab7ebd19d5feac307cfb194 Azure:

[GitHub] [flink] echauchot commented on pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-09-08 Thread GitBox
echauchot commented on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-688845131 > Thanks for updating your PR @echauchot > There is no cyclic dependency now and `CompletedCheckpointStore`s are not affected! > > I'm not sure I understood you

[GitHub] [flink] echauchot removed a comment on pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-09-08 Thread GitBox
echauchot removed a comment on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-688844832 > checkpointCleaningFinishedCallback Yes I think this refactoring will work from _CompletedCheckpoint_ and is indeed better as it allows to keep the

[GitHub] [flink] godfreyhe commented on a change in pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

2020-09-08 Thread GitBox
godfreyhe commented on a change in pull request #13283: URL: https://github.com/apache/flink/pull/13283#discussion_r484895757 ## File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md ## @@ -1,19 +1,21 @@ # TPC-DS tool -This directory contains the necessary

[GitHub] [flink] flinkbot edited a comment on pull request #13128: [FLINK-18795][hbase] Support for HBase 2

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13128: URL: https://github.com/apache/flink/pull/13128#issuecomment-672766836 ## CI report: * 313b80f4474455d7013b0852929b5a8458f391a1 UNKNOWN * bed4e3388e10406af39aef4edb136fa84864dca7 Azure:

[GitHub] [flink] dawidwys commented on a change in pull request #13343: [FLINK-19083] Remove deprecated DataStream#split

2020-09-08 Thread GitBox
dawidwys commented on a change in pull request #13343: URL: https://github.com/apache/flink/pull/13343#discussion_r484789663 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamGraphGeneratorTest.java ## @@ -138,138 +132,6 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #13306: [FLINK-17779][Connectors/ORC]Orc file format support filter push down

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13306: URL: https://github.com/apache/flink/pull/13306#issuecomment-685717187 ## CI report: * a7f4abab05ad875bf6acef6510fcec6df7d2dc6c UNKNOWN * 174d9d69aa825ce53661c38b2bf9c7e71440c687 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13353: [FLINK-17104] Support registering custom JobStatusListeners from config

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13353: URL: https://github.com/apache/flink/pull/13353#issuecomment-688773787 ## CI report: * 7e976d876453d16074bf46ba0bfd174a54e52408 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13352: [FLINK-19092][sql-parser] Parse comment on computed column failed

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13352: URL: https://github.com/apache/flink/pull/13352#issuecomment-688773679 ## CI report: * d06dbcd04a611f3adfa2812668a13195f65237fd Azure:

[jira] [Commented] (FLINK-19159) Using Scalafmt to format scala source code

2020-09-08 Thread Patrick Lucas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192174#comment-17192174 ] Patrick Lucas commented on FLINK-19159: --- [~aljoscha] some plugins, like

[jira] [Commented] (FLINK-19154) Always clean up HA data when application completion

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192192#comment-17192192 ] Robert Metzger commented on FLINK-19154: Let's first understand the problem properly on the user

[GitHub] [flink] dawidwys commented on pull request #13343: [FLINK-19083] Remove deprecated DataStream#split

2020-09-08 Thread GitBox
dawidwys commented on pull request #13343: URL: https://github.com/apache/flink/pull/13343#issuecomment-688848011 As for the question if it was easy to use side outputs instead of split/select. Personally I found it rather straightforward. In the IterateExample I even find the code much

[GitHub] [flink] leonardBang commented on a change in pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

2020-09-08 Thread GitBox
leonardBang commented on a change in pull request #13283: URL: https://github.com/apache/flink/pull/13283#discussion_r484912329 ## File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md ## @@ -1,19 +1,21 @@ # TPC-DS tool -This directory contains the

[GitHub] [flink] flinkbot commented on pull request #13351: [FLINK-18990][task] Read channel state sequentially

2020-09-08 Thread GitBox
flinkbot commented on pull request #13351: URL: https://github.com/apache/flink/pull/13351#issuecomment-688741492 ## CI report: * 3c797163b965710a41ea0b427a583223b2db02a0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Assigned] (FLINK-19054) KafkaTableITCase.testKafkaSourceSink hangs

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-19054: -- Assignee: Jark Wu > KafkaTableITCase.testKafkaSourceSink hangs >

[jira] [Updated] (FLINK-18990) Optimize reading of channel state on recovery

2020-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18990: --- Labels: pull-request-available (was: ) > Optimize reading of channel state on recovery >

[jira] [Commented] (FLINK-19054) KafkaTableITCase.testKafkaSourceSink hangs

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192066#comment-17192066 ] Robert Metzger commented on FLINK-19054: Thanks a lot for looking into this [~becket_qin]! I'll

[jira] [Assigned] (FLINK-16595) Support extra hadoop filesystem URLs for which to request delegation tokens

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-16595: -- Assignee: Husky Zeng > Support extra hadoop filesystem URLs for which to request

[GitHub] [flink] flinkbot edited a comment on pull request #13351: [FLINK-18990][task] Read channel state sequentially

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13351: URL: https://github.com/apache/flink/pull/13351#issuecomment-688741492 ## CI report: * 3c797163b965710a41ea0b427a583223b2db02a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13228: URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456 ## CI report: * d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN * 4af565f8d262b2ed2ebfb7614e0f24494eb22186 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13284: [FLINK-17016][runtime] Enable pipelined region scheduling

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13284: URL: https://github.com/apache/flink/pull/13284#issuecomment-683683000 ## CI report: * 6af35bfdfa14c049bf4abe1c88ee49a689f38085 UNKNOWN * 9ab00d3240a796ded1f76b47249c9a2df9da8149 Azure:

[GitHub] [flink] flinkbot commented on pull request #13353: [FLINK-17104] Support registering custom JobStatusListeners from config

2020-09-08 Thread GitBox
flinkbot commented on pull request #13353: URL: https://github.com/apache/flink/pull/13353#issuecomment-688773787 ## CI report: * 7e976d876453d16074bf46ba0bfd174a54e52408 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #13352: [FLINK-19092][sql-parser] Parse comment on computed column failed

2020-09-08 Thread GitBox
flinkbot commented on pull request #13352: URL: https://github.com/apache/flink/pull/13352#issuecomment-688773679 ## CI report: * d06dbcd04a611f3adfa2812668a13195f65237fd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] sujun1020 commented on pull request #13306: [FLINK-17779][Connectors/ORC]Orc file format support filter push down

2020-09-08 Thread GitBox
sujun1020 commented on pull request #13306: URL: https://github.com/apache/flink/pull/13306#issuecomment-688777219 @JingsongLi Thanks for the review. Updated the PR. This is an automated message from the Apache Git Service.

[GitHub] [flink] flinkbot edited a comment on pull request #13321: [FLINK-14870] Remove nullable assumption of task slot sharing group

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13321: URL: https://github.com/apache/flink/pull/13321#issuecomment-686567896 ## CI report: * d79f152fa91b8bc555af6fb2a00a8d62b184be5a UNKNOWN * 96e983d10c7095847b404461abd01b4d1ebb0aac Azure:

[GitHub] [flink] wuchong commented on a change in pull request #13333: [FLINK-18823][format] Support serialization for debezium-json format

2020-09-08 Thread GitBox
wuchong commented on a change in pull request #1: URL: https://github.com/apache/flink/pull/1#discussion_r484857382 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/debezium/DebeziumJsonSerializationSchema.java ## @@ -0,0 +1,112 @@

[GitHub] [flink] wuchong commented on pull request #13352: [FLINK-19092][sql-parser] Parse comment on computed column failed

2020-09-08 Thread GitBox
wuchong commented on pull request #13352: URL: https://github.com/apache/flink/pull/13352#issuecomment-688818272 cc @danny0405 , could you help to review this? This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #13352: [FLINK-19092][sql-parser] Parse comment on computed column failed

2020-09-08 Thread GitBox
flinkbot commented on pull request #13352: URL: https://github.com/apache/flink/pull/13352#issuecomment-688762790 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #13353: [FLINK-17104] Support registering custom JobStatusListeners from config

2020-09-08 Thread GitBox
flinkbot commented on pull request #13353: URL: https://github.com/apache/flink/pull/13353#issuecomment-688762762 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Comment Edited] (FLINK-16595) Support extra hadoop filesystem URLs for which to request delegation tokens

2020-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192136#comment-17192136 ] Robert Metzger edited comment on FLINK-16595 at 9/8/20, 11:00 AM: -- I'm

[GitHub] [flink] flinkbot edited a comment on pull request #13306: [FLINK-17779][Connectors/ORC]Orc file format support filter push down

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13306: URL: https://github.com/apache/flink/pull/13306#issuecomment-685717187 ## CI report: * a7f4abab05ad875bf6acef6510fcec6df7d2dc6c UNKNOWN * 174d9d69aa825ce53661c38b2bf9c7e71440c687 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13284: [FLINK-17016][runtime] Enable pipelined region scheduling

2020-09-08 Thread GitBox
flinkbot edited a comment on pull request #13284: URL: https://github.com/apache/flink/pull/13284#issuecomment-683683000 ## CI report: * 6af35bfdfa14c049bf4abe1c88ee49a689f38085 UNKNOWN * 9ab00d3240a796ded1f76b47249c9a2df9da8149 Azure:

  1   2   3   >