[GitHub] [flink] flinkbot edited a comment on pull request #13445: [FLINK-19331][state-processor-api] Native resource leak when working with RocksDB

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13445: URL: https://github.com/apache/flink/pull/13445#issuecomment-696389960 ## CI report: * 0e2560c93ca18cc37117b89ffabf7dc2a85f80bf Azure:

[GitHub] [flink-statefun] sjwiesman opened a new pull request #160: [hotfix][dockerfile] Add newline to end of flink-conf

2020-09-21 Thread GitBox
sjwiesman opened a new pull request #160: URL: https://github.com/apache/flink-statefun/pull/160 I ran into this while doing release testing, this is mostly quality of life and I wouldn't consider a release blocker. When building small applications it's often easy to simply append

[GitHub] [flink-statefun] sjwiesman commented on pull request #159: [FLINK-19330][core] Move intialization logic to open() instead initializeState

2020-09-21 Thread GitBox
sjwiesman commented on pull request #159: URL: https://github.com/apache/flink-statefun/pull/159#issuecomment-696412736 Out of scope for this PR but based on our offline conversation today it seems like there should be a remote e2e test with TM failures

[GitHub] [flink] flinkbot edited a comment on pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13228: URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456 ## CI report: * d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN * 89b0550c7b223f304b67a6f64dfc4252509eb76e UNKNOWN *

[GitHub] [flink] kezhuw commented on a change in pull request #13445: [FLINK-19331][state-processor-api] Native resource leak when working with RocksDB

2020-09-21 Thread GitBox
kezhuw commented on a change in pull request #13445: URL: https://github.com/apache/flink/pull/13445#discussion_r492405421 ## File path: flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/input/ClosableIterator.java ## @@ -0,0 +1,27 @@ +/* + *

[GitHub] [flink] flinkbot edited a comment on pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13228: URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456 ## CI report: * d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN * 89b0550c7b223f304b67a6f64dfc4252509eb76e UNKNOWN *

[jira] [Updated] (FLINK-19289) K8s resource manager terminated pod garbage collection

2020-09-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-19289: - Component/s: Deployment / Kubernetes > K8s resource manager terminated pod garbage collection >

[jira] [Updated] (FLINK-19289) K8s resource manager terminated pod garbage collection

2020-09-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-19289: - Priority: Major (was: Minor) > K8s resource manager terminated pod garbage collection >

[jira] [Assigned] (FLINK-19289) K8s resource manager terminated pod garbage collection

2020-09-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-19289: Assignee: Xintong Song > K8s resource manager terminated pod garbage collection >

[GitHub] [flink] WeiZhong94 commented on pull request #13420: [FLINK-19229][python] Introduce the PythonStreamGroupAggregateOperator for Python UDAF.

2020-09-21 Thread GitBox
WeiZhong94 commented on pull request #13420: URL: https://github.com/apache/flink/pull/13420#issuecomment-695981508 @dianfu Thanks for your comments! I have updated this PR. This is an automated message from the Apache Git

[GitHub] [flink] tzulitai commented on pull request #13189: [FLINK-18661][Kinesis] Stream consumer Registration/Deregistration

2020-09-21 Thread GitBox
tzulitai commented on pull request #13189: URL: https://github.com/apache/flink/pull/13189#issuecomment-695908373 Merging this now ... This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot edited a comment on pull request #13443: [FLINK-19288] Make the InternalTimeServiceManager an interface

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13443: URL: https://github.com/apache/flink/pull/13443#issuecomment-696209532 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] rmetzger commented on pull request #13412: [FLINK-19069] execute finalizeOnMaster with io executor to avoid hea…

2020-09-21 Thread GitBox
rmetzger commented on pull request #13412: URL: https://github.com/apache/flink/pull/13412#issuecomment-696048919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] asfgit closed pull request #13401: [FLINK-19161][file connector] Add first version of the FLIP-27 File Source

2020-09-21 Thread GitBox
asfgit closed pull request #13401: URL: https://github.com/apache/flink/pull/13401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zhuxiaoshang commented on pull request #13431: [FLINK-19281][Table SQL / API]LIKE cannot recognize full table path

2020-09-21 Thread GitBox
zhuxiaoshang commented on pull request #13431: URL: https://github.com/apache/flink/pull/13431#issuecomment-695805887 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot edited a comment on pull request #13416: [FLINK-19179] Extend managed memory fraction calculation for various use cases.

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13416: URL: https://github.com/apache/flink/pull/13416#issuecomment-694678006 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] zhijiangW merged pull request #13435: [FLINK-19299][tests] Fix that NettyShuffleEnvironmentBuilder#setBufferSize does not take effect

2020-09-21 Thread GitBox
zhijiangW merged pull request #13435: URL: https://github.com/apache/flink/pull/13435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] kl0u commented on a change in pull request #13357: [FLINK-19165] Refactor the UnilateralSortMerger

2020-09-21 Thread GitBox
kl0u commented on a change in pull request #13357: URL: https://github.com/apache/flink/pull/13357#discussion_r492107272 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/SortingThread.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache

[GitHub] [flink] dugenkui03 removed a comment on pull request #13277: [FLINK-19089][Connectors / Kafka] Replace ReentrantLock with ReentrantReadWriteLock in ClosableBlockingQueue

2020-09-21 Thread GitBox
dugenkui03 removed a comment on pull request #13277: URL: https://github.com/apache/flink/pull/13277#issuecomment-684804553 hi @JingsongLi @wuchong , would you help me review this, thanks. This is an automated message from

[GitHub] [flink] flinkbot edited a comment on pull request #13128: [FLINK-18795][hbase] Support for HBase 2

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13128: URL: https://github.com/apache/flink/pull/13128#issuecomment-672766836 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] wangxlong commented on a change in pull request #13392: [FLINK-18713][table-planner-blink] Change duration configOption to duration type

2020-09-21 Thread GitBox
wangxlong commented on a change in pull request #13392: URL: https://github.com/apache/flink/pull/13392#discussion_r491683758 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowEmitStrategy.scala ## @@ -153,12

[GitHub] [flink] flinkbot commented on pull request #13448: [FLINK-19289][k8s] Remove pods terminated during JM failover.

2020-09-21 Thread GitBox
flinkbot commented on pull request #13448: URL: https://github.com/apache/flink/pull/13448#issuecomment-696496421 ## CI report: * b48645e3f6c23d452238042692f9a291e09a311d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13447: URL: https://github.com/apache/flink/pull/13447#issuecomment-696488834 ## CI report: * d4a56d85b6a00b8c10a4993a5f3c483ad26e5213 UNKNOWN * 620bd4aeecbb133a360cefae8c873ded05e5b720 UNKNOWN Bot commands The

[jira] [Closed] (FLINK-19244) CsvRowDataDeserializationSchema throws cast exception : Row length mismatch.

2020-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-19244. --- Fix Version/s: 1.11.3 1.12.0 Resolution: Fixed Fixed in - master:

[GitHub] [flink] libenchao commented on a change in pull request #13427: [FLINK-17767][table-planner-blink]Tumbling/Sliding window aggregate support window start offset in batch and streaming mode

2020-09-21 Thread GitBox
libenchao commented on a change in pull request #13427: URL: https://github.com/apache/flink/pull/13427#discussion_r491855446 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala ## @@

[jira] [Updated] (FLINK-19282) Support watermark push down with WatermarkStrategy

2020-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19282: --- Labels: pull-request-available (was: ) > Support watermark push down with

[GitHub] [flink] wuchong merged pull request #13275: [FLINK-19064][hbase] HBaseRowDataInputFormat is leaking resources

2020-09-21 Thread GitBox
wuchong merged pull request #13275: URL: https://github.com/apache/flink/pull/13275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (FLINK-19291) Meeting `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type

2020-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-19291: --- Assignee: xiaozilong > Meeting `SchemaParseException` when use `AvroSchemaConverter` converts

[GitHub] [flink] fsk119 opened a new pull request #13449: [FLINK-19282][table sql/planner]Supports watermark push down with Wat…

2020-09-21 Thread GitBox
fsk119 opened a new pull request #13449: URL: https://github.com/apache/flink/pull/13449 …ermarkStrategy 1. convert class FunctionContext to interface which allows us convert WatermarkStrategy.Context to FunctionContext; 2. add bindConstructorTerm in ExprCodeGenerator; 3. add

[jira] [Commented] (FLINK-19291) Meeting `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type

2020-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199798#comment-17199798 ] Jark Wu commented on FLINK-19291: - Thanks for reporting this [~xiaozilong]. This is a bug in

[jira] [Updated] (FLINK-19295) YARNSessionFIFOITCase.checkForProhibitedLogContents found a log with prohibited string

2020-09-21 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19295: Affects Version/s: 1.11.0 > YARNSessionFIFOITCase.checkForProhibitedLogContents found a log with >

[jira] [Comment Edited] (FLINK-19295) YARNSessionFIFOITCase.checkForProhibitedLogContents found a log with prohibited string

2020-09-21 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199723#comment-17199723 ] Dian Fu edited comment on FLINK-19295 at 9/22/20, 1:06 AM: --- Another instance

[jira] [Commented] (FLINK-19295) YARNSessionFIFOITCase.checkForProhibitedLogContents found a log with prohibited string

2020-09-21 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199723#comment-17199723 ] Dian Fu commented on FLINK-19295: - Another instance: 

[jira] [Updated] (FLINK-19295) YARNSessionFIFOITCase.checkForProhibitedLogContents found a log with prohibited string

2020-09-21 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-19295: Affects Version/s: (was: 1.11.0) 1.11.3 >

[GitHub] [flink] wuchong commented on a change in pull request #13426: [FLINK-19244] CsvRowDataDeserializationSchema throws cast exception : Row length mismatch.

2020-09-21 Thread GitBox
wuchong commented on a change in pull request #13426: URL: https://github.com/apache/flink/pull/13426#discussion_r491782475 ## File path: flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java ## @@ -331,6 +364,16 @@ private Row

[GitHub] [flink] rmetzger commented on a change in pull request #13412: [FLINK-19069] execute finalizeOnMaster with io executor to avoid hea…

2020-09-21 Thread GitBox
rmetzger commented on a change in pull request #13412: URL: https://github.com/apache/flink/pull/13412#discussion_r491975797 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ## @@ -1292,23 +1292,28 @@ void vertexFinished()

[GitHub] [flink] lirui-apache commented on pull request #13216: [FLINK-18999][table-planner-blink][hive] Temporary generic table does…

2020-09-21 Thread GitBox
lirui-apache commented on pull request #13216: URL: https://github.com/apache/flink/pull/13216#issuecomment-695957004 @JingsongLi I have separated the changes to planner from those to the hive connector. This is an

[GitHub] [flink] flinkbot edited a comment on pull request #13433: [BP-1.11][FLINK-19280][jdbc] Fix option "sink.buffer-flush.max-rows" for JDBC can't be disabled by setting to zero

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13433: URL: https://github.com/apache/flink/pull/13433#issuecomment-695890558 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] dawidwys commented on a change in pull request #13357: [FLINK-19165] Refactor the UnilateralSortMerger

2020-09-21 Thread GitBox
dawidwys commented on a change in pull request #13357: URL: https://github.com/apache/flink/pull/13357#discussion_r492172027 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/StageRunner.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[GitHub] [flink] dianfu commented on a change in pull request #13421: [FLINK-19186][python] Add Python building blocks to make sure the basic functionality of Pandas Batch Group Aggregation could work

2020-09-21 Thread GitBox
dianfu commented on a change in pull request #13421: URL: https://github.com/apache/flink/pull/13421#discussion_r492448420 ## File path: docs/dev/python/table-api-users-guide/udfs/vectorized_python_udfs.md ## @@ -28,7 +28,7 @@ The performance of vectorized Python user-defined

[GitHub] [flink] JingsongLi commented on a change in pull request #13401: [FLINK-19161][file connector] Add first version of the FLIP-27 File Source

2020-09-21 Thread GitBox
JingsongLi commented on a change in pull request #13401: URL: https://github.com/apache/flink/pull/13401#discussion_r491894894 ## File path: flink-formats/flink-orc/src/main/java/org/apache/flink/orc/util/SerializableHadoopConfigWrapper.java ## @@ -0,0 +1,78 @@ +/* + *

[GitHub] [flink] wuchong commented on a change in pull request #13427: [FLINK-17767][table-planner-blink]Tumbling/Sliding window aggregate support window start offset in batch and streaming mode

2020-09-21 Thread GitBox
wuchong commented on a change in pull request #13427: URL: https://github.com/apache/flink/pull/13427#discussion_r492461768 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala ## @@

[GitHub] [flink] flinkbot commented on pull request #13449: [FLINK-19282][table sql/planner]Supports watermark push down with Wat…

2020-09-21 Thread GitBox
flinkbot commented on pull request #13449: URL: https://github.com/apache/flink/pull/13449#issuecomment-696509354 ## CI report: * b042779c3149b0f43d95e6de34a0807b046960bc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Commented] (FLINK-19016) Checksum mismatch when restore from RocksDB

2020-09-21 Thread Steven Zhen Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199720#comment-17199720 ] Steven Zhen Wu commented on FLINK-19016: [~sewen] we didn't dig deeper and we don't know how to

[jira] [Updated] (FLINK-19289) K8s resource manager terminated pod garbage collection

2020-09-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-19289: - Fix Version/s: 1.12.0 > K8s resource manager terminated pod garbage collection >

[jira] [Updated] (FLINK-19289) K8s resource manager terminated pod garbage collection

2020-09-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-19289: - Affects Version/s: 1.12.0 > K8s resource manager terminated pod garbage collection >

[GitHub] [flink] flinkbot edited a comment on pull request #13432: [FLINK-19280][connectors] fix the bug of the option "sink.buffer-flush.max-rows" for JDBC can't be disabled by set to zero

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13432: URL: https://github.com/apache/flink/pull/13432#issuecomment-695808835 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-statefun] igalshilman commented on a change in pull request #152: [FLINK-19176] Add pluggable statefun payload serializer

2020-09-21 Thread GitBox
igalshilman commented on a change in pull request #152: URL: https://github.com/apache/flink-statefun/pull/152#discussion_r492318196 ## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/message/MessageFactoryKey.java ## @@ -0,0

[GitHub] [flink-statefun] tzulitai closed pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

2020-09-21 Thread GitBox
tzulitai closed pull request #156: URL: https://github.com/apache/flink-statefun/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] wangxlong commented on a change in pull request #13427: [FLINK-17767][table-planner-blink]Tumbling/Sliding window aggregate support window start offset in batch and streaming mode

2020-09-21 Thread GitBox
wangxlong commented on a change in pull request #13427: URL: https://github.com/apache/flink/pull/13427#discussion_r491767275 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala ## @@

[GitHub] [flink-statefun] galenwarren commented on pull request #152: [FLINK-19176] Add pluggable statefun payload serializer

2020-09-21 Thread GitBox
galenwarren commented on pull request #152: URL: https://github.com/apache/flink-statefun/pull/152#issuecomment-695807576 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] yingshin closed pull request #13441: [BP-1.11][FLINK-19244] CsvRowDataDeserializationSchema throws cast exception : Row length mismatch.

2020-09-21 Thread GitBox
yingshin closed pull request #13441: URL: https://github.com/apache/flink/pull/13441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot edited a comment on pull request #13316: [FLINK-14422][runtime] Expose network memory usage to TaskManagerDetailsHandler's endpoint

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13316: URL: https://github.com/apache/flink/pull/13316#issuecomment-686398901 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-19335) Automatically get udf's resource files from hdfs when running a job that uses hive-udf

2020-09-21 Thread Husky Zeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Husky Zeng updated FLINK-19335: --- Description:

[GitHub] [flink] crazyzhou commented on a change in pull request #13303: [FLINK-19098][format] Make row data converters public

2020-09-21 Thread GitBox
crazyzhou commented on a change in pull request #13303: URL: https://github.com/apache/flink/pull/13303#discussion_r491833689 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonToRowDataConverters.java ## @@ -0,0 +1,391 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #13429: [FLINK-19140] Fix UDTF documentation which uses wrong alias

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13429: URL: https://github.com/apache/flink/pull/13429#issuecomment-695772106 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-21 Thread GitBox
flinkbot commented on pull request #13447: URL: https://github.com/apache/flink/pull/13447#issuecomment-696485547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] azagrebin commented on a change in pull request #13422: [FLINK-19286][runtime] Improve pipelined region scheduling performance

2020-09-21 Thread GitBox
azagrebin commented on a change in pull request #13422: URL: https://github.com/apache/flink/pull/13422#discussion_r491870224 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java ## @@ -127,13 +136,9 @@

[GitHub] [flink] dawidwys commented on pull request #13423: [FLINK-19269] Make the PushingAsyncDataInput.DataOutput aware of endOfInput

2020-09-21 Thread GitBox
dawidwys commented on pull request #13423: URL: https://github.com/apache/flink/pull/13423#issuecomment-695955429 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot commented on pull request #13433: [BP-1.11][FLINK-19280][jdbc] Fix option "sink.buffer-flush.max-rows" for JDBC can't be disabled by setting to zero

2020-09-21 Thread GitBox
flinkbot commented on pull request #13433: URL: https://github.com/apache/flink/pull/13433#issuecomment-695888255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #13442: [FLINK-19321][Table SQL / Runtime]CollectSinkFunction does not define serialVersionUID

2020-09-21 Thread GitBox
flinkbot commented on pull request #13442: URL: https://github.com/apache/flink/pull/13442#issuecomment-696189196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot edited a comment on pull request #13449: [FLINK-19282][table sql/planner]Supports watermark push down with Wat…

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13449: URL: https://github.com/apache/flink/pull/13449#issuecomment-696509354 ## CI report: * b042779c3149b0f43d95e6de34a0807b046960bc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13228: URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456 ## CI report: * d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN * 89b0550c7b223f304b67a6f64dfc4252509eb76e UNKNOWN *

[jira] [Created] (FLINK-19335) Automatically get udf's resource files from hdfs when running a job that uses hive-udf

2020-09-21 Thread Husky Zeng (Jira)
Husky Zeng created FLINK-19335: -- Summary: Automatically get udf's resource files from hdfs when running a job that uses hive-udf Key: FLINK-19335 URL: https://issues.apache.org/jira/browse/FLINK-19335

[GitHub] [flink-statefun] tdbgamer opened a new pull request #161: Add Haskell SDK to 3rd party SDKs

2020-09-21 Thread GitBox
tdbgamer opened a new pull request #161: URL: https://github.com/apache/flink-statefun/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot edited a comment on pull request #13322: [FLINK-17480][kubernetes] Support running PyFlink on Kubernetes.

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13322: URL: https://github.com/apache/flink/pull/13322#issuecomment-686859976 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] azagrebin commented on a change in pull request #13316: [FLINK-14422][runtime] Expose network memory usage to TaskManagerDetailsHandler's endpoint

2020-09-21 Thread GitBox
azagrebin commented on a change in pull request #13316: URL: https://github.com/apache/flink/pull/13316#discussion_r491842527 ## File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot ## @@ -3082,4 +3100,4 @@ } } } ] -} +} Review comment:

[GitHub] [flink] flinkbot edited a comment on pull request #13437: [FLINK-19189][runtime] Enable pipelined scheduling by default

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13437: URL: https://github.com/apache/flink/pull/13437#issuecomment-695945303 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #13435: [FLINK-19299][tests] Fix that NettyShuffleEnvironmentBuilder#setBufferSize does not take effect

2020-09-21 Thread GitBox
flinkbot commented on pull request #13435: URL: https://github.com/apache/flink/pull/13435#issuecomment-695891985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot edited a comment on pull request #13423: [FLINK-19269] Make the PushingAsyncDataInput.DataOutput aware of endOfInput

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13423: URL: https://github.com/apache/flink/pull/13423#issuecomment-694841940 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-21 Thread GitBox
flinkbot commented on pull request #13434: URL: https://github.com/apache/flink/pull/13434#issuecomment-695890247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot edited a comment on pull request #13445: [FLINK-19331][state-processor-api] Native resource leak when working with RocksDB

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13445: URL: https://github.com/apache/flink/pull/13445#issuecomment-696389960 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] aljoscha commented on a change in pull request #13425: [FLINK-19272][table-common] Add metadata interfaces for FLIP-107

2020-09-21 Thread GitBox
aljoscha commented on a change in pull request #13425: URL: https://github.com/apache/flink/pull/13425#discussion_r491927152 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/abilities/SupportsWritingMetadata.java ## @@ -0,0

[GitHub] [flink] libenchao commented on a change in pull request #13431: [FLINK-19281][Table SQL / API]LIKE cannot recognize full table path

2020-09-21 Thread GitBox
libenchao commented on a change in pull request #13431: URL: https://github.com/apache/flink/pull/13431#discussion_r491904834 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java ## @@ -141,7

[GitHub] [flink] wsry opened a new pull request #13447: [FLINK-19297][network] Make ResultPartitionWriter record-oriented

2020-09-21 Thread GitBox
wsry opened a new pull request #13447: URL: https://github.com/apache/flink/pull/13447 ## What is the purpose of the change Currently, ResultPartitionWriter is buffer-oriented, that is, RecordWriter will add buffer of different channels to ResultPartitionWriter and the buffer

[GitHub] [flink] AHeise commented on pull request #12962: [FLINK-18694] Add unaligned checkpoint config to web ui

2020-09-21 Thread GitBox
AHeise commented on pull request #12962: URL: https://github.com/apache/flink/pull/12962#issuecomment-695816303 Hey @kbohinski , thank you very much for starting this, but the ticket is currently assigned to someone else. It would be good to clarify first if there is already some progress

[GitHub] [flink-statefun] tzulitai commented on pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

2020-09-21 Thread GitBox
tzulitai commented on pull request #156: URL: https://github.com/apache/flink-statefun/pull/156#issuecomment-695902793 LGTM! Thanks @igalshilman, merging this. This is an automated message from the Apache Git Service. To

[GitHub] [flink] dianfu closed pull request #13436: [FLINK-19301][python] Improve the package structure of Python DataStream API

2020-09-21 Thread GitBox
dianfu closed pull request #13436: URL: https://github.com/apache/flink/pull/13436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] rkhachatryan commented on a change in pull request #13040: [FLINK-17073] [checkpointing] checkpointing backpressure if there are too many checkpoints to clean

2020-09-21 Thread GitBox
rkhachatryan commented on a change in pull request #13040: URL: https://github.com/apache/flink/pull/13040#discussion_r491905895 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-19244) CsvRowDataDeserializationSchema throws cast exception : Row length mismatch.

2020-09-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-19244: Affects Version/s: (was: 1.11.0) 1.11.2 > CsvRowDataDeserializationSchema

[GitHub] [flink] tzulitai commented on pull request #13102: [FLINK-18515][Kinesis] Adding FanOutRecordPublisher for Kinesis EFO support

2020-09-21 Thread GitBox
tzulitai commented on pull request #13102: URL: https://github.com/apache/flink/pull/13102#issuecomment-695904969 Had a final pass at the code, LGTM. Thanks for addressing the comments @dannycranmer! Am merging this now ...

[GitHub] [flink] gyfora commented on pull request #13128: [FLINK-18795][hbase] Support for HBase 2

2020-09-21 Thread GitBox
gyfora commented on pull request #13128: URL: https://github.com/apache/flink/pull/13128#issuecomment-696017106 @leonardBang If you want to review it you need to review this ASAP as waiting causes us a lot of extra work that we are going to try to avoid. We will try to rebase this

[jira] [Updated] (FLINK-19338) New source interface cannot unregister unregistered source

2020-09-21 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise updated FLINK-19338: Component/s: Connectors / Common > New source interface cannot unregister unregistered source >

[GitHub] [flink] HuangXingBo commented on pull request #13421: [FLINK-19186][python] Add Python building blocks to make sure the basic functionality of Pandas Batch Group Aggregation could work

2020-09-21 Thread GitBox
HuangXingBo commented on pull request #13421: URL: https://github.com/apache/flink/pull/13421#issuecomment-696507110 @dianfu Thanks a lot for the review. I have addressed the comments at the latest commit. This is an

[jira] [Created] (FLINK-19338) New source interface cannot unregister unregistered source

2020-09-21 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-19338: --- Summary: New source interface cannot unregister unregistered source Key: FLINK-19338 URL: https://issues.apache.org/jira/browse/FLINK-19338 Project: Flink

[jira] [Commented] (FLINK-19237) LeaderChangeClusterComponentsTest.testReelectionOfJobMaster failed with "NoResourceAvailableException: Could not allocate the required slot within slot request timeout

2020-09-21 Thread Matthias (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199828#comment-17199828 ] Matthias commented on FLINK-19237: -- The problem seems to be caused by

[jira] [Created] (FLINK-19332) Special characters issue using Kinesis Data Analytics for Apache Flink

2020-09-21 Thread Zekun Yu (Jira)
Zekun Yu created FLINK-19332: Summary: Special characters issue using Kinesis Data Analytics for Apache Flink Key: FLINK-19332 URL: https://issues.apache.org/jira/browse/FLINK-19332 Project: Flink

[GitHub] [flink] dianfu commented on pull request #13436: [FLINK-19301][python] Improve the package structure of Python DataStream API

2020-09-21 Thread GitBox
dianfu commented on pull request #13436: URL: https://github.com/apache/flink/pull/13436#issuecomment-696043930 @shuiqiangchen Thanks a lot for the review. Merging... This is an automated message from the Apache Git Service.

[GitHub] [flink] aljoscha commented on a change in pull request #13405: [FLINK-19270] Extract an inteface from AbstractKeyedStateBackend

2020-09-21 Thread GitBox
aljoscha commented on a change in pull request #13405: URL: https://github.com/apache/flink/pull/13405#discussion_r491936770 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java ## @@ -74,19 +74,16 @@

[jira] [Assigned] (FLINK-19336) EncodingUtils#encodeObjectToString should propagate inner exception

2020-09-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-19336: -- Assignee: Benchao Li > EncodingUtils#encodeObjectToString should propagate inner exception >

[GitHub] [flink] flinkbot edited a comment on pull request #13216: [FLINK-18999][table-planner-blink][hive] Temporary generic table does…

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13216: URL: https://github.com/apache/flink/pull/13216#issuecomment-678268420 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-statefun] sjwiesman commented on pull request #159: [FLINK-19330][core] Move intialization logic to open() instead initializeState

2020-09-21 Thread GitBox
sjwiesman commented on pull request #159: URL: https://github.com/apache/flink-statefun/pull/159#issuecomment-696412736 Out of scope for this PR but based on our offline conversation today it seems like there should be a remote e2e test with TM failures

[jira] [Created] (FLINK-19336) EncodingUtils#encodeObjectToString should propagate inner exception

2020-09-21 Thread Benchao Li (Jira)
Benchao Li created FLINK-19336: -- Summary: EncodingUtils#encodeObjectToString should propagate inner exception Key: FLINK-19336 URL: https://issues.apache.org/jira/browse/FLINK-19336 Project: Flink

[jira] [Updated] (FLINK-19289) Remove pods terminated during JM failover

2020-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19289: --- Labels: pull-request-available (was: ) > Remove pods terminated during JM failover >

[GitHub] [flink] wuchong merged pull request #13444: [BP-1.11][FLINK-19244] CsvRowDataDeserializationSchema throws cast ex…

2020-09-21 Thread GitBox
wuchong merged pull request #13444: URL: https://github.com/apache/flink/pull/13444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

2020-09-21 Thread GitBox
flinkbot edited a comment on pull request #13446: URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728 ## CI report: * 10d22d3c1c5b291c3bd6d730b00f152a675d7bd4 Azure:

[GitHub] [flink] xintongsong opened a new pull request #13448: [FLINK-19289][k8s] Remove pods terminated during JM failover.

2020-09-21 Thread GitBox
xintongsong opened a new pull request #13448: URL: https://github.com/apache/flink/pull/13448 ## What is the purpose of the change This PR cleans up pods terminated during JM failover (between previous watcher closed and new watcher started) from Kubernetes. ## Verifying this

[jira] [Updated] (FLINK-18779) Support the SupportsFilterPushDown interface for LookupTableSource

2020-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18779: --- Labels: pull-request-available (was: ) > Support the SupportsFilterPushDown interface for

[GitHub] [flink] wuchong commented on pull request #13433: [BP-1.11][FLINK-19280][jdbc] Fix option "sink.buffer-flush.max-rows" for JDBC can't be disabled by setting to zero

2020-09-21 Thread GitBox
wuchong commented on pull request #13433: URL: https://github.com/apache/flink/pull/13433#issuecomment-696048513 Merging... This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] weizheng92 commented on pull request #13003: [FLINK-18737][docs]translate jdbc connector

2020-09-21 Thread GitBox
weizheng92 commented on pull request #13003: URL: https://github.com/apache/flink/pull/13003#issuecomment-695930243 @klion26 您好,已经修改完成,有时间再看一下吗,非常感谢。 This is an automated message from the Apache Git Service. To respond to

  1   2   3   4   5   6   >