flinkbot edited a comment on pull request #13445:
URL: https://github.com/apache/flink/pull/13445#issuecomment-696389960
## CI report:
* 0e2560c93ca18cc37117b89ffabf7dc2a85f80bf Azure:
sjwiesman opened a new pull request #160:
URL: https://github.com/apache/flink-statefun/pull/160
I ran into this while doing release testing, this is mostly quality of life
and I wouldn't consider a release blocker.
When building small applications it's often easy to simply append
sjwiesman commented on pull request #159:
URL: https://github.com/apache/flink-statefun/pull/159#issuecomment-696412736
Out of scope for this PR but based on our offline conversation today it
seems like there should be a remote e2e test with TM failures
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
## CI report:
* d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN
* 89b0550c7b223f304b67a6f64dfc4252509eb76e UNKNOWN
*
kezhuw commented on a change in pull request #13445:
URL: https://github.com/apache/flink/pull/13445#discussion_r492405421
##
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/input/ClosableIterator.java
##
@@ -0,0 +1,27 @@
+/*
+ *
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
## CI report:
* d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN
* 89b0550c7b223f304b67a6f64dfc4252509eb76e UNKNOWN
*
[
https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song updated FLINK-19289:
-
Component/s: Deployment / Kubernetes
> K8s resource manager terminated pod garbage collection
>
[
https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song updated FLINK-19289:
-
Priority: Major (was: Minor)
> K8s resource manager terminated pod garbage collection
>
[
https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song reassigned FLINK-19289:
Assignee: Xintong Song
> K8s resource manager terminated pod garbage collection
>
WeiZhong94 commented on pull request #13420:
URL: https://github.com/apache/flink/pull/13420#issuecomment-695981508
@dianfu Thanks for your comments! I have updated this PR.
This is an automated message from the Apache Git
tzulitai commented on pull request #13189:
URL: https://github.com/apache/flink/pull/13189#issuecomment-695908373
Merging this now ...
This is an automated message from the Apache Git Service.
To respond to the message,
flinkbot edited a comment on pull request #13443:
URL: https://github.com/apache/flink/pull/13443#issuecomment-696209532
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmetzger commented on pull request #13412:
URL: https://github.com/apache/flink/pull/13412#issuecomment-696048919
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
asfgit closed pull request #13401:
URL: https://github.com/apache/flink/pull/13401
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhuxiaoshang commented on pull request #13431:
URL: https://github.com/apache/flink/pull/13431#issuecomment-695805887
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
flinkbot edited a comment on pull request #13416:
URL: https://github.com/apache/flink/pull/13416#issuecomment-694678006
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhijiangW merged pull request #13435:
URL: https://github.com/apache/flink/pull/13435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kl0u commented on a change in pull request #13357:
URL: https://github.com/apache/flink/pull/13357#discussion_r492107272
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/SortingThread.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache
dugenkui03 removed a comment on pull request #13277:
URL: https://github.com/apache/flink/pull/13277#issuecomment-684804553
hi @JingsongLi @wuchong , would you help me review this, thanks.
This is an automated message from
flinkbot edited a comment on pull request #13128:
URL: https://github.com/apache/flink/pull/13128#issuecomment-672766836
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wangxlong commented on a change in pull request #13392:
URL: https://github.com/apache/flink/pull/13392#discussion_r491683758
##
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowEmitStrategy.scala
##
@@ -153,12
flinkbot commented on pull request #13448:
URL: https://github.com/apache/flink/pull/13448#issuecomment-696496421
## CI report:
* b48645e3f6c23d452238042692f9a291e09a311d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot edited a comment on pull request #13447:
URL: https://github.com/apache/flink/pull/13447#issuecomment-696488834
## CI report:
* d4a56d85b6a00b8c10a4993a5f3c483ad26e5213 UNKNOWN
* 620bd4aeecbb133a360cefae8c873ded05e5b720 UNKNOWN
Bot commands
The
[
https://issues.apache.org/jira/browse/FLINK-19244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu closed FLINK-19244.
---
Fix Version/s: 1.11.3
1.12.0
Resolution: Fixed
Fixed in
- master:
libenchao commented on a change in pull request #13427:
URL: https://github.com/apache/flink/pull/13427#discussion_r491855446
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##
@@
[
https://issues.apache.org/jira/browse/FLINK-19282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-19282:
---
Labels: pull-request-available (was: )
> Support watermark push down with
wuchong merged pull request #13275:
URL: https://github.com/apache/flink/pull/13275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/FLINK-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu reassigned FLINK-19291:
---
Assignee: xiaozilong
> Meeting `SchemaParseException` when use `AvroSchemaConverter` converts
fsk119 opened a new pull request #13449:
URL: https://github.com/apache/flink/pull/13449
…ermarkStrategy
1. convert class FunctionContext to interface which allows us convert
WatermarkStrategy.Context to FunctionContext;
2. add bindConstructorTerm in ExprCodeGenerator;
3. add
[
https://issues.apache.org/jira/browse/FLINK-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199798#comment-17199798
]
Jark Wu commented on FLINK-19291:
-
Thanks for reporting this [~xiaozilong]. This is a bug in
[
https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu updated FLINK-19295:
Affects Version/s: 1.11.0
> YARNSessionFIFOITCase.checkForProhibitedLogContents found a log with
>
[
https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199723#comment-17199723
]
Dian Fu edited comment on FLINK-19295 at 9/22/20, 1:06 AM:
---
Another instance
[
https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199723#comment-17199723
]
Dian Fu commented on FLINK-19295:
-
Another instance:
[
https://issues.apache.org/jira/browse/FLINK-19295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu updated FLINK-19295:
Affects Version/s: (was: 1.11.0)
1.11.3
>
wuchong commented on a change in pull request #13426:
URL: https://github.com/apache/flink/pull/13426#discussion_r491782475
##
File path:
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvRowDataSerDeSchemaTest.java
##
@@ -331,6 +364,16 @@ private Row
rmetzger commented on a change in pull request #13412:
URL: https://github.com/apache/flink/pull/13412#discussion_r491975797
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##
@@ -1292,23 +1292,28 @@ void vertexFinished()
lirui-apache commented on pull request #13216:
URL: https://github.com/apache/flink/pull/13216#issuecomment-695957004
@JingsongLi I have separated the changes to planner from those to the hive
connector.
This is an
flinkbot edited a comment on pull request #13433:
URL: https://github.com/apache/flink/pull/13433#issuecomment-695890558
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dawidwys commented on a change in pull request #13357:
URL: https://github.com/apache/flink/pull/13357#discussion_r492172027
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/StageRunner.java
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
dianfu commented on a change in pull request #13421:
URL: https://github.com/apache/flink/pull/13421#discussion_r492448420
##
File path: docs/dev/python/table-api-users-guide/udfs/vectorized_python_udfs.md
##
@@ -28,7 +28,7 @@ The performance of vectorized Python user-defined
JingsongLi commented on a change in pull request #13401:
URL: https://github.com/apache/flink/pull/13401#discussion_r491894894
##
File path:
flink-formats/flink-orc/src/main/java/org/apache/flink/orc/util/SerializableHadoopConfigWrapper.java
##
@@ -0,0 +1,78 @@
+/*
+ *
wuchong commented on a change in pull request #13427:
URL: https://github.com/apache/flink/pull/13427#discussion_r492461768
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##
@@
flinkbot commented on pull request #13449:
URL: https://github.com/apache/flink/pull/13449#issuecomment-696509354
## CI report:
* b042779c3149b0f43d95e6de34a0807b046960bc UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
[
https://issues.apache.org/jira/browse/FLINK-19016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199720#comment-17199720
]
Steven Zhen Wu commented on FLINK-19016:
[~sewen] we didn't dig deeper and we don't know how to
[
https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song updated FLINK-19289:
-
Fix Version/s: 1.12.0
> K8s resource manager terminated pod garbage collection
>
[
https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song updated FLINK-19289:
-
Affects Version/s: 1.12.0
> K8s resource manager terminated pod garbage collection
>
flinkbot edited a comment on pull request #13432:
URL: https://github.com/apache/flink/pull/13432#issuecomment-695808835
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
igalshilman commented on a change in pull request #152:
URL: https://github.com/apache/flink-statefun/pull/152#discussion_r492318196
##
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/message/MessageFactoryKey.java
##
@@ -0,0
tzulitai closed pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wangxlong commented on a change in pull request #13427:
URL: https://github.com/apache/flink/pull/13427#discussion_r491767275
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##
@@
galenwarren commented on pull request #152:
URL: https://github.com/apache/flink-statefun/pull/152#issuecomment-695807576
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yingshin closed pull request #13441:
URL: https://github.com/apache/flink/pull/13441
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
flinkbot edited a comment on pull request #13316:
URL: https://github.com/apache/flink/pull/13316#issuecomment-686398901
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-19335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Husky Zeng updated FLINK-19335:
---
Description:
crazyzhou commented on a change in pull request #13303:
URL: https://github.com/apache/flink/pull/13303#discussion_r491833689
##
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonToRowDataConverters.java
##
@@ -0,0 +1,391 @@
+/*
+ * Licensed
flinkbot edited a comment on pull request #13429:
URL: https://github.com/apache/flink/pull/13429#issuecomment-695772106
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
flinkbot commented on pull request #13447:
URL: https://github.com/apache/flink/pull/13447#issuecomment-696485547
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
azagrebin commented on a change in pull request #13422:
URL: https://github.com/apache/flink/pull/13422#discussion_r491870224
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java
##
@@ -127,13 +136,9 @@
dawidwys commented on pull request #13423:
URL: https://github.com/apache/flink/pull/13423#issuecomment-695955429
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message,
flinkbot commented on pull request #13433:
URL: https://github.com/apache/flink/pull/13433#issuecomment-695888255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot commented on pull request #13442:
URL: https://github.com/apache/flink/pull/13442#issuecomment-696189196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot edited a comment on pull request #13449:
URL: https://github.com/apache/flink/pull/13449#issuecomment-696509354
## CI report:
* b042779c3149b0f43d95e6de34a0807b046960bc Azure:
flinkbot edited a comment on pull request #13228:
URL: https://github.com/apache/flink/pull/13228#issuecomment-679099456
## CI report:
* d141f10ef060063162dc073b1cd66729f5f75a3b UNKNOWN
* 89b0550c7b223f304b67a6f64dfc4252509eb76e UNKNOWN
*
Husky Zeng created FLINK-19335:
--
Summary: Automatically get udf's resource files from hdfs when
running a job that uses hive-udf
Key: FLINK-19335
URL: https://issues.apache.org/jira/browse/FLINK-19335
tdbgamer opened a new pull request #161:
URL: https://github.com/apache/flink-statefun/pull/161
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
flinkbot edited a comment on pull request #13322:
URL: https://github.com/apache/flink/pull/13322#issuecomment-686859976
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
azagrebin commented on a change in pull request #13316:
URL: https://github.com/apache/flink/pull/13316#discussion_r491842527
##
File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot
##
@@ -3082,4 +3100,4 @@
}
}
} ]
-}
+}
Review comment:
flinkbot edited a comment on pull request #13437:
URL: https://github.com/apache/flink/pull/13437#issuecomment-695945303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
flinkbot commented on pull request #13435:
URL: https://github.com/apache/flink/pull/13435#issuecomment-695891985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot edited a comment on pull request #13423:
URL: https://github.com/apache/flink/pull/13423#issuecomment-694841940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
flinkbot commented on pull request #13434:
URL: https://github.com/apache/flink/pull/13434#issuecomment-695890247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot edited a comment on pull request #13445:
URL: https://github.com/apache/flink/pull/13445#issuecomment-696389960
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
aljoscha commented on a change in pull request #13425:
URL: https://github.com/apache/flink/pull/13425#discussion_r491927152
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/abilities/SupportsWritingMetadata.java
##
@@ -0,0
libenchao commented on a change in pull request #13431:
URL: https://github.com/apache/flink/pull/13431#discussion_r491904834
##
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java
##
@@ -141,7
wsry opened a new pull request #13447:
URL: https://github.com/apache/flink/pull/13447
## What is the purpose of the change
Currently, ResultPartitionWriter is buffer-oriented, that is, RecordWriter
will add buffer of different channels to ResultPartitionWriter and the buffer
AHeise commented on pull request #12962:
URL: https://github.com/apache/flink/pull/12962#issuecomment-695816303
Hey @kbohinski , thank you very much for starting this, but the ticket is
currently assigned to someone else. It would be good to clarify first if there
is already some progress
tzulitai commented on pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156#issuecomment-695902793
LGTM! Thanks @igalshilman, merging this.
This is an automated message from the Apache Git Service.
To
dianfu closed pull request #13436:
URL: https://github.com/apache/flink/pull/13436
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rkhachatryan commented on a change in pull request #13040:
URL: https://github.com/apache/flink/pull/13040#discussion_r491905895
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-19244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-19244:
Affects Version/s: (was: 1.11.0)
1.11.2
> CsvRowDataDeserializationSchema
tzulitai commented on pull request #13102:
URL: https://github.com/apache/flink/pull/13102#issuecomment-695904969
Had a final pass at the code, LGTM.
Thanks for addressing the comments @dannycranmer! Am merging this now ...
gyfora commented on pull request #13128:
URL: https://github.com/apache/flink/pull/13128#issuecomment-696017106
@leonardBang If you want to review it you need to review this ASAP as
waiting causes us a lot of extra work that we are going to try to avoid.
We will try to rebase this
[
https://issues.apache.org/jira/browse/FLINK-19338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arvid Heise updated FLINK-19338:
Component/s: Connectors / Common
> New source interface cannot unregister unregistered source
>
HuangXingBo commented on pull request #13421:
URL: https://github.com/apache/flink/pull/13421#issuecomment-696507110
@dianfu Thanks a lot for the review. I have addressed the comments at the
latest commit.
This is an
Arvid Heise created FLINK-19338:
---
Summary: New source interface cannot unregister unregistered source
Key: FLINK-19338
URL: https://issues.apache.org/jira/browse/FLINK-19338
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199828#comment-17199828
]
Matthias commented on FLINK-19237:
--
The problem seems to be caused by
Zekun Yu created FLINK-19332:
Summary: Special characters issue using Kinesis Data Analytics for
Apache Flink
Key: FLINK-19332
URL: https://issues.apache.org/jira/browse/FLINK-19332
Project: Flink
dianfu commented on pull request #13436:
URL: https://github.com/apache/flink/pull/13436#issuecomment-696043930
@shuiqiangchen Thanks a lot for the review. Merging...
This is an automated message from the Apache Git Service.
aljoscha commented on a change in pull request #13405:
URL: https://github.com/apache/flink/pull/13405#discussion_r491936770
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java
##
@@ -74,19 +74,16 @@
[
https://issues.apache.org/jira/browse/FLINK-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benchao Li reassigned FLINK-19336:
--
Assignee: Benchao Li
> EncodingUtils#encodeObjectToString should propagate inner exception
>
flinkbot edited a comment on pull request #13216:
URL: https://github.com/apache/flink/pull/13216#issuecomment-678268420
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sjwiesman commented on pull request #159:
URL: https://github.com/apache/flink-statefun/pull/159#issuecomment-696412736
Out of scope for this PR but based on our offline conversation today it
seems like there should be a remote e2e test with TM failures
Benchao Li created FLINK-19336:
--
Summary: EncodingUtils#encodeObjectToString should propagate inner
exception
Key: FLINK-19336
URL: https://issues.apache.org/jira/browse/FLINK-19336
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-19289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-19289:
---
Labels: pull-request-available (was: )
> Remove pods terminated during JM failover
>
wuchong merged pull request #13444:
URL: https://github.com/apache/flink/pull/13444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728
## CI report:
* 10d22d3c1c5b291c3bd6d730b00f152a675d7bd4 Azure:
xintongsong opened a new pull request #13448:
URL: https://github.com/apache/flink/pull/13448
## What is the purpose of the change
This PR cleans up pods terminated during JM failover (between previous
watcher closed and new watcher started) from Kubernetes.
## Verifying this
[
https://issues.apache.org/jira/browse/FLINK-18779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-18779:
---
Labels: pull-request-available (was: )
> Support the SupportsFilterPushDown interface for
wuchong commented on pull request #13433:
URL: https://github.com/apache/flink/pull/13433#issuecomment-696048513
Merging...
This is an automated message from the Apache Git Service.
To respond to the message, please log on
weizheng92 commented on pull request #13003:
URL: https://github.com/apache/flink/pull/13003#issuecomment-695930243
@klion26 您好,已经修改完成,有时间再看一下吗,非常感谢。
This is an automated message from the Apache Git Service.
To respond to
1 - 100 of 582 matches
Mail list logo