[GitHub] [flink] flinkbot edited a comment on pull request #17056: [FLINK-23748][tests] Testing window TVF session window

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17056: URL: https://github.com/apache/flink/pull/17056#issuecomment-908449260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17041: [release-1.13][FLINK-24010][connector/common] HybridSourceReader/Enumerator delegate checkpoint notifications

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17041: URL: https://github.com/apache/flink/pull/17041#issuecomment-907875334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-893364145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on a change in pull request #17059: [FLINK-24005][coordination] Only return fulfilled requirements for reserved slots

2021-08-31 Thread GitBox
zentol commented on a change in pull request #17059: URL: https://github.com/apache/flink/pull/17059#discussion_r698580248 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java ## @@ -354,30 +369,49 @@ public

[GitHub] [flink] dmvk commented on a change in pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…

2021-08-31 Thread GitBox
dmvk commented on a change in pull request #17000: URL: https://github.com/apache/flink/pull/17000#discussion_r698686629 ## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrap.java ## @@ -147,35 +146,34 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17064: [FLINK-24059][Connectors/Common] Allow SourceReaderTestBase.NUM_SPLITS to be overridden

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17064: URL: https://github.com/apache/flink/pull/17064#issuecomment-908893945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] akalash commented on a change in pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
akalash commented on a change in pull request #17024: URL: https://github.com/apache/flink/pull/17024#discussion_r698661266 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java ## @@ -692,6 +692,17 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #17070: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17070: URL: https://github.com/apache/flink/pull/17070#issuecomment-909190301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-training] alpinegizmo commented on a change in pull request #31: [FLINK-23653] exercise and test rework

2021-08-31 Thread GitBox
alpinegizmo commented on a change in pull request #31: URL: https://github.com/apache/flink-training/pull/31#discussion_r698855269 ## File path: rides-and-fares/src/main/scala/org/apache/flink/training/exercises/ridesandfares/scala/RidesAndFaresExercise.scala ## @@ -18,55

[GitHub] [flink] flinkbot edited a comment on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpse…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-904741081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17054: [FLINK-24055][connectors/kafka] Deprecate FlinkKafkaConsumer

2021-08-31 Thread GitBox
flinkbot commented on pull request #17054: URL: https://github.com/apache/flink/pull/17054#issuecomment-908396962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17058: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17058: URL: https://github.com/apache/flink/pull/17058#issuecomment-908449514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] lirui-apache closed pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…

2021-08-31 Thread GitBox
lirui-apache closed pull request #16936: URL: https://github.com/apache/flink/pull/16936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] tisonkun commented on a change in pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-31 Thread GitBox
tisonkun commented on a change in pull request #17051: URL: https://github.com/apache/flink/pull/17051#discussion_r698588574 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java ## @@ -30,14 +30,23 @@ import

[GitHub] [flink] CrynetLogistics commented on pull request #17040: [FLINK-24041][connectors] Flip 171 - Abstract Async Sink Base

2021-08-31 Thread GitBox
CrynetLogistics commented on pull request #17040: URL: https://github.com/apache/flink/pull/17040#issuecomment-909076474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] Airblader commented on a change in pull request #17060: [FLINK-23895][table] Upsert materializer is not inserted for all sink providers

2021-08-31 Thread GitBox
Airblader commented on a change in pull request #17060: URL: https://github.com/apache/flink/pull/17060#discussion_r699048585 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -260,76

[GitHub] [flink] AHeise commented on pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
AHeise commented on pull request #17067: URL: https://github.com/apache/flink/pull/17067#issuecomment-909060257 > LGTM % do you know if the KafkaSource implements all the listed metrics? Thanks for reminding. I actually found 3 metrics that are currently not supported. -- This is

[GitHub] [flink] fapaul opened a new pull request #17080: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
fapaul opened a new pull request #17080: URL: https://github.com/apache/flink/pull/17080 Unchanged backport of #17058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] XComp edited a comment on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
XComp edited a comment on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-909301145 FYI: Build failures of the [most-recent build](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22955) covered by

[GitHub] [flink] XComp commented on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
XComp commented on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-909301145 FYI: Build failures covered by [FLINK-23984](https://issues.apache.org/jira/browse/FLINK-23984) and [FLINK-23828](https://issues.apache.org/jira/browse/FLINK-23828) -- This is

[GitHub] [flink] flinkbot commented on pull request #17079: [FLINK-24054][table-runtime] Let SinkUpsertMaterializer produce +U's when possible

2021-08-31 Thread GitBox
flinkbot commented on pull request #17079: URL: https://github.com/apache/flink/pull/17079#issuecomment-909298595 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24054) Let SinkUpsertMaterializer emit +U instead of only +I

2021-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24054: --- Labels: pull-request-available (was: ) > Let SinkUpsertMaterializer emit +U instead of

[GitHub] [flink] twalthr opened a new pull request #17079: [FLINK-24054][table-runtime] Let SinkUpsertMaterializer produce +U's when possible

2021-08-31 Thread GitBox
twalthr opened a new pull request #17079: URL: https://github.com/apache/flink/pull/17079 ## What is the purpose of the change This ensures a correct changelog after the `SinkUpsertMaterializer` without introducing additional runtime overhead. ## Brief change log It

[jira] [Commented] (FLINK-23468) Benchmarks networkThroughput for OpenSSL do not run

2021-08-31 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407380#comment-17407380 ] Piotr Nowojski commented on FLINK-23468: Thanks [~chesnay], good to know. I've also enabled

[GitHub] [flink] AHeise commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
AHeise commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699384463 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -183,62 +181,83 @@ public

[GitHub] [flink] flinkbot commented on pull request #17077: [FLINK-24085][docs] Add first class subject for page `versioned table` and `Timezone`

2021-08-31 Thread GitBox
flinkbot commented on pull request #17077: URL: https://github.com/apache/flink/pull/17077#issuecomment-909283338 ## CI report: * 87fe6f2b508bb6923b16345e95204bade06af980 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17075: [FLINK-24035][network][refactor] Move the blocking allocation of one floating buffer logic from the constructor of LocalBufferPool to

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17075: URL: https://github.com/apache/flink/pull/17075#issuecomment-909241018 ## CI report: * ccdf9bfaaa9e6d6eefb728b07ccf69df8233e93a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909240894 ## CI report: * 3a29aa6e7ce0cd8c5c4a46615378b7eb36bea78d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909190390 ## CI report: * 5f6b9cba775dee77385bdd4506aaae9660801ba4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17067: URL: https://github.com/apache/flink/pull/17067#issuecomment-908989247 ## CI report: * 2a4d75712d460c5bf001b999680c5a3cf6523977 UNKNOWN * 97911f50837619825f2d8df9964b2e1072810b31 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17049: [FLINK-23971][tests] fix connector testing framework error when compare records in different splits

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17049: URL: https://github.com/apache/flink/pull/17049#issuecomment-908270735 ## CI report: * daad66852e5f50e47b36652f0207a63f3096c125 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17058: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17058: URL: https://github.com/apache/flink/pull/17058#issuecomment-908449514 ## CI report: * 9c505bff67259f080b8724eff1d2e7659aa5e3a3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17024: URL: https://github.com/apache/flink/pull/17024#issuecomment-907189537 ## CI report: * a55891c9402712a818155f1ea798464754243b5a Azure:

[jira] [Updated] (FLINK-24086) Do not re-register SharedStateRegistry to reduce the recovery time of the job

2021-08-31 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ming li updated FLINK-24086: Description: At present, we only recover the {{CompletedCheckpointStore}} when the {{JobManager}}

[GitHub] [flink] flinkbot edited a comment on pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16988: URL: https://github.com/apache/flink/pull/16988#issuecomment-905730008 ## CI report: * 680f8172bea8a9b7396604e8f0c5dcaf4efff5f9 Azure:

[jira] [Commented] (FLINK-23875) ReducingUpsertSink can loose records during failover

2021-08-31 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407376#comment-17407376 ] Arvid Heise commented on FLINK-23875: - Reverted in e45c72d1bc6f8c81ba8bb3659fd1cd58e56652d9. Thanks

[jira] [Created] (FLINK-24086) Do not re-register SharedStateRegistry to reduce the recovery time of the job

2021-08-31 Thread ming li (Jira)
ming li created FLINK-24086: --- Summary: Do not re-register SharedStateRegistry to reduce the recovery time of the job Key: FLINK-24086 URL: https://issues.apache.org/jira/browse/FLINK-24086 Project: Flink

[GitHub] [flink] RocMarshal commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
RocMarshal commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909273188 @wuchong Thank you so much for the comments. And I updated it based on your suggestions. PTAL. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-24005) Resource requirements declaration may be incorrect if JobMaster disconnects with a TaskManager with available slots in the SlotPool

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407372#comment-17407372 ] Till Rohrmann commented on FLINK-24005: --- {quote}In practice this is currently the case, but if the

[GitHub] [flink-training] alpinegizmo merged pull request #31: [FLINK-23653] exercise and test rework

2021-08-31 Thread GitBox
alpinegizmo merged pull request #31: URL: https://github.com/apache/flink-training/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-24085) The `versioned table` and `Timezone` pages missed the first class subject

2021-08-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-24085: Fix Version/s: 1.15.0 1.14.0 > The `versioned table` and `Timezone` pages missed the

[jira] [Updated] (FLINK-24081) OVER window throws exception when the rowtime is timestamp_ltz type

2021-08-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-24081: Fix Version/s: 1.15.0 1.13.3 1.14.0 > OVER window throws exception

[jira] [Assigned] (FLINK-24081) OVER window throws exception when the rowtime is timestamp_ltz type

2021-08-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-24081: --- Assignee: Leonard Xu > OVER window throws exception when the rowtime is timestamp_ltz type >

[jira] [Assigned] (FLINK-24085) The `versioned table` and `Timezone` pages missed the first class subject

2021-08-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-24085: --- Assignee: Leonard Xu > The `versioned table` and `Timezone` pages missed the first class subject

[GitHub] [flink] wsry commented on a change in pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
wsry commented on a change in pull request #16988: URL: https://github.com/apache/flink/pull/16988#discussion_r699354935 ## File path: docs/content/docs/deployment/network_buffer.md ## @@ -0,0 +1,125 @@ +--- +title: "Network Tuning" +weight: 100 +type: docs +aliases: + -

[jira] [Commented] (FLINK-22483) Recover checkpoints when JobMaster gains leadership

2021-08-31 Thread ming li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407365#comment-17407365 ] ming li commented on FLINK-22483: - Hi, [~trohrmann]. Thanks for your reply, I will create a separate

[GitHub] [flink] flinkbot edited a comment on pull request #16192: [FLINK-22954][table-planner-blink] Rewrite Join on constant TableFunctionScan to Correlate

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16192: URL: https://github.com/apache/flink/pull/16192#issuecomment-863860019 ## CI report: * 6bfa8ca05323eca73531adb548f84c0c222afd30 Azure:

[jira] [Closed] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman closed FLINK-24084. Resolution: Fixed > The example in sql join document is incorrect >

[jira] [Updated] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-24084: - Fix Version/s: 1.15.0 1.14.0 > The example in sql join document is incorrect

[jira] [Commented] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407361#comment-17407361 ] Seth Wiesman commented on FLINK-24084: -- fixed in master: 04e7433cc4ea4ffc8f254212f0d6a4355a4c051a

[GitHub] [flink] sjwiesman closed pull request #17076: [FLINK-24084][docs] Correct the examples in SQL JOIN docs

2021-08-31 Thread GitBox
sjwiesman closed pull request #17076: URL: https://github.com/apache/flink/pull/17076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-13172) JVM crash with dynamic netty-tcnative wrapper to openSSL on some OS

2021-08-31 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-13172: --- Priority: Not a Priority (was: Minor) > JVM crash with dynamic netty-tcnative wrapper to

[jira] [Commented] (FLINK-23468) Benchmarks networkThroughput for OpenSSL do not run

2021-08-31 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407359#comment-17407359 ] Chesnay Schepler commented on FLINK-23468: -- FYI this is also what we do in Flink:

[jira] [Assigned] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman reassigned FLINK-24084: Assignee: Leonard Xu > The example in sql join document is incorrect >

[jira] [Comment Edited] (FLINK-23468) Benchmarks networkThroughput for OpenSSL do not run

2021-08-31 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407352#comment-17407352 ] Piotr Nowojski edited comment on FLINK-23468 at 8/31/21, 1:47 PM: --

[GitHub] [flink] fapaul commented on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
fapaul commented on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909253263 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #17078: [FLINK-23468][test] Do not hide original exception if SSL is not available

2021-08-31 Thread GitBox
flinkbot commented on pull request #17078: URL: https://github.com/apache/flink/pull/17078#issuecomment-909252758 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-23468) Benchmarks networkThroughput for OpenSSL do not run

2021-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23468: --- Labels: pull-request-available (was: ) > Benchmarks networkThroughput for OpenSSL do not

[GitHub] [flink] pnowojski opened a new pull request #17078: [FLINK-23468][test] Do not hide original exception if SSL is not available

2021-08-31 Thread GitBox
pnowojski opened a new pull request #17078: URL: https://github.com/apache/flink/pull/17078 This is a simple change in tests that throws the original exception instead of failing with JUnit assertion if OpenSSL was not found. ## Does this pull request potentially affect one of the

[jira] [Commented] (FLINK-22483) Recover checkpoints when JobMaster gains leadership

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407351#comment-17407351 ] Till Rohrmann commented on FLINK-22483: --- Ui, if the reconstruction of the {{SharedStateRegistry}}

[jira] [Commented] (FLINK-23468) Benchmarks networkThroughput for OpenSSL do not run

2021-08-31 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407352#comment-17407352 ] Piotr Nowojski commented on FLINK-23468: After checking the underlying exception: {noformat}

[jira] [Commented] (FLINK-24063) Reconsider the behavior of ClusterEntrypoint#startCluster failure handler

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407347#comment-17407347 ] Till Rohrmann commented on FLINK-24063: --- I agree that if the {{ClusterEntrypoint.runCluster}}

[GitHub] [flink-web] sjwiesman closed pull request #463: Statefun release 3.1

2021-08-31 Thread GitBox
sjwiesman closed pull request #463: URL: https://github.com/apache/flink-web/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-22672) Some enhancements for pluggable shuffle service framework

2021-08-31 Thread Joe Moser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407345#comment-17407345 ] Joe Moser commented on FLINK-22672: --- [~jinxing6...@126.com] how are your plans going with publishing

[jira] [Commented] (FLINK-24038) DispatcherResourceManagerComponent fails to deregister application if no leading ResourceManager

2021-08-31 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407343#comment-17407343 ] Till Rohrmann commented on FLINK-24038: --- It is a good question what the easiest solution is. I

[GitHub] [flink] flinkbot commented on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
flinkbot commented on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909240894 ## CI report: * 3a29aa6e7ce0cd8c5c4a46615378b7eb36bea78d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17075: [FLINK-24035][network][refactor] Move the blocking allocation of one floating buffer logic from the constructor of LocalBufferPool to Single

2021-08-31 Thread GitBox
flinkbot commented on pull request #17075: URL: https://github.com/apache/flink/pull/17075#issuecomment-909241018 ## CI report: * ccdf9bfaaa9e6d6eefb728b07ccf69df8233e93a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17069: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17069: URL: https://github.com/apache/flink/pull/17069#issuecomment-909162379 ## CI report: * aed06a7ed1fb587d27ca6b1e86bebdbfc7a887da Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17067: URL: https://github.com/apache/flink/pull/17067#issuecomment-908989247 ## CI report: * b673222ab13a56c49d31c804d3bde5f8f69c440c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17070: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17070: URL: https://github.com/apache/flink/pull/17070#issuecomment-909190301 ## CI report: * 3700dfa72cd72d384bf6d69376321fb7ef9eaab9 UNKNOWN * 4aac2774925e49df9f75903734eb4a98f7f9f3bc Azure:

[jira] [Updated] (FLINK-12340) Cache frontend-maven-plugin npm artifacts

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-12340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk updated FLINK-12340: -- Component/s: Build System > Cache frontend-maven-plugin npm artifacts >

[GitHub] [flink] flinkbot edited a comment on pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17024: URL: https://github.com/apache/flink/pull/17024#issuecomment-907189537 ## CI report: * a55891c9402712a818155f1ea798464754243b5a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-893364145 ## CI report: * ce83c52813ef9b754a0aded512e80503507b1547 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16192: [FLINK-22954][table-planner-blink] Rewrite Join on constant TableFunctionScan to Correlate

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16192: URL: https://github.com/apache/flink/pull/16192#issuecomment-863860019 ## CI report: * 6bfa8ca05323eca73531adb548f84c0c222afd30 Azure:

[GitHub] [flink] flinkbot commented on pull request #17077: [FLINK-24085][docs] Add first class subject for page `versioned table` and `Timezone`

2021-08-31 Thread GitBox
flinkbot commented on pull request #17077: URL: https://github.com/apache/flink/pull/17077#issuecomment-909236529 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24078) Remove brackets around variables

2021-08-31 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24078: - Description: Internally, variable keys are stored with brackets, e.g., {{}}. In

[jira] [Commented] (FLINK-24085) The `versioned table` and `Timezone` pages missed the first class subject

2021-08-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407335#comment-17407335 ] Leonard Xu commented on FLINK-24085: [~jark] Could you help assign this to me? appreciate if you can

[jira] [Updated] (FLINK-24085) The `versioned table` and `Timezone` pages missed the first class subject

2021-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24085: --- Labels: pull-request-available (was: ) > The `versioned table` and `Timezone` pages missed

[GitHub] [flink] leonardBang opened a new pull request #17077: [FLINK-24085][docs] Add first class subject for page `versioned table` and `Timezone`

2021-08-31 Thread GitBox
leonardBang opened a new pull request #17077: URL: https://github.com/apache/flink/pull/17077 ## What is the purpose of the change * Add first class subject for page `versioned table` and `Timezone` ## Brief change log * Add first class subject for page `versioned

[GitHub] [flink] flinkbot commented on pull request #17076: [FLINK-24084][docs] Correct the examples in SQL JOIN docs

2021-08-31 Thread GitBox
flinkbot commented on pull request #17076: URL: https://github.com/apache/flink/pull/17076#issuecomment-909232576 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink-training] alpinegizmo commented on pull request #31: [FLINK-23653] exercise and test rework

2021-08-31 Thread GitBox
alpinegizmo commented on pull request #31: URL: https://github.com/apache/flink-training/pull/31#issuecomment-909228839 @NicoK The two open points you raised are outdated. Those tests are gone and were replaced by a combination of a revised integration test with more rides and fares, and

[jira] [Created] (FLINK-24085) The `versioned table` and `Timezone` pages missed the first class subject

2021-08-31 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-24085: -- Summary: The `versioned table` and `Timezone` pages missed the first class subject Key: FLINK-24085 URL: https://issues.apache.org/jira/browse/FLINK-24085 Project:

[GitHub] [flink] lometheus commented on a change in pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
lometheus commented on a change in pull request #17024: URL: https://github.com/apache/flink/pull/17024#discussion_r699310015 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java ## @@ -692,6 +692,17 @@ public void

[jira] [Commented] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407329#comment-17407329 ] Leonard Xu commented on FLINK-24084: CC [~sjwiesman] Could you help assign this one to me?

[GitHub] [flink] lometheus commented on a change in pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
lometheus commented on a change in pull request #17024: URL: https://github.com/apache/flink/pull/17024#discussion_r699309381 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java ## @@ -330,9 +330,12 @@

[GitHub] [flink-web] Airblader commented on a change in pull request #460: Add blog post - Implement custom source connector for Table API and SQL

2021-08-31 Thread GitBox
Airblader commented on a change in pull request #460: URL: https://github.com/apache/flink-web/pull/460#discussion_r699159814 ## File path: _posts/2021-08-16-connector-table-sql-api-part2.md ## @@ -0,0 +1,497 @@ +--- +layout: post +title: "Implementing a custom source

[jira] [Commented] (FLINK-23389) AWS Glue Schema Registry JSON support for Apache Flink

2021-08-31 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407326#comment-17407326 ] Danny Cranmer commented on FLINK-23389: --- We have missed Flink 1.14 so will need to target 1.15 now

[jira] [Updated] (FLINK-23389) AWS Glue Schema Registry JSON support for Apache Flink

2021-08-31 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-23389: -- Fix Version/s: 1.15.0 > AWS Glue Schema Registry JSON support for Apache Flink >

[GitHub] [flink] lometheus commented on a change in pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
lometheus commented on a change in pull request #17024: URL: https://github.com/apache/flink/pull/17024#discussion_r699305515 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java ## @@ -330,9 +330,12 @@

[jira] [Updated] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24084: --- Labels: pull-request-available (was: ) > The example in sql join document is incorrect >

[GitHub] [flink] leonardBang opened a new pull request #17076: [FLINK-24084][docs] Correct the examples in SQL JOIN docs

2021-08-31 Thread GitBox
leonardBang opened a new pull request #17076: URL: https://github.com/apache/flink/pull/17076 ## What is the purpose of the change * This pull request Fix the examples in SQL JOIN docs ## Brief change log - The metadata key `values.source.timestamp` only supports in

[jira] [Updated] (FLINK-24084) The example in sql join document is incorrect

2021-08-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-24084: --- Summary: The example in sql join document is incorrect (was: The example in sql join document

[GitHub] [flink] flinkbot edited a comment on pull request #17070: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17070: URL: https://github.com/apache/flink/pull/17070#issuecomment-909190301 ## CI report: * 3700dfa72cd72d384bf6d69376321fb7ef9eaab9 UNKNOWN * 4aac2774925e49df9f75903734eb4a98f7f9f3bc UNKNOWN Bot commands The

[GitHub] [flink] flinkbot edited a comment on pull request #17069: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17069: URL: https://github.com/apache/flink/pull/17069#issuecomment-909162379 ## CI report: * aed06a7ed1fb587d27ca6b1e86bebdbfc7a887da Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909190390 ## CI report: * 5f6b9cba775dee77385bdd4506aaae9660801ba4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17073: [FLINK-24058][coordination][tests] Harden TaskSlotTableImplTest#runDeactivateSlotTimeoutTest

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17073: URL: https://github.com/apache/flink/pull/17073#issuecomment-909190473 ## CI report: * 64652a612587229163e00d740031f8b303308c86 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17050: [FLINK-23351][tests] Harden FileReadingWatermarkITCase by counting wa…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17050: URL: https://github.com/apache/flink/pull/17050#issuecomment-908295316 ## CI report: * a4c9501964a166055517eeead5bdebe58cb466a8 UNKNOWN * 7c20e7910b5f15eb88d6d2b25733c50a8c214f14 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 ## CI report: * fa25b27d642ab7e6af356ca1e9738a006d48 UNKNOWN * 60655804ce59530d485c1ae939f9b005b1ef5ede Azure:

[jira] [Created] (FLINK-24084) The example in sql join document missed primary key

2021-08-31 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-24084: -- Summary: The example in sql join document missed primary key Key: FLINK-24084 URL: https://issues.apache.org/jira/browse/FLINK-24084 Project: Flink Issue Type:

[GitHub] [flink] flinkbot commented on pull request #17075: [FLINK-24035][network][refactor] Move the blocking allocation of one floating buffer logic from the constructor of LocalBufferPool to Single

2021-08-31 Thread GitBox
flinkbot commented on pull request #17075: URL: https://github.com/apache/flink/pull/17075#issuecomment-909203226 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

<    1   2   3   4   5   6   7   8   >