[GitHub] [flink] flinkbot commented on pull request #17639: [FLINK-24731] add a blank space

2021-11-02 Thread GitBox
flinkbot commented on pull request #17639: URL: https://github.com/apache/flink/pull/17639#issuecomment-957242407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] galenwarren commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2021-11-02 Thread GitBox
galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-956400920 @MartijnVisser I have the remaining work basically done, except I need to figure out the LICENSE file for the new project. @xintongsong has provided instructions for how to

[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='

2021-11-02 Thread GitBox
hililiwei commented on pull request #17613: URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301 @MartijnVisser added two test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
flinkbot commented on pull request #17632: URL: https://github.com/apache/flink/pull/17632#issuecomment-956326604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-948251540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17229: [FLINK-23381][state] Back-pressure on reaching state change to upload limit

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17229: URL: https://github.com/apache/flink/pull/17229#issuecomment-916519510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] JingGe commented on a change in pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-11-02 Thread GitBox
JingGe commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r740224352 ## File path: flink-formats/flink-parquet/pom.xml ## @@ -45,6 +45,14 @@ under the License. provided +

[GitHub] [flink] Aitozi commented on pull request #17428: [hotfix]Refactor the registerJobManager to registerJobMaster

2021-11-02 Thread GitBox
Aitozi commented on pull request #17428: URL: https://github.com/apache/flink/pull/17428#issuecomment-957485338 Could you also help review this minor refactor, thanks @tillrohrmann -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] tillrohrmann commented on a change in pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…

2021-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #17426: URL: https://github.com/apache/flink/pull/17426#discussion_r740964619 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to the

[GitHub] [flink] xuyangzhong commented on a change in pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
xuyangzhong commented on a change in pull request #17632: URL: https://github.com/apache/flink/pull/17632#discussion_r740708151 ## File path:

[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17608: URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172 ## CI report: * 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17636: [hotfix][typos] Typos in PULL_REQUEST_TEMPLATE.md

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17636: URL: https://github.com/apache/flink/pull/17636#issuecomment-956577935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-904541061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] akalash commented on pull request #17620: [FLINK-24671][runtime] Return 0 buffers in use until subpartition vie…

2021-11-02 Thread GitBox
akalash commented on pull request #17620: URL: https://github.com/apache/flink/pull/17620#issuecomment-956386170 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] akalash commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
akalash commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r739087076 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] dannycranmer commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
dannycranmer commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r741246342 ## File path: flink-connectors/flink-connector-aws/pom.xml ## @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] zentol commented on pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
zentol commented on pull request #17633: URL: https://github.com/apache/flink/pull/17633#issuecomment-957182630 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] pnowojski merged pull request #17629: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
pnowojski merged pull request #17629: URL: https://github.com/apache/flink/pull/17629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-11-02 Thread GitBox
AHeise commented on pull request #17501: URL: https://github.com/apache/flink/pull/17501#issuecomment-957254354 > > > > @echauchot > > > > > Sure, I saw the comments about split and data types etc... But I feel unconfortable about draft PRs because they usually cannot be merged as is.

[GitHub] [flink] meetjunsu removed a comment on pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-11-02 Thread GitBox
meetjunsu removed a comment on pull request #17542: URL: https://github.com/apache/flink/pull/17542#issuecomment-956078481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17633: URL: https://github.com/apache/flink/pull/17633#issuecomment-956406134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957180521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17630: [hotfix][javadocs] Improve JavaDocs of SupportsAggregatePushDown

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17630: URL: https://github.com/apache/flink/pull/17630#issuecomment-956266960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] akalash commented on pull request #17627: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
akalash commented on pull request #17627: URL: https://github.com/apache/flink/pull/17627#issuecomment-957350370 As I can see tests are good, the one failed test is also present in main branch(https://issues.apache.org/jira/browse/FLINK-24734) -- This is an automated message from the

[GitHub] [flink] zentol edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957620163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser closed pull request #17484: [hotfix][docs] Add Analytics GA4 implementation to be prepared for migration

2021-11-02 Thread GitBox
MartijnVisser closed pull request #17484: URL: https://github.com/apache/flink/pull/17484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] iyupeng commented on pull request #17630: [hotfix][javadocs] Improve JavaDocs of SupportsAggregatePushDown

2021-11-02 Thread GitBox
iyupeng commented on pull request #17630: URL: https://github.com/apache/flink/pull/17630#issuecomment-957109574 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #17635: [FLINK-24724] Update Sun XML Bind dependencies to latest minor version

2021-11-02 Thread GitBox
flinkbot commented on pull request #17635: URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] TanYuxin-tyx commented on a change in pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-02 Thread GitBox
TanYuxin-tyx commented on a change in pull request #17532: URL: https://github.com/apache/flink/pull/17532#discussion_r740326336 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/ServerTransportErrorHandlingTest.java ## @@ -101,7 +104,22 @@

[GitHub] [flink] MartijnVisser closed pull request #17623: [FLINK-24718] Update AVRO dependency to latest version

2021-11-02 Thread GitBox
MartijnVisser closed pull request #17623: URL: https://github.com/apache/flink/pull/17623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17634: URL: https://github.com/apache/flink/pull/17634#issuecomment-956440201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17641: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17641: URL: https://github.com/apache/flink/pull/17641#issuecomment-957270143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-benchmarks] dawidwys commented on pull request #40: [FLINK-24732] Remove scala suffix from respective benchmarks dependencies

2021-11-02 Thread GitBox
dawidwys commented on pull request #40: URL: https://github.com/apache/flink-benchmarks/pull/40#issuecomment-957252066 duplicate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] alibahadirzeybek commented on pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
alibahadirzeybek commented on pull request #17633: URL: https://github.com/apache/flink/pull/17633#issuecomment-956408059 > @alibahadirzeybek the change looks good to me, but can you please apply it to the scala quickstart pom as well? We should keep these in sync. Done -- This

[GitHub] [flink] rkhachatryan commented on a change in pull request #17229: [FLINK-23381][state] Back-pressure on reaching state change to upload limit

2021-11-02 Thread GitBox
rkhachatryan commented on a change in pull request #17229: URL: https://github.com/apache/flink/pull/17229#discussion_r740357432 ## File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/UploadThrottle.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] [flink] dawidwys commented on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-957321556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] alisdlyc commented on pull request #17639: [FLINK-24731] add a blank space

2021-11-02 Thread GitBox
alisdlyc commented on pull request #17639: URL: https://github.com/apache/flink/pull/17639#issuecomment-957282820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
fapaul commented on a change in pull request #17580: URL: https://github.com/apache/flink/pull/17580#discussion_r741067353 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -279,6 +282,10 @@ public void start() throws

[GitHub] [flink] tillrohrmann closed pull request #17428: [hotfix]Refactor the registerJobManager to registerJobMaster

2021-11-02 Thread GitBox
tillrohrmann closed pull request #17428: URL: https://github.com/apache/flink/pull/17428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17647: URL: https://github.com/apache/flink/pull/17647#issuecomment-957882505 ## CI report: * 6c39b7b30fb6a4f81fac803ccf7969f67a699da9 Azure:

[GitHub] [flink] fapaul commented on a change in pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
fapaul commented on a change in pull request #17626: URL: https://github.com/apache/flink/pull/17626#discussion_r740798571 ## File path: flink-table/flink-table-planner/pom.xml ## @@ -356,6 +356,7 @@ under the License.

[GitHub] [flink] pnowojski merged pull request #17627: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
pnowojski merged pull request #17627: URL: https://github.com/apache/flink/pull/17627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 ## CI report: * 31f4cbdab0cc2c8701c2ee049491a0b0b45a9167 Azure:

[GitHub] [flink] MartijnVisser commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2021-11-02 Thread GitBox
MartijnVisser commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-956450941 @galenwarren I have no problem setting deadlines :D If you reach the end of this month, it would make the 1.15 release normally -- This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on pull request #17607: [FLINK-24543][runtime] Avoid possible inconsistencies of ZookeeperSta…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17607: URL: https://github.com/apache/flink/pull/17607#issuecomment-954762085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-benchmarks] dawidwys closed pull request #40: [FLINK-24732] Remove scala suffix from respective benchmarks dependencies

2021-11-02 Thread GitBox
dawidwys closed pull request #40: URL: https://github.com/apache/flink-benchmarks/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] meetjunsu commented on pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-11-02 Thread GitBox
meetjunsu commented on pull request #17542: URL: https://github.com/apache/flink/pull/17542#issuecomment-957024848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] GOODBOY008 commented on pull request #17622: [FLINK-24407][doc-zh]Pulsar connector chinese document link to Pulsar document location incorrectly.

2021-11-02 Thread GitBox
GOODBOY008 commented on pull request #17622: URL: https://github.com/apache/flink/pull/17622#issuecomment-957187711 @wuchong Please cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17635: [FLINK-24724] Update Sun XML Bind dependencies to latest minor version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17635: URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
flinkbot commented on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957412578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] sjwiesman closed pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
sjwiesman closed pull request #17633: URL: https://github.com/apache/flink/pull/17633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] TanYuxin-tyx commented on pull request #17532: [FLINK-22096][tests] Fix port conflict for ServerTransportErrorHandlingTest#testRemoteClose

2021-11-02 Thread GitBox
TanYuxin-tyx commented on pull request #17532: URL: https://github.com/apache/flink/pull/17532#issuecomment-956355809 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-957219037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on a change in pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-02 Thread GitBox
AHeise commented on a change in pull request #17538: URL: https://github.com/apache/flink/pull/17538#discussion_r740484286 ## File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java

[GitHub] [flink] mayuehappy commented on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-02 Thread GitBox
mayuehappy commented on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-957040774 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] CrynetLogistics commented on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
CrynetLogistics commented on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-956491159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] echauchot commented on pull request #17641: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
echauchot commented on pull request #17641: URL: https://github.com/apache/flink/pull/17641#issuecomment-957268928 R: @AHeise as discussed slightly_smiling_face -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
zentol commented on a change in pull request #17580: URL: https://github.com/apache/flink/pull/17580#discussion_r741004140 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -279,6 +282,10 @@ public void start() throws

[GitHub] [flink] flinkbot edited a comment on pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for window-t

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17509: URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] tillrohrmann commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957309354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-web] sjwiesman commented on a change in pull request #478: add Flink Backward blog post

2021-11-02 Thread GitBox
sjwiesman commented on a change in pull request #478: URL: https://github.com/apache/flink-web/pull/478#discussion_r740478608 ## File path: _posts/2021-11-03-flink-backward.md ## @@ -0,0 +1,79 @@ +--- +layout: post +title: "Flink Backward - The Apache Flink Retrospective"

[GitHub] [flink] flinkbot edited a comment on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-957264269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dawidwys commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r741117079 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot commented on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink

2021-11-02 Thread GitBox
flinkbot commented on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-957219037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] beyond1920 commented on a change in pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
beyond1920 commented on a change in pull request #17632: URL: https://github.com/apache/flink/pull/17632#discussion_r740955153 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalWindowDeduplicate.scala

[GitHub] [flink] flinkbot edited a comment on pull request #17627: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17627: URL: https://github.com/apache/flink/pull/17627#issuecomment-956258384 ## CI report: * 258555b03cdc7d8366291d5a131bc0afad6d3ee8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol merged pull request #17631: [FLINK-24720][tests] Remove flink-runtime-web dependency

2021-11-02 Thread GitBox
zentol merged pull request #17631: URL: https://github.com/apache/flink/pull/17631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] AHeise commented on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-02 Thread GitBox
AHeise commented on pull request #17538: URL: https://github.com/apache/flink/pull/17538#issuecomment-957933362 Btw it's hard to see if all comments of @fapaul have been addressed. Please always respond to feedback, so it's easier to follow what has been improved already. I use  reaction

[GitHub] [flink] MartijnVisser commented on a change in pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
MartijnVisser commented on a change in pull request #17626: URL: https://github.com/apache/flink/pull/17626#discussion_r741022824 ## File path: flink-table/flink-table-planner/pom.xml ## @@ -356,6 +356,7 @@ under the License.

[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17426: URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17626: URL: https://github.com/apache/flink/pull/17626#issuecomment-956209711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #17635: [FLINK-24724] Update Sun XML Bind dependencies to latest minor version

2021-11-02 Thread GitBox
MartijnVisser commented on pull request #17635: URL: https://github.com/apache/flink/pull/17635#issuecomment-956752220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] syhily edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
syhily edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355 I don't think this fixed the data loss issue. Pulsar [internally

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * a9ce74387e3be7c9fa8e4309886c9b86825c3aea Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * c0bcfc327fad7eb71a6bd2272cd0a667d53ec475 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] dannycranmer commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
dannycranmer commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r741246342 ## File path: flink-connectors/flink-connector-aws/pom.xml ## @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 ## CI report: * a76716059642a21592769cb39242be82d01091a5 Azure:

[jira] [Assigned] (FLINK-24733) Data loss in pulsar source when using shared mode

2021-11-02 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-24733: -- Assignee: Yufan Sheng > Data loss in pulsar source when using shared mode >

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 ## CI report: * a76716059642a21592769cb39242be82d01091a5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] AHeise commented on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-02 Thread GitBox
AHeise commented on pull request #17538: URL: https://github.com/apache/flink/pull/17538#issuecomment-957933362 Btw it's hard to see if all comments of @fapaul have been addressed. Please always respond to feedback, so it's easier to follow what has been improved already. I use  reaction

[GitHub] [flink] AHeise commented on a change in pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-02 Thread GitBox
AHeise commented on a change in pull request #17538: URL: https://github.com/apache/flink/pull/17538#discussion_r740484286 ## File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java

[GitHub] [flink] flinkbot edited a comment on pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17626: URL: https://github.com/apache/flink/pull/17626#issuecomment-956209711 ## CI report: * 7bd72621e104983e4b338723b95527dc5df31941 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17644: [FLINK-24725] Update Cython to the latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17644: URL: https://github.com/apache/flink/pull/17644#issuecomment-957525049 ## CI report: * d8769c88e83f53222375497108e64134e1eef664 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17635: [FLINK-24724] Update Sun XML Bind dependencies to latest minor version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17635: URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981 ## CI report: * 5bca0bc1a4495c80ca7651acf949133da8bc2d69 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[jira] [Commented] (FLINK-24733) Data loss in pulsar source when using shared mode

2021-11-02 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437460#comment-17437460 ] Yufan Sheng commented on FLINK-24733: - [~shengzhi] The fix didn't touch the core of data loss. We

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] syhily edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
syhily edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355 I don't think this fixed the data loss issue. Pulsar [internally

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

<    1   2   3   4   5   6   7   8   >