flinkbot commented on pull request #17639:
URL: https://github.com/apache/flink/pull/17639#issuecomment-957242407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
galenwarren commented on pull request #15599:
URL: https://github.com/apache/flink/pull/15599#issuecomment-956400920
@MartijnVisser I have the remaining work basically done, except I need to
figure out the LICENSE file for the new project. @xintongsong has provided
instructions for how to
hililiwei commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301
@MartijnVisser added two test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flinkbot commented on pull request #17632:
URL: https://github.com/apache/flink/pull/17632#issuecomment-956326604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #17345:
URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #17532:
URL: https://github.com/apache/flink/pull/17532#issuecomment-948251540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #17229:
URL: https://github.com/apache/flink/pull/17229#issuecomment-916519510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
JingGe commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r740224352
##
File path: flink-formats/flink-parquet/pom.xml
##
@@ -45,6 +45,14 @@ under the License.
provided
+
Aitozi commented on pull request #17428:
URL: https://github.com/apache/flink/pull/17428#issuecomment-957485338
Could you also help review this minor refactor, thanks @tillrohrmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tillrohrmann commented on a change in pull request #17426:
URL: https://github.com/apache/flink/pull/17426#discussion_r740964619
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the
xuyangzhong commented on a change in pull request #17632:
URL: https://github.com/apache/flink/pull/17632#discussion_r740708151
##
File path:
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
## CI report:
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure:
flinkbot edited a comment on pull request #17636:
URL: https://github.com/apache/flink/pull/17636#issuecomment-956577935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #16962:
URL: https://github.com/apache/flink/pull/16962#issuecomment-904541061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
akalash commented on pull request #17620:
URL: https://github.com/apache/flink/pull/17620#issuecomment-956386170
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
akalash commented on a change in pull request #17541:
URL: https://github.com/apache/flink/pull/17541#discussion_r739087076
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to
dannycranmer commented on a change in pull request #17345:
URL: https://github.com/apache/flink/pull/17345#discussion_r741246342
##
File path: flink-connectors/flink-connector-aws/pom.xml
##
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
zentol commented on pull request #17633:
URL: https://github.com/apache/flink/pull/17633#issuecomment-957182630
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
pnowojski merged pull request #17629:
URL: https://github.com/apache/flink/pull/17629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on pull request #17648:
URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
AHeise commented on pull request #17501:
URL: https://github.com/apache/flink/pull/17501#issuecomment-957254354
> > > > @echauchot
> > > > > Sure, I saw the comments about split and data types etc... But I
feel unconfortable about draft PRs because they usually cannot be merged as is.
meetjunsu removed a comment on pull request #17542:
URL: https://github.com/apache/flink/pull/17542#issuecomment-956078481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
flinkbot edited a comment on pull request #17633:
URL: https://github.com/apache/flink/pull/17633#issuecomment-956406134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zentol commented on pull request #17606:
URL: https://github.com/apache/flink/pull/17606#issuecomment-957180521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #17630:
URL: https://github.com/apache/flink/pull/17630#issuecomment-956266960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
akalash commented on pull request #17627:
URL: https://github.com/apache/flink/pull/17627#issuecomment-957350370
As I can see tests are good, the one failed test is also present in main
branch(https://issues.apache.org/jira/browse/FLINK-24734)
--
This is an automated message from the
zentol edited a comment on pull request #17606:
URL: https://github.com/apache/flink/pull/17606#issuecomment-957620163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
MartijnVisser closed pull request #17484:
URL: https://github.com/apache/flink/pull/17484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
iyupeng commented on pull request #17630:
URL: https://github.com/apache/flink/pull/17630#issuecomment-957109574
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flinkbot commented on pull request #17635:
URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
TanYuxin-tyx commented on a change in pull request #17532:
URL: https://github.com/apache/flink/pull/17532#discussion_r740326336
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/ServerTransportErrorHandlingTest.java
##
@@ -101,7 +104,22 @@
MartijnVisser closed pull request #17623:
URL: https://github.com/apache/flink/pull/17623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot edited a comment on pull request #17634:
URL: https://github.com/apache/flink/pull/17634#issuecomment-956440201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #17641:
URL: https://github.com/apache/flink/pull/17641#issuecomment-957270143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dawidwys commented on pull request #40:
URL: https://github.com/apache/flink-benchmarks/pull/40#issuecomment-957252066
duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alibahadirzeybek commented on pull request #17633:
URL: https://github.com/apache/flink/pull/17633#issuecomment-956408059
> @alibahadirzeybek the change looks good to me, but can you please apply it
to the scala quickstart pom as well? We should keep these in sync.
Done
--
This
rkhachatryan commented on a change in pull request #17229:
URL: https://github.com/apache/flink/pull/17229#discussion_r740357432
##
File path:
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/UploadThrottle.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the
dawidwys commented on pull request #17541:
URL: https://github.com/apache/flink/pull/17541#issuecomment-957321556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alisdlyc commented on pull request #17639:
URL: https://github.com/apache/flink/pull/17639#issuecomment-957282820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
fapaul commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741067353
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##
@@ -279,6 +282,10 @@ public void start() throws
tillrohrmann closed pull request #17428:
URL: https://github.com/apache/flink/pull/17428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot edited a comment on pull request #17647:
URL: https://github.com/apache/flink/pull/17647#issuecomment-957882505
## CI report:
* 6c39b7b30fb6a4f81fac803ccf7969f67a699da9 Azure:
fapaul commented on a change in pull request #17626:
URL: https://github.com/apache/flink/pull/17626#discussion_r740798571
##
File path: flink-table/flink-table-planner/pom.xml
##
@@ -356,6 +356,7 @@ under the License.
pnowojski merged pull request #17627:
URL: https://github.com/apache/flink/pull/17627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot edited a comment on pull request #17648:
URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509
## CI report:
* 31f4cbdab0cc2c8701c2ee049491a0b0b45a9167 Azure:
MartijnVisser commented on pull request #15599:
URL: https://github.com/apache/flink/pull/15599#issuecomment-956450941
@galenwarren I have no problem setting deadlines :D If you reach the end of
this month, it would make the 1.15 release normally
--
This is an automated message from the
flinkbot edited a comment on pull request #17607:
URL: https://github.com/apache/flink/pull/17607#issuecomment-954762085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dawidwys closed pull request #40:
URL: https://github.com/apache/flink-benchmarks/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
meetjunsu commented on pull request #17542:
URL: https://github.com/apache/flink/pull/17542#issuecomment-957024848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
GOODBOY008 commented on pull request #17622:
URL: https://github.com/apache/flink/pull/17622#issuecomment-957187711
@wuchong Please cc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
flinkbot edited a comment on pull request #17635:
URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot commented on pull request #17643:
URL: https://github.com/apache/flink/pull/17643#issuecomment-957412578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sjwiesman closed pull request #17633:
URL: https://github.com/apache/flink/pull/17633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TanYuxin-tyx commented on pull request #17532:
URL: https://github.com/apache/flink/pull/17532#issuecomment-956355809
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
flinkbot edited a comment on pull request #17638:
URL: https://github.com/apache/flink/pull/17638#issuecomment-957219037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
AHeise commented on a change in pull request #17538:
URL: https://github.com/apache/flink/pull/17538#discussion_r740484286
##
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java
mayuehappy commented on pull request #17525:
URL: https://github.com/apache/flink/pull/17525#issuecomment-957040774
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
CrynetLogistics commented on pull request #17345:
URL: https://github.com/apache/flink/pull/17345#issuecomment-956491159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
echauchot commented on pull request #17641:
URL: https://github.com/apache/flink/pull/17641#issuecomment-957268928
R: @AHeise as discussed slightly_smiling_face
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zentol commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r741004140
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##
@@ -279,6 +282,10 @@ public void start() throws
flinkbot edited a comment on pull request #17509:
URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tillrohrmann commented on pull request #17606:
URL: https://github.com/apache/flink/pull/17606#issuecomment-957309354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sjwiesman commented on a change in pull request #478:
URL: https://github.com/apache/flink-web/pull/478#discussion_r740478608
##
File path: _posts/2021-11-03-flink-backward.md
##
@@ -0,0 +1,79 @@
+---
+layout: post
+title: "Flink Backward - The Apache Flink Retrospective"
flinkbot edited a comment on pull request #17640:
URL: https://github.com/apache/flink/pull/17640#issuecomment-957264269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dawidwys commented on a change in pull request #17541:
URL: https://github.com/apache/flink/pull/17541#discussion_r741117079
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to
flinkbot commented on pull request #17638:
URL: https://github.com/apache/flink/pull/17638#issuecomment-957219037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
beyond1920 commented on a change in pull request #17632:
URL: https://github.com/apache/flink/pull/17632#discussion_r740955153
##
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalWindowDeduplicate.scala
flinkbot edited a comment on pull request #17627:
URL: https://github.com/apache/flink/pull/17627#issuecomment-956258384
## CI report:
* 258555b03cdc7d8366291d5a131bc0afad6d3ee8 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zentol merged pull request #17631:
URL: https://github.com/apache/flink/pull/17631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AHeise commented on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-957933362
Btw it's hard to see if all comments of @fapaul have been addressed. Please
always respond to feedback, so it's easier to follow what has been improved
already. I use reaction
MartijnVisser commented on a change in pull request #17626:
URL: https://github.com/apache/flink/pull/17626#discussion_r741022824
##
File path: flink-table/flink-table-planner/pom.xml
##
@@ -356,6 +356,7 @@ under the License.
flinkbot edited a comment on pull request #17426:
URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
flinkbot edited a comment on pull request #17626:
URL: https://github.com/apache/flink/pull/17626#issuecomment-956209711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
MartijnVisser commented on pull request #17635:
URL: https://github.com/apache/flink/pull/17635#issuecomment-956752220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
syhily edited a comment on pull request #17643:
URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355
I don't think this fixed the data loss issue. Pulsar [internally
flinkbot edited a comment on pull request #17606:
URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065
## CI report:
* a9ce74387e3be7c9fa8e4309886c9b86825c3aea Azure:
flinkbot edited a comment on pull request #17345:
URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717
## CI report:
* c0bcfc327fad7eb71a6bd2272cd0a667d53ec475 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
dannycranmer commented on a change in pull request #17345:
URL: https://github.com/apache/flink/pull/17345#discussion_r741246342
##
File path: flink-connectors/flink-connector-aws/pom.xml
##
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
flinkbot edited a comment on pull request #17525:
URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227
## CI report:
* a76716059642a21592769cb39242be82d01091a5 Azure:
[
https://issues.apache.org/jira/browse/FLINK-24733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martijn Visser reassigned FLINK-24733:
--
Assignee: Yufan Sheng
> Data loss in pulsar source when using shared mode
>
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
flinkbot edited a comment on pull request #17525:
URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227
## CI report:
* a76716059642a21592769cb39242be82d01091a5 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
AHeise commented on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-957933362
Btw it's hard to see if all comments of @fapaul have been addressed. Please
always respond to feedback, so it's easier to follow what has been improved
already. I use reaction
AHeise commented on a change in pull request #17538:
URL: https://github.com/apache/flink/pull/17538#discussion_r740484286
##
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java
flinkbot edited a comment on pull request #17626:
URL: https://github.com/apache/flink/pull/17626#issuecomment-956209711
## CI report:
* 7bd72621e104983e4b338723b95527dc5df31941 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
flinkbot edited a comment on pull request #17644:
URL: https://github.com/apache/flink/pull/17644#issuecomment-957525049
## CI report:
* d8769c88e83f53222375497108e64134e1eef664 Azure:
flinkbot edited a comment on pull request #17635:
URL: https://github.com/apache/flink/pull/17635#issuecomment-956476981
## CI report:
* 5bca0bc1a4495c80ca7651acf949133da8bc2d69 Azure:
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
[
https://issues.apache.org/jira/browse/FLINK-24733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437460#comment-17437460
]
Yufan Sheng commented on FLINK-24733:
-
[~shengzhi] The fix didn't touch the core of data loss. We
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
syhily edited a comment on pull request #17643:
URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355
I don't think this fixed the data loss issue. Pulsar [internally
flinkbot edited a comment on pull request #17580:
URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532
## CI report:
* 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:
301 - 400 of 751 matches
Mail list logo