[GitHub] [flink] syhily commented on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
syhily commented on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355 I don't think this fixed the data loss issue. Pulsar internally wrap the CompletableFuture in `receiveAsync()` with a `CompletableFutureCancellationHandler`. The pending

[GitHub] [flink] flinkbot edited a comment on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 ## CI report: * 31f4cbdab0cc2c8701c2ee049491a0b0b45a9167 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
fapaul commented on a change in pull request #17580: URL: https://github.com/apache/flink/pull/17580#discussion_r741254958 ## File path: flink-clients/src/test/resources/META-INF/services/org.apache.flink.core.fs.FileSystemFactory ## @@ -0,0 +1,16 @@ +# Licensed to the Apache

[GitHub] [flink] flinkbot commented on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957894409 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 ## CI report: * 31f4cbdab0cc2c8701c2ee049491a0b0b45a9167 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17647: URL: https://github.com/apache/flink/pull/17647#issuecomment-957882505 ## CI report: * 6c39b7b30fb6a4f81fac803ccf7969f67a699da9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[GitHub] [flink] hililiwei opened a new pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
hililiwei opened a new pull request #17648: URL: https://github.com/apache/flink/pull/17648 #17106 (review) backport to release 1.13 @AHeise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot commented on pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17647: URL: https://github.com/apache/flink/pull/17647#issuecomment-957882505 ## CI report: * 6c39b7b30fb6a4f81fac803ccf7969f67a699da9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17647: URL: https://github.com/apache/flink/pull/17647#issuecomment-957881822 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 ## CI report: * 501c93d6fb01c5a757d5ee0cf5d77705faa80727 Azure:

[jira] [Updated] (FLINK-24729) Support IterationBody with mixed per-round and all-round operators

2021-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24729: --- Labels: pull-request-available (was: ) > Support IterationBody with mixed per-round and

[GitHub] [flink-ml] gaoyunhaii opened a new pull request #23: [FLINK-24729][iteration] Support iteration with mixed operator life-cycle

2021-11-02 Thread GitBox
gaoyunhaii opened a new pull request #23: URL: https://github.com/apache/flink-ml/pull/23 This PR supports the `forEachRound` method inside the iteration. With this method, users then could create iteration body with mixed operator life-cycle. -- This is an automated message from the

[GitHub] [flink] hililiwei opened a new pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
hililiwei opened a new pull request #17647: URL: https://github.com/apache/flink/pull/17647 https://github.com/apache/flink/pull/17106#pullrequestreview-793911533 backport to release 1.14 @AHeise -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * ba618e645cced0c40c270ffdf9a289f786de82c4 Azure:

[GitHub] [flink] zentol commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957870305 > You could enable debug logs and check whether we send heartbeat requests after the TM died. We do still send requests, but Akka does not report the TM as being

[GitHub] [flink] flinkbot edited a comment on pull request #17637: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17637: URL: https://github.com/apache/flink/pull/17637#issuecomment-957122792 ## CI report: * 44b724b179b0e30969f5bb8eab5e8633c4938928 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17646: [FLINK-24740] Update testcontainers dependency to the latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17646: URL: https://github.com/apache/flink/pull/17646#issuecomment-957837700 ## CI report: * 45ffcecaa3a2beddb7ee68003ad2717176fc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957416596 ## CI report: * cf441ef1184f44a76f08dcc304de6f1da8f0fd55 Azure:

[jira] [Commented] (FLINK-24741) Deprecate FileRecordFormat, use StreamFormat instead

2021-11-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437429#comment-17437429 ] Jing Ge commented on FLINK-24741: - [~arvid] I'd like to work on this task. Many thanks. > Deprecate

[jira] [Commented] (FLINK-24721) Update the based on the Maven official indication

2021-11-02 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437430#comment-17437430 ] Jing Ge commented on FLINK-24721: - [~arvid] I'd like to work on this task. Many thanks. > Update the

[jira] [Created] (FLINK-24741) Deprecate FileRecordFormat, use StreamFormat instead

2021-11-02 Thread Jing Ge (Jira)
Jing Ge created FLINK-24741: --- Summary: Deprecate FileRecordFormat, use StreamFormat instead Key: FLINK-24741 URL: https://issues.apache.org/jira/browse/FLINK-24741 Project: Flink Issue Type:

[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='

2021-11-02 Thread GitBox
hililiwei commented on pull request #17613: URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301 @MartijnVisser added two test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #17646: [FLINK-24740] Update testcontainers dependency to the latest version

2021-11-02 Thread GitBox
flinkbot commented on pull request #17646: URL: https://github.com/apache/flink/pull/17646#issuecomment-957837700 ## CI report: * 45ffcecaa3a2beddb7ee68003ad2717176fc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17645: URL: https://github.com/apache/flink/pull/17645#issuecomment-957822962 ## CI report: * 2525e7c4029e53a2dbb46cc55bdcdfdce60b69f9 Azure:

[GitHub] [flink] flinkbot commented on pull request #17646: [FLINK-24740] Update testcontainers dependency to the latest version

2021-11-02 Thread GitBox
flinkbot commented on pull request #17646: URL: https://github.com/apache/flink/pull/17646#issuecomment-957835052 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24740) Update testcontainers dependency to the latest version

2021-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24740: --- Labels: pull-request-available (was: ) > Update testcontainers dependency to the latest

[GitHub] [flink] MartijnVisser opened a new pull request #17646: [FLINK-24740] Update testcontainers dependency to the latest version

2021-11-02 Thread GitBox
MartijnVisser opened a new pull request #17646: URL: https://github.com/apache/flink/pull/17646 ## What is the purpose of the change * Update testcontainers dependency to the latest version for various improvements ## Brief change log * Updated POM ## Verifying

[GitHub] [flink] flinkbot commented on pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-02 Thread GitBox
flinkbot commented on pull request #17645: URL: https://github.com/apache/flink/pull/17645#issuecomment-957822962 ## CI report: * 2525e7c4029e53a2dbb46cc55bdcdfdce60b69f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[jira] [Created] (FLINK-24740) Update testcontainers dependency to the latest version

2021-11-02 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-24740: -- Summary: Update testcontainers dependency to the latest version Key: FLINK-24740 URL: https://issues.apache.org/jira/browse/FLINK-24740 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-02 Thread GitBox
flinkbot commented on pull request #17645: URL: https://github.com/apache/flink/pull/17645#issuecomment-957817663 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24667) Channel state writer would fail the task directly if meeting exception previously

2021-11-02 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-24667: -- Fix Version/s: 1.13.4 1.14.1 1.15.0 > Channel

[GitHub] [flink] rkhachatryan opened a new pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-02 Thread GitBox
rkhachatryan opened a new pull request #17645: URL: https://github.com/apache/flink/pull/17645 ## What is the purpose of the change Fix error handling in `ChannelStateCheckpointWriter`. The change is split into 4 commits to ease reviewing; before merging they should be

[jira] [Updated] (FLINK-24667) Channel state writer would fail the task directly if meeting exception previously

2021-11-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24667: --- Labels: pull-request-available (was: ) > Channel state writer would fail the task directly

[GitHub] [flink] flinkbot edited a comment on pull request #17607: [FLINK-24543][runtime] Avoid possible inconsistencies of ZookeeperSta…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17607: URL: https://github.com/apache/flink/pull/17607#issuecomment-954762085 ## CI report: * 497cb1c9352a1097ca8ee32d2bf68afba094e263 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-948765818 ## CI report: * f43d31bf75a76df316a986e2afab6fcc550c9f80 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-904541061 ## CI report: * a304d4ca7d52177b97eb40581b966d2f32820cbf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-948765818 ## CI report: * f43d31bf75a76df316a986e2afab6fcc550c9f80 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-904541061 ## CI report: * a304d4ca7d52177b97eb40581b966d2f32820cbf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * ea2e8c89180d033c8fa6ce8d8885a009750539de Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[jira] [Updated] (FLINK-24739) State requirements for Flink's application mode in the documentation

2021-11-02 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-24739: -- Description: If I am not mistaken, then Flink won't ship jars when using the application

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[jira] [Created] (FLINK-24739) State requirements for Flink's application mode in the documentation

2021-11-02 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-24739: - Summary: State requirements for Flink's application mode in the documentation Key: FLINK-24739 URL: https://issues.apache.org/jira/browse/FLINK-24739 Project:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17632: URL: https://github.com/apache/flink/pull/17632#issuecomment-956326604 ## CI report: * 6d6de1e30a41f6bf218dae3e03615a222a6c42e3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
CrynetLogistics commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r741148450 ## File path: flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/streaming/connectors/kinesis/unified/KinesisDataStreamsSinkWriter.java

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
CrynetLogistics commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r741148173 ## File path: flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/streaming/connectors/kinesis/unified/KinesisDataStreamsSinkWriter.java

[jira] [Updated] (FLINK-24722) Fix the issues with supporting keyed stream

2021-11-02 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-24722: Summary: Fix the issues with supporting keyed stream (was: Only set keyContext for the normal records)

[GitHub] [flink] flinkbot edited a comment on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-948765818 ## CI report: * f43d31bf75a76df316a986e2afab6fcc550c9f80 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] akalash commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
akalash commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r741142294 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[GitHub] [flink] tillrohrmann commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957738541 The advantage of increasing the restart attempts instead of the delay is that the test will on average run faster. With the increased delay, the execution of the test will

[jira] [Commented] (FLINK-24733) Data loss in pulsar source when using shared mode

2021-11-02 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437403#comment-17437403 ] Yufan Sheng commented on FLINK-24733: - [~shengzhi] Tks for your fix. I'm digging into the Pulsar

[jira] [Closed] (FLINK-24723) Add ServicesResourceTransformer to the quickstart project

2021-11-02 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman closed FLINK-24723. Resolution: Fixed > Add ServicesResourceTransformer to the quickstart project >

[jira] [Commented] (FLINK-24723) Add ServicesResourceTransformer to the quickstart project

2021-11-02 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437400#comment-17437400 ] Seth Wiesman commented on FLINK-24723: -- fixed in master: ea484357b222d850f8df4d7b6ae8dacb110b19b7

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-948765818 ## CI report: * 9b84d08ded8b9bb26c497dd0b541a4c2c01bde4c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[GitHub] [flink] sjwiesman closed pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
sjwiesman closed pull request #17633: URL: https://github.com/apache/flink/pull/17633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] dawidwys commented on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-957723927 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-948765818 ## CI report: * 9b84d08ded8b9bb26c497dd0b541a4c2c01bde4c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[GitHub] [flink] dawidwys commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r741127153 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #17642: [hotfix][table-common] Add `DataType#excludeFields`

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17642: URL: https://github.com/apache/flink/pull/17642#issuecomment-957339647 ## CI report: * c85a0c22da8d2e8e9e28cda3a182c5ac16a220be Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[jira] [Commented] (FLINK-24401) TM cannot exit after Metaspace OOM

2021-11-02 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17437392#comment-17437392 ] Till Rohrmann commented on FLINK-24401: --- I think the assumption was that a meta space OOM mainly

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for window-t

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17509: URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594 ## CI report: * 47e6223322b4e409c54080919c7954507f27fea1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * e15212e71e63b6c4927a85057e7e036fd49bce30 Azure:

[GitHub] [flink] tillrohrmann edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957696510 Maybe. You could enable debug logs and check whether we send heartbeat requests after the TM died. If these requests are not failed, then it is most likely because

[GitHub] [flink] dawidwys commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r741117079 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] tillrohrmann commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957696510 Maybe. You could enable debug logs and check whether we send heartbeat requests after the TM died. If these requests are not failed, then it is most likely because Akka

[jira] [Closed] (FLINK-24167) Split HeartbeatTarget to HeartbeatReceiver and HeartbeatSender

2021-11-02 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-24167. - Fix Version/s: 1.15.0 Resolution: Fixed Fixed via

[GitHub] [flink] tillrohrmann closed pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…

2021-11-02 Thread GitBox
tillrohrmann closed pull request #17426: URL: https://github.com/apache/flink/pull/17426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 ## CI report: * ade8b47510aaf11753d52b1283588366107245a0 Azure:

[GitHub] [flink] zentol commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957678218 > This has never been a problem though. Isn't that because previously we still waited for the heartbeat to time out (10 seconds in this test)? -- This is an automated

[GitHub] [flink] tillrohrmann closed pull request #17428: [hotfix]Refactor the registerJobManager to registerJobMaster

2021-11-02 Thread GitBox
tillrohrmann closed pull request #17428: URL: https://github.com/apache/flink/pull/17428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
CrynetLogistics commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r741099316 ## File path: flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/streaming/connectors/kinesis/unified/util/AWSConfigConstants.java

[GitHub] [flink] akalash commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
akalash commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r739087076 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] tillrohrmann edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957663355 I don't know exactly how fast Akka can detect it. I would assume that this can happen quite quickly once the TCP connection is terminated. This has never been a

[GitHub] [flink] tillrohrmann commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957663355 I don't know exactly how fast Akka can detect it. I would assume that this can happen quite quickly once the TCP connection is terminated. -- This is an automated

[jira] [Closed] (FLINK-24699) Move scalastyle execution to validation phase

2021-11-02 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-24699. Resolution: Fixed master: 210711c4c1e9e324b9a897fd9411e50162754f6d > Move scalastyle

[GitHub] [flink] zentol merged pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase

2021-11-02 Thread GitBox
zentol merged pull request #17602: URL: https://github.com/apache/flink/pull/17602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] tillrohrmann commented on a change in pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #17606: URL: https://github.com/apache/flink/pull/17606#discussion_r741094093 ## File path: flink-tests/src/test/java/org/apache/flink/test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java ## @@ -67,7 +67,7 @@

[jira] [Created] (FLINK-24738) Fail during announcing buffer size to released local channel

2021-11-02 Thread Anton Kalashnikov (Jira)
Anton Kalashnikov created FLINK-24738: - Summary: Fail during announcing buffer size to released local channel Key: FLINK-24738 URL: https://issues.apache.org/jira/browse/FLINK-24738 Project:

[GitHub] [flink] zentol commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957635293 So yeah, increasing the restart delay to ~5 seconds would probably do the trick. -- This is an automated message from the Apache Git Service. To respond to the message, please

<    1   2   3   4   5   6   7   8   >