[jira] [Created] (FLINK-33592) The return type of the function is void,not convenient to use

2023-11-17 Thread ZhangTao (Jira)
ZhangTao created FLINK-33592: Summary: The return type of the function is void,not convenient to use Key: FLINK-33592 URL: https://issues.apache.org/jira/browse/FLINK-33592 Project: Flink Issue

[jira] [Updated] (FLINK-33592) The return type of the function is void,not convenient to use

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33592: --- Labels: pull-request-available (was: ) > The return type of the function is void,not

[PR] [FLINK-33592]Modified the return type of the method, make it more convenient to use. [flink]

2023-11-17 Thread via GitHub
Tao-Zhang9876 opened a new pull request, #23750: URL: https://github.com/apache/flink/pull/23750 ## What is the purpose of the change Modify the method return type from void to StreamExecutionEnvironment. ## Brief change log - Modify the return type.

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException in DescriptiveStatisticsHistogramStatistics [flink]

2023-11-17 Thread via GitHub
qinping416 commented on PR #23749: URL: https://github.com/apache/flink/pull/23749#issuecomment-1817400787 This change improves the robustness of the system -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33592]Modified the return type of the method, make it more convenient to use. [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23750: URL: https://github.com/apache/flink/pull/23750#issuecomment-1817420288 ## CI report: * 4d1c18402ded7421609ac8dad28f5978082d067b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Add flink-shaded 16.2 release [flink-web]

2023-11-17 Thread via GitHub
reswqa merged PR #697: URL: https://github.com/apache/flink-web/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-32006) AsyncWaitOperatorTest.testProcessingTimeWithTimeoutFunctionOrderedWithRetry times out on Azure

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787083#comment-17787083 ] Sergey Nuyanzin commented on FLINK-32006: -

[jira] [Updated] (FLINK-33582) Update flink-shaded version

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33582: --- Labels: pull-request-available (was: ) > Update flink-shaded version >

Re: [PR] Add flink-shaded 16.2 release [flink-web]

2023-11-17 Thread via GitHub
reswqa commented on PR #697: URL: https://github.com/apache/flink-web/pull/697#issuecomment-1815943688 Thanks all for the review, merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FLINK-33583) Support state ttl hint for join

2023-11-17 Thread xuyang (Jira)
xuyang created FLINK-33583: -- Summary: Support state ttl hint for join Key: FLINK-33583 URL: https://issues.apache.org/jira/browse/FLINK-33583 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-13230) Retry acknowledgement calls

2023-11-17 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787097#comment-17787097 ] Ryan Skraba commented on FLINK-13230: - The changes proposed in this PR have been applied to the

[PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-17 Thread via GitHub
MartijnVisser opened a new pull request, #23740: URL: https://github.com/apache/flink/pull/23740 ## What is the purpose of the change * Update Hadoop Filesystem dependencies to 3.3.6 ## Brief change log * Updated POM and NOTICE files ## Verifying this change

[jira] [Updated] (FLINK-33584) Update Hadoop Filesystems to 3.3.6

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33584: --- Labels: pull-request-available (was: ) > Update Hadoop Filesystems to 3.3.6 >

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
KarmaGYZ commented on code in PR #23706: URL: https://github.com/apache/flink/pull/23706#discussion_r1396978365 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -197,6 +201,13 @@ public void

[jira] [Updated] (FLINK-33584) Update Hadoop Filesystems to 3.3.6

2023-11-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33584: --- Component/s: FileSystems > Update Hadoop Filesystems to 3.3.6 >

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
KarmaGYZ commented on code in PR #23706: URL: https://github.com/apache/flink/pull/23706#discussion_r1396983394 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -425,6 +436,26 @@ private Path getResourceLocalPath(Path

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
KarmaGYZ merged PR #23706: URL: https://github.com/apache/flink/pull/23706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-33585) Upgrade Zookeeper to 3.7.1

2023-11-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33585: -- Assignee: Martijn Visser > Upgrade Zookeeper to 3.7.1 > -- >

Re: [PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23741: URL: https://github.com/apache/flink/pull/23741#issuecomment-1816065684 ## CI report: * 7f773d4ed30a91d6877cd1e37024d7c5b9a4eb25 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Refactor grammar on flink-architecture markdown [flink-web]

2023-11-17 Thread via GitHub
Limookiplimo closed pull request #663: Refactor grammar on flink-architecture markdown URL: https://github.com/apache/flink-web/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update version to 16.2 [flink-shaded]

2023-11-17 Thread via GitHub
reswqa commented on PR #128: URL: https://github.com/apache/flink-shaded/pull/128#issuecomment-1815936138 Thanks @TanYuxin-tyx for the quick review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-17 Thread via GitHub
TanYuxin-tyx opened a new pull request, #23739: URL: https://github.com/apache/flink/pull/23739 ## What is the purpose of the change *After flink-shaded 16.2 is released, we should update the flink-shaded version for Flink 1.17 to resolve the issue thoroughly. Note the

Re: [PR] [FLINK-33411] Implement type inference for window properties functions [flink]

2023-11-17 Thread via GitHub
dawidwys closed pull request #23735: [FLINK-33411] Implement type inference for window properties functions URL: https://github.com/apache/flink/pull/23735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23740: URL: https://github.com/apache/flink/pull/23740#issuecomment-1816040944 ## CI report: * 843f50b982f61f84b92bead8912e35ac4b837eeb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33542] Update tests to JUnit5 [flink-connector-hbase]

2023-11-17 Thread via GitHub
MartijnVisser merged PR #32: URL: https://github.com/apache/flink-connector-hbase/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33582) Update flink-shaded version

2023-11-17 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-33582: -- Description: This is a follow-up task for https://issues.apache.org/jira/browse/FLINK-33417. After

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
FangYongs commented on code in PR #23706: URL: https://github.com/apache/flink/pull/23706#discussion_r1396844151 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -197,6 +201,13 @@ public void

[PR] Update version to 16.2 [flink-shaded]

2023-11-17 Thread via GitHub
reswqa opened a new pull request, #128: URL: https://github.com/apache/flink-shaded/pull/128 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-17 Thread via GitHub
dawidwys merged PR #23713: URL: https://github.com/apache/flink/pull/23713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-33410) Implement type inference for Over function

2023-11-17 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33410. Resolution: Fixed Implemented in 1986cfe1cb3606fc00fd13735f7ba901b806f56f > Implement

[jira] [Closed] (FLINK-33411) Implement type inference for window properties functions

2023-11-17 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33411. Resolution: Fixed Implemented in 873bd130c838b4b56cf9af8fdb2e0390ddbe6e4a > Implement

[jira] [Closed] (FLINK-32299) Upload python jar when sql contains python udf jar

2023-11-17 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo closed FLINK-32299. -- Resolution: Fixed > Upload python jar when sql contains python udf jar >

[jira] [Commented] (FLINK-32299) Upload python jar when sql contains python udf jar

2023-11-17 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787106#comment-17787106 ] Yangze Guo commented on FLINK-32299: master: febbbf3c09c1670faed4dbf1c46a1d1719d8fa8f > Upload

[jira] [Created] (FLINK-33585) Upgrade Zookeeper to 3.7.1

2023-11-17 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33585: -- Summary: Upgrade Zookeeper to 3.7.1 Key: FLINK-33585 URL: https://issues.apache.org/jira/browse/FLINK-33585 Project: Flink Issue Type: Technical Debt

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-17 Thread via GitHub
TanYuxin-tyx commented on PR #23739: URL: https://github.com/apache/flink/pull/23739#issuecomment-1816071118 @MartijnVisser Yeah, thank you for reminding me. I will trigger CI again after the landing is confirmed. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Assigned] (FLINK-33542) Update HBase connector tests to JUnit5

2023-11-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33542: -- Assignee: Ferenc Csaky > Update HBase connector tests to JUnit5 >

[jira] [Closed] (FLINK-33542) Update HBase connector tests to JUnit5

2023-11-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33542. -- Fix Version/s: hbase-3.0.1 Resolution: Fixed Fixed in apache/flink-connector-hbase:

[jira] [Created] (FLINK-33582) Update flink-shaded version

2023-11-17 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33582: - Summary: Update flink-shaded version Key: FLINK-33582 URL: https://issues.apache.org/jira/browse/FLINK-33582 Project: Flink Issue Type: Bug Components:

[jira] [Assigned] (FLINK-33582) Update flink-shaded version

2023-11-17 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-33582: - Assignee: Yuxin Tan > Update flink-shaded version > --- > >

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
FangYongs commented on code in PR #23706: URL: https://github.com/apache/flink/pull/23706#discussion_r1396847241 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -425,6 +436,26 @@ private Path

Re: [PR] Update version to 16.2 [flink-shaded]

2023-11-17 Thread via GitHub
TanYuxin-tyx commented on PR #128: URL: https://github.com/apache/flink-shaded/pull/128#issuecomment-1815918639 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update version to 16.2 [flink-shaded]

2023-11-17 Thread via GitHub
reswqa merged PR #128: URL: https://github.com/apache/flink-shaded/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23739: URL: https://github.com/apache/flink/pull/23739#issuecomment-1815949662 ## CI report: * dbeff2c00c32d2c4d5005aebc25c96f43a4b25d7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
FangYongs commented on PR #23706: URL: https://github.com/apache/flink/pull/23706#issuecomment-1816048826 Thanks @KarmaGYZ, LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-17 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787123#comment-17787123 ] david radley commented on FLINK-33365: -- [~libenchao]  fyi this fix asis appears to have regressed

[jira] [Created] (FLINK-33584) Update Hadoop Filesystems to 3.3.6

2023-11-17 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33584: -- Summary: Update Hadoop Filesystems to 3.3.6 Key: FLINK-33584 URL: https://issues.apache.org/jira/browse/FLINK-33584 Project: Flink Issue Type: Technical

Re: [PR] [FLINK-32299][gateway] Upload python jar when sql contains python udf… [flink]

2023-11-17 Thread via GitHub
KarmaGYZ commented on code in PR #23706: URL: https://github.com/apache/flink/pull/23706#discussion_r1396983394 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/resource/ResourceManager.java: ## @@ -425,6 +436,26 @@ private Path getResourceLocalPath(Path

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-17 Thread via GitHub
MartijnVisser commented on PR #23739: URL: https://github.com/apache/flink/pull/23739#issuecomment-1816055211 @TanYuxin-tyx Most likely you're too quickly with this PR, the released artifacts probably haven't landed yet on Maven Central -- This is an automated message from the Apache Git

[PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2023-11-17 Thread via GitHub
MartijnVisser opened a new pull request, #23741: URL: https://github.com/apache/flink/pull/23741 ## What is the purpose of the change * Update Zookeeper to 3.7.2 ## Brief change log * Updated POM and testcontainer setup ## Verifying this change This change

Re: [PR] [FLINK-33568] Fix NullpointerException in SinkV2MetricsITCase [flink]

2023-11-17 Thread via GitHub
pvary commented on code in PR #23737: URL: https://github.com/apache/flink/pull/23737#discussion_r1397044749 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2MetricsITCase.java: ## @@ -228,32 +228,54 @@ private void assertSinkCommitterMetrics(

Re: [PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-17 Thread via GitHub
snuyanzin commented on PR #23685: URL: https://github.com/apache/flink/pull/23685#issuecomment-1816207453 also cc @libenchao since this idea came from [CALCITE-5117](https://issues.apache.org/jira/browse/CALCITE-5117) -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-33578) Remove scala-2.12 system variable

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787166#comment-17787166 ] Matthias Pohl commented on FLINK-33578: --- No backport is necessary because omitting the system

[jira] [Resolved] (FLINK-33578) Remove scala-2.12 system variable

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33578. --- Fix Version/s: 1.19.0 Resolution: Fixed master:

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1816445044 ## CI report: * c004ce1848a0623f3fbd12d63734e89c386db01e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-17 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787123#comment-17787123 ] david radley edited comment on FLINK-33365 at 11/17/23 10:53 AM: -

[jira] [Commented] (FLINK-31332) Limit the use of ExecutionConfig on JdbcOutputFormat

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787140#comment-17787140 ] Sergey Nuyanzin commented on FLINK-31332: - Merged as

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-17 Thread via GitHub
snuyanzin commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1816246436 can we also add a test to `org.apache.flink.connector.jdbc.table.JdbcTablePlanTest` to be sure that the exeution plan is expected? -- This is an automated message from

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink

[jira] [Commented] (FLINK-33546) Implement type inference for order(asc/desc) function

2023-11-17 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787181#comment-17787181 ] Dawid Wysakowicz commented on FLINK-33546: -- [~jackylau] We can not cover it 100% in the API.

[jira] [Commented] (FLINK-28383) HDFS source: Trying to access closed classloader

2023-11-17 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787186#comment-17787186 ] gabrywu commented on FLINK-28383: - No, actually, it's caused by Configuration.CACHE_CLASSES > HDFS

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397338085 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: exactly, as this should be the

[jira] [Commented] (FLINK-33550) "DataSet allround end-to-end test" failed due to certificate error

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787237#comment-17787237 ] Matthias Pohl commented on FLINK-33550: --- https://www.misterpki.com/java-keystore-pkcs12-legacy/ >

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397421543 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397421543 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1397104072 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,21 +96,35 @@ public

[jira] [Commented] (FLINK-33546) Implement type inference for order(asc/desc) function

2023-11-17 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787136#comment-17787136 ] Jacky Lau commented on FLINK-33546: --- hi [~dwysakowicz]  the input any may not cover this case if the

Re: [PR] [FLINK-33568] Fix NullpointerException in SinkV2MetricsITCase [flink]

2023-11-17 Thread via GitHub
XComp commented on code in PR #23737: URL: https://github.com/apache/flink/pull/23737#discussion_r1397153112 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2MetricsITCase.java: ## @@ -217,43 +215,41 @@ private void assertSinkMetrics(

[jira] (FLINK-28383) HDFS source: Trying to access closed classloader

2023-11-17 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28383 ] gabrywu deleted comment on FLINK-28383: - was (Author: gabry.wu): No, actually, it's caused by Configuration.CACHE_CLASSES > HDFS source: Trying to access closed classloader >

[jira] [Created] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread Robin Moffatt (Jira)
Robin Moffatt created FLINK-33587: - Summary: Tidy up docs around JDBC Key: FLINK-33587 URL: https://issues.apache.org/jira/browse/FLINK-33587 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-17 Thread via GitHub
Shreya11 commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1816521711 @snuyanzin I want to work on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397395729 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java: ## @@ -99,7 +99,11 @@ * @see JdbcParameterValuesProvider *

Re: [PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2023-11-17 Thread via GitHub
Shreya11 commented on PR #23741: URL: https://github.com/apache/flink/pull/23741#issuecomment-1816524692 @MartijnVisser want to work on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33578][ci] Removes scala-2.12 system property [flink]

2023-11-17 Thread via GitHub
XComp merged PR #23738: URL: https://github.com/apache/flink/pull/23738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink

[jira] [Assigned] (FLINK-33006) Add e2e test for Kubernetes Operator HA

2023-11-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33006: -- Assignee: Zhenqiu Huang > Add e2e test for Kubernetes Operator HA >

[jira] [Assigned] (FLINK-30529) Use simple cancel for savepoint upgrades on failing jobs

2023-11-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30529: -- Assignee: Zhenqiu Huang > Use simple cancel for savepoint upgrades on failing jobs >

[jira] [Created] (FLINK-33586) Add GHA support in release-1.17 branch

2023-11-17 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33586: - Summary: Add GHA support in release-1.17 branch Key: FLINK-33586 URL: https://issues.apache.org/jira/browse/FLINK-33586 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-33587: -- Assignee: Robin Moffatt > Tidy up docs around JDBC > > >

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397218900 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java: ## @@ -99,7 +99,11 @@ * @see JdbcParameterValuesProvider *

[PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-17 Thread via GitHub
snuyanzin opened a new pull request, #23742: URL: https://github.com/apache/flink/pull/23742 ## What is the purpose of the change The PR is to bump jackson to 2.15.3 ## Brief change log pom and NOTICE files ## Verifying this change This change is a

[jira] [Updated] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread Robin Moffatt (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Moffatt updated FLINK-33587: -- Description: The documentation around using JDBC with Flink is, IMHO, a bit disjointed and

Re: [PR] [FLINK-33568] Fix NullpointerException in SinkV2MetricsITCase [flink]

2023-11-17 Thread via GitHub
pvary commented on code in PR #23737: URL: https://github.com/apache/flink/pull/23737#discussion_r1397045161 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2MetricsITCase.java: ## @@ -228,32 +228,54 @@ private void assertSinkCommitterMetrics(

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-17 Thread via GitHub
echauchot commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1394495515 ## module-with-no-tests/src/main/java/org/apache/flink/connector/testing/SomeClass2.java: ## @@ -19,4 +19,7 @@ package

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-17 Thread via GitHub
echauchot commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1394495515 ## module-with-no-tests/src/main/java/org/apache/flink/connector/testing/SomeClass2.java: ## @@ -19,4 +19,7 @@ package

Re: [PR] [FLINK-31332] Limit the use of ExecutionConfig on JdbcOutputFormat [flink-connector-jdbc]

2023-11-17 Thread via GitHub
snuyanzin commented on PR #73: URL: https://github.com/apache/flink-connector-jdbc/pull/73#issuecomment-1816180988 sorry for the delay, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (FLINK-31332) Limit the use of ExecutionConfig on JdbcOutputFormat

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-31332. - Fix Version/s: jdbc-3.2.0 Resolution: Fixed > Limit the use of ExecutionConfig

[jira] [Assigned] (FLINK-31332) Limit the use of ExecutionConfig on JdbcOutputFormat

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-31332: --- Assignee: João Boto > Limit the use of ExecutionConfig on JdbcOutputFormat >

Re: [PR] [FLINK-31332] Limit the use of ExecutionConfig on JdbcOutputFormat [flink-connector-jdbc]

2023-11-17 Thread via GitHub
snuyanzin merged PR #73: URL: https://github.com/apache/flink-connector-jdbc/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-30703) PulsarOrderedPartitionSplitReaderTest>PulsarPartitionSplitReaderTestBase.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition fails

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787157#comment-17787157 ] Matthias Pohl commented on FLINK-30703: --- 1.16:

[jira] [Commented] (FLINK-32523) NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted fails with timeout on AZP

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787156#comment-17787156 ] Matthias Pohl commented on FLINK-32523: --- 1.16:

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787161#comment-17787161 ] Matthias Pohl commented on FLINK-33531: ---

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-17 Thread via GitHub
TanYuxin-tyx commented on PR #23739: URL: https://github.com/apache/flink/pull/23739#issuecomment-1816274599 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33568) SinkV2MetricsITCase.testCommitterMetrics fails with NullPointerException

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787160#comment-17787160 ] Matthias Pohl commented on FLINK-33568: ---

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
snuyanzin commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397216656 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: the minimum supported version

Re: [PR] [FLINK-33501][ci] Makes use of Maven wrapper [flink]

2023-11-17 Thread via GitHub
XComp commented on PR #23689: URL: https://github.com/apache/flink/pull/23689#issuecomment-1816379461 @zentol do you have any objections to that change? That would also enable us to remove Maven from the Docker ci image. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-17 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787224#comment-17787224 ] Wencong Liu commented on FLINK-33502: - Thank you for your reminder [~mapohl] . I would like to ask

Re: [PR] [FLINK-30960] Fix a corner case oom error [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #77: URL: https://github.com/apache/flink-connector-jdbc/pull/77#discussion_r1397462056 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java: ## @@ -153,6 +153,16 @@ public void open(int

[jira] [Commented] (FLINK-33462) Sort out the document page about the new Jdbc source.

2023-11-17 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787258#comment-17787258 ] david radley commented on FLINK-33462: -- I am curious what we intend to document here. the main

Re: [PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23743: URL: https://github.com/apache/flink/pull/23743#issuecomment-1816772920 ## CI report: * 940465d9294f4cbc4e64b06610bfe7d47a6a1ee7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >