Re: [PR] [FLINK-33545][Connectors/Kafka] KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching [flink-connector-kafka]

2024-01-18 Thread via GitHub
hhktseng commented on PR #70: URL: https://github.com/apache/flink-connector-kafka/pull/70#issuecomment-1899929011 > @hhktseng Can you rebase your PR? @MartijnVisser can you point me to which commit to rebase onto? thanks -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34128] [bugfix] Some jdbc objects cannot be obtained properly in oracle jdbc,Specify the required type explicitly [flink-connector-jdbc]

2024-01-18 Thread via GitHub
BlackPigHe commented on PR #91: URL: https://github.com/apache/flink-connector-jdbc/pull/91#issuecomment-1899926723 @snuyanzin Building this test case requires using jdbc to link to oracle, which can be difficult to simulate.Can I simulate with mock data. haha -- This is an

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-18 Thread via GitHub
libenchao commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1457562374 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/statement/FieldNamedPreparedStatementImpl.java: ## @@ -178,26 +178,42 @@ public void

Re: [PR] [FLINK-34167] add dependence to fit jdk21 [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin closed pull request #94: [FLINK-34167] add dependence to fit jdk21 URL: https://github.com/apache/flink-connector-jdbc/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34167] add dependence to fit jdk21 [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on PR #94: URL: https://github.com/apache/flink-connector-jdbc/pull/94#issuecomment-1899916737 Please do not create duplicate PR there is already existing one https://github.com/apache/flink-connector-jdbc/pull/93 -- This is an automated message from the Apache

[jira] [Created] (FLINK-34168) Refactor all callers that using the public Xxx getXxx(String key) and public void setXxx(String key, Xxx value)

2024-01-18 Thread Rui Fan (Jira)
Rui Fan created FLINK-34168: --- Summary: Refactor all callers that using the public Xxx getXxx(String key) and public void setXxx(String key, Xxx value) Key: FLINK-34168 URL:

[jira] [Commented] (FLINK-31691) Add MAP_FROM_ENTRIES supported in SQL & Table API

2024-01-18 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808519#comment-17808519 ] Jacky Lau commented on FLINK-31691: --- hi [~Sergey Nuyanzin] will you help to review this pr again

[jira] [Commented] (FLINK-34167) add dependence to fit jdk21

2024-01-18 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808518#comment-17808518 ] blackpighe commented on FLINK-34167: {code:java} Caused by: java.util.concurrent.ExecutionException:

[jira] [Updated] (FLINK-34164) [Benchmark] Compilation error since Jan. 16th

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34164: --- Labels: pull-request-available (was: ) > [Benchmark] Compilation error since Jan. 16th >

[jira] [Updated] (FLINK-34167) add dependence to fit jdk21

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34167: --- Labels: pull-request-available (was: ) > add dependence to fit jdk21 >

Re: [PR] [FLINK-33865][runtime] Adding an ITCase to ensure `exponential-delay.attempts-before-reset-backoff` works well [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #23942: URL: https://github.com/apache/flink/pull/23942#issuecomment-1899899509 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-34167) add dependence to fit jdk21

2024-01-18 Thread blackpighe (Jira)
blackpighe created FLINK-34167: -- Summary: add dependence to fit jdk21 Key: FLINK-34167 URL: https://issues.apache.org/jira/browse/FLINK-34167 Project: Flink Issue Type: Bug

Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on PR #93: URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899894520 @BlackPigHe i didn't get your comment have you seen the changes proposed within this PR? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33974] Implement the Sink transformation depending on the new SinkV2 interfaces [flink]

2024-01-18 Thread via GitHub
pvary commented on PR #24103: URL: https://github.com/apache/flink/pull/24103#issuecomment-1899886919 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-34015) Setting `execution.savepoint.ignore-unclaimed-state` does not take effect when passing this parameter by dynamic properties

2024-01-18 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808503#comment-17808503 ] Zakelly Lan commented on FLINK-34015: - {quote}Hi [~Zakelly], I'm reaching out to you as you've

[jira] [Updated] (FLINK-34164) [Benchmark] Compilation error since Jan. 16th

2024-01-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-34164: - Fix Version/s: 1.19.0 > [Benchmark] Compilation error since Jan. 16th >

[jira] [Updated] (FLINK-34164) [Benchmark] Compilation error since Jan. 16th

2024-01-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-34164: - Priority: Critical (was: Major) > [Benchmark] Compilation error since Jan. 16th >

[jira] [Created] (FLINK-34166) KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty

2024-01-18 Thread lincoln lee (Jira)
lincoln lee created FLINK-34166: --- Summary: KeyedLookupJoinWrapper incorrectly process delete message for inner join when previous lookup result is empty Key: FLINK-34166 URL:

[jira] [Updated] (FLINK-34165) It seems that Apache download link has been changed

2024-01-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-34165: Description: For example, the link

[jira] [Created] (FLINK-34165) It seems that Apache download link has been changed

2024-01-18 Thread Jing Ge (Jira)
Jing Ge created FLINK-34165: --- Summary: It seems that Apache download link has been changed Key: FLINK-34165 URL: https://issues.apache.org/jira/browse/FLINK-34165 Project: Flink Issue Type: Bug

Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]

2024-01-18 Thread via GitHub
BlackPigHe commented on PR #93: URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899867428 I also found this problem, and found that the work flow kept failing when mr -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]

2024-01-18 Thread via GitHub
BlackPigHe commented on PR #93: URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899866113 javax.activation activation 1.1.1 test

[jira] [Commented] (FLINK-34135) A number of ci failures with Access to the path '.../_work/_temp/containerHandlerInvoker.js' is denied.

2024-01-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808494#comment-17808494 ] Sergey Nuyanzin commented on FLINK-34135: - [~jingge] I'm not sure that this is working... it

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-18 Thread via GitHub
SinBex commented on PR #24087: URL: https://github.com/apache/flink/pull/24087#issuecomment-1899864181 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-34135) A number of ci failures with Access to the path '.../_work/_temp/containerHandlerInvoker.js' is denied.

2024-01-18 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808492#comment-17808492 ] Jing Ge commented on FLINK-34135: - CI works again, I will close this ticket. [~mapohl] [~Sergey

[jira] [Comment Edited] (FLINK-34156) Move Flink Calcite rules from Scala to Java

2024-01-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808489#comment-17808489 ] Sergey Nuyanzin edited comment on FLINK-34156 at 1/19/24 6:45 AM: --

[jira] [Commented] (FLINK-34156) Move Flink Calcite rules from Scala to Java

2024-01-18 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808489#comment-17808489 ] Sergey Nuyanzin commented on FLINK-34156: - Thanks for volunteering currently this is only MVP

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-18 Thread via GitHub
SinBex commented on PR #24087: URL: https://github.com/apache/flink/pull/24087#issuecomment-1899854481 @zhuzhurk Thanks for reviewing! I have fixed the problems you commented. PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-34164) [Benchmark] Compilation error since Jan. 16th

2024-01-18 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808486#comment-17808486 ] Junrui Li commented on FLINK-34164: --- Thanks [~Zakelly] for pointing out, I'll prepare a pr to fix this

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808485#comment-17808485 ] Gyula Fora commented on FLINK-34007: [~wangyang0918] the tests failed. The executor service (single

Re: [PR] [FLINK-33719][table] Cleanup the usage of deprecated StreamTableEnvir… [flink]

2024-01-18 Thread via GitHub
snuyanzin commented on PR #23898: URL: https://github.com/apache/flink/pull/23898#issuecomment-1899850866 @liuyongvs are you going to continuwe working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (FLINK-34164) [Benchmark] Compilation error since Jan. 16th

2024-01-18 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34164: --- Summary: [Benchmark] Compilation error since Jan. 16th Key: FLINK-34164 URL: https://issues.apache.org/jira/browse/FLINK-34164 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-34087][tests][JUnit5 Migration] Migarate to junit5 of flink-dist module [flink]

2024-01-18 Thread via GitHub
Jiabao-Sun commented on PR #24092: URL: https://github.com/apache/flink/pull/24092#issuecomment-1899841647 Hi @PatrickRen, could you help review it when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-34132][runtime] Correct the error message and doc of AdaptiveBatch only supports all edges being BLOCKING or HYBRID_FULL/HYBRID_SELECTIVE. [flink]

2024-01-18 Thread via GitHub
JunRuiLee commented on PR #24118: URL: https://github.com/apache/flink/pull/24118#issuecomment-1899838542 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33221][core][config] Add config options for administrator JVM options [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #24098: URL: https://github.com/apache/flink/pull/24098#issuecomment-1899825447 Hi @X-czh , https://github.com/apache/flink/pull/24089 is merged, please go ahead, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-34083) Deprecate string configuration keys and unused constants in ConfigConstants

2024-01-18 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808476#comment-17808476 ] Rui Fan commented on FLINK-34083: - Merged to master(1.19) via: 38f7b51d0cc45293dc71ad31607ecc685b11498f

[jira] [Resolved] (FLINK-34083) Deprecate string configuration keys and unused constants in ConfigConstants

2024-01-18 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34083. - Resolution: Fixed > Deprecate string configuration keys and unused constants in ConfigConstants >

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

2024-01-18 Thread via GitHub
1996fanrui merged PR #24089: URL: https://github.com/apache/flink/pull/24089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34109][connectors] FileSystem sink connector restore job from historical checkpoint bugfix [flink]

2024-01-18 Thread via GitHub
ParyshevSergey commented on PR #24113: URL: https://github.com/apache/flink/pull/24113#issuecomment-1899822873 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #24089: URL: https://github.com/apache/flink/pull/24089#issuecomment-1899822924 The CI is green, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-34080) Simplify the Configuration

2024-01-18 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808475#comment-17808475 ] Rui Fan commented on FLINK-34080: - Merged to master(1.19) via :

[jira] [Resolved] (FLINK-34080) Simplify the Configuration

2024-01-18 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34080. - Resolution: Fixed > Simplify the Configuration > -- > > Key:

Re: [PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]

2024-01-18 Thread via GitHub
masteryhx merged PR #23676: URL: https://github.com/apache/flink/pull/23676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34080][configuration] Simplify the Configuration [flink]

2024-01-18 Thread via GitHub
1996fanrui merged PR #24088: URL: https://github.com/apache/flink/pull/24088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34080][configuration] Simplify the Configuration [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #24088: URL: https://github.com/apache/flink/pull/24088#issuecomment-1899820154 Thanks @Sxnan for the reviewing! The CI is green, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-18 Thread via GitHub
justin-chen commented on code in PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1458380663 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java: ## @@ -55,4 +55,7 @@

Re: [PR] [hotfix] TestingTierConsumerAgent#peekNextBufferSubpartitionId shouldn't throw UnsupportedDataTypeException [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24147: URL: https://github.com/apache/flink/pull/24147#issuecomment-1899803891 ## CI report: * 11aee7489e6adb60aedebfdaee7dbb92c4f2b5af UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34148) Potential regression (Jan. 13): stringWrite with Java8

2024-01-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-34148: - Priority: Critical (was: Major) > Potential regression (Jan. 13): stringWrite with Java8 >

[jira] [Updated] (FLINK-34148) Potential regression (Jan. 13): stringWrite with Java8

2024-01-18 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-34148: - Fix Version/s: 1.19.0 > Potential regression (Jan. 13): stringWrite with Java8 >

[PR] [hotfix] TestingTierConsumerAgent#peekNextBufferSubpartitionId shouldn't throw UnsupportedDataTypeException [flink]

2024-01-18 Thread via GitHub
reswqa opened a new pull request, #24147: URL: https://github.com/apache/flink/pull/24147 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-18 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808457#comment-17808457 ] Zhu Zhu commented on FLINK-34105: - [~lsdy] Sounds good to me. Feel free to open a PR for it. > Akka

Re: [PR] [FLINK-34089] Verify that the subscribed topics match the assigned topics [flink-connector-kafka]

2024-01-18 Thread via GitHub
Tan-JiaLiang commented on PR #77: URL: https://github.com/apache/flink-connector-kafka/pull/77#issuecomment-1899714802 But now I am thinking more carefully, maybe just removing the topics from state that are not in the current subscription list is a better solution. @MartijnVisser

[jira] [Updated] (FLINK-34140) Rename WindowContext and TriggerContext in window

2024-01-18 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34140: --- Description: Currently, WindowContext and TriggerContext not only contains a series of get methods to

Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]

2024-01-18 Thread via GitHub
lindong28 commented on PR #24146: URL: https://github.com/apache/flink/pull/24146#issuecomment-1899635755 Thanks for the PR! LGTM. Will merge PR after the CI has passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Closed] (FLINK-33928) Should not throw exception while creating view with specify field names even if the query conflicts in field names

2024-01-18 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-33928. - Fix Version/s: 1.19.0 Resolution: Fixed > Should not throw exception while creating view

[jira] [Commented] (FLINK-33928) Should not throw exception while creating view with specify field names even if the query conflicts in field names

2024-01-18 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808447#comment-17808447 ] Shengkai Fang commented on FLINK-33928: --- Merged into master:

Re: [PR] [FLINK-34089] Verify that the subscribed topics match the assigned topics [flink-connector-kafka]

2024-01-18 Thread via GitHub
Tan-JiaLiang commented on PR #77: URL: https://github.com/apache/flink-connector-kafka/pull/77#issuecomment-1899618447 @MartijnVisser Suppose there is a flink job that subscribes two topics in a source at the same time, TopicA and TopicB. * Write some data to both TopicA and

Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24146: URL: https://github.com/apache/flink/pull/24146#issuecomment-1899616723 ## CI report: * a9ab0eaa9f38ddca0f6ba23c450ececb33acc7ee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33928][table-planner] Should not throw exception while creating view with specify field names [flink]

2024-01-18 Thread via GitHub
fsk119 merged PR #24096: URL: https://github.com/apache/flink/pull/24096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-18 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808441#comment-17808441 ] Yang Wang commented on FLINK-34007: --- I also remember that the fabric8 kubernetes-client community has

[jira] [Commented] (FLINK-33950) Update max aggregate functions to new type system

2024-01-18 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808439#comment-17808439 ] Jacky Lau commented on FLINK-33950: --- hi [~twalthr]  [~martijnvisser]  [~dwysakowicz] what is your

Re: [PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]

2024-01-18 Thread via GitHub
yunfengzhou-hub commented on PR #24146: URL: https://github.com/apache/flink/pull/24146#issuecomment-1899595132 Hi @lindong28, could you please take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-34149) Flink Kafka connector can't compile against 1.19-SNAPSHOT

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34149: --- Labels: pull-request-available (was: ) > Flink Kafka connector can't compile against

Re: [PR] [FLINK-33951][table] Use aggCallNeedRetractions instead of needRetrac… [flink]

2024-01-18 Thread via GitHub
liuyongvs commented on code in PR #24015: URL: https://github.com/apache/flink/pull/24015#discussion_r1439142391 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala: ## @@ -1230,8 +1232,26 @@ class

[PR] [FLINK-34149][Runtime/Checkpointing] Fix SplitEnumeratorContext compatibility issue [flink]

2024-01-18 Thread via GitHub
yunfengzhou-hub opened a new pull request, #24146: URL: https://github.com/apache/flink/pull/24146 ## What is the purpose of the change This PR adds a default implementation to SplitEnumeratorContext#setIsProcessingBacklog to fix the compatibility issue introduced in #22931.

Re: [PR] [FLINK-32743][Connectors/Kafka] Parse data from kafka connect and convert it into regular JSON data [flink-connector-kafka]

2024-01-18 Thread via GitHub
sunxiaojian commented on PR #42: URL: https://github.com/apache/flink-connector-kafka/pull/42#issuecomment-1899549561 > @sunxiaojian Can you please rebase your PR? @MartijnVisser Thanks for your review, it has been processed -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34104][autoscaler] Improve the ScalingReport format of autoscaling [flink-kubernetes-operator]

2024-01-18 Thread via GitHub
1996fanrui commented on code in PR #757: URL: https://github.com/apache/flink-kubernetes-operator/pull/757#discussion_r1458204048 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoscalerEventUtils.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (FLINK-23687) Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys

2024-01-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-23687: -- Assignee: yunfan (was: Jing Zhang) > Introduce partitioned lookup join to enforce input of

[jira] [Commented] (FLINK-23687) Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys

2024-01-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808433#comment-17808433 ] Benchao Li commented on FLINK-23687: [~yunfanfight...@foxmail.com] Thanks for taking it, I've

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-18 Thread via GitHub
libenchao commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1899537774 > @libenchao Could you help review it after #24128 is merged? I assigned it to myself. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-34080][configuration] Simplify the Configuration [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #24088: URL: https://github.com/apache/flink/pull/24088#issuecomment-1899532157 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-18 Thread via GitHub
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1899531944 @libenchao Could you help review it after #24128 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1899532108 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

2024-01-18 Thread via GitHub
1996fanrui commented on PR #24089: URL: https://github.com/apache/flink/pull/24089#issuecomment-1899531748 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-34156) Move Flink Calcite rules from Scala to Java

2024-01-18 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808430#comment-17808430 ] Jacky Lau commented on FLINK-34156: --- hi [~Sergey Nuyanzin] can I also help with this task? > Move

[jira] [Commented] (FLINK-34156) Move Flink Calcite rules from Scala to Java

2024-01-18 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808425#comment-17808425 ] Jiabao Sun commented on FLINK-34156: Hi [~Sergey Nuyanzin], can I help with this task? > Move Flink

[jira] [Commented] (FLINK-34144) Update the documentation and configuration description about dynamic source parallelism inference

2024-01-18 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808424#comment-17808424 ] Zhu Zhu commented on FLINK-34144: - [~xiasun] Assigned. Feel free to open a PR for it. > Update the

[jira] [Commented] (FLINK-34143) Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism`

2024-01-18 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808423#comment-17808423 ] Zhu Zhu commented on FLINK-34143: - [~xiasun]Assigned. Feel free to open a PR for it. > Modify the

[jira] [Comment Edited] (FLINK-34143) Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism`

2024-01-18 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808423#comment-17808423 ] Zhu Zhu edited comment on FLINK-34143 at 1/19/24 1:54 AM: -- [~xiasun] Assigned.

[jira] [Assigned] (FLINK-34143) Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism`

2024-01-18 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-34143: --- Assignee: xingbe > Modify the effective strategy of >

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-18 Thread via GitHub
masteryhx commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1458185586 ## docs/layouts/shortcodes/generated/rocksdb_configurable_configuration.html: ## @@ -62,6 +62,12 @@ Enum The specified compaction style for

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-18 Thread via GitHub
masteryhx commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1458185586 ## docs/layouts/shortcodes/generated/rocksdb_configurable_configuration.html: ## @@ -62,6 +62,12 @@ Enum The specified compaction style for

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-18 Thread via GitHub
masteryhx commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1458185586 ## docs/layouts/shortcodes/generated/rocksdb_configurable_configuration.html: ## @@ -62,6 +62,12 @@ Enum The specified compaction style for

[jira] [Commented] (FLINK-34135) A number of ci failures with Access to the path '.../_work/_temp/containerHandlerInvoker.js' is denied.

2024-01-18 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808420#comment-17808420 ] Yang Wang commented on FLINK-34135: --- The CI should work since the {{containerHandlerInvoker.js}} and

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-18 Thread via GitHub
xuyangzhong commented on PR #23505: URL: https://github.com/apache/flink/pull/23505#issuecomment-1899499981 Hi, @snuyanzin . Regarding this PR, my original intention was to implement it according to the existing FLIP and not to introduce features that haven't been discussed. IMO,

[jira] [Commented] (FLINK-34155) Recurring SqlExecutionException

2024-01-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808419#comment-17808419 ] lincoln lee commented on FLINK-34155: - [~jeyhunkarimov] thanks for the investigation! Could you

[jira] [Comment Edited] (FLINK-30656) Provide more logs for schema compatibility check

2024-01-18 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807968#comment-17807968 ] Hangxiang Yu edited comment on FLINK-30656 at 1/19/24 1:37 AM: --- We should

[jira] [Updated] (FLINK-34038) IncrementalGroupAggregateRestoreTest.testRestore fails

2024-01-18 Thread Bonnie Varghese (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bonnie Varghese updated FLINK-34038: Parent: FLINK-33421 Issue Type: Sub-task (was: Bug) >

Re: [PR] [FLINK-34163][table] Migration of SimplifyJoinConditionRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24145: URL: https://github.com/apache/flink/pull/24145#issuecomment-1899376797 ## CI report: * 2328e1349a9515b710ab28ab63549ac91e9302ab UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-18 Thread via GitHub
snuyanzin commented on PR #23505: URL: https://github.com/apache/flink/pull/23505#issuecomment-1899372916 I would vote for having order by support as welll within this PR (assuming that there is no blockers for that). WDYT? -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-34162][table] Migrate LogicalUnnestRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24144: URL: https://github.com/apache/flink/pull/24144#issuecomment-1899370307 ## CI report: * fb9cb9e1dbcc55e715f9345e7a676f04dd3aab44 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-18 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1458074979 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -116,6 +124,15 @@ public void

[jira] [Updated] (FLINK-34163) Migrate SimplifyJoinConditionRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34163: --- Labels: pull-request-available (was: ) > Migrate SimplifyJoinConditionRule >

[PR] [FLINK-34163][table] Migration of SimplifyJoinConditionRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24145: URL: https://github.com/apache/flink/pull/24145 ## What is the purpose of the change The PR migrates `SimplifyJoinConditionRule` to java it doesn't touch `SimplifyJoinConditionRuleTest` to be sure that java version continues passing

Re: [PR] [FLINK-34161][table] Migration of RewriteMinusAllRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24143: URL: https://github.com/apache/flink/pull/24143#issuecomment-1899363542 ## CI report: * 24534c846740a8abf784616925b68b4418d1db16 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34163) Migrate SimplifyJoinConditionRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34163: --- Summary: Migrate SimplifyJoinConditionRule Key: FLINK-34163 URL: https://issues.apache.org/jira/browse/FLINK-34163 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-34160][table] Migration of FlinkCalcMergeRule to java [flink]

2024-01-18 Thread via GitHub
flinkbot commented on PR #24142: URL: https://github.com/apache/flink/pull/24142#issuecomment-1899362772 ## CI report: * 80fbc2393ec077476aec2eecb498c2ebf29aff96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34162) Migrate LogicalUnnestRule

2024-01-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34162: --- Labels: pull-request-available (was: ) > Migrate LogicalUnnestRule >

[jira] [Created] (FLINK-34162) Migrate LogicalUnnestRule

2024-01-18 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-34162: --- Summary: Migrate LogicalUnnestRule Key: FLINK-34162 URL: https://issues.apache.org/jira/browse/FLINK-34162 Project: Flink Issue Type: Sub-task

[PR] [FLINK-34162][table] Migrate LogicalUnnestRule to java [flink]

2024-01-18 Thread via GitHub
snuyanzin opened a new pull request, #24144: URL: https://github.com/apache/flink/pull/24144 ## What is the purpose of the change The PR migrates `LogicalUnnestRule` to java it doesn't touch `LogicalUnnestRuleTest` to be sure that java version continues passing it

  1   2   3   4   >