Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp commented on PR #24347: URL: https://github.com/apache/flink/pull/24347#issuecomment-1956693303 Closing this PR in favor of PR #24362 which is backed by a branch in the Apache repo which enables the CI run and helps testing the changes before merging them to `master`. -- This is

Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp closed pull request #24347: [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner URL: https://github.com/apache/flink/pull/24347 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [BP-1.19][FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp commented on PR #24356: URL: https://github.com/apache/flink/pull/24356#issuecomment-1956690903 There's more work that needs to be done (see [my Jira issue

Re: [PR] [BP-1.19][FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp closed pull request #24356: [BP-1.19][FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner URL: https://github.com/apache/flink/pull/24356 -- This is an automated message from the Apache Git Service. To respond to the

[PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp opened a new pull request, #24362: URL: https://github.com/apache/flink/pull/24362 ## What is the purpose of the change The goal is to enable Apache-hosted runners for the main repo but allow forks to use the GitHub-hosted runners. ## Brief change log * Adds

[jira] [Commented] (FLINK-34331) Enable Apache INFRA runners for nightly builds

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819260#comment-17819260 ] Matthias Pohl commented on FLINK-34331: --- I reverted the change in

Re: [PR] [BP-1.18][FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp commented on PR #24357: URL: https://github.com/apache/flink/pull/24357#issuecomment-1956682167 I reverted the change in 0293639170b85720003faa2aacc0d4f1d127b8f4 because of errors in the compilation phase. We can test CI by pushing the branch to the Apache Flink repo instead of using

[jira] [Commented] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-21 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819257#comment-17819257 ] Jinzhong Li commented on FLINK-34050: - [~srichter]   Thanks for your comments. I think:  1. The

Re: [PR] [FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp commented on PR #24347: URL: https://github.com/apache/flink/pull/24347#issuecomment-1956670454 Thanks for the review. I went ahead and merged the 1.18 backport as a first try (see [related workflow run](https://github.com/apache/flink/actions/runs/7989772037) and [1.18 baseline

[jira] [Commented] (FLINK-34331) Enable Apache INFRA runners for nightly builds

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819252#comment-17819252 ] Matthias Pohl commented on FLINK-34331: --- I merged the 1.18 backport PR first to monitor the CI

Re: [PR] [FLINK-34476][table-planner] Consider assignment operator during TVF column expansion [flink]

2024-02-21 Thread via GitHub
flinkbot commented on PR #24361: URL: https://github.com/apache/flink/pull/24361#issuecomment-1956659473 ## CI report: * f96077bfbf48aee7b379122e736cdf5f8712650a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34476) Window TVFs with named parameters don't support column expansion

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34476: --- Labels: pull-request-available (was: ) > Window TVFs with named parameters don't support

[PR] [FLINK-34476][table-planner] Consider assignment operator during TVF column expansion [flink]

2024-02-21 Thread via GitHub
twalthr opened a new pull request, #24361: URL: https://github.com/apache/flink/pull/24361 ## What is the purpose of the change Considers the assignment operator `=>` when performing metadata virtual column expansion. Enabling e.g. the following query: ``` TUMBLE(DATA

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-02-21 Thread Nathan Taylor Armstrong Lewis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819243#comment-17819243 ] Nathan Taylor Armstrong Lewis commented on FLINK-33817: --- [~libenchao], yes that

Re: [PR] [FLINK-34401][docs-zh] Translate "Flame Graphs" page into Chinese [flink]

2024-02-21 Thread via GitHub
Zakelly commented on code in PR #24279: URL: https://github.com/apache/flink/pull/24279#discussion_r1497538955 ## docs/content.zh/docs/ops/debugging/flame_graphs.md: ## @@ -25,38 +25,39 @@ specific language governing permissions and limitations under the License. --> -#

Re: [PR] [BP-1.18][FLINK-34331][ci] Adds reusable workflow that is used to load the runner configuration based on the projects owner [flink]

2024-02-21 Thread via GitHub
XComp merged PR #24357: URL: https://github.com/apache/flink/pull/24357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819235#comment-17819235 ] Zakelly Lan commented on FLINK-34456: - [~spoon-lz] yes you are right. And

[jira] [Assigned] (FLINK-34484) Split 'state.backend.local-recovery' into two options for checkpointing and recovery

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34484: --- Assignee: Jinzhong Li > Split 'state.backend.local-recovery' into two options for

[jira] [Assigned] (FLINK-34483) Merge 'state.checkpoints.dir' and 'state.checkpoints-storage' into one

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34483: --- Assignee: Yanfei Lei > Merge 'state.checkpoints.dir' and 'state.checkpoints-storage' into

[jira] [Assigned] (FLINK-34482) Rename options for checkpointing

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34482: --- Assignee: Hangxiang Yu > Rename options for checkpointing >

[jira] [Commented] (FLINK-34471) Tune the network memroy in Autoscaler

2024-02-21 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819233#comment-17819233 ] Maximilian Michels commented on FLINK-34471: Thanks Rui! > Tune the network memroy in

[jira] [Assigned] (FLINK-34471) Tune the network memroy in Autoscaler

2024-02-21 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reassigned FLINK-34471: -- Assignee: Maximilian Michels > Tune the network memroy in Autoscaler >

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-21 Thread via GitHub
liuyongvs commented on PR #23171: URL: https://github.com/apache/flink/pull/23171#issuecomment-1956587783 @dawidwys great plan +1. because my prs do not have people to review. will you have time to help review them? -- This is an automated message from the Apache Git Service. To respond

[PR] [hotfix] Update version in `docs/data/jdbc.yml` [flink-connector-jdbc]

2024-02-21 Thread via GitHub
snuyanzin opened a new pull request, #106: URL: https://github.com/apache/flink-connector-jdbc/pull/106 Update version in `jdbc.yml` based on

Re: [PR] [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi… [flink]

2024-02-21 Thread via GitHub
XComp commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1497437961 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -66,33 +91,47 @@ public void open(

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819208#comment-17819208 ] liuzhuo commented on FLINK-34456: - [~Zakelly] I looked at FLIP-406 and took a quick look at the code.

[jira] [Commented] (FLINK-34101) use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0'

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819207#comment-17819207 ] Matthias Pohl commented on FLINK-34101: --- Hi [~blackpighe], thanks for reporting this issue. Is

Re: [PR] [FLINK-34485] Add URI/Configuration constructor to DynamicTemporaryAWSCredentialsProvider [flink]

2024-02-21 Thread via GitHub
flinkbot commented on PR #24360: URL: https://github.com/apache/flink/pull/24360#issuecomment-1956510240 ## CI report: * 6918294786a1dcba8d0f5c792f4107d3291c5c98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31664][Table SQL/API] Add ARRAY_INTERSECT supported in SQL & Table API [flink]

2024-02-21 Thread via GitHub
dawidwys commented on PR #22320: URL: https://github.com/apache/flink/pull/22320#issuecomment-1956506745 Since we have not heard in a while from the contributor and we have more advanced solutions, I'll close this PR. * https://github.com/apache/flink/pull/23171 *

Re: [PR] [FLINK-31664][Table SQL/API] Add ARRAY_INTERSECT supported in SQL & Table API [flink]

2024-02-21 Thread via GitHub
dawidwys closed pull request #22320: [FLINK-31664][Table SQL/API] Add ARRAY_INTERSECT supported in SQL & Table API URL: https://github.com/apache/flink/pull/22320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-34101) use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0'

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34101: -- Description: use flink ui upload jar, Something went wrong.  

[jira] [Updated] (FLINK-34101) use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0'

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34101: -- Description: use flink ui upload jar, Something went wrong.  

[jira] [Assigned] (FLINK-31663) Add ARRAY_EXCEPT supported in SQL & Table API

2024-02-21 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-31663: Assignee: Hanyu Zheng (was: Bonnie Varghese) > Add ARRAY_EXCEPT supported in

[jira] [Assigned] (FLINK-31664) Add ARRAY_INTERSECT supported in SQL & Table API

2024-02-21 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-31664: Assignee: Jacky Lau > Add ARRAY_INTERSECT supported in SQL & Table API >

Re: [PR] [FLINK-31664][table]Add ARRAY_INTERSECT function [flink]

2024-02-21 Thread via GitHub
dawidwys commented on PR #23171: URL: https://github.com/apache/flink/pull/23171#issuecomment-1956501651 Hey @liuyongvs I am sorry for the situation we ended up here. You're right we should've checked with you. I admit I have not been careful enough here. Please accept my apologies.

[jira] [Updated] (FLINK-34485) Token delegation doesn't work with Presto S3 filesystem

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34485: --- Labels: pull-request-available (was: ) > Token delegation doesn't work with Presto S3

[jira] [Created] (FLINK-34486) Add documentation on how to add the shared utils as a submodule to the connector repo

2024-02-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34486: - Summary: Add documentation on how to add the shared utils as a submodule to the connector repo Key: FLINK-34486 URL: https://issues.apache.org/jira/browse/FLINK-34486

[jira] [Updated] (FLINK-13602) S3 Presto filesystem effectively does not support credential providers

2024-02-21 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-13602: - Summary: S3 Presto filesystem effectively does not support credential providers (was:

[jira] [Created] (FLINK-34485) Token delegation doesn't work with Presto S3 filesystem

2024-02-21 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-34485: Summary: Token delegation doesn't work with Presto S3 filesystem Key: FLINK-34485 URL: https://issues.apache.org/jira/browse/FLINK-34485 Project: Flink

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2024-02-21 Thread via GitHub
XComp commented on PR #23880: URL: https://github.com/apache/flink/pull/23880#issuecomment-1956456977 @zhengzhili333 sorry for the delay. But can you rebased the branch and remove any merge commits? That would help with the review -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33472][Client] Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded [flink]

2024-02-21 Thread via GitHub
XComp commented on PR #23782: URL: https://github.com/apache/flink/pull/23782#issuecomment-1956443330 Sorry for leaving you hanging for that long time. I was busy with other topics. Can you rebase the branch and bring the test case back? I hope I find time to review it in the next days.

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-34456: Description: Move all checkpoint-related options that are out of `CheckpointingOptions` into

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-34456: Description: Move all checkpoint-related options that out of  > Move all checkpoint-related

[jira] [Comment Edited] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819191#comment-17819191 ] Zakelly Lan edited comment on FLINK-34456 at 2/21/24 11:19 AM: ---

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819191#comment-17819191 ] Zakelly Lan commented on FLINK-34456: - Assigned to you. If you need any help, feel free to reach

[jira] [Assigned] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34456: --- Assignee: liuzhuo (was: Zakelly Lan) > Move all checkpoint-related options into

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: (was: image-2024-02-21-19-17-43-975.png) > Move all checkpoint-related options into

[jira] [Comment Edited] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819190#comment-17819190 ] liuzhuo edited comment on FLINK-34456 at 2/21/24 11:17 AM: --- [~Zakelly] Yes,

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: (was: image-2024-02-21-19-16-38-846.png) > Move all checkpoint-related options into

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819190#comment-17819190 ] liuzhuo commented on FLINK-34456: - [~Zakelly] Yes, please forgive me for returning to the previous

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: image-2024-02-21-19-16-38-846.png > Move all checkpoint-related options into

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819188#comment-17819188 ] Zakelly Lan commented on FLINK-34456: - [~spoon-lz] It seems two accounts here. I'm sorry but are you

[jira] [Commented] (FLINK-34322) Make secrets work in GitHub Action workflows

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819186#comment-17819186 ] Matthias Pohl commented on FLINK-34322: --- [~jingge] The secrets are currently listed in the Azure

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-21 Thread via GitHub
libenchao commented on code in PR #24035: URL: https://github.com/apache/flink/pull/24035#discussion_r1497332715 ## docs/content/docs/connectors/table/formats/protobuf.md: ## @@ -149,9 +149,12 @@ Format Options false Boolean - This option only

Re: [PR] [FLINK-34363] Set artifact version to $project_version if $FLINK_VERSION is not set [flink-connector-shared-utils]

2024-02-21 Thread via GitHub
echauchot commented on PR #38: URL: https://github.com/apache/flink-connector-shared-utils/pull/38#issuecomment-1956402403 @zentol I coded as discussed and tested on a local cassandra connector release and a local connector-parent release. PTAL -- This is an automated message from the

[jira] [Updated] (FLINK-34326) Add Slack integration

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34326: -- Description: There are Slack actions (e.g.

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: (was: image-2024-02-21-18-58-47-817.png) > Move all checkpoint-related options into

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: image-2024-02-21-18-58-47-817.png > Move all checkpoint-related options into

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819184#comment-17819184 ] liuzhuo commented on FLINK-34456: - [~Zakelly] Please assign the issue to me and I will try to complete

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819183#comment-17819183 ] Matthias Pohl edited comment on FLINK-34202 at 2/21/24 10:57 AM: - That

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819183#comment-17819183 ] Matthias Pohl commented on FLINK-34202: --- That still leaves the question why we don't see this in

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819183#comment-17819183 ] Matthias Pohl edited comment on FLINK-34202 at 2/21/24 10:56 AM: - That

[jira] [Comment Edited] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819183#comment-17819183 ] Matthias Pohl edited comment on FLINK-34202 at 2/21/24 10:56 AM: - That

Re: [PR] [FLINK-34363] Set artifact version to $project_version if $FLINK_VERSION is not set [flink-connector-shared-utils]

2024-02-21 Thread via GitHub
echauchot commented on PR #38: URL: https://github.com/apache/flink-connector-shared-utils/pull/38#issuecomment-1956394417 > I'm not sure about defaulting to the project version. 樂 I agree, for the vast majority of the use cases (all the connectors except parent), the script will be

[jira] [Created] (FLINK-34484) Split 'state.backend.local-recovery' into two options for checkpointing and recovery

2024-02-21 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34484: --- Summary: Split 'state.backend.local-recovery' into two options for checkpointing and recovery Key: FLINK-34484 URL: https://issues.apache.org/jira/browse/FLINK-34484

[jira] [Created] (FLINK-34483) Merge 'state.checkpoints.dir' and 'state.checkpoints-storage' into one

2024-02-21 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34483: --- Summary: Merge 'state.checkpoints.dir' and 'state.checkpoints-storage' into one Key: FLINK-34483 URL: https://issues.apache.org/jira/browse/FLINK-34483 Project: Flink

[jira] [Created] (FLINK-34482) Rename options for checkpointing

2024-02-21 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34482: --- Summary: Rename options for checkpointing Key: FLINK-34482 URL: https://issues.apache.org/jira/browse/FLINK-34482 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819181#comment-17819181 ] Zakelly Lan commented on FLINK-34456: - [~clevermose] Thanks for volunteering! I've just started

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-21 Thread Lorenzo Affetti (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819180#comment-17819180 ] Lorenzo Affetti commented on FLINK-34202: - Update, CI001 looks just a bit overcommitted:

[jira] [Updated] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-21 Thread Lorenzo Affetti (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenzo Affetti updated FLINK-34202: Attachment: Screenshot 2024-02-21 at 09.45.18.png > python tests take suspiciously long

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core package api-common [flink]

2024-02-21 Thread via GitHub
1996fanrui commented on PR #23960: URL: https://github.com/apache/flink/pull/23960#issuecomment-1956306060 > Hi @1996fanrui, Since this PR is quite large, can you help double-check it? Thanks @GOODBOY008 for the hard work and @Jiabao-Sun for the hard review. I will review this week.

Re: [PR] [FLINK-34458][checkpointing] Rename options for Generalized incremental checkpoints (changelog) [flink]

2024-02-21 Thread via GitHub
Zakelly commented on code in PR #24324: URL: https://github.com/apache/flink/pull/24324#discussion_r1497229726 ## docs/content.zh/docs/deployment/config.md: ## @@ -470,7 +470,7 @@ using State Changelog. FileSystem-based Changelog options -These settings take effect

Re: [PR] [FLINK-34362][docs] Add argument to skip integrate connector docs in setup_docs.sh to improve build times [flink]

2024-02-21 Thread via GitHub
swuferhong commented on PR #24271: URL: https://github.com/apache/flink/pull/24271#issuecomment-1956296250 Hi, @MartijnVisser. Could you please help review it again? Thank you so much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-32443][docs-zh] Translate "State Processor API" page into Chinese [flink]

2024-02-21 Thread via GitHub
fredia merged PR #23496: URL: https://github.com/apache/flink/pull/23496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33859] Support OpenSearch v2 [flink-connector-opensearch]

2024-02-21 Thread via GitHub
snuyanzin commented on PR #38: URL: https://github.com/apache/flink-connector-opensearch/pull/38#issuecomment-1956291868 @reswqa do you have time to have a look here please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-32443][docs-zh] Translate "State Processor API" page into Chinese [flink]

2024-02-21 Thread via GitHub
fredia commented on PR #23496: URL: https://github.com/apache/flink/pull/23496#issuecomment-1956292399 Thanks for the review, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate … [flink]

2024-02-21 Thread via GitHub
caodizhou commented on PR #24115: URL: https://github.com/apache/flink/pull/24115#issuecomment-1956287203 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: (was: image-2024-02-21-17-54-36-194.png) > Move all checkpoint-related options into

[jira] [Resolved] (FLINK-34479) Fix missed changelog configs in the documentation

2024-02-21 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-34479. -- Fix Version/s: 1.19.0 1.20.0 Resolution: Fixed Merged 

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819164#comment-17819164 ] liuzhuo commented on FLINK-34456: - Is there anyone working on this issue? If no one is working on it, I

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-21 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: image-2024-02-21-17-54-36-194.png > Move all checkpoint-related options into

Re: [PR] [FLINK-34479][documentation] Fix missed changelog configs in the mentation [flink]

2024-02-21 Thread via GitHub
masteryhx commented on PR #24355: URL: https://github.com/apache/flink/pull/24355#issuecomment-1956274670 Thanks for the review. Merged d19e886b into release-1.19. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-34479][documentation] Fix missed changelog configs in the mentation [flink]

2024-02-21 Thread via GitHub
masteryhx closed pull request #24355: [FLINK-34479][documentation] Fix missed changelog configs in the mentation URL: https://github.com/apache/flink/pull/24355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34481][table] Migrate SetOpRewriteUtil to java [flink]

2024-02-21 Thread via GitHub
flinkbot commented on PR #24358: URL: https://github.com/apache/flink/pull/24358#issuecomment-1956272958 ## CI report: * 70da561fa780493943ed6567200bbd06bce54a91 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34371][runtime] Support EndOfStreamTrigger and isOutputOnlyAfterEndOfStream operator attribute to optimize task deployment [flink]

2024-02-21 Thread via GitHub
yunfengzhou-hub commented on code in PR #24272: URL: https://github.com/apache/flink/pull/24272#discussion_r1497209330 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -2303,6 +2307,102 @@ void

Re: [PR] [FLINK-34480] support user jar class overwrite flink inner when meet the same. [flink]

2024-02-21 Thread via GitHub
flinkbot commented on PR #24359: URL: https://github.com/apache/flink/pull/24359#issuecomment-1956273172 ## CI report: * 6848a06fdbbe25bc8e944b538bf31c6d2b6a7fc2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34401][docs-zh] Translate "Flame Graphs" page into Chinese [flink]

2024-02-21 Thread via GitHub
lxliyou001 commented on PR #24279: URL: https://github.com/apache/flink/pull/24279#issuecomment-1956268739 > > @Zakelly 谢谢建议,还有这个pr没合入之前,每次master变更都要merge,然后merge又要过CI,CI耗时又很长,很是麻烦,我想问问CI在跑的过程中能合入吗 > >

Re: [PR] [FLINK-34480] support user jar class overwrite flink inner when meet the same. [flink]

2024-02-21 Thread via GitHub
TJX2014 commented on PR #24359: URL: https://github.com/apache/flink/pull/24359#issuecomment-1956268368 cc @dannycranmer pls help review this : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-34479][documentation] Fix missed changelog configs in the documentation [flink]

2024-02-21 Thread via GitHub
masteryhx commented on PR #24354: URL: https://github.com/apache/flink/pull/24354#issuecomment-1956267620 Thanks for the review. Merged 6f7e841d into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34479][documentation] Fix missed changelog configs in the documentation [flink]

2024-02-21 Thread via GitHub
masteryhx closed pull request #24354: [FLINK-34479][documentation] Fix missed changelog configs in the documentation URL: https://github.com/apache/flink/pull/24354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-34480) Add method to support user jar overwrite flink inner jar class when same class

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34480: --- Labels: pull-request-available (was: ) > Add method to support user jar overwrite flink

[PR] [FLINK-34480] support user jar class overwrite flink inner when meet the same. [flink]

2024-02-21 Thread via GitHub
TJX2014 opened a new pull request, #24359: URL: https://github.com/apache/flink/pull/24359 ## What is the purpose of the change When we use flink on kubernetes, user jar to overwrite flink cluster is convenient for users. Add option to support user jar class to overwrite flink inner

[jira] [Updated] (FLINK-34481) Migrate SetOpRewriteUtil

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34481: --- Labels: pull-request-available (was: ) > Migrate SetOpRewriteUtil >

[PR] [FLINK-34481][table] Migrate SetOpRewriteUtil to java [flink]

2024-02-21 Thread via GitHub
liuyongvs opened a new pull request, #24358: URL: https://github.com/apache/flink/pull/24358 ## What is the purpose of the change The PR migrates SetOpRewriteUtil to java for migrating ReplaceMinusWithAntiJoinRule ReplaceMinusWithAntiJoinRule RewriteIntersectAllRule

Re: [PR] [FLINK-34401][docs-zh] Translate "Flame Graphs" page into Chinese [flink]

2024-02-21 Thread via GitHub
Zakelly commented on PR #24279: URL: https://github.com/apache/flink/pull/24279#issuecomment-1956262446 > @Zakelly 谢谢建议,还有这个pr没合入之前,每次master变更都要merge,然后merge又要过CI,CI耗时又很长,很是麻烦,我想问问CI在跑的过程中能合入吗

Re: [PR] [FLINK-34383][Documentation] Modify the comment with incorrect syntax [flink]

2024-02-21 Thread via GitHub
lxliyou001 commented on PR #24273: URL: https://github.com/apache/flink/pull/24273#issuecomment-1956257364 Hi @zhuzhurk , thanks for your advice. i have start the project by translating Chinese documents. you can review it when you have free time.

[jira] [Updated] (FLINK-34481) Migrate SetOpRewriteUtil

2024-02-21 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Lau updated FLINK-34481: -- Description: we should Migrate SetOpRewriteUtil for  ReplaceMinusWithAntiJoinRule

[jira] [Created] (FLINK-34481) Migrate SetOpRewriteUtil

2024-02-21 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-34481: - Summary: Migrate SetOpRewriteUtil Key: FLINK-34481 URL: https://issues.apache.org/jira/browse/FLINK-34481 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-34480) Add method to support user jar overwrite flink inner jar class when same class

2024-02-21 Thread JinxinTang (Jira)
JinxinTang created FLINK-34480: -- Summary: Add method to support user jar overwrite flink inner jar class when same class Key: FLINK-34480 URL: https://issues.apache.org/jira/browse/FLINK-34480 Project:

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819154#comment-17819154 ] Matthias Pohl commented on FLINK-29114: ---

<    1   2   3   >