Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2024-04-18 Thread via GitHub
afedulov commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-2064139948 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-34916) Support `ALTER CATALOG SET` syntax

2024-04-18 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-34916: - Summary: Support `ALTER CATALOG SET` syntax (was: Support `ALTER CATALOG` syntax) > Support `ALTER

Re: [PR] [FLINK-35159] Transition ExecutionGraph to RUNNING after slot assignment [flink]

2024-04-18 Thread via GitHub
zentol commented on code in PR #24680: URL: https://github.com/apache/flink/pull/24680#discussion_r1571216390 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -1783,56 +1778,6 @@ void

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2024-04-18 Thread via GitHub
afedulov commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-2064985125 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-35165) AdaptiveBatch Scheduler should not restrict the default source parallelism to the max parallelism set

2024-04-18 Thread Venkata krishnan Sowrirajan (Jira)
Venkata krishnan Sowrirajan created FLINK-35165: --- Summary: AdaptiveBatch Scheduler should not restrict the default source parallelism to the max parallelism set Key: FLINK-35165 URL:

Re: [PR] [FLINK-34915][table] Complete `DESCRIBE CATALOG` syntax [flink]

2024-04-18 Thread via GitHub
liyubin117 commented on PR #24630: URL: https://github.com/apache/flink/pull/24630#issuecomment-2064501044 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35159] Transition ExecutionGraph to RUNNING in Executing state [flink]

2024-04-18 Thread via GitHub
zentol commented on PR #24680: URL: https://github.com/apache/flink/pull/24680#issuecomment-2064570934 meh, stop-with-savepoint failures need to be able to transition back into executing without recreating the EG :/ -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Adding JDBC Connector v3.2.0 [flink-web]

2024-04-18 Thread via GitHub
Samrat002 commented on code in PR #734: URL: https://github.com/apache/flink-web/pull/734#discussion_r1571145570 ## docs/data/flink_connectors.yml: ## @@ -51,11 +51,11 @@ hbase: compatibility: ["1.16.x", "1.17.x"] jdbc: - name: "Apache Flink JDBC Connector 3.1.2" -

Re: [PR] [FLINK-35115][Connectors/Kinesis] Allow kinesis consumer to snapshotState after operator had been cancelled [flink-connector-aws]

2024-04-18 Thread via GitHub
z3d1k commented on code in PR #138: URL: https://github.com/apache/flink-connector-aws/pull/138#discussion_r1571230798 ## flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java: ## @@ -149,6 +149,7 @@

Re: [PR] [FLINK-35155] Introduce TableRuntimeException [flink]

2024-04-18 Thread via GitHub
twalthr commented on code in PR #24679: URL: https://github.com/apache/flink/pull/24679#discussion_r1570922395 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MiscAggFunctionITCase.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the

Re: [PR] [FLINK-35159] Transition ExecutionGraph to RUNNING after slot assignment [flink]

2024-04-18 Thread via GitHub
zentol commented on code in PR #24680: URL: https://github.com/apache/flink/pull/24680#discussion_r1571218899 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraphTest.java: ## @@ -166,18 +170,19 @@ static class

Re: [PR] [FLINK-35159] Transition ExecutionGraph to RUNNING after slot assignment [flink]

2024-04-18 Thread via GitHub
dmvk commented on code in PR #24680: URL: https://github.com/apache/flink/pull/24680#discussion_r1571177099 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraphTest.java: ## @@ -166,18 +170,19 @@ static class

Re: [PR] [FLINK-35159] Transition ExecutionGraph to RUNNING after slot assignment [flink]

2024-04-18 Thread via GitHub
zentol commented on code in PR #24680: URL: https://github.com/apache/flink/pull/24680#discussion_r1571216654 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraphTest.java: ## @@ -93,8 +93,12 @@ void

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-04-18 Thread via GitHub
pvary commented on PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#issuecomment-2065143602 Good catch @loserwang1024! Could you please add a test case to prevent later code changes to revert this fix? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-34915][table] Complete `DESCRIBE CATALOG` syntax [flink]

2024-04-18 Thread via GitHub
liyubin117 commented on PR #24630: URL: https://github.com/apache/flink/pull/24630#issuecomment-2065504494 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34444] Initial implementation of JM operator metric rest api [flink]

2024-04-18 Thread via GitHub
afedulov commented on code in PR #24564: URL: https://github.com/apache/flink/pull/24564#discussion_r1571313741 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java: ## @@ -184,6 +184,21 @@ public synchronized ComponentMetricStore

Re: [PR] Support skip verify ssl certificate and hostname [flink-connector-elasticsearch]

2024-04-18 Thread via GitHub
liuml07 commented on PR #96: URL: https://github.com/apache/flink-connector-elasticsearch/pull/96#issuecomment-2065368913 Thank you @tosone . Could you help review that PR? Also I can update that one to port your change about Table API changes. If you would like to co-author that by

Re: [PR] [FLINK-35047][state] Support ForStStateBackend and ForStKeyedStateBackend [flink]

2024-04-18 Thread via GitHub
flinkbot commented on PR #24682: URL: https://github.com/apache/flink/pull/24682#issuecomment-2065635116 ## CI report: * a5be0a188101bcaf6fb76c8d5144ad002a79a192 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35166] Make the SortBufferAccumulator use more buffers when the parallelism is small [flink]

2024-04-18 Thread via GitHub
flinkbot commented on PR #24683: URL: https://github.com/apache/flink/pull/24683#issuecomment-2065635252 ## CI report: * 0d0a7bcca23de55518958f32eb36a242bd4b615d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-18 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115 ] Vadim Vararu deleted comment on FLINK-35115: -- was (Author: JIRAUSER305101): [~a.pilipenko] 4.3.0 will be released for Flink 1.18 as well, right? > Kinesis connector writes wrong Kinesis

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-18 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838854#comment-17838854 ] Vadim Vararu commented on FLINK-35115: -- [~a.pilipenko] 4.3.0 will be released for Flink 1.18 as

[jira] [Created] (FLINK-35166) Improve the performance of Hybrid Shuffle when enable memory decoupling

2024-04-18 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-35166: - Summary: Improve the performance of Hybrid Shuffle when enable memory decoupling Key: FLINK-35166 URL: https://issues.apache.org/jira/browse/FLINK-35166 Project: Flink

[jira] [Created] (FLINK-35167) [CDC] Introduce MaxCompute pipeline DataSink

2024-04-18 Thread zhangdingxin (Jira)
zhangdingxin created FLINK-35167: Summary: [CDC] Introduce MaxCompute pipeline DataSink Key: FLINK-35167 URL: https://issues.apache.org/jira/browse/FLINK-35167 Project: Flink Issue Type: New

[jira] [Updated] (FLINK-35162) Support grouping state get and put access

2024-04-18 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinzhong Li updated FLINK-35162: Component/s: Runtime / State Backends > Support grouping state get and put access >

[jira] [Updated] (FLINK-35163) Utilize ForSt's native MultiGet API to optimize remote state access

2024-04-18 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinzhong Li updated FLINK-35163: Component/s: Runtime / State Backends > Utilize ForSt's native MultiGet API to optimize remote

Re: [PR] [FLINK-35127] remove HybridSource to avoid CI failure. [flink-cdc]

2024-04-18 Thread via GitHub
lvyanquan commented on PR #3237: URL: https://github.com/apache/flink-cdc/pull/3237#issuecomment-2065637354 The failure in current CI contains a error message of ``` (4185ef2c5087300d32f25ea842d3ec59_cbc357ccb763df2852fee8c4fc7d55f2_0_0) switched from RUNNING to FAILED with failure

[jira] [Created] (FLINK-35168) Basic State Iterator for async processing

2024-04-18 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-35168: --- Summary: Basic State Iterator for async processing Key: FLINK-35168 URL: https://issues.apache.org/jira/browse/FLINK-35168 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-35168) Basic State Iterator for async processing

2024-04-18 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35168: Component/s: Runtime / State Backends > Basic State Iterator for async processing >

Re: [PR] [FLINK-35028][runtime] Timer firing under async execution model [flink]

2024-04-18 Thread via GitHub
Zakelly commented on code in PR #24672: URL: https://github.com/apache/flink/pull/24672#discussion_r1571754617 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceAsyncImpl.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache

[PR] [FLINK-35154] Javadoc generating fix [flink]

2024-04-18 Thread via GitHub
ldadima opened a new pull request, #24684: URL: https://github.com/apache/flink/pull/24684 ## What is the purpose of the change To fix [FLINK-35154](https://issues.apache.org/jira/browse/FLINK-35154) ## Verifying this change Run mvn javadoc:aggregate -Prelease ##

[jira] [Created] (FLINK-35169) Recycle buffers to freeSegments before releasing data buffer for sort accumulator

2024-04-18 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-35169: - Summary: Recycle buffers to freeSegments before releasing data buffer for sort accumulator Key: FLINK-35169 URL: https://issues.apache.org/jira/browse/FLINK-35169 Project:

[jira] [Updated] (FLINK-35047) Introduce ForStStateBackend to manage ForSt

2024-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35047: --- Labels: pull-request-available (was: ) > Introduce ForStStateBackend to manage ForSt >

[PR] [FLINK-35047][state] Support ForStStateBackend and ForStKeyedStateBackend [flink]

2024-04-18 Thread via GitHub
masteryhx opened a new pull request, #24682: URL: https://github.com/apache/flink/pull/24682 ## What is the purpose of the change A ForStStateBackend is introduced to leverage ForSt as state store for Flink. This ticket includes: - Life cycle of ForSt, including

[jira] [Updated] (FLINK-35167) Introduce MaxCompute pipeline DataSink

2024-04-18 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdingxin updated FLINK-35167: - Summary: Introduce MaxCompute pipeline DataSink (was: [CDC] Introduce MaxCompute pipeline

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-18 Thread via GitHub
RocMarshal commented on code in PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#discussion_r1571809638 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java: ## @@ -90,6 +101,11 @@ public

[jira] [Updated] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35154: --- Labels: pull-request-available (was: ) > Javadoc aggregate fails > ---

[PR] [FLINK-35166] Make the SortBufferAccumulator use more buffers when the parallelism is small [flink]

2024-04-18 Thread via GitHub
jiangxin369 opened a new pull request, #24683: URL: https://github.com/apache/flink/pull/24683 ## What is the purpose of the change Improve the performance of hybrid shuffle when enable memory decoupling and meantime the parallelism is small. ## Brief change log

[jira] [Updated] (FLINK-35166) Improve the performance of Hybrid Shuffle when enable memory decoupling

2024-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35166: --- Labels: pull-request-available (was: ) > Improve the performance of Hybrid Shuffle when

Re: [PR] [FLINK-34915][table] Complete `DESCRIBE CATALOG` syntax [flink]

2024-04-18 Thread via GitHub
liyubin117 commented on PR #24630: URL: https://github.com/apache/flink/pull/24630#issuecomment-2065632965 @LadyForest Hi, I have updated as you said, besides, rebased on the latest master branch and CI passed, PTAL, thanks :) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-18 Thread via GitHub
Zakelly commented on code in PR #24667: URL: https://github.com/apache/flink/pull/24667#discussion_r1571771428 ## flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java: ## @@ -181,4 +182,73 @@ public class ExecutionOptions {

Re: [PR] [FLINK-32315][k8s] Support uploading "local://" artifacts in Kubernetes Application Mode [flink]

2024-04-18 Thread via GitHub
ferenc-csaky commented on PR #24303: URL: https://github.com/apache/flink/pull/24303#issuecomment-2065736703 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35027][runtime/checkpoint] Implement checkpoint drain in AsyncExecutionController [flink]

2024-04-18 Thread via GitHub
Zakelly commented on code in PR #24676: URL: https://github.com/apache/flink/pull/24676#discussion_r1571777947 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java: ## @@ -133,6 +136,20 @@

Re: [PR] [FLINK-35154] Javadoc generating fix [flink]

2024-04-18 Thread via GitHub
flinkbot commented on PR #24684: URL: https://github.com/apache/flink/pull/24684#issuecomment-2065793603 ## CI report: * b2a3ede0b60213c2dc38e5ff050c5f827e1e86bc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34996][Connectors/Kafka] Use UserCodeCL to instantiate Deserializer [flink-connector-kafka]

2024-04-18 Thread via GitHub
hugogu commented on PR #89: URL: https://github.com/apache/flink-connector-kafka/pull/89#issuecomment-2065806444 Hi @uce and @rmetzger, do you mind reviewing the change and let me know if any change is required before merging. Thanks. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35127] remove HybridSource to avoid CI failure. [flink-cdc]

2024-04-18 Thread via GitHub
lvyanquan commented on PR #3237: URL: https://github.com/apache/flink-cdc/pull/3237#issuecomment-2065589494 Looks like HybridSource has a requirement for parallelism, but some of our tests use the core number of the machine itself

[jira] [Updated] (FLINK-35161) Implement StateExecutor for ForStStateBackend

2024-04-18 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinzhong Li updated FLINK-35161: Component/s: Runtime / State Backends > Implement StateExecutor for ForStStateBackend >

[jira] [Comment Edited] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-18 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838854#comment-17838854 ] Vadim Vararu edited comment on FLINK-35115 at 4/19/24 4:54 AM: ---

[jira] [Commented] (FLINK-35167) Introduce MaxCompute pipeline DataSink

2024-04-18 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838836#comment-17838836 ] zhangdingxin commented on FLINK-35167: -- I'd like to do it

[jira] [Updated] (FLINK-35167) Introduce MaxCompute pipeline DataSink

2024-04-18 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangdingxin updated FLINK-35167: - Labels: (was: Flink-CDC connector) > Introduce MaxCompute pipeline DataSink >

[jira] [Assigned] (FLINK-35167) Introduce MaxCompute pipeline DataSink

2024-04-18 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-35167: - Assignee: zhangdingxin > Introduce MaxCompute pipeline DataSink >

[jira] [Comment Edited] (FLINK-35167) Introduce MaxCompute pipeline DataSink

2024-04-18 Thread zhangdingxin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838836#comment-17838836 ] zhangdingxin edited comment on FLINK-35167 at 4/19/24 2:22 AM: --- I'd like

[jira] [Updated] (FLINK-35167) Introduce MaxCompute pipeline DataSink

2024-04-18 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-35167: -- Fix Version/s: cdc-3.2.0 > Introduce MaxCompute pipeline DataSink >

Re: [PR] [FLINK-35162][state] Implement WriteBatchOperation and general MultiGetOperation for ForSt [flink]

2024-04-18 Thread via GitHub
Zakelly commented on code in PR #24681: URL: https://github.com/apache/flink/pull/24681#discussion_r1571721125 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStValueState.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-35115) Kinesis connector writes wrong Kinesis sequence number at stop with savepoint

2024-04-18 Thread Vadim Vararu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838853#comment-17838853 ] Vadim Vararu commented on FLINK-35115: -- [~a.pilipenko] 4.3.0 will be released for Flink 1.18 as

[jira] [Commented] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838529#comment-17838529 ] Dmitriy Linevich commented on FLINK-35154: -- [~MartijnVisser] [~trohrmann]  Hi, Please, assign

[jira] [Created] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
Dmitriy Linevich created FLINK-35154: Summary: Javadoc aggregate fails Key: FLINK-35154 URL: https://issues.apache.org/jira/browse/FLINK-35154 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Linevich updated FLINK-35154: - Description: Javadoc plugin fails with error "cannot find symbol". Using {code:java}

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-18 Thread via GitHub
RocMarshal commented on PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#issuecomment-2063308586 hi, @snuyanzin @eskabetxe Could you help to have a review if you had the free time ? Thank you~ -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Linevich updated FLINK-35154: - Description: Javadoc plugin fails with error "cannot find symbol". Using {code:java}

Re: [PR] [FLINK-35115][Connectors/Kinesis] Allow kinesis consumer to snapshotState after operator had been cancelled [flink-connector-aws]

2024-04-18 Thread via GitHub
dannycranmer commented on code in PR #138: URL: https://github.com/apache/flink-connector-aws/pull/138#discussion_r1570265098 ## flink-connector-aws/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java: ## @@ -312,6

[jira] [Assigned] (FLINK-35124) Connector Release Fails to run Checkstyle

2024-04-18 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-35124: - Assignee: Danny Cranmer > Connector Release Fails to run Checkstyle >

[jira] [Commented] (FLINK-35088) watermark alignment maxAllowedWatermarkDrift and updateInterval param need check

2024-04-18 Thread elon_X (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838534#comment-17838534 ] elon_X commented on FLINK-35088: [~martijnvisser] [~masc]  I'm sorry for the late reply. I have

[jira] [Commented] (FLINK-35124) Connector Release Fails to run Checkstyle

2024-04-18 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838537#comment-17838537 ] Danny Cranmer commented on FLINK-35124: --- This resulted in bad source archives being generated for

[jira] [Updated] (FLINK-35124) Connector Release Fails to run Checkstyle

2024-04-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35124: --- Labels: pull-request-available (was: ) > Connector Release Fails to run Checkstyle >

[PR] [FLINK-35124] Include Maven build configuration in the pristine source clone [flink-connector-shared-utils]

2024-04-18 Thread via GitHub
dannycranmer opened a new pull request, #40: URL: https://github.com/apache/flink-connector-shared-utils/pull/40 Reverting https://github.com/apache/flink-connector-shared-utils/commit/a75b89ee3f8c9a03e97ead2d0bd9d5b7bb02b51a to ensure Maven build configuration is included in the source

[jira] [Updated] (FLINK-35002) GitHub action request timeout to ArtifactService

2024-04-18 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Skraba updated FLINK-35002: Summary: GitHub action request timeout to ArtifactService (was: GitHub

[jira] [Updated] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Linevich updated FLINK-35154: - Description: Javadoc plugin fails with error. Using {code:java} javadoc:aggregate{code}

[jira] [Comment Edited] (FLINK-35002) GitHub action request timeout to ArtifactService

2024-04-18 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838541#comment-17838541 ] Ryan Skraba edited comment on FLINK-35002 at 4/18/24 8:55 AM: -- I changed

[jira] [Commented] (FLINK-35002) GitHub action request timeout to ArtifactService

2024-04-18 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838541#comment-17838541 ] Ryan Skraba commented on FLINK-35002: - I changed the title; requests to the artifact service can

[jira] [Updated] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Linevich updated FLINK-35154: - Description: Javadoc plugin fails with error "cannot find symbol". Using {code:java}

[jira] [Updated] (FLINK-35154) Javadoc aggregate fails

2024-04-18 Thread Dmitriy Linevich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy Linevich updated FLINK-35154: - Description: Javadoc plugin fails with error. Using {code:java} javadoc:aggregate{code}

[jira] [Commented] (FLINK-35088) watermark alignment maxAllowedWatermarkDrift and updateInterval param need check

2024-04-18 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838543#comment-17838543 ] Martijn Visser commented on FLINK-35088: [~fanrui] What are your thoughts on this? > watermark

[jira] [Updated] (FLINK-35153) Internal Async State Implementation and StateDescriptor for Map/List State

2024-04-18 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35153: Parent: FLINK-34974 Issue Type: Sub-task (was: Bug) > Internal Async State

[jira] [Created] (FLINK-35153) Internal Async State Implementation and StateDescriptor for Map/List State

2024-04-18 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-35153: --- Summary: Internal Async State Implementation and StateDescriptor for Map/List State Key: FLINK-35153 URL: https://issues.apache.org/jira/browse/FLINK-35153 Project:

Re: [PR] [FLINK-35028][runtime] Timer firing under async execution model [flink]

2024-04-18 Thread via GitHub
fredia commented on PR #24672: URL: https://github.com/apache/flink/pull/24672#issuecomment-2063204411 @Zakelly @yunfengzhou-hub Thanks for the detailed review, I updated the PR and addressed some comments, would you please take a look again? -- This is an automated message from the

[jira] [Commented] (FLINK-35151) Flink mysql cdc will stuck when suspend binlog split and ChangeEventQueue is full

2024-04-18 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838499#comment-17838499 ] Leonard Xu commented on FLINK-35151: Thanks [~pacinogong]for the report, [~ruanhang1993] Would you

[jira] [Assigned] (FLINK-35097) Table API Filesystem connector with 'raw' format repeats last line

2024-04-18 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-35097: Assignee: Kumar Mallikarjuna > Table API Filesystem connector with 'raw' format repeats

Re: [PR] [FLINK-35097][table] Fix 'raw' format deserialization [flink]

2024-04-18 Thread via GitHub
twalthr commented on code in PR #24661: URL: https://github.com/apache/flink/pull/24661#discussion_r1570166387 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/formats/raw/RawFormatSerDeSchemaTest.java: ## @@ -197,12 +247,12 @@ public static TestSpec

[jira] [Updated] (FLINK-35153) Internal Async State Implementation and StateDescriptor for Map/List State

2024-04-18 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35153: Component/s: Runtime / State Backends > Internal Async State Implementation and StateDescriptor

Re: [PR] [FLINK-34574] Add CPU and memory size autoscaler quota [flink-kubernetes-operator]

2024-04-18 Thread via GitHub
gaborgsomogyi commented on code in PR #789: URL: https://github.com/apache/flink-kubernetes-operator/pull/789#discussion_r1570203474 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -129,8 +133,10 @@ public boolean scaleResource(

Re: [PR] [FLINK-35115][Connectors/Kinesis] Allow kinesis consumer to snapshotState after operator had been cancelled [flink-connector-aws]

2024-04-18 Thread via GitHub
vahmed-hamdy commented on code in PR #138: URL: https://github.com/apache/flink-connector-aws/pull/138#discussion_r1570201177 ## flink-connector-aws/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java: ## @@ -312,6

Re: [PR] [FLINK-34444] Initial implementation of JM operator metric rest api [flink]

2024-04-18 Thread via GitHub
mas-chen commented on code in PR #24564: URL: https://github.com/apache/flink/pull/24564#discussion_r1570041925 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -1089,6 +1089,37 @@ paths: application/json: schema: $ref:

Re: [PR] [FLINK-35028][runtime] Timer firing under async execution model [flink]

2024-04-18 Thread via GitHub
fredia commented on code in PR #24672: URL: https://github.com/apache/flink/pull/24672#discussion_r1570075307 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java: ## @@ -117,6 +120,7 @@ public class

[jira] [Updated] (FLINK-35152) Flink CDC Doris/Starrocks Sink Auto create table event should support setting auto partition fields for each table

2024-04-18 Thread tumengyao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tumengyao updated FLINK-35152: -- Description: In some scenarios, when creating a physical table in Doris, appropriate partition

Re: [PR] [FLINK-35045][state] Introduce ForStFlinkFileSystem to support reading and writing with ByteBuffer [flink]

2024-04-18 Thread via GitHub
masteryhx commented on code in PR #24632: URL: https://github.com/apache/flink/pull/24632#discussion_r1570109129 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ByteBufferReadableFSDataInputStream.java: ## @@ -0,0 +1,195 @@ +/* + *

Re: [PR] [FLINK-35028][runtime] Timer firing under async execution model [flink]

2024-04-18 Thread via GitHub
fredia commented on code in PR #24672: URL: https://github.com/apache/flink/pull/24672#discussion_r1570140913 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceAsyncImpl.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34444] Initial implementation of JM operator metric rest api [flink]

2024-04-18 Thread via GitHub
mas-chen commented on code in PR #24564: URL: https://github.com/apache/flink/pull/24564#discussion_r1570041925 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -1089,6 +1089,37 @@ paths: application/json: schema: $ref:

Re: [PR] [FLINK-34444] Initial implementation of JM operator metric rest api [flink]

2024-04-18 Thread via GitHub
mas-chen commented on code in PR #24564: URL: https://github.com/apache/flink/pull/24564#discussion_r1570041925 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -1089,6 +1089,37 @@ paths: application/json: schema: $ref:

Re: [PR] [FLINK-31860] FlinkDeployments never finalize when namespace is deleted [flink-kubernetes-operator]

2024-04-18 Thread via GitHub
gyfora merged PR #817: URL: https://github.com/apache/flink-kubernetes-operator/pull/817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2024-04-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31860. -- Fix Version/s: kubernetes-operator-1.9.0 Assignee: Zhou JIANG (was: Jayme Howard)

Re: [PR] [hotfix][values] Temporary fix for ValuesDataSource stuck in infinite loop [flink-cdc]

2024-04-18 Thread via GitHub
lvyanquan commented on PR #3235: URL: https://github.com/apache/flink-cdc/pull/3235#issuecomment-2063146409 Looks like there are other places that use ValueSource with paralism > 1, and I'm trying to find out the reason of this failure. -- This is an automated message from the Apache

Re: [PR] [FLINK-35028][runtime] Timer firing under async execution model [flink]

2024-04-18 Thread via GitHub
fredia commented on code in PR #24672: URL: https://github.com/apache/flink/pull/24672#discussion_r1570100169 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/KeyAccountingUnit.java: ## @@ -32,6 +32,8 @@ */ public class KeyAccountingUnit { +

Re: [PR] [FLINK-35045][state] Introduce ForStFlinkFileSystem to support reading and writing with ByteBuffer [flink]

2024-04-18 Thread via GitHub
masteryhx commented on code in PR #24632: URL: https://github.com/apache/flink/pull/24632#discussion_r1570103838 ## flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStream.java: ## @@ -140,4 +144,43 @@ public void skipFully(long

[jira] [Created] (FLINK-35152) Flink CDC Doris/Starrocks Sink Auto create table event should support setting auto partition fields for each table

2024-04-18 Thread tumengyao (Jira)
tumengyao created FLINK-35152: - Summary: Flink CDC Doris/Starrocks Sink Auto create table event should support setting auto partition fields for each table Key: FLINK-35152 URL:

Re: [PR] [FLINK-35045][state] Introduce ForStFlinkFileSystem to support reading and writing with ByteBuffer [flink]

2024-04-18 Thread via GitHub
masteryhx commented on code in PR #24632: URL: https://github.com/apache/flink/pull/24632#discussion_r1570106555 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ByteBufferReadableFSDataInputStream.java: ## @@ -0,0 +1,210 @@ +/* + *

[jira] [Updated] (FLINK-35152) Flink CDC Doris Sink Auto create table event should support setting auto partition fields for each table

2024-04-18 Thread tumengyao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tumengyao updated FLINK-35152: -- Summary: Flink CDC Doris Sink Auto create table event should support setting auto partition fields

Re: [PR] [FLINK-34633][table] Support unnesting array constants [flink]

2024-04-18 Thread via GitHub
jeyhunkarimov commented on PR #24510: URL: https://github.com/apache/flink/pull/24510#issuecomment-2063179382 Thanks a lot for the review @LadyForest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

<    1   2