[jira] [Commented] (FLINK-629) Add support for null values to the java api

2015-01-20 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283640#comment-14283640 ] Robert Metzger commented on FLINK-629: -- This screenshot from github is related I guess

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/318#discussion_r23212042 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SharedSlot.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (FLINK-629) Add support for null values to the java api

2015-01-20 Thread mustafa elbehery (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mustafa elbehery updated FLINK-629: --- Attachment: Selection_006.png Add support for null values to the java api

[jira] [Assigned] (FLINK-1319) Add static code analysis for UDFs

2015-01-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-1319: --- Assignee: Timo Walther Add static code analysis for UDFs -

[jira] [Assigned] (FLINK-1417) Automatically register nested types at Kryo

2015-01-20 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-1417: - Assignee: Robert Metzger Automatically register nested types at Kryo

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-01-20 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/316#issuecomment-70635445 Looks good. You should add generics or least `?` to `TypeSerializer` in the `PojoSerializer`. My IDE shows me lots of warnings. --- If your project is set up for it, you

[jira] [Commented] (FLINK-1353) Execution always uses DefaultAkkaAskTimeout, rather than the configured value

2015-01-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283731#comment-14283731 ] Till Rohrmann commented on FLINK-1353: -- Good catch. I'll forward the timeout set in

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/326 [FLINK-1201] Add flink-gelly to flink-addons This PR adds an initial version of Gelly, a graph API for Flink, to the flink-addons project. The development of Gelly took place as a collaboration on

[GitHub] flink pull request: [FLINK-1372] [runtime] Fix akka logging

2015-01-20 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/321#issuecomment-70705539 I've tested this and the logging works as before (pre akka), e.g. everything is in the jm/tm log file. :-) Logging of the temp directories got somehow lost on the

[GitHub] flink pull request: [FLINK-1296] Add sorter support for very large...

2015-01-20 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/249#issuecomment-70702082 OK I've rebased this PR on the current master. All tests are running locally (Travis is still flaky). @mxm is running some cluster tests. I'll push to master after his OK.

[GitHub] flink pull request: [FLINK-1147][Java API] TypeInference on POJOs

2015-01-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/315#issuecomment-70723442 I didn't find any issues in the code. Good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/326#discussion_r23252081 --- Diff: flink-addons/flink-gelly/src/main/java/org/apache/flink/gelly/Edge.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70725539 Hi @rmetzger! Thanks for starting on it so fast ^^ Regarding the name, we thought it'd be nice to have one.. It was actually @ktzoumas that came up with Gelly :)

[jira] [Created] (FLINK-1423) No Tags for new release on the github repo

2015-01-20 Thread Carsten Brandt (JIRA)
Carsten Brandt created FLINK-1423: - Summary: No Tags for new release on the github repo Key: FLINK-1423 URL: https://issues.apache.org/jira/browse/FLINK-1423 Project: Flink Issue Type: Task

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70744282 I also prefer flink-graph. After having a quick look at the commits I would suggest to squash a couple of them, e. g. fda6e4c, which is empty or 393902c which

[jira] [Updated] (FLINK-629) Add support for null values to the java api

2015-01-20 Thread mustafa elbehery (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mustafa elbehery updated FLINK-629: --- Attachment: SimpleTweetInputFormat.java Tweet.java Add support for null

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70759342 I'm very exited about this :-) I will have a look later as well. Regarding the name: I like the name gelly, but would also prefer flink-graph (or something along the

[jira] [Commented] (FLINK-629) Add support for null values to the java api

2015-01-20 Thread mustafa elbehery (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284534#comment-14284534 ] mustafa elbehery commented on FLINK-629: It is proper POJO with all the setters and

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70767467 I think Gelly has way more personality than flink-graph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70743431 Woot! :) As for merging the streaming back then, it was @StephanEwen who came up with the solution, pasting the important parts here: BTW: I used

[GitHub] flink pull request: [FLINK-1296] Add sorter support for very large...

2015-01-20 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/249#issuecomment-70758622 Cluster tests worked fine. If no one objects I'll merge this later today. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70796718 +1 for Gelly :) It's good to personalize flink libraries somehow, people remember these. Though, to be honest, it would be more consistent in that case if

[GitHub] flink pull request: Rename coGroupDataSet.scala to CoGroupDataSet....

2015-01-20 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/324#issuecomment-70715529 I rename the file from coGroupDataSet.scala to CoGroupDataSet.scala and crossDataSet.scala to CrossDataSet.scala to follow convention Scala file naming. And move

[jira] [Resolved] (FLINK-1372) TaskManager and JobManager do not log startup settings any more

2015-01-20 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-1372. Resolution: Fixed Fixed in 4e197d5..ce8acc4 TaskManager and JobManager do not log startup

[jira] [Created] (FLINK-1422) Missing usage example for withParameters

2015-01-20 Thread Alexander Alexandrov (JIRA)
Alexander Alexandrov created FLINK-1422: --- Summary: Missing usage example for withParameters Key: FLINK-1422 URL: https://issues.apache.org/jira/browse/FLINK-1422 Project: Flink Issue

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/326#discussion_r23248831 --- Diff: flink-addons/flink-gelly/src/test/java/org/apache/flink/gelly/test/TestWeaklyConnected.java --- @@ -0,0 +1,143 @@ +/* + * Licensed to the

[GitHub] flink pull request: Implement the convenience methods count and co...

2015-01-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/210#issuecomment-70718732 I've implemented count and collect in the Scala API. There is still a problem with the `ListAccumulator` for non-primitive Objects (e.g. not Integer or Long) probably due to

[GitHub] flink pull request: [FLINK-1372] [runtime] Fix akka logging

2015-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70717064 Great, I'm super excited to see the graph API being offered to the main project. I'll start reviewing the code right away, to merge it as soon as possible.