[GitHub] flink pull request: Flink-3196: InputStream should be closed in En...

2016-01-26 Thread smarthi
GitHub user smarthi opened a pull request: https://github.com/apache/flink/pull/1552 Flink-3196: InputStream should be closed in EnvironmentInformation#ge… …tRevisionInformation() You can merge this pull request into a Git repository by running: $ git pull https://github.co

[jira] [Commented] (FLINK-3135) Add chainable driver for UNARY_NO_OP strategy

2016-01-26 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118624#comment-15118624 ] ramkrishna.s.vasudevan commented on FLINK-3135: --- Thank you. > Add chainable

[jira] [Reopened] (FLINK-3135) Add chainable driver for UNARY_NO_OP strategy

2016-01-26 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan reopened FLINK-3135: --- Assignee: ramkrishna.s.vasudevan Reopening for changing the assignment. Will

[jira] [Closed] (FLINK-3135) Add chainable driver for UNARY_NO_OP strategy

2016-01-26 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan closed FLINK-3135. - Resolution: Fixed > Add chainable driver for UNARY_NO_OP strategy > --

[jira] [Assigned] (FLINK-3179) Combiner is not injected if Reduce or GroupReduce input is explicitly partitioned

2016-01-26 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan reassigned FLINK-3179: - Assignee: ramkrishna.s.vasudevan > Combiner is not injected if Reduce or

[jira] [Resolved] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-26 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li resolved FLINK-2871. -- Resolution: Fixed Fix Version/s: 1.0.0 > Add OuterJoin strategy with HashTable on outer s

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118587#comment-15118587 ] ASF GitHub Bot commented on FLINK-2871: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118558#comment-15118558 ] ASF GitHub Bot commented on FLINK-3282: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-26 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-175365963 Just curious, about the merging the PR, the way i know is that, checkout the tableOnCalcite, apply the patch, commit and push to flink repo, is this the way how you

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118527#comment-15118527 ] ASF GitHub Bot commented on FLINK-3282: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-26 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-175360681 @fhueske , yes, i just remove the method in `FlinkRelNode` as java interface only allow public method, just forgot to change the methods in implemented FlinkRelNode

[jira] [Created] (FLINK-3293) Custom Application Name on YARN is ignored in deploy jobmanager mode

2016-01-26 Thread Johannes (JIRA)
Johannes created FLINK-3293: --- Summary: Custom Application Name on YARN is ignored in deploy jobmanager mode Key: FLINK-3293 URL: https://issues.apache.org/jira/browse/FLINK-3293 Project: Flink Iss

[jira] [Commented] (FLINK-1885) Bulk mode for gelly

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118209#comment-15118209 ] ASF GitHub Bot commented on FLINK-1885: --- Github user markus-h closed the pull reques

[GitHub] flink pull request: [FLINK-1885] [gelly] Added bulk execution mode...

2016-01-26 Thread markus-h
Github user markus-h closed the pull request at: https://github.com/apache/flink/pull/598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (FLINK-3292) Bug in flink-jdbc. Not all JDBC drivers supported

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117913#comment-15117913 ] ASF GitHub Bot commented on FLINK-3292: --- GitHub user sbcd90 opened a pull request:

[GitHub] flink pull request: [FLINK-3292]Fix for Bug in flink-jdbc. Not all...

2016-01-26 Thread sbcd90
GitHub user sbcd90 opened a pull request: https://github.com/apache/flink/pull/1551 [FLINK-3292]Fix for Bug in flink-jdbc. Not all JDBC drivers supported Hello, Here is the fix for issue FLINK-3292. Kindly review & merge. Thanks & regards, Subhobrata You can me

[jira] [Created] (FLINK-3292) Bug in flink-jdbc. Not all JDBC drivers supported

2016-01-26 Thread Subhobrata Dey (JIRA)
Subhobrata Dey created FLINK-3292: - Summary: Bug in flink-jdbc. Not all JDBC drivers supported Key: FLINK-3292 URL: https://issues.apache.org/jira/browse/FLINK-3292 Project: Flink Issue Type:

[jira] [Commented] (FLINK-2933) Flink scala libraries exposed with maven should carry scala version

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117647#comment-15117647 ] ASF GitHub Bot commented on FLINK-2933: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-175143232 Rebased and squashed commits. For the documentation, I will update all unsuffixed module references with a Scala suffix variable. For example, flink-streaming-java

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117567#comment-15117567 ] ASF GitHub Bot commented on FLINK-3282: --- Github user fhueske commented on the pull r

[jira] [Updated] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-01-26 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-3291: --- Component/s: Distributed Runtime > Object reuse bug in MergeIterator.HeadStream.nextHead > ---

[jira] [Created] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-01-26 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-3291: -- Summary: Object reuse bug in MergeIterator.HeadStream.nextHead Key: FLINK-3291 URL: https://issues.apache.org/jira/browse/FLINK-3291 Project: Flink Issue Type: B

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-175119125 @ChengXiangLi, actually I proposed to make all methods other than `translateToPlan()` private methods. If the Flink RelNodes directly return the DataSet program, we do n

[jira] [Assigned] (FLINK-3215) Add CEP library to Flink

2016-01-26 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-3215: Assignee: Till Rohrmann > Add CEP library to Flink > > >

[GitHub] flink pull request:

2016-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/commit/a7d4334f1843fd341be49605c2814e01bc786ccf#commitcomment-15678832 Should we add a checkstyle rule to not allow `junit.framework` imports? --- If your project is set up for it, you can reply to this em

[GitHub] flink pull request:

2016-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/a7d4334f1843fd341be49605c2814e01bc786ccf#commitcomment-15679008 That's a good idea! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [hotfix]: remove references to deprecated juni...

2016-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1539#issuecomment-175042991 Thanks for your contribution @smarthi :-) Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] flink pull request: [hotfix]: remove references to deprecated juni...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request:

2016-01-26 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/commit/dd4e278545182f0d4cbf403911f550c1badde125#commitcomment-15677128 I can further improve the examples using `case classes` in the Scala example. Doing it while retaining the usage of inherita

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-175001442 Can't you use it again? On Tue, Jan 26, 2016 at 1:48 PM, Ronny Bräunlich wrote: > We used scikit-learn as a reference. > > > Am 26.

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread rbraeunlich
Github user rbraeunlich commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174997159 We used scikit-learn as a reference. Am 26.01.2016 um 21:36 schrieb Till Rohrmann : > How have you done it in the first place for the poems? Don'

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117138#comment-15117138 ] ASF GitHub Bot commented on FLINK-2021: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174991021 Good point! When the example was added, only Tuples were supported by CsvInputFormats. In the meantime, we Pojo support was added for CsvInputFormats. IMO, it makes sens

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174988478 How have you done it in the first place for the poems? Don't you have an automatic tool for that? On Tue, Jan 26, 2016 at 1:21 PM, Ronny Bräunlich w

[jira] [Closed] (FLINK-3233) PartitionOperator does not support expression keys on atomic types

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3233. Resolution: Fixed Fixed with af029e7e0c6377ec12edafedb4d6ea53c4fa9fe9 > PartitionOperator does not

[jira] [Closed] (FLINK-1666) Clean-up Field Expression Code

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-1666. Resolution: Done Fix Version/s: 1.0.0 Done with af029e7e0c6377ec12edafedb4d6ea53c4fa9fe9 > C

[jira] [Resolved] (FLINK-1903) Joins where one side uses a field more than once don't work

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske resolved FLINK-1903. -- Resolution: Fixed Fix Version/s: 1.0.0 Fixed with af029e7e0c6377ec12edafedb4d6ea53c4fa9fe

[jira] [Updated] (FLINK-3198) Rename Grouping.getDataSet() method and add JavaDocs

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-3198: - Fix Version/s: (was: 0.10.2) > Rename Grouping.getDataSet() method and add JavaDocs >

[jira] [Closed] (FLINK-3198) Rename Grouping.getDataSet() method and add JavaDocs

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3198. Resolution: Fixed Fixed with 902d420e1a2322fa5ef516716ff10837a6e36ce8 > Rename Grouping.getDataSet(

[jira] [Closed] (FLINK-3289) Double reference to flink-contrib

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-3289. Resolution: Fixed Fixed with 1e67a05960b645d06628bd19a9063a88dab98a44 > Double reference to flink-c

[jira] [Closed] (FLINK-1045) Remove Combinable Annotation

2016-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-1045. Resolution: Implemented Implemented with 5914e9ab3fa8e8be8fff9d7e6c10d612af7e27cf > Remove Combinab

[jira] [Commented] (FLINK-1045) Remove Combinable Annotation

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117116#comment-15117116 ] ASF GitHub Bot commented on FLINK-1045: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-3198) Rename Grouping.getDataSet() method and add JavaDocs

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117118#comment-15117118 ] ASF GitHub Bot commented on FLINK-3198: --- Github user asfgit closed the pull request

[GitHub] flink pull request: FLINK-3198: Renames and documents the getDataS...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3289) Double reference to flink-contrib

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117117#comment-15117117 ] ASF GitHub Bot commented on FLINK-3289: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-1666) Clean-up Field Expression Code

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117115#comment-15117115 ] ASF GitHub Bot commented on FLINK-1666: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3289] References to flink-contrib merge...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-1666] [FLINK-1903] [FLINK-3233] Refacto...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-1045] Remove Combinable annotation.

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread rbraeunlich
Github user rbraeunlich commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174979030 Somebody has to do the new calculations. I suppose that'll be the biggest amount of work. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174977804 Would this involve too much work? On Tue, Jan 26, 2016 at 12:03 PM, Ronny Bräunlich wrote: > Well, one test would have to be changed. That tes

[jira] [Updated] (FLINK-3290) [py] Generalize OperationInfo transfer

2016-01-26 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-3290: Issue Type: Improvement (was: Bug) > [py] Generalize OperationInfo transfer > -

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174966751 This can be a starting point for further discussion. The only weak point I see (but maybe I'm wrong) is that right now we're reading `Tuple`s and then converting

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117086#comment-15117086 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on the

[jira] [Created] (FLINK-3290) [py] Generalize OperationInfo transfer

2016-01-26 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-3290: --- Summary: [py] Generalize OperationInfo transfer Key: FLINK-3290 URL: https://issues.apache.org/jira/browse/FLINK-3290 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [hotfix] Fix interaction of Async calls/checkp...

2016-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1532#issuecomment-174965038 Very good fix, +1 to merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3270] Add Kafka example

2016-01-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1533#issuecomment-174964868 Not quite sure about adding examples for the connectors to the examples project. If we do that for all connectors, it becomes heavily loaded with dependencies.

[jira] [Commented] (FLINK-3270) Add example for reading and writing to Kafka

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117083#comment-15117083 ] ASF GitHub Bot commented on FLINK-3270: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117072#comment-15117072 ] ASF GitHub Bot commented on FLINK-2021: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174962013 Thanks @stefanobaghino! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117070#comment-15117070 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on the

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174960226 I'll edit the code so that we can all read the result and maybe discuss about the pros and cons of this approach. Again, thank you both for the feedback. --- If

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117069#comment-15117069 ] ASF GitHub Bot commented on FLINK-2021: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174959098 The examples handle inputs differently than most other DataSet programs because they use default input data if no input paths are specified. This adds complexity which i

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread rbraeunlich
Github user rbraeunlich commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174957852 Well, one test would have to be changed. That test currently reads the values from ```poems_out.txt```, orders them and compares them afterwards with the calculated n

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174956562 Yep, that is still to do alongside with the mailing list announcement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-2933) Flink scala libraries exposed with maven should carry scala version

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117061#comment-15117061 ] ASF GitHub Bot commented on FLINK-2933: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174955141 What do you mean with rewriting the tests? It would mean to re-calculate the tfidf values, right? Would this mean a lot of work? On Tue, Jan 26, 2016 at 1

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117057#comment-15117057 ] ASF GitHub Bot commented on FLINK-2021: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174953115 I don't really see the points of encapsulating parts of the examples into methods: Usually, methods are used when functionality is used in different places. In this cas

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174951427 Maybe I can rework the example so that secondary needs (like parameter parsing and source reading) are encapsulated in functions kept at the bottom, while eventua

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117052#comment-15117052 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on the

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174950907 Right, but this is boilerplate code would still be accessible at the bottom of the file. It is not gone. --- If your project is set up for it, you can reply to this ema

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117050#comment-15117050 ] ASF GitHub Bot commented on FLINK-2021: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117048#comment-15117048 ] ASF GitHub Bot commented on FLINK-2021: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174950736 I think its important that users also see how to read data from sources. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117046#comment-15117046 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on the

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117047#comment-15117047 ] ASF GitHub Bot commented on FLINK-2021: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174950409 Sorry for the late notice, but why did we move the code to fetch the data to the top of the main function? IMO, it distracts from the main part of the example code,

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174950384 Good, I'll keep on working on the PR with the other examples, thank you for the feedback and for the guidance provided so far. :smiley: --- If your project is s

[jira] [Commented] (FLINK-2933) Flink scala libraries exposed with maven should carry scala version

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117044#comment-15117044 ] ASF GitHub Bot commented on FLINK-2933: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174948935 I think we should also update the documentation along with the change! --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread rbraeunlich
Github user rbraeunlich commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174947692 Well, writing our own poems would result in rewriting the tests... Does the checkstyle plugin maybe expect public domain header in a certain format? --- If your

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117043#comment-15117043 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1469#issuecomment-174946482 Thanks for the update @ChengXiangLi! PR is good to merge, IMO. Do you want to do it yourself? --- If your project is set up for it, you can reply to this e

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117042#comment-15117042 ] ASF GitHub Bot commented on FLINK-2021: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1536#issuecomment-174946246 Okay, since nobody objected on the mailing list, we can start changing all examples. --- If your project is set up for it, you can reply to this email and have your re

[jira] [Updated] (FLINK-3276) Move runtime parts of flink-streaming-java to flink-runtime

2016-01-26 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3276: -- Assignee: (was: Maximilian Michels) > Move runtime parts of flink-streaming-java to

[jira] [Updated] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2016-01-26 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3273: -- Assignee: (was: Maximilian Michels) > Remove Scala dependency from flink-streaming-j

[jira] [Updated] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2016-01-26 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3273: -- Issue Type: Improvement (was: Sub-task) Parent: (was: FLINK-2940) > Remove

[jira] [Commented] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2016-01-26 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117039#comment-15117039 ] Maximilian Michels commented on FLINK-3273: --- As per mailing list discussion, we'

[jira] [Updated] (FLINK-3273) Remove Scala dependency from flink-streaming-java

2016-01-26 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3273: -- Priority: Major (was: Critical) > Remove Scala dependency from flink-streaming-java > -

[jira] [Updated] (FLINK-3262) Remove fuzzy versioning from Bower dependencies

2016-01-26 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3262: -- Fix Version/s: 1.0.0 > Remove fuzzy versioning from Bower dependencies > ---

[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117030#comment-15117030 ] ASF GitHub Bot commented on FLINK-3265: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-3265] Make RabbitMQ source threadsafe

2016-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1534#issuecomment-174941767 Thanks for the pull request. +1 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] flink pull request: [Flink-1999] basic TfidfTransformer

2016-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/730#issuecomment-174940437 Hmm according to http://www.apache.org/legal/resolved.html#can-works-placed-in-the-public-domain-be-included-in-apache-products, it should be no problem to include w

[jira] [Commented] (FLINK-3282) Add FlinkRelNode interface.

2016-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117007#comment-15117007 ] ASF GitHub Bot commented on FLINK-3282: --- Github user twalthr commented on the pull r

[GitHub] flink pull request: [FLINK-3282] Add FlinkRelNode interface.

2016-01-26 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/1544#issuecomment-174936146 Thanks for the refactoring. IMO I think we can remove the "Flink" prefix if we use DataSet/DataStream as prefix. Maybe it makes sense to add a `TranslationContext` param

[GitHub] flink pull request: Removed spark repl detection code from closure...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

  1   2   >