[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461048 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java --- @@ -100,340 +101,371 @@ @Test

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2016-02-10 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-182393013 @tillrohrmann just updated this. Let's see if you think it is ready now... ;) --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-3356) JobClientActorRecoveryITCase.testJobClientRecovery

2016-02-10 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140840#comment-15140840 ] Matthias J. Sax commented on FLINK-3356: https://travis-ci.org/mjsax/flink/jobs/108263582 >

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52466304 --- Diff: flink-contrib/flink-statebackend-redis/src/test/java/org/apache/flink/contrib/streaming/state/RedisStateBackendTest.java --- @@ -0,0 +1,60 @@

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140907#comment-15140907 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140904#comment-15140904 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on the pull request:

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52468108 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java --- @@ -0,0 +1,374 @@ +/**

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140934#comment-15140934 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52470915 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java --- @@ -102,7 +102,7 @@ public void

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140970#comment-15140970 ] ASF GitHub Bot commented on FLINK-2991: --- Github user aljoscha commented on the pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140972#comment-15140972 ] ASF GitHub Bot commented on FLINK-3035: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1617#issuecomment-182424633 @aljoscha @rmetzger Should we move this discussion to the mailing list? @sbcd90 are you following dev-mailing list? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461236 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReduceHashTableTest.java --- @@ -0,0 +1,501 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461306 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-3372] Setting custom YARN application n...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1607#issuecomment-182391843 Will add this as well to 0.10-SNAPSHOT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-3372) Setting custom YARN application name is ignored

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140830#comment-15140830 ] ASF GitHub Bot commented on FLINK-3372: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140833#comment-15140833 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3226] Translate logical aggregations to...

2016-02-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1600#issuecomment-182392029 I've rebased this one on top of `tableOnCalcite` which includes #1595. Regarding the average aggregate, I went for @tillrohrmann's suggestion of adding 0.5. That

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140834#comment-15140834 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52461281 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-3372] Setting custom YARN application n...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1607#issuecomment-182391709 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1517#issuecomment-182398031 Hi @ggevay, sorry it took me very long to review your PR. As I said before, this is a very desirable feature and a solid implementation. I think a few

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-10 Thread twalthr
Github user twalthr closed the pull request at: https://github.com/apache/flink/pull/1595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52466186 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java --- @@ -0,0 +1,374 @@ +/**

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52468737 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisListState.java --- @@ -0,0 +1,167 @@ +/**

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52468882 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java --- @@ -0,0 +1,374 @@

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140943#comment-15140943 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52471114 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java --- @@ -100,340 +101,371 @@ @Test

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140978#comment-15140978 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140977#comment-15140977 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140823#comment-15140823 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460829 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460943 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java --- @@ -102,7 +102,7 @@ public void

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52464062 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140895#comment-15140895 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140897#comment-15140897 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140898#comment-15140898 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140896#comment-15140896 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140939#comment-15140939 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140958#comment-15140958 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52469979 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140990#comment-15140990 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on the pull request:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459151 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java --- @@ -83,6 +83,7 @@ protected

[GitHub] flink pull request: [docs] Fixed typo in Storm Compatibility page

2016-02-10 Thread geoand
Github user geoand commented on the pull request: https://github.com/apache/flink/pull/1618#issuecomment-182386278 You're welcome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140788#comment-15140788 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140797#comment-15140797 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3372] Setting custom YARN application n...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1607#issuecomment-182393690 Actually, this is only relevant for 0.10-SNAPSHOT, 1.0-SNAPSHOT has this behavior already --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-3260) ExecutionGraph gets stuck in state FAILING

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140874#comment-15140874 ] ASF GitHub Bot commented on FLINK-3260: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3377] Remove final flag from ResultPart...

2016-02-10 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1609#issuecomment-182398308 Can share why you want to make this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52465387 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisListState.java --- @@ -0,0 +1,167 @@ +/**

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52465448 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisValueState.java --- @@ -0,0 +1,141 @@ +/**

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52465416 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140893#comment-15140893 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52465412 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisReducingState.java --- @@ -0,0 +1,157 @@ +/**

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52468562 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java --- @@ -0,0 +1,374 @@ +/**

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52470557 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52472588 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141005#comment-15141005 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141015#comment-15141015 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460226 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140808#comment-15140808 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140826#comment-15140826 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3372) Setting custom YARN application name is ignored

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140847#comment-15140847 ] ASF GitHub Bot commented on FLINK-3372: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52463167 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Resolved] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-10 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3373. - Resolution: Fixed Assignee: Stephan Ewen Fix Version/s: 1.0.0 The HTTP components

[jira] [Closed] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-10 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3373. --- > Using a newer library of Apache HttpClient than 4.2.6 will get class loading > problems >

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140908#comment-15140908 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140920#comment-15140920 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140941#comment-15140941 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52468705 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisListState.java --- @@ -0,0 +1,167 @@ +/**

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52468711 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1605#discussion_r52469417 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java --- @@ -0,0 +1,175 @@

[jira] [Commented] (FLINK-3035) Redis as State Backend

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140949#comment-15140949 ] ASF GitHub Bot commented on FLINK-3035: --- Github user mjsax commented on the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140969#comment-15140969 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3332] Cassandra connector

2016-02-10 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/1620 [FLINK-3332] Cassandra connector This PR adds an Exactly-Once Cassandra Sink. The Exactly-once guarantee is made by saving incoming records in the OperatorState, and only committing them

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-10 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1605#issuecomment-182421429 I addressed the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-3332) Provide an exactly-once Cassandra connector

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140971#comment-15140971 ] ASF GitHub Bot commented on FLINK-3332: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1617#issuecomment-182421979 Yes @mjsax you have the right ideas here. :smile: Those are the things that need to be figured out. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52473636 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [docs] Fixed typo in Storm Compatibility page

2016-02-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52458969 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java --- @@ -52,6 +52,30 @@ */ public class

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459830 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140798#comment-15140798 ] ASF GitHub Bot commented on FLINK-3373: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460590 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java --- @@ -0,0 +1,1014 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140818#comment-15140818 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3226] Implement a CodeGenerator for an ...

2016-02-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1595#issuecomment-182390675 Hey @twalthr, I merged this yesterday but the PR didn't automatically close. Could you please close it manually? Thanks! --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460659 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java --- @@ -52,6 +52,30 @@ */ public class

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52460684 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java --- @@ -45,9 +45,12 @@ public

[jira] [Commented] (FLINK-2915) JobManagerProcessFailureBatchRecoveryITCase

2016-02-10 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140844#comment-15140844 ] Matthias J. Sax commented on FLINK-2915: https://travis-ci.org/apache/flink/jobs/108263590 >

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140842#comment-15140842 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull request:

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140860#comment-15140860 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1617#issuecomment-182404055 We cannot have binary files in an release (ie, `redis-server-2.8.19` in resource folder). Need to figure out to deal with this. Of course, you need also to fix

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1617#discussion_r52467132 --- Diff: flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java --- @@ -0,0 +1,374 @@ +/**

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140937#comment-15140937 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52468223 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140951#comment-15140951 ] ASF GitHub Bot commented on FLINK-2991: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-10 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1617#issuecomment-182416665 I just put a few initial comments. Before you update this, we need to figure out, how to deal with Redis server (ie, single server for each job, shared server for

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52471392 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-02-10 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r52459053 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java --- @@ -45,9 +45,12 @@ public

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140784#comment-15140784 ] ASF GitHub Bot commented on FLINK-2237: --- Github user fhueske commented on a diff in the pull

  1   2   3   >