[jira] [Commented] (FLINK-3367) Annotate all user-facing API classes with @Public or @PublicEvolving

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145492#comment-15145492 ] ASF GitHub Bot commented on FLINK-3367: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-12 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1606#issuecomment-183517665 Updated and rebased the PR. Any objections to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-3393) ExternalProcessRunner wait to finish copying error stream

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145389#comment-15145389 ] ASF GitHub Bot commented on FLINK-3393: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3393] [core] ExternalProcessRunner wait...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1630#issuecomment-183506103 I merged it. Could you please close the PR if github doesn't. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Resolved] (FLINK-3393) ExternalProcessRunner wait to finish copying error stream

2016-02-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-3393. - Resolution: Fixed Fix Version/s: 1.0.0 Fixed in https://github.com/apache/flink/co

[jira] [Resolved] (FLINK-3359) Make RocksDB file copies asynchronous

2016-02-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-3359. - Resolution: Fixed Implemented in https://github.com/apache/flink/commit/31310cd657381d403

[jira] [Resolved] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-3352. - Resolution: Fixed Fix Version/s: 1.0.0 Fixed in https://github.com/apache/flink/co

[jira] [Commented] (FLINK-3359) Make RocksDB file copies asynchronous

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145378#comment-15145378 ] ASF GitHub Bot commented on FLINK-3359: --- Github user aljoscha closed the pull reques

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145377#comment-15145377 ] ASF GitHub Bot commented on FLINK-3352: --- Github user aljoscha closed the pull reques

[GitHub] flink pull request: [FLINK-3359] Make RocksDB File Copies Asynchro...

2016-02-12 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1631 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Commented] (FLINK-3396) Job submission Savepoint restore logic flawed

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145312#comment-15145312 ] ASF GitHub Bot commented on FLINK-3396: --- GitHub user uce opened a pull request:

[GitHub] flink pull request: [FLINK-3396] [runtime] Fail job submission aft...

2016-02-12 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/1633 [FLINK-3396] [runtime] Fail job submission after state restore failure If state restore fails during job graph submission, the submitting client never gets notified about the submission failure. For det

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145227#comment-15145227 ] ASF GitHub Bot commented on FLINK-3226: --- GitHub user vasia opened a pull request:

[GitHub] flink pull request: [FLINK-3226] Translate logical joins to physic...

2016-02-12 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1632 [FLINK-3226] Translate logical joins to physical This PR contains the logical to physical translation for joins. - Joins with equality conditions only do not generate a join function. - Joins w

[jira] [Created] (FLINK-3396) Job submission Savepoint restore logic flawed

2016-02-12 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3396: -- Summary: Job submission Savepoint restore logic flawed Key: FLINK-3396 URL: https://issues.apache.org/jira/browse/FLINK-3396 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-3395) Polishing the web UI

2016-02-12 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-3395: - Summary: Polishing the web UI Key: FLINK-3395 URL: https://issues.apache.org/jira/browse/FLINK-3395 Project: Flink Issue Type: Improvement Components: We

[jira] [Resolved] (FLINK-3392) Unprotected access to elements in ClosableBlockingQueue#size()

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3392. - Resolution: Fixed Fix Version/s: 1.0.0 Fixed via c47cb7af1474b08ee1b7b7a813d03da022015ed1

[jira] [Closed] (FLINK-3392) Unprotected access to elements in ClosableBlockingQueue#size()

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-3392. --- > Unprotected access to elements in ClosableBlockingQueue#size() > ---

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144971#comment-15144971 ] ASF GitHub Bot commented on FLINK-3352: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1631#issuecomment-183432667 Ahhh, rebased on latest master changes again (folding window state...). :sweat_smile: --- If your project is set up for it, you can reply to this email and have your

[jira] [Assigned] (FLINK-3392) Unprotected access to elements in ClosableBlockingQueue#size()

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen reassigned FLINK-3392: --- Assignee: Stephan Ewen > Unprotected access to elements in ClosableBlockingQueue#size() > ---

[jira] [Commented] (FLINK-3392) Unprotected access to elements in ClosableBlockingQueue#size()

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144959#comment-15144959 ] Stephan Ewen commented on FLINK-3392: - You are right, it is not primitive. I looked at

[jira] [Closed] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2991. --- > Extend Window Operators to Allow Efficient Fold Operation >

[jira] [Resolved] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2991. - Resolution: Fixed Fix Version/s: 1.0.0 Fixed via 94cba8998c726092e2cc80fd022ca40bf0c38ec2

[jira] [Commented] (FLINK-3393) ExternalProcessRunner wait to finish copying error stream

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144953#comment-15144953 ] ASF GitHub Bot commented on FLINK-3393: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-2991) Extend Window Operators to Allow Efficient Fold Operation

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144952#comment-15144952 ] ASF GitHub Bot commented on FLINK-2991: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3393] [core] ExternalProcessRunner wait...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1630#issuecomment-183428695 Thanks for the fix. I'll merge as soon as travis is all green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2991] Add Folding State and use in Wind...

2016-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1605 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144911#comment-15144911 ] ASF GitHub Bot commented on FLINK-3352: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1631#issuecomment-183422654 The two jobs have separate directories, so the would not interfere, correct? --- If your project is set up for it, you can reply to this email and have your reply ap

[jira] [Commented] (FLINK-3368) Kafka 0.8 consumer fails to recover from broker shutdowns

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144906#comment-15144906 ] ASF GitHub Bot commented on FLINK-3368: --- Github user ndimiduk commented on the pull

[GitHub] flink pull request: [FLINK-3368][Kafka 0.8] Handle leader changes ...

2016-02-12 Thread ndimiduk
Github user ndimiduk commented on the pull request: https://github.com/apache/flink/pull/1623#issuecomment-183421908 My timeline for adopting Flink 1.0 depends heavily on the amount of code change required to adopt. I haven't looked closely at my exposure to API and dependency c

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1631#issuecomment-183418609 We could write it only once, but is it worth it? It would require piping another parameter through all the rocksdb related classes and I would assume there is only one

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144884#comment-15144884 ] ASF GitHub Bot commented on FLINK-3352: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-3296) DataStream.write*() methods are not flushing properly

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144868#comment-15144868 ] ASF GitHub Bot commented on FLINK-3296: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3296] Remove 'flushing' behavior of the...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1563#issuecomment-183414977 I think the `writeOutputFormat` method name could be misleading. To me it implies writing the `OutputFormat` not writing something by using the `OutputFormat`. --- If

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144866#comment-15144866 ] ASF GitHub Bot commented on FLINK-3352: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144865#comment-15144865 ] ASF GitHub Bot commented on FLINK-3352: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1631#issuecomment-183414734 Otherwise, looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1631#issuecomment-183414679 Does it make sense to write the config once in the `RocksDBStateBackend.initializeForJob()` rather than in every state? --- If your project is set up for it, you c

[jira] [Commented] (FLINK-3352) RocksDB Backend cannot determine correct hdfs path

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144847#comment-15144847 ] ASF GitHub Bot commented on FLINK-3352: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1631 [FLINK-3352] Use HDFS Config in RocksDB Copy Utilities This also moves the utilities (HDFSCopyFromLocal and HDFSCopyToLocal) to the RocksDB package because we would need a HDFS dependency in

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144815#comment-15144815 ] Stephan Ewen commented on FLINK-3291: - What I quoted there was the initial contract. I

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144823#comment-15144823 ] Gabor Gevay commented on FLINK-3291: I tried to do that, but with the one I came up wi

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144821#comment-15144821 ] Stephan Ewen commented on FLINK-3291: - Just saying that this contract is not carved in

[jira] [Updated] (FLINK-3394) Clear up the contract of MutableObjectIterator.next(reuse)

2016-02-12 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-3394: --- Description: {{MutableObjectIterator.next(reuse)}} has the following contract (according to [~Stephan

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144809#comment-15144809 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2016-02-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183400616 Updated. I did not take your last two comments about `@SuppressWarnings` and `@SuppressWarnings("serial")` because this commit should not touch those files (not unrelated c

[jira] [Created] (FLINK-3394) Clear up the contract of MutableObjectIterator.next(reuse)

2016-02-12 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-3394: -- Summary: Clear up the contract of MutableObjectIterator.next(reuse) Key: FLINK-3394 URL: https://issues.apache.org/jira/browse/FLINK-3394 Project: Flink Issue Ty

[jira] [Updated] (FLINK-3394) Clear up the contract of MutableObjectIterator.next(reuse)

2016-02-12 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-3394: --- Fix Version/s: 1.0.0 > Clear up the contract of MutableObjectIterator.next(reuse) > --

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2016-02-12 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183390556 Alright, will do. On Fri, Feb 12, 2016 at 5:10 PM, Matthias J. Sax wrote: > About vendor.css etc (I guess I did not commit after the last run of

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144765#comment-15144765 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-3393) ExternalProcessRunner wait to finish copying error stream

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144759#comment-15144759 ] ASF GitHub Bot commented on FLINK-3393: --- GitHub user greghogan opened a pull request

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144757#comment-15144757 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-3340] [runtime] Fix object juggling in ...

2016-02-12 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1626#issuecomment-183390101 OK, after Stephan's comment on FLINK-3291, I agree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-3340) Fix object juggling in drivers

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144761#comment-15144761 ] ASF GitHub Bot commented on FLINK-3340: --- Github user ggevay commented on the pull re

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2016-02-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183389977 About vendor.css etc (I guess I did not commit after the last run of gulp), so the committed version are dirty... It worked for me -- I guess it would be required that you

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144754#comment-15144754 ] ASF GitHub Bot commented on FLINK-2111: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144755#comment-15144755 ] Gabor Gevay commented on FLINK-3291: {quote} The initial idea of a contract for Mutabl

[GitHub] flink pull request: [FLINK-3393] [core] ExternalProcessRunner wait...

2016-02-12 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1630 [FLINK-3393] [core] ExternalProcessRunner wait to finish copying error stream You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[jira] [Commented] (FLINK-3340) Fix object juggling in drivers

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144753#comment-15144753 ] ASF GitHub Bot commented on FLINK-3340: --- Github user greghogan commented on the pull

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2016-02-12 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183389629 Let us squash them, once we merge the PR. Otherwise changes are hard to track. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] flink pull request: [FLINK-3340] [runtime] Fix object juggling in ...

2016-02-12 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1626#issuecomment-183389185 `MergeIterator.next(reuse)` should allow object swapping. The source code documentation should be improved to make this clearer, but this contract is necessary to mini

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144735#comment-15144735 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull req

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2016-02-12 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-183382789 I will merge your PR and take care of the other issues you mentioned. Should I squash afterwards to get a potential final state of this PR that we might merge? --- If you

[jira] [Comment Edited] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144732#comment-15144732 ] Greg Hogan edited comment on FLINK-3291 at 2/12/16 3:48 PM: I

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144732#comment-15144732 ] Greg Hogan commented on FLINK-3291: --- I started looking at `MergeIterator` last year sinc

[GitHub] flink pull request: [FLINK-3340] [runtime] Fix object juggling in ...

2016-02-12 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1626#issuecomment-183375884 Sorry, but I don't think it is independent, because the bug in the reduce drivers could alternatively be fixed by saying that the bug is actually not in the reduce driver

[jira] [Commented] (FLINK-3340) Fix object juggling in drivers

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144710#comment-15144710 ] ASF GitHub Bot commented on FLINK-3340: --- Github user ggevay commented on the pull re

[jira] [Comment Edited] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144654#comment-15144654 ] Stephan Ewen edited comment on FLINK-3291 at 2/12/16 2:51 PM: --

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-02-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144654#comment-15144654 ] Stephan Ewen commented on FLINK-3291: - Thanks, @Greg and [~ggevay] for looking into th

[GitHub] flink pull request: [FLINK-3296] Remove 'flushing' behavior of the...

2016-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1563#issuecomment-183356403 Thank you for the review. I've addressed the comments and rebased the change. Once travis has passed, I'll merge it! --- If your project is set up for it, you

[jira] [Commented] (FLINK-3296) DataStream.write*() methods are not flushing properly

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144642#comment-15144642 ] ASF GitHub Bot commented on FLINK-3296: --- Github user rmetzger commented on the pull

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144622#comment-15144622 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3226] Translation from and to POJOs for...

2016-02-12 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1624#issuecomment-183349741 Thanks @twalthr, the PR looks pretty good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-3340) Fix object juggling in drivers

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144619#comment-15144619 ] ASF GitHub Bot commented on FLINK-3340: --- Github user greghogan commented on the pull

[GitHub] flink pull request: [FLINK-3340] [runtime] Fix object juggling in ...

2016-02-12 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1626#issuecomment-183348625 Hi, @ggevay, these fixes to the reduce drivers are independent of changes to `MutableObjectIterator`. This patch is intended to fix the bug you reported in [FLINK-3291

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144611#comment-15144611 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3270) Add example for reading and writing to Kafka

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144609#comment-15144609 ] ASF GitHub Bot commented on FLINK-3270: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-3270) Add example for reading and writing to Kafka

2016-02-12 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3270. --- Resolution: Fixed Fix Version/s: 1.0.0 Resolved in http://git-wip-us.apache.org/repos/a

[GitHub] flink pull request: [FLINK-3226] Translation from and to POJOs for...

2016-02-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1624#discussion_r52744266 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -749,4 +867,23 @@ class CodeGenerator(

[GitHub] flink pull request: [FLINK-3270] Add Kafka example

2016-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-02-12 Thread Trevor Grant (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144606#comment-15144606 ] Trevor Grant commented on FLINK-2259: - In the spirit of sci-kit, and just data stuff i

[jira] [Assigned] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-02-12 Thread Trevor Grant (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trevor Grant reassigned FLINK-2259: --- Assignee: Trevor Grant > Support training Estimators using a (train, validation, test) split

[jira] [Commented] (FLINK-3367) Annotate all user-facing API classes with @Public or @PublicEvolving

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144585#comment-15144585 ] ASF GitHub Bot commented on FLINK-3367: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3367] Add PublicEvolving and Internal a...

2016-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1606#issuecomment-183332749 Except for two questions, the PR looks good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144584#comment-15144584 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on a diff in

[jira] [Updated] (FLINK-3393) ExternalProcessRunner wait to finish copying error stream

2016-02-12 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3393: -- Component/s: Core > ExternalProcessRunner wait to finish copying error stream >

[GitHub] flink pull request: [FLINK-3226] Translation from and to POJOs for...

2016-02-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1624#discussion_r52741150 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala --- @@ -150,7 +151,11 @@ object CodeGenUtils {

[jira] [Created] (FLINK-3393) ExternalProcessRunner wait to finish copying error stream

2016-02-12 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-3393: - Summary: ExternalProcessRunner wait to finish copying error stream Key: FLINK-3393 URL: https://issues.apache.org/jira/browse/FLINK-3393 Project: Flink Issue Type:

[jira] [Commented] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2016-02-12 Thread Trevor Grant (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144579#comment-15144579 ] Trevor Grant commented on FLINK-2259: - I need this functionality now, and I'm fairly c

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-12 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-183330257 Thanks for the comment @rmetzger. I changed the error message. Please review and let me know. --- If your project is set up for it, you can reply to this email and have yo

[jira] [Commented] (FLINK-2380) Allow to configure default FS for file inputs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144576#comment-15144576 ] ASF GitHub Bot commented on FLINK-2380: --- Github user kl0u commented on the pull requ

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144574#comment-15144574 ] ASF GitHub Bot commented on FLINK-3226: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3226] Translation from and to POJOs for...

2016-02-12 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1624#discussion_r52740335 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -231,29 +252,40 @@ class CodeGenerator(

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-183326898 Any more comments? Ideas? I think we should merge this soon because it should go into the 1.0 release. --- If your project is set up for it, you can reply to this emai

[jira] [Commented] (FLINK-3243) Fix Interplay of TimeCharacteristic and Time Windows

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144571#comment-15144571 ] ASF GitHub Bot commented on FLINK-3243: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-3359) Make RocksDB file copies asynchronous

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144567#comment-15144567 ] ASF GitHub Bot commented on FLINK-3359: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3359] Make RocksDB File Copies Asynchro...

2016-02-12 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1629#issuecomment-183325582 @uce This also moves the determination of the state size in `StreamTaskStateList` from the constructor to the method `getSize()`. I had to do this because the size of a

  1   2   >