[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420641#comment-15420641 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-08-14 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2244 @wuchong Tests passed on most platforms, and failures do not seem to be related to code that added/changed: ``` java.lang.IllegalStateException: cannot create children while

[jira] [Commented] (FLINK-4391) Provide support for asynchronous operations over streams

2016-08-14 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420638#comment-15420638 ] Gyula Fora commented on FLINK-4391: --- We have also done something similar at King for handling heavy db

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420617#comment-15420617 ] ASF GitHub Bot commented on FLINK-4309: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2371: [FLINK-4309] Potential null pointer dereference in Delega...

2016-08-14 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2371 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420616#comment-15420616 ] ASF GitHub Bot commented on FLINK-4309: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2371#discussion_r74720168 --- Diff: flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java --- @@ -88,4 +89,51 @@ private String

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420601#comment-15420601 ] ASF GitHub Bot commented on FLINK-4309: --- GitHub user tsunny opened a pull request:

[GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...

2016-08-14 Thread tsunny
GitHub user tsunny opened a pull request: https://github.com/apache/flink/pull/2371 [FLINK-4309] Potential null pointer dereference in DelegatingCo… Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420558#comment-15420558 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-08-14 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2244 The CsvTableSinkTest failed, can you check it ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-4373) Introduce SlotID, AllocationID, ResourceProfile

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420543#comment-15420543 ] ASF GitHub Bot commented on FLINK-4373: --- GitHub user KurtYoung opened a pull request:

[GitHub] flink pull request #2370: [FLINK-4373] [cluster management] Introduce SlotID...

2016-08-14 Thread KurtYoung
GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/2370 [FLINK-4373] [cluster management] Introduce SlotID, AllocationID, Res… Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420538#comment-15420538 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on the issue:

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on the issue: https://github.com/apache/flink/pull/2332 Hi @ramkrish86 , thanks for your reviews and detailed comments :-) I will update this PR soon. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420536#comment-15420536 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74711908 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseClient.java --- @@ -0,0 +1,69 @@

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420537#comment-15420537 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74711889 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420533#comment-15420533 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74711637 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[jira] [Commented] (FLINK-3703) Add sequence matching semantics to discard matched events

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420531#comment-15420531 ] ASF GitHub Bot commented on FLINK-3703: --- Github user smarthi commented on a diff in the pull

[GitHub] flink pull request #2367: [FLINK-3703][cep] Add sequence matching semantics ...

2016-08-14 Thread smarthi
Github user smarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/2367#discussion_r74711517 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -256,16 +267,75 @@ public void prune(long

[jira] [Commented] (FLINK-3703) Add sequence matching semantics to discard matched events

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420530#comment-15420530 ] ASF GitHub Bot commented on FLINK-3703: --- Github user smarthi commented on a diff in the pull

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420529#comment-15420529 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[jira] [Commented] (FLINK-3703) Add sequence matching semantics to discard matched events

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420526#comment-15420526 ] ASF GitHub Bot commented on FLINK-3703: --- Github user smarthi commented on a diff in the pull

[GitHub] flink pull request #2367: [FLINK-3703][cep] Add sequence matching semantics ...

2016-08-14 Thread smarthi
Github user smarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/2367#discussion_r74711491 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java --- @@ -256,16 +267,75 @@ public void prune(long

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74711470 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2367: [FLINK-3703][cep] Add sequence matching semantics ...

2016-08-14 Thread smarthi
Github user smarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/2367#discussion_r74711450 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java --- @@ -26,6 +26,7 @@ import

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420523#comment-15420523 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74711244 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74711022 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420522#comment-15420522 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-14 Thread delding
Github user delding commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74710964 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420521#comment-15420521 ] ASF GitHub Bot commented on FLINK-2055: --- Github user delding commented on a diff in the pull

[jira] [Commented] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-14 Thread Sunny T (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420469#comment-15420469 ] Sunny T commented on FLINK-4309: Hi, I would like to work on this issue. However, I am not able to assign

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420438#comment-15420438 ] ASF GitHub Bot commented on FLINK-4035: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request #2369: [FLINK-4035] Add a streaming connector for Apache ...

2016-08-14 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2369 [FLINK-4035] Add a streaming connector for Apache Kafka 0.10.x This pull request subsumes https://github.com/apache/flink/pull/2231. Compared to #2231, I've based the connector on the

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420406#comment-15420406 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-08-14 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2244 I removed fieldNames and fieldTypes from the constructor arguments and rely on **configure** method. Because of that I had to add an additional method for create serialization scheme in sub

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420404#comment-15420404 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74705587 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -592,7 +592,7 @@ class Table( .map(field =>

[jira] [Assigned] (FLINK-3950) Add Meter Metric Type

2016-08-14 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-3950: - Assignee: Ivan Mushketyk > Add Meter Metric Type > - > >

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420375#comment-15420375 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74704156 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420369#comment-15420369 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74703734 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420364#comment-15420364 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74703534 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -592,7 +592,7 @@ class Table( .map(field =>

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420361#comment-15420361 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-08-14 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2244 @wuchong @twalthr I've updated the PR according to your review. Could you please review it one more time? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Closed] (FLINK-4386) Add as way to assert that code runs in the RpcEndpoint's Main Thread

2016-08-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4386. --- > Add as way to assert that code runs in the RpcEndpoint's Main Thread >

[jira] [Resolved] (FLINK-4386) Add as way to assert that code runs in the RpcEndpoint's Main Thread

2016-08-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4386. - Resolution: Implemented Implemented in 363f07cc4d0f452cd9479a704703ae59e8d450c6 > Add as way to

[jira] [Resolved] (FLINK-4392) Make RPC Service Thread Safe

2016-08-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4392. - Resolution: Fixed Fixed via 133c394d5a92afd420751d2c27b1e082931871dc > Make RPC Service Thread

[jira] [Closed] (FLINK-4392) Make RPC Service Thread Safe

2016-08-14 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4392. --- > Make RPC Service Thread Safe > > > Key: FLINK-4392 >

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420329#comment-15420329 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420330#comment-15420330 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74701669 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74701671 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -590,7 +592,7 @@ class Table( .map(field =>

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420327#comment-15420327 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74701625 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java --- @@

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420301#comment-15420301 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...

2016-08-14 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2244 LGTM except a few nits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420299#comment-15420299 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74700122 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java ---

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420294#comment-15420294 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74700046 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74699857 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -590,7 +592,7 @@ class Table( .map(field =>

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420291#comment-15420291 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74699836 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java ---

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420288#comment-15420288 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420289#comment-15420289 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420287#comment-15420287 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74699840 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java --- @@

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74699842 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java --- @@

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420286#comment-15420286 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74699827 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java ---

[GitHub] flink issue #2267: [FLINK-4205] Create a simple stratified sampling function...

2016-08-14 Thread doflink
Github user doflink commented on the issue: https://github.com/apache/flink/pull/2267 Till Rohrmann had a look, this pull request needs some more works. Therefore, I think you should not spend time to review it for now. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-4205) Implement stratified sampling for DataSet

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420281#comment-15420281 ] ASF GitHub Bot commented on FLINK-4205: --- Github user doflink commented on the issue:

[jira] [Commented] (FLINK-3866) StringArraySerializer claims type is immutable; shouldn't

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420263#comment-15420263 ] ASF GitHub Bot commented on FLINK-3866: --- Github user mushketyk commented on the issue:

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420262#comment-15420262 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink issue #2289: [FLINK-3866] StringArraySerializer type should be mutable

2016-08-14 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2289 Hi @rmetzger, Thank you for helping with this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74698018 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74698003 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420261#comment-15420261 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74697524 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java ---

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420259#comment-15420259 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[jira] [Updated] (FLINK-4205) Implement stratified sampling for DataSet

2016-08-14 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4205: -- Component/s: DataSet API > Implement stratified sampling for DataSet >

[jira] [Commented] (FLINK-4205) Implement stratified sampling for DataSet

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420258#comment-15420258 ] ASF GitHub Bot commented on FLINK-4205: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2267: [FLINK-4205] Create a simple stratified sampling function...

2016-08-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2267 @greghogan would you be willing to review this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...

2016-08-14 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2244#discussion_r74697490 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java ---

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420257#comment-15420257 ] ASF GitHub Bot commented on FLINK-3874: --- Github user wuchong commented on a diff in the pull

[GitHub] flink issue #2289: [FLINK-3866] StringArraySerializer type should be mutable

2016-08-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2289 Hi @mushketyk, I'll try to find somebody to review this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-3866) StringArraySerializer claims type is immutable; shouldn't

2016-08-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420255#comment-15420255 ] ASF GitHub Bot commented on FLINK-3866: --- Github user rmetzger commented on the issue: