[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457533#comment-15457533
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4536 at 9/2/16 5:07 AM:
Hi
[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457533#comment-15457533
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4536 at 9/2/16 5:07 AM:
Hi
[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457533#comment-15457533
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4536 at 9/2/16 4:58 AM:
Hi
[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457533#comment-15457533
]
Tzu-Li (Gordon) Tai commented on FLINK-4536:
Hi [~skidder], just to clarify, the thread leak
[
https://issues.apache.org/jira/browse/FLINK-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457364#comment-15457364
]
ASF GitHub Bot commented on FLINK-4561:
---
GitHub user shijinkui opened a pull request:
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2459
[FLINK-4561] replace all the scala version as a `scala.binary.version`
property
Replace all the scala version(2.10) as a property `scala.binary.version`
defined in root pom properties. default
[
https://issues.apache.org/jira/browse/FLINK-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
shijinkui updated FLINK-4561:
-
Summary: replace all the scala version as a `scala.binary.version` property
(was: replace all the scala
shijinkui created FLINK-4561:
Summary: replace all the scala version as a property
Key: FLINK-4561
URL: https://issues.apache.org/jira/browse/FLINK-4561
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457312#comment-15457312
]
ASF GitHub Bot commented on FLINK-4560:
---
GitHub user shijinkui opened a pull request:
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2458
[FLINK-4560] enforcer java version as 1.7
[FLINK-4560](https://issues.apache.org/jira/browse/FLINK-4560) enforcer
java version as 1.7
1. maven-enforcer-plugin add java version enforce
2.
shijinkui created FLINK-4560:
Summary: enforcer java version as 1.7
Key: FLINK-4560
URL: https://issues.apache.org/jira/browse/FLINK-4560
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456481#comment-15456481
]
Scott Kidder commented on FLINK-4536:
-
On second thought, I'll leave the issue open and allow the
[
https://issues.apache.org/jira/browse/FLINK-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Mushketyk reassigned FLINK-3719:
-
Assignee: Ivan Mushketyk
> WebInterface: Moving the barrier between graph and stats
>
[
https://issues.apache.org/jira/browse/FLINK-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456480#comment-15456480
]
Ivan Mushketyk commented on FLINK-3719:
---
I'll implement this.
> WebInterface: Moving the barrier
[
https://issues.apache.org/jira/browse/FLINK-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456474#comment-15456474
]
ASF GitHub Bot commented on FLINK-3030:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2448
@StephanEwen I've renamed the class as you suggested.
Regarding the CSS change, I don't know why these changes are added. I have
the required (according to README.md) `gulp` version:
```
[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456462#comment-15456462
]
Scott Kidder edited comment on FLINK-4536 at 9/1/16 8:04 PM:
-
Thank you so
[
https://issues.apache.org/jira/browse/FLINK-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456462#comment-15456462
]
Scott Kidder commented on FLINK-4536:
-
Thank you so much [~tzulitai] and [~StephanEwen] for looking
[
https://issues.apache.org/jira/browse/FLINK-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456392#comment-15456392
]
ASF GitHub Bot commented on FLINK-3680:
---
GitHub user mushketyk opened a pull request:
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2457
[FLINK-3680] Remove "(not set)" text in the Job Plan UI
This PR removes the "(not set)" text in the web frontend.
Currently it looks like this:
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456319#comment-15456319
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user vijikarthi commented on the issue:
Github user vijikarthi commented on the issue:
https://github.com/apache/flink/pull/2425
>
According to the design document, netty authentication is also part of this
JIRA. Why was it not addressed?
The netty layer is addressed as part of web layer authentication (T2-3 &
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456282#comment-15456282
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user vijikarthi commented on a diff in the pull
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77230955
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
[
https://issues.apache.org/jira/browse/FLINK-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-4559:
---
Priority: Minor (was: Critical)
> Kinesis Producer not setting credentials provider
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456245#comment-15456245
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user vijikarthi commented on a diff in the pull
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77227679
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSecureTest.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456217#comment-15456217
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user vijikarthi commented on a diff in the pull
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77226096
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -426,4 +440,11 @@ void
[
https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456204#comment-15456204
]
Tzu-Li (Gordon) Tai commented on FLINK-3679:
+1 to fix the issue, the proposed changes seem
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456157#comment-15456157
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user vijikarthi commented on a diff in the pull
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77221958
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
---
@@ -99,7 +110,43 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456065#comment-15456065
]
ramkrishna.s.vasudevan commented on FLINK-3322:
---
Reading the code I think I need to update
Tzu-Li (Gordon) Tai created FLINK-4559:
--
Summary: Kinesis Producer not setting credentials provider
properly when AWS_CREDENTIALS_PROVIDER is "AUTO"
Key: FLINK-4559
URL:
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456048#comment-15456048
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2450
Thanks for the review @StephanEwen.
I agree that we've different style preferences concerning method
parameters. I also agree that the one parameter per line is a little bit more
[
https://issues.apache.org/jira/browse/FLINK-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456040#comment-15456040
]
Elias Levy commented on FLINK-3947:
---
The use case us maintaining a large set of items as state for a
[
https://issues.apache.org/jira/browse/FLINK-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-4559:
---
Affects Version/s: 1.1.2
> Kinesis Producer not setting credentials provider properly
[
https://issues.apache.org/jira/browse/FLINK-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-4559:
---
Fix Version/s: 1.1.3
> Kinesis Producer not setting credentials provider properly
[
https://issues.apache.org/jira/browse/FLINK-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-4559:
---
Affects Version/s: 1.1.1
1.1.0
> Kinesis Producer not setting
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2450#discussion_r77212855
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
@@ -69,7 +69,7 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455997#comment-15455997
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2449
I've addressed your comments @StephanEwen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455990#comment-15455990
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455966#comment-15455966
]
Elias Levy commented on FLINK-4558:
---
It should be noted that Flink already perform a similar function in
[
https://issues.apache.org/jira/browse/FLINK-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated FLINK-4461:
--
Attachment: FLINK_annotations.xlsx
Just attaching a list of public classes and
Elias Levy created FLINK-4558:
-
Summary: Add support for synchronizing streams
Key: FLINK-4558
URL: https://issues.apache.org/jira/browse/FLINK-4558
Project: Flink
Issue Type: Improvement
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2449
Thanks for the quick and thorough review @StephanEwen.
- Concerning the `ExecutionContext` in the `TaskManager`: This is simply
the `ExecutionContext` which was passed before to the
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455878#comment-15455878
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther reassigned FLINK-4549:
---
Assignee: Timo Walther
> Test and document implicitly supported SQL functions
>
[
https://issues.apache.org/jira/browse/FLINK-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455755#comment-15455755
]
Niels Basjes commented on FLINK-4485:
-
I have tried to create a minimal application that reproduces
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455751#comment-15455751
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2449#discussion_r77195218
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -18,130 +18,88 @@
package
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455743#comment-15455743
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455740#comment-15455740
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2449#discussion_r77194470
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -18,130 +18,88 @@
package
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2449#discussion_r77194531
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -476,6 +252,29 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455704#comment-15455704
]
ASF GitHub Bot commented on FLINK-4459:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2424
I will try and rebase/merge this on top of #2447 and add this to the
`flip-6` branch as soon as #2447 is approved.
---
If your project is set up for it, you can reply to this email and have
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2456
[FLINK-4456] Replace ActorGateway in Task and RuntimeEnvironment
Replaces the `ActorGateway` in `Task` and `RuntimeEnvironment` by
interfaces to decouple these components from the actors.
[
https://issues.apache.org/jira/browse/FLINK-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455674#comment-15455674
]
ASF GitHub Bot commented on FLINK-4456:
---
GitHub user tillrohrmann opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455668#comment-15455668
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2425
According to the design document, netty authentication is also part of this
JIRA. Why was it not addressed?
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455664#comment-15455664
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2425
I'm done with my initial review.
If you have a minute @mxm, it would be good if you could check the
CliFrontend changes, to see if they fit the architecture well.
---
If your project is set up
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455662#comment-15455662
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2425
I manually tested the code. Taskmanagers are properly rejected on
missmatching cookies, it works when they match.
One thing I found was that the error reporting is not very good:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77181460
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -597,6 +610,11 @@ public static ContainerLaunchContext
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455536#comment-15455536
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user StephanEwen commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455534#comment-15455534
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77182333
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2450
I think these changes are good.
As a very personal and biased statement: I think the code overdoes it a bit
with the "every parameter on a new line" policy. We have beautiful wide
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455531#comment-15455531
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77182101
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455524#comment-15455524
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77181663
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -439,8 +450,8 @@ public static void
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455520#comment-15455520
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455509#comment-15455509
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user StephanEwen commented on a diff in the pull
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2450#discussion_r77180730
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
@@ -69,7 +69,7 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455506#comment-15455506
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77180355
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSecureTest.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455491#comment-15455491
]
ASF GitHub Bot commented on FLINK-4510:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2453
Thanks for looking into this.
I wonder if we can do this simpler, without changes to the
CheckpointCoordinator.
The only thing that really needs to change is that without periodic
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77178647
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSecureTest.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455477#comment-15455477
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Timo Walther created FLINK-4557:
---
Summary: Table API Stream Aggregations
Key: FLINK-4557
URL: https://issues.apache.org/jira/browse/FLINK-4557
Project: Flink
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455463#comment-15455463
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455465#comment-15455465
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77177808
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1470,6 +1470,18 @@ object TaskManager {
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77177744
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -2041,6 +2044,18 @@ object JobManager {
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455428#comment-15455428
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user StephanEwen commented on a diff in the pull
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2449
+1 for moving the `PartitionStateChecker` and
`ResultPartitionConsumableNotifier` out of the `NetworkEnvironment`.
Few questions and comments:
- Do we need an extra
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455431#comment-15455431
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2449#discussion_r77175883
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -18,130 +18,88 @@
package
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455423#comment-15455423
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77175545
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -530,6 +529,7 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455396#comment-15455396
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user StephanEwen commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455399#comment-15455399
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user StephanEwen commented on a diff in the pull
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2449#discussion_r77174082
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
@@ -476,6 +252,29 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455407#comment-15455407
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in the pull
1 - 100 of 224 matches
Mail list logo
