[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481091#comment-15481091 ] ASF GitHub Bot commented on FLINK-4609: --- Github user apivovarov commented on a diff in the pull

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78288200 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[jira] [Updated] (FLINK-4611) Make "AUTO" credential provider as default for Kinesis Connector

[ https://issues.apache.org/jira/browse/FLINK-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-4611: --- Priority: Major (was: Minor) > Make "AUTO" credential provider as default for

[jira] [Created] (FLINK-4611) Make "AUTO" credential provider as default for Kinesis Connector

Tzu-Li (Gordon) Tai created FLINK-4611: -- Summary: Make "AUTO" credential provider as default for Kinesis Connector Key: FLINK-4611 URL: https://issues.apache.org/jira/browse/FLINK-4611 Project:

[jira] [Commented] (FLINK-4602) Move RocksDB backed to proper package

[ https://issues.apache.org/jira/browse/FLINK-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15481024#comment-15481024 ] Tzu-Li (Gordon) Tai commented on FLINK-4602: Does this also mean we will be moving the rocksdb

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78287335 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480951#comment-15480951 ] ASF GitHub Bot commented on FLINK-4609: --- Github user apivovarov commented on a diff in the pull

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480755#comment-15480755 ] ASF GitHub Bot commented on FLINK-4609: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78286377 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName() {

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480602#comment-15480602 ] ASF GitHub Bot commented on FLINK-4609: --- Github user apivovarov commented on a diff in the pull

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78285322 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480599#comment-15480599 ] ASF GitHub Bot commented on FLINK-4609: --- Github user apivovarov commented on the issue:

[GitHub] flink issue #2490: [FLINK-4609] Remove redundant check for null in CrossOper...

Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2490 Ok, I added null check for input1 and input2 with a message before calling super in DefaultCross --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils

[ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480465#comment-15480465 ] ASF GitHub Bot commented on FLINK-4610: --- Github user apivovarov commented on the issue:

[GitHub] flink issue #2491: [FLINK-4610] Replace keySet/getValue with entrySet in Udf...

Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2491 @twalthr Can you look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480437#comment-15480437 ] ASF GitHub Bot commented on FLINK-4609: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78283727 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480384#comment-15480384 ] ASF GitHub Bot commented on FLINK-4609: --- Github user apivovarov commented on a diff in the pull

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78283317 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[jira] [Commented] (FLINK-4148) incorrect calculation distance in QuadTree

[ https://issues.apache.org/jira/browse/FLINK-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479369#comment-15479369 ] ASF GitHub Bot commented on FLINK-4148: --- Github user xhumanoid commented on the issue:

[GitHub] flink issue #2442: [FLINK-4148] incorrect calculation minDist distance in Qu...

Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/2442 slave was killed without any notifications: ERROR: Maven JVM terminated unexpectedly with exit code 137 Putting comment on the pull request Finished: FAILURE --- If your project

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78273103 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1,

[jira] [Commented] (FLINK-4609) Remove redundant check for null in CrossOperator

[ https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479356#comment-15479356 ] ASF GitHub Bot commented on FLINK-4609: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4608) Use short-circuit AND in Max/Min AggregationFunction

[ https://issues.apache.org/jira/browse/FLINK-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479354#comment-15479354 ] ASF GitHub Bot commented on FLINK-4608: --- Github user zentol commented on the issue:

[GitHub] flink issue #2489: [FLINK-4608] Use short-circuit AND in Max/Min Aggregation...

Github user zentol commented on the issue: https://github.com/apache/flink/pull/2489 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4607) Close FileInputStream in ParameterTool and other

[ https://issues.apache.org/jira/browse/FLINK-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479351#comment-15479351 ] ASF GitHub Bot commented on FLINK-4607: --- Github user zentol commented on the issue:

[GitHub] flink issue #2488: [FLINK-4607] Close FileInputStream in ParameterTool and o...

Github user zentol commented on the issue: https://github.com/apache/flink/pull/2488 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils

[ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479259#comment-15479259 ] ASF GitHub Bot commented on FLINK-4610: --- GitHub user apivovarov opened a pull request:

[GitHub] flink pull request #2491: [FLINK-4610] Replace keySet/getValue with entrySet...

GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2491 [FLINK-4610] Replace keySet/getValue with entrySet in UdfAnalyzerUtils https://issues.apache.org/jira/browse/FLINK-4610 You can merge this pull request into a Git repository by running: $

[jira] [Updated] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils

[ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pivovarov updated FLINK-4610: --- Description: Map.keySet + getValue combination is not very efficient It can be

[jira] [Created] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils

Alexander Pivovarov created FLINK-4610: -- Summary: Replace keySet/getValue with entrySet in UdfAnalyzerUtils Key: FLINK-4610 URL: https://issues.apache.org/jira/browse/FLINK-4610 Project: Flink

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @apivovarov thanks very much for the comments. I have formatted all code as required. Pls. kindly help continue reviewing. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-4520) Integrate Siddhi as a lightweight CEP Library

[ https://issues.apache.org/jira/browse/FLINK-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479245#comment-15479245 ] ASF GitHub Bot commented on FLINK-4520: --- Github user haoch commented on the issue: