[jira] [Commented] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673053#comment-15673053 ] ASF GitHub Bot commented on FLINK-5075: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2822: [FLINK-5075] [kinesis] Make Kinesis consumer fail-proof t...

2016-11-16 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2822 I'm not entirely sure whether the fix is a good workaround, or whether we should really bother with Kinesalite's incorrect behaviour at all in our Kinesis connector. I've considered the alt

[jira] [Commented] (FLINK-5075) Kinesis consumer incorrectly determines shards as newly discovered when tested against Kinesalite

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673047#comment-15673047 ] ASF GitHub Bot commented on FLINK-5075: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #2822: [FLINK-5075] [kinesis] Make Kinesis consumer fail-...

2016-11-16 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/2822 [FLINK-5075] [kinesis] Make Kinesis consumer fail-proof to incorrect Kinesalite API behaviour A user reported that when tested against Kinesalite (a widely used mock Kinesis implementation), the c

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673034#comment-15673034 ] Kostas Kloudas commented on FLINK-2646: --- Yes I agree. This is what I also meant in m

[jira] [Commented] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673030#comment-15673030 ] Kostas Kloudas commented on FLINK-2646: --- Yes, I think we are on the same page. This

[jira] [Issue Comment Deleted] (FLINK-2646) Rich functions should provide a method "closeAfterFailure()"

2016-11-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-2646: -- Comment: was deleted (was: Yes, I think we are on the same page. This is what I also meant in my

[jira] [Commented] (FLINK-5085) Execute CheckpointCoodinator's state discard calls asynchronously

2016-11-16 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673026#comment-15673026 ] Xiaogang Shi commented on FLINK-5085: - Great, this is what i thought of in recent days

[GitHub] flink pull request #2821: [MINOR][DOC] Fix incorrect URL

2016-11-16 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2821 [MINOR][DOC] Fix incorrect URL You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink patch-1 Alternatively you can review and app

[jira] [Created] (FLINK-5085) Execute CheckpointCoodinator's state discard calls asynchronously

2016-11-16 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5085: Summary: Execute CheckpointCoodinator's state discard calls asynchronously Key: FLINK-5085 URL: https://issues.apache.org/jira/browse/FLINK-5085 Project: Flink

[jira] [Closed] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-5063. --- > State handles are not properly cleaned up for declined or expired checkpoints >

[jira] [Resolved] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-5063. - Resolution: Fixed Fixed in - 1.1.4 via 4daf3bbc1e0251e1e84d799421dae9e3fa2363fc - 1.2.0 via 72

[jira] [Resolved] (FLINK-5057) Cancellation timeouts are picked from wrong config

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-5057. - Resolution: Fixed Fixed in - 1.1.4 via ad3e674b26fb5766ffefda653701af5180d60413 - 1.2.0 via bf

[jira] [Closed] (FLINK-5057) Cancellation timeouts are picked from wrong config

2016-11-16 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-5057. --- > Cancellation timeouts are picked from wrong config > --

[GitHub] flink pull request #2812: [FLINK-5063] Discard state handles of declined or ...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2793: [FLINK-5057] [task] Pick cancellation timeout from...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5063) State handles are not properly cleaned up for declined or expired checkpoints

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672074#comment-15672074 ] ASF GitHub Bot commented on FLINK-5063: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-5006) SystemProcessingTimeServiceTest.testTimerSorting fails

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672075#comment-15672075 ] ASF GitHub Bot commented on FLINK-5006: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2785: [FLINK-5006] SystemProcessingTimeServiceTest.testT...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2785 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-5057) Cancellation timeouts are picked from wrong config

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672073#comment-15672073 ] ASF GitHub Bot commented on FLINK-5057: --- Github user asfgit closed the pull request

[jira] [Created] (FLINK-5084) Replace Java Table API integration tests by unit tests

2016-11-16 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-5084: Summary: Replace Java Table API integration tests by unit tests Key: FLINK-5084 URL: https://issues.apache.org/jira/browse/FLINK-5084 Project: Flink Issue Ty

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88342301 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/DataStreamCorrelateRule.scala --- @@ -0,0 +1,89 @@

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88339990 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/FlinkCorrelate.scala --- @@ -0,0 +1,161 @@ +/* + * License

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671952#comment-15671952 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671927#comment-15671927 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88348205 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetCorrelateRule.scala --- @@ -0,0 +1,89 @@ +/*

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88337239 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/call.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671932#comment-15671932 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88339350 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/FlinkCorrelate.scala --- @@ -0,0 +1,161 @@ +/* + * License

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88336779 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -162,24 +191,107 @@ obj

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671947#comment-15671947 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88338123 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -611,6 +612,130 @@ class Table( } /**

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88347146 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/EvaluableFunction.scala --- @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88345307 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala --- @@ -0,0 +1,136 @@ +/* +

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88348343 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -0,0 +1,77 @@ +/* + *

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88347669 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88337706 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/call.scala --- @@ -0,0 +1,169 @@ +/* + * Licensed to the

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88343373 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala --- @@ -0,0 +1,136 @@ +/* +

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88345505 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/FlinkTableFunctionImpl.scala --- @@ -0,0 +1,77 @@ +/* + *

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671936#comment-15671936 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671957#comment-15671957 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671950#comment-15671950 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671924#comment-15671924 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88335427 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671934#comment-15671934 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671955#comment-15671955 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88343933 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala --- @@ -0,0 +1,136 @@ +/* +

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671940#comment-15671940 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88346931 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/EvaluableFunction.scala --- @@ -0,0 +1,62 @@ +/* --- End di

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88346802 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/FunctionCatalog.scala --- @@ -47,13 +52,50 @@ class FunctionCatalog

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88344259 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamCorrelate.scala --- @@ -0,0 +1,138 @@ +/*

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88336518 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -135,6 +138,32 @@ objec

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88342273 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetCorrelateRule.scala --- @@ -0,0 +1,89 @@ +/*

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88345712 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/FunctionCatalog.scala --- @@ -47,13 +52,50 @@ class FunctionCatalog

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671942#comment-15671942 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671925#comment-15671925 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671959#comment-15671959 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671946#comment-15671946 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671928#comment-15671928 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671930#comment-15671930 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88345175 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamCorrelate.scala --- @@ -0,0 +1,138 @@ +/*

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88325623 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/UserDefinedTableFunctionITCase.java --- @@ -0,0 +1,201 @@ +/* + *

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88343322 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamCorrelate.scala --- @@ -0,0 +1,138 @@ +/*

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88337810 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -17,20 +17,30 @@ */ package or

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88348227 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/DataStreamCorrelateRule.scala --- @@ -0,0 +1,89 @@

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88339010 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -611,6 +612,130 @@ class Table( } /**

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671956#comment-15671956 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671951#comment-15671951 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88344133 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala --- @@ -0,0 +1,136 @@ +/* +

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88339652 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/FlinkCorrelate.scala --- @@ -0,0 +1,161 @@ +/* + * License

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671939#comment-15671939 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671938#comment-15671938 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671943#comment-15671943 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671931#comment-15671931 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671958#comment-15671958 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671953#comment-15671953 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671933#comment-15671933 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671935#comment-15671935 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671929#comment-15671929 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671937#comment-15671937 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671949#comment-15671949 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671945#comment-15671945 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671948#comment-15671948 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671941#comment-15671941 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671926#comment-15671926 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671944#comment-15671944 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671954#comment-15671954 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4469) Add support for user defined table function in Table API & SQL

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671960#comment-15671960 ] ASF GitHub Bot commented on FLINK-4469: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88336697 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -162,24 +191,107 @@ obj

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88338243 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -611,6 +612,130 @@ class Table( } /**

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88336271 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r87304840 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -360,7 +370,8 @@ case class Join(

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r87303197 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarFunctions.scala --- @@ -305,6 +305,16 @@ object ScalarFun

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88335748 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] flink pull request #2653: [FLINK-4469] [table] Add support for user defined ...

2016-11-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2653#discussion_r88335539 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala --- @@ -0,0 +1,119 @@ +/* + * Licensed

[jira] [Commented] (FLINK-5083) Race condition in Rolling/Bucketing Sink pending files cleanup

2016-11-16 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671880#comment-15671880 ] Kostas Kloudas commented on FLINK-5083: --- Thanks for reporting it! There is a pendin

[GitHub] flink issue #2740: [FLINK-4964] [ml]

2016-11-16 Thread tfournier314
Github user tfournier314 commented on the issue: https://github.com/apache/flink/pull/2740 @greghogan Ok I've pushed the code with my tests and some modifications in mapping @thvasilo It seems to work perfectly! --- If your project is set up for it, you can reply to this em

[jira] [Commented] (FLINK-4964) FlinkML - Add StringIndexer

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671741#comment-15671741 ] ASF GitHub Bot commented on FLINK-4964: --- Github user tfournier314 commented on the i

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88332568 --- Diff: pom.xml --- @@ -96,7 +96,7 @@ under the License. 1.7.7 18.0 2.3.7 - 1.7 +

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2016-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671666#comment-15671666 ] ASF GitHub Bot commented on FLINK-5067: --- Github user melentye commented on a diff in

  1   2   3   >