[GitHub] flink pull request #2810: [FLINK-3848] Add ProjectableTableSource interface ...

2016-11-20 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2810#discussion_r88841542 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala --- @@ -0,0 +1,67 @@ +/*

[jira] [Commented] (FLINK-3848) Add ProjectableTableSource interface and translation rule

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682790#comment-15682790 ] ASF GitHub Bot commented on FLINK-3848: --- Github user tonycox commented on a diff in the pull

[jira] [Commented] (FLINK-4872) Type erasure problem exclusively on cluster execution

2016-11-20 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682781#comment-15682781 ] Martin Junghanns commented on FLINK-4872: - [~twalthr] Thank you! I will test it this week and

[jira] [Commented] (FLINK-4937) Add incremental group window aggregation for streaming Table API

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682771#comment-15682771 ] ASF GitHub Bot commented on FLINK-4937: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #2792: [FLINK-4937] [Table] Add incremental group window ...

2016-11-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2792#discussion_r88840617 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@ -0,0 +1,69

[jira] [Commented] (FLINK-5002) Lack of synchronization in LocalBufferPool#getNumberOfUsedBuffers

2016-11-20 Thread Roman Maier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682680#comment-15682680 ] Roman Maier commented on FLINK-5002: Here is a link to the commit:

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682610#comment-15682610 ] ASF GitHub Bot commented on FLINK-5092: --- GitHub user BorisOsipov opened a pull request:

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2016-11-20 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2836 [FLINK-5092] Add maven profile with code coverage report generation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #2792: [FLINK-4937] [Table] Add incremental group window ...

2016-11-20 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/2792#discussion_r88824600 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@

[jira] [Commented] (FLINK-4937) Add incremental group window aggregation for streaming Table API

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682381#comment-15682381 ] ASF GitHub Bot commented on FLINK-4937: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...

2016-11-20 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2758 Great ! The PR looks good to me now, thank you for your contribution ! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682259#comment-15682259 ] ASF GitHub Bot commented on FLINK-4260: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682257#comment-15682257 ] ASF GitHub Bot commented on FLINK-4260: --- Github user miaoever commented on the issue:

[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...

2016-11-20 Thread miaoever
Github user miaoever commented on the issue: https://github.com/apache/flink/pull/2758 @wuchong sure, fixed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682214#comment-15682214 ] ASF GitHub Bot commented on FLINK-4260: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...

2016-11-20 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2758 The Travis CI has failed because of `BuiltInMethods` line length, could you fix this ? ``` [INFO] --- scalastyle-maven-plugin:0.8.0:check (default) @ flink-table_2.10 --- error

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681210#comment-15681210 ] ASF GitHub Bot commented on FLINK-4260: --- Github user miaoever commented on the issue:

[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...

2016-11-20 Thread miaoever
Github user miaoever commented on the issue: https://github.com/apache/flink/pull/2758 Hi @wuchong, I have resolved the conficts :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-1536) Graph partitioning operators for Gelly

2016-11-20 Thread joey (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681135#comment-15681135 ] joey commented on FLINK-1536: - At least I have stopped involving in this task long time ago. You can contact

[jira] [Commented] (FLINK-1536) Graph partitioning operators for Gelly

2016-11-20 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681133#comment-15681133 ] Ivan Mushketyk commented on FLINK-1536: --- Hi [~vkalavri] What is the status of this task? Is anybody

[jira] [Commented] (FLINK-3110) Add support for partition-centric iterations

2016-11-20 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681110#comment-15681110 ] Ivan Mushketyk commented on FLINK-3110: --- Is anybody working on this? Is there anything that should

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-11-20 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681106#comment-15681106 ] Ivan Mushketyk commented on FLINK-2254: --- Regarding the metrics that we need for the bipartite graph.

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-11-20 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681101#comment-15681101 ] Ivan Mushketyk commented on FLINK-2254: --- [~vkalavri] [~greghogan] I've made some progress in this

[jira] [Commented] (FLINK-5104) Implement BipartiteGraph validator

2016-11-20 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681090#comment-15681090 ] Ivan Mushketyk commented on FLINK-5104: --- Implemented here:

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680915#comment-15680915 ] ASF GitHub Bot commented on FLINK-4260: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...

2016-11-20 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2758 It would be great if you can rebase your branch and resolve the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-3869) WindowedStream.apply with FoldFunction is too restrictive

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680892#comment-15680892 ] ASF GitHub Bot commented on FLINK-3869: --- GitHub user ymarzougui opened a pull request:

[GitHub] flink pull request #2835: [FLINK-3869] WindowedStream.apply with FoldFunctio...

2016-11-20 Thread ymarzougui
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/2835 [FLINK-3869] WindowedStream.apply with FoldFunction is too restrictive This pull request removes the restriction that a WindowFunction in a fold/apply should emit the same type as the

[GitHub] flink issue #2758: [FLINK-4260] Support specifying ESCAPE character in LIKE ...

2016-11-20 Thread miaoever
Github user miaoever commented on the issue: https://github.com/apache/flink/pull/2758 Hi @wuchong , I have modified the test cases according to your comments, please review my latest commit. Thanks :) --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-4260) Allow SQL's LIKE ESCAPE

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680864#comment-15680864 ] ASF GitHub Bot commented on FLINK-4260: --- Github user miaoever commented on the issue:

[GitHub] flink pull request #2792: [FLINK-4937] [Table] Add incremental group window ...

2016-11-20 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2792#discussion_r88796985 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@ -0,0 +1,69

[jira] [Commented] (FLINK-4937) Add incremental group window aggregation for streaming Table API

2016-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680835#comment-15680835 ] ASF GitHub Bot commented on FLINK-4937: --- Github user wuchong commented on a diff in the pull