[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880059#comment-15880059 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102654252 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java ---

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880057#comment-15880057 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102654126 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java ---

[jira] [Updated] (FLINK-5893) Race condition in removing previous JobManagerRegistration in ResourceManager

2017-02-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-5893: Description: The map of {{JobManagerRegistration}} in ResourceManager is not thread-safe, and currently

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652877 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@ -52,9

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880052#comment-15880052 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880051#comment-15880051 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652936 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/GlobalEventTimeRowWindowAssigner.java --- @@ -0,0 +1,113

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880050#comment-15880050 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880049#comment-15880049 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652926 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102652914 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class

[jira] [Assigned] (FLINK-5893) Race condition in removing previous JobManagerRegistration in ResourceManager

2017-02-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang reassigned FLINK-5893: --- Assignee: zhijiang > Race condition in removing previous JobManagerRegistration in ResourceManager >

[jira] [Updated] (FLINK-5893) Race condition in removing previous JobManagerRegistration in ResourceManager

2017-02-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-5893: Description: The map of {{JobManagerRegistration}} in ResourceManager is not thread-safe, and currently

[jira] [Updated] (FLINK-5893) Race condition in removing previous JobManagerRegistration in ResourceManager

2017-02-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-5893: Description: The map of {{JobManagerRegistration}} in {{ResourceManager}} is not thread-safe, and

[jira] [Created] (FLINK-5893) Race condition in removing previous JobManagerRegistration in ResourceManager

2017-02-22 Thread zhijiang (JIRA)
zhijiang created FLINK-5893: --- Summary: Race condition in removing previous JobManagerRegistration in ResourceManager Key: FLINK-5893 URL: https://issues.apache.org/jira/browse/FLINK-5893 Project: Flink

[jira] [Updated] (FLINK-5892) Recover job state at the granularity of operator

2017-02-22 Thread MaGuowei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] MaGuowei updated FLINK-5892: Description: JobGraph has no `Operator` info so `ExecutionGraph` can only recovery at the granularity of

[jira] [Created] (FLINK-5892) Recover job state at the granularity of operator

2017-02-22 Thread MaGuowei (JIRA)
MaGuowei created FLINK-5892: --- Summary: Recover job state at the granularity of operator Key: FLINK-5892 URL: https://issues.apache.org/jira/browse/FLINK-5892 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880012#comment-15880012 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102650085 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880004#comment-15880004 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102649307 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[jira] [Commented] (FLINK-5546) java.io.tmpdir setted as project build directory in surefire plugin

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879996#comment-15879996 ] ASF GitHub Bot commented on FLINK-5546: --- Github user wenlong88 commented on the issue:

[GitHub] flink issue #3190: [FLINK-5546][build] java.io.tmpdir setted as project buil...

2017-02-22 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/3190 Can we just use the `${project.build.directory}` as `java.io.tmpdir` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-5859) support partition pruning on Table API & SQL

2017-02-22 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879991#comment-15879991 ] Kurt Young commented on FLINK-5859: --- Hi [~fhueske], You raised a very good question, which is

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879990#comment-15879990 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102648005 --- Diff:

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879988#comment-15879988 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102647903 --- Diff:

[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-22 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102647565 --- Diff:

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879974#comment-15879974 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-5728) FlinkKafkaProducer should flush on checkpoint by default

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879965#comment-15879965 ] ASF GitHub Bot commented on FLINK-5728: --- Github user tzulitai commented on the pull request:

[GitHub] flink pull request #:

2017-02-22 Thread tzulitai
Github user tzulitai commented on the pull request: https://github.com/apache/flink/commit/646490c4e93eca315e4bf41704f149390f8639cc#commitcomment-21009882 @StephanEwen Yes. We discussed that in https://issues.apache.org/jira/browse/FLINK-5728 with some other aspects regarding the

[jira] [Commented] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879942#comment-15879942 ] Kurt Young commented on FLINK-5568: --- Hi [~fhueske], I want to emphasize there exists a very big

[jira] [Commented] (FLINK-5879) ExecutionAttemptID should invoke super() in constructor

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879940#comment-15879940 ] ASF GitHub Bot commented on FLINK-5879: --- GitHub user ifndef-SleePy opened a pull request:

[GitHub] flink pull request #3396: [FLINK-5879] Fix bug about ExecutionAttemptID, add...

2017-02-22 Thread ifndef-SleePy
GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/3396 [FLINK-5879] Fix bug about ExecutionAttemptID, add super() in constructor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alibaba/flink

[jira] [Commented] (FLINK-5861) TaskManager's components support updating JobManagerConnection

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879923#comment-15879923 ] ASF GitHub Bot commented on FLINK-5861: --- GitHub user ifndef-SleePy opened a pull request:

[GitHub] flink pull request #3395: [FLINK-5861] Components of TaskManager support upd...

2017-02-22 Thread ifndef-SleePy
GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/3395 [FLINK-5861] Components of TaskManager support updating JobManagerConnection You can merge this pull request into a Git repository by running: $ git pull

[jira] [Comment Edited] (FLINK-5891) ConnectedComponents is broken when object reuse enabled

2017-02-22 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879742#comment-15879742 ] Xingcan Cui edited comment on FLINK-5891 at 2/23/17 5:38 AM: - Hi Greg, may I

[jira] [Comment Edited] (FLINK-5891) ConnectedComponents is broken when object reuse enabled

2017-02-22 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879742#comment-15879742 ] Xingcan Cui edited comment on FLINK-5891 at 2/23/17 5:25 AM: - Hi Greg, may I

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879871#comment-15879871 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879873#comment-15879873 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102634209 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879879#comment-15879879 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879870#comment-15879870 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879874#comment-15879874 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879876#comment-15879876 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879878#comment-15879878 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879880#comment-15879880 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879877#comment-15879877 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879872#comment-15879872 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879875#comment-15879875 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879869#comment-15879869 ] ASF GitHub Bot commented on FLINK-5658: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102635310 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowRule.scala --- @@ -0,0 +1,87 @@

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631646 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102632122 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowRule.scala --- @@ -0,0 +1,87 @@

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102632917 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/LogicalWindowRule.scala --- @@ -0,0 +1,73 @@

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631440 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102630342 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631105 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala --- @@ -52,9

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102631831 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala --- @@ -0,0

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102634122 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -171,4 +175,98 @@ class

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102634927 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/GlobalEventTimeRowWindowAssigner.java --- @@ -0,0

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-02-22 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r102633283 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -395,7 +395,8 @@ object

[jira] [Issue Comment Deleted] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2017-02-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4534: -- Comment: was deleted (was: Feel free to work on this. Thanks, Liwei.) > Lack of synchronization in

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Description: The {{TableEnvironment}} now provides a mechanism to register temporary table. It registers

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879786#comment-15879786 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102632219 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala --- @@ -48,10 +48,16 @@ class

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879761#comment-15879761 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879759#comment-15879759 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102626945 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala --- @@ -48,10 +48,16 @@ class

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102628732 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/UserDefinedScalarFunctionTest.scala --- @@ -181,6 +181,22 @@ class

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879760#comment-15879760 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879763#comment-15879763 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879762#comment-15879762 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102628111 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -140,6 +147,25 @@ object

[jira] [Commented] (FLINK-5881) ScalarFunction(UDF) should support variable types and variable arguments

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879764#comment-15879764 ] ASF GitHub Bot commented on FLINK-5881: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102627293 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -87,10 +87,16 @@ object

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102627751 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -87,10 +87,16 @@ object

[GitHub] flink pull request #3389: [FLINK-5881] [table] ScalarFunction(UDF) should su...

2017-02-22 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3389#discussion_r102628665 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -140,6 +147,25 @@ object

[jira] [Commented] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879755#comment-15879755 ] jingzhang commented on FLINK-5568: -- [~fhueske], thanks for your response. There is still a detail problem

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Description: The {{TableEnvironment}} now provides a mechanism to register temporary table. It registers

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Description: The {{TableEnvironment}} now provides a mechanism to register temporary table. It registers

[jira] [Updated] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread jingzhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jingzhang updated FLINK-5568: - Description: The {{TableEnvironment}} now provides a mechanism to register temporary table. It registers

[jira] [Commented] (FLINK-5891) ConnectedComponents is broken when object reuse enabled

2017-02-22 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879742#comment-15879742 ] Xingcan Cui commented on FLINK-5891: Hi Greg, may I ask what does "when object reuse enabled" mean

[jira] [Commented] (FLINK-5888) ForwardedFields annotation is not generating optimised execution plan in example KMeans job

2017-02-22 Thread Ziyad Muhammed Mohiyudheen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879605#comment-15879605 ] Ziyad Muhammed Mohiyudheen commented on FLINK-5888: --- [~fhueske], Here is the output for

[GitHub] flink issue #3354: [FLINK-5767] [Table] New aggregate function interface and...

2017-02-22 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3354 @fhueske thanks for the review. I agree with you that we should provide more specific types for the accumulators (backend state). I will update code today to address all your comments. ---

[jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879512#comment-15879512 ] ASF GitHub Bot commented on FLINK-5767: --- Github user shaoxuan-wang commented on the issue:

[jira] [Commented] (FLINK-5767) New aggregate function interface and built-in aggregate functions

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879498#comment-15879498 ] ASF GitHub Bot commented on FLINK-5767: --- Github user shaoxuan-wang commented on a diff in the pull

[GitHub] flink pull request #3354: [FLINK-5767] [Table] New aggregate function interf...

2017-02-22 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3354#discussion_r102606570 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/builtInAggFuncs/SumAggFunction.scala --- @@ -0,0 +1,146 @@

[jira] [Commented] (FLINK-5568) Introduce interface for catalog, and provide an in-memory implementation, and integrate with calcite schema

2017-02-22 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879377#comment-15879377 ] Fabian Hueske commented on FLINK-5568: -- I think this is a good approach. > Introduce interface for

[jira] [Commented] (FLINK-5888) ForwardedFields annotation is not generating optimised execution plan in example KMeans job

2017-02-22 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879297#comment-15879297 ] Fabian Hueske commented on FLINK-5888: -- Yes, [~ggevay] is right. The hash partitioning is moved

[jira] [Created] (FLINK-5891) ConnectedComponents is broken when object reuse enabled

2017-02-22 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-5891: - Summary: ConnectedComponents is broken when object reuse enabled Key: FLINK-5891 URL: https://issues.apache.org/jira/browse/FLINK-5891 Project: Flink Issue Type:

[jira] [Created] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-02-22 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-5890: - Summary: GatherSumApply broken when object reuse enabled Key: FLINK-5890 URL: https://issues.apache.org/jira/browse/FLINK-5890 Project: Flink Issue Type: Bug

[GitHub] flink pull request #:

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/646490c4e93eca315e4bf41704f149390f8639cc#commitcomment-21003603 Should we make `flushOnCheckpoint` true by default? --- If your project is set up for it, you can reply to this email and

[jira] [Created] (FLINK-5889) Improving the Flink Python batch API test framework

2017-02-22 Thread Lior Amar (JIRA)
Lior Amar created FLINK-5889: Summary: Improving the Flink Python batch API test framework Key: FLINK-5889 URL: https://issues.apache.org/jira/browse/FLINK-5889 Project: Flink Issue Type:

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879194#comment-15879194 ] ASF GitHub Bot commented on FLINK-4422: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3384: [FLINK-4422] Convert all time interval measurements to Sy...

2017-02-22 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3384 Looks good, +1 to merge Optional comment: I have seen that developers get confused when working with the code whether a `long` refers to a "millisecond" timestamp or to a "nanosecond"

[jira] [Commented] (FLINK-1526) Add Minimum Spanning Tree library method and example

2017-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879128#comment-15879128 ] ASF GitHub Bot commented on FLINK-1526: --- Github user greghogan commented on the issue:

  1   2   3   4   >