[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885251#comment-15885251
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user wuchong commented on the issue:
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3418
Thanks for updating, the code looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3418
Hi, @wuchong thanks a lot for your review. I had change the test to
UnitTest.
bests,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885192#comment-15885192
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user sunjincheng121 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885098#comment-15885098
]
godfrey he edited comment on FLINK-5859 at 2/27/17 6:10 AM:
Hi, [~fhueske],
[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885188#comment-15885188
]
ASF GitHub Bot commented on FLINK-5791:
---
Github user shuai-xu commented on the issue:
Github user shuai-xu commented on the issue:
https://github.com/apache/flink/pull/3304
hi @tillrohrmann , thank for you careful review. I modify this pr according
to your comments. Adding universal resource profile if no resource profile are
passed to task executor. And for resource
[
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885179#comment-15885179
]
Kurt Young commented on FLINK-5859:
---
Hi [~fhueske], i think your API suggestion is good way to start
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885143#comment-15885143
]
ASF GitHub Bot commented on FLINK-4422:
---
GitHub user jinmingjian opened a pull request:
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3422
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-base
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885129#comment-15885129
]
ASF GitHub Bot commented on FLINK-4422:
---
GitHub user jinmingjian opened a pull request:
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3421
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-0.9
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the
[
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885098#comment-15885098
]
godfrey he edited comment on FLINK-5859 at 2/27/17 4:12 AM:
Hi, [~fhueske],
[
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885098#comment-15885098
]
godfrey he edited comment on FLINK-5859 at 2/27/17 4:08 AM:
Hi, [~fhueske],
[
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885098#comment-15885098
]
godfrey he edited comment on FLINK-5859 at 2/27/17 3:58 AM:
Hi, [~fhueske],
[
https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaoxuan Wang updated FLINK-5768:
-
Description:
Apply new aggregation functions for datastream and dataset tables
This includes:
1.
[
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885098#comment-15885098
]
godfrey he commented on FLINK-5859:
---
Hi, [~fhueske], Thanks for you advice.
IMO, Rules including
[
https://issues.apache.org/jira/browse/FLINK-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaoxuan Wang updated FLINK-5768:
-
Summary: Apply new aggregation functions for datastream and dataset tables
(was: Apply new
Github user jinmingjian commented on the issue:
https://github.com/apache/flink/pull/3420
another way is to modify the API to pass timeInNano. But considering all
references are named with test*. I suggest the conservative fix.
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885089#comment-15885089
]
ASF GitHub Bot commented on FLINK-4422:
---
Github user jinmingjian commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885087#comment-15885087
]
ASF GitHub Bot commented on FLINK-4422:
---
GitHub user jinmingjian opened a pull request:
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3420
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-0.8
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885077#comment-15885077
]
ASF GitHub Bot commented on FLINK-4422:
---
GitHub user jinmingjian opened a pull request:
GitHub user jinmingjian opened a pull request:
https://github.com/apache/flink/pull/3419
[FLINK-4422] Convert all time interval measurements to System.nanoTime() -
flink-connector-kafka-0.10
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885060#comment-15885060
]
ASF GitHub Bot commented on FLINK-5791:
---
Github user shuai-xu commented on a diff in the pull
Github user shuai-xu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r103130387
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -342,6 +346,14 @@ private ContainerLaunchContext
Github user shuai-xu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3304#discussion_r103129000
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -198,9 +197,9 @@ public static
[
https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885051#comment-15885051
]
ASF GitHub Bot commented on FLINK-5791:
---
Github user shuai-xu commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885044#comment-15885044
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user wuchong commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885042#comment-15885042
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user wuchong commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885043#comment-15885043
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user wuchong commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885045#comment-15885045
]
ASF GitHub Bot commented on FLINK-5776:
---
Github user wuchong commented on a diff in the pull
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103126204
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/MapRunnerTest.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103127937
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FlatMapRunner.scala
---
@@ -43,7 +45,15 @@ class FlatMapRunner[IN,
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103127935
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FlatMapRunner.scala
---
@@ -43,7 +45,15 @@ class FlatMapRunner[IN,
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103127459
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/MapRunnerTest.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885019#comment-15885019
]
Xiaogang Shi commented on FLINK-5917:
-
I think it's okay to remove this method. But a better choice is
[
https://issues.apache.org/jira/browse/FLINK-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Biao Liu updated FLINK-5861:
Fix Version/s: 1.3.0
> TaskManager's components support updating JobManagerConnection
>
[
https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885009#comment-15885009
]
ASF GitHub Bot commented on FLINK-5658:
---
Github user hongyuhong commented on a diff in the pull
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r103125615
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSlideEventTimeRowAgg.scala
---
@@ -0,0
[
https://issues.apache.org/jira/browse/FLINK-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885004#comment-15885004
]
ASF GitHub Bot commented on FLINK-5758:
---
Github user barcahead commented on the issue:
Github user barcahead commented on the issue:
https://github.com/apache/flink/pull/3391
@StephanEwen could you help review this pr please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884993#comment-15884993
]
ASF GitHub Bot commented on FLINK-5723:
---
Github user WangTaoTheTonic closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884992#comment-15884992
]
ASF GitHub Bot commented on FLINK-5723:
---
Github user WangTaoTheTonic commented on the issue:
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3274
sure.
Fixed in
- 1.2.1 via e3e3c2a7f9c8dd8576e0e27b2efddb7ff42c7c0d
- 1.3.0 via 03e6c249156fbbfeef39397a70c70bb905469d09
---
If your project is set up for it, you can
Github user WangTaoTheTonic closed the pull request at:
https://github.com/apache/flink/pull/3274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/FLINK-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884991#comment-15884991
]
ASF GitHub Bot commented on FLINK-5803:
---
Github user sunjincheng121 commented on a diff in the pull
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3397#discussion_r103123784
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamOverAggregateRule.scala
---
@@ -0,0
Github user dsnz closed the pull request at:
https://github.com/apache/flink/pull/3250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dsnz commented on the issue:
https://github.com/apache/flink/pull/3250
Hi,
The examples given (by greghogan) are specialized C++ programs. I don't say
that this example shows Flink's capabilities relative to other solutions but
that it's a very helpful for the
[
https://issues.apache.org/jira/browse/FLINK-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884862#comment-15884862
]
Konstantin Knauf commented on FLINK-2922:
-
[~uce] Is there a design doc/branch for current work on
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3250
@dsnz Thanks for this PR. In general, I think it's a good idea to think
about what kind of example programs we have. Unfortunately, I don't think that
this example adds much in comparison to the already
[
https://issues.apache.org/jira/browse/FLINK-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884827#comment-15884827
]
ASF GitHub Bot commented on FLINK-5723:
---
Github user uce commented on the issue:
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3274
@WangTaoTheTonic We forgot to close this PR while merging. Could you please
close this manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884822#comment-15884822
]
ASF GitHub Bot commented on FLINK-5896:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884820#comment-15884820
]
ASF GitHub Bot commented on FLINK-5597:
---
Github user uce commented on the issue:
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3404
Changes read well. +1 to merge.
Small note on JavaDocs and usage of `` tags: I think the common way is
to use `` when the paragraph starts.
```java
/**
* Hyperlink-Induced
[
https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884816#comment-15884816
]
Ufuk Celebi commented on FLINK-5778:
I think your suggestion makes a lot of sense. I will do it as you
[
https://issues.apache.org/jira/browse/FLINK-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884803#comment-15884803
]
ASF GitHub Bot commented on FLINK-3475:
---
Github user docete commented on the issue:
Github user docete commented on the issue:
https://github.com/apache/flink/pull/3111
@fhueske Fixed according to your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
61 matches
Mail list logo
