[GitHub] flink issue #3314: [FLINK-3679] DeserializationSchema should handle zero or ...

2017-03-08 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3314 Yes totally agree. Thanks very much for taking the time to review the PRs. Will do it next time. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3679) Allow Kafka consumer to skip corrupted messages

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902597#comment-15902597 ] ASF GitHub Bot commented on FLINK-3679: --- Github user haohui commented on the issue:

[jira] [Commented] (FLINK-5991) Expose Broadcast Operator State through public APIs

2017-03-08 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902577#comment-15902577 ] Aljoscha Krettek commented on FLINK-5991: - I prefer to only expose it on the operator state store

[GitHub] flink issue #3487: [FLINK-5980] Expose max-parallelism value in RuntimeConte...

2017-03-08 Thread ifndef-SleePy
Github user ifndef-SleePy commented on the issue: https://github.com/apache/flink/pull/3487 Thank you, Stephan and zentol. Good question and suggestion. I didn't consider it too much for batch jobs. Also I think it's a bad idea that naming the variable "numberOfKeyGroups" in

[jira] [Commented] (FLINK-5832) Support for simple hive UDF

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902572#comment-15902572 ] ASF GitHub Bot commented on FLINK-5832: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3456: [FLINK-5832] [table] Support for simple hive UDF

2017-03-08 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3456#discussion_r105095839 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -92,6 +92,11 @@ under the License. +

[jira] [Updated] (FLINK-5995) Get a Exception when creating the ListStateDescriptor with a TypeInformation

2017-03-08 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5995: Component/s: (was: Core) State Backends, Checkpointing

[jira] [Updated] (FLINK-6004) Allow FlinkKinesisConsumer to skip corrupted messages

2017-03-08 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-6004: Component/s: Streaming Connectors > Allow FlinkKinesisConsumer to skip corrupted messages >

[GitHub] flink issue #3314: [FLINK-3679] DeserializationSchema should handle zero or ...

2017-03-08 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3314 @haohui - one suggestion for future contributions for easier reviews: We usually use follow-up commits that addresses review comments, instead of force pushing the whole branch. For reviewers,

[jira] [Commented] (FLINK-3679) Allow Kafka consumer to skip corrupted messages

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902563#comment-15902563 ] ASF GitHub Bot commented on FLINK-3679: --- Github user tzulitai commented on the issue:

[jira] [Updated] (FLINK-6004) Allow FlinkKinesisConsumer to skip corrupted messages

2017-03-08 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6004: --- Description: It is quite clear from the fix of FLINK-3679 that in reality, users

[jira] [Created] (FLINK-6004) Allow FlinkKinesisConsumer to skip corrupted messages

2017-03-08 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-6004: -- Summary: Allow FlinkKinesisConsumer to skip corrupted messages Key: FLINK-6004 URL: https://issues.apache.org/jira/browse/FLINK-6004 Project: Flink

[jira] [Commented] (FLINK-5980) Expose max-parallelism value in RuntimeContext

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902558#comment-15902558 ] ASF GitHub Bot commented on FLINK-5980: --- Github user ifndef-SleePy commented on the issue:

[jira] [Commented] (FLINK-3679) Allow Kafka consumer to skip corrupted messages

2017-03-08 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902554#comment-15902554 ] Tzu-Li (Gordon) Tai commented on FLINK-3679: I'm a bit hesitant whether or not we want to

[GitHub] flink pull request #3314: [FLINK-3679] DeserializationSchema should handle z...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-5583) Support flexible error handling in the Kafka consumer

2017-03-08 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-5583. Resolution: Fixed Fix Version/s: 1.3.0 Resolved for {{master}} with

[jira] [Resolved] (FLINK-3679) Allow Kafka consumer to skip corrupted messages

2017-03-08 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-3679. Resolution: Fixed Fix Version/s: 1.3.0 Resolved for {{master}} with

[jira] [Commented] (FLINK-3679) Allow Kafka consumer to skip corrupted messages

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902546#comment-15902546 ] ASF GitHub Bot commented on FLINK-3679: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4810) Checkpoint Coordinator should fail ExecutionGraph after "n" unsuccessful checkpoints

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902515#comment-15902515 ] ASF GitHub Bot commented on FLINK-4810: --- Github user ramkrish86 commented on the issue:

[GitHub] flink issue #3334: FLINK-4810 Checkpoint Coordinator should fail ExecutionGr...

2017-03-08 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3334 @StephanEwen I saw in another JIRA one of your comment where you talked about refactoring CheckPointcoordinator and Pendingcheckpoint. So you woud this PR to wait till then? --- If your

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902429#comment-15902429 ] ASF GitHub Bot commented on FLINK-4545: --- Github user wenlong88 commented on a diff in the pull

[GitHub] flink pull request #3467: [FLINK-4545] preparations for removing the network...

2017-03-08 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3467#discussion_r105081191 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -265,11 +281,15 @@ public String toString()

[jira] [Commented] (FLINK-5781) Generation HTML from ConfigOption

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902401#comment-15902401 ] ASF GitHub Bot commented on FLINK-5781: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3495: [FLINK-5781] Generation HTML from ConfigOption

2017-03-08 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3495#discussion_r105077753 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java --- @@ -137,6 +153,26 @@ public boolean hasDeprecatedKeys() {

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902390#comment-15902390 ] sunjincheng commented on FLINK-5658: Hi, [~Yuhong_kyo], sounds good to me. The [partitioned] PR[#3397

[jira] [Assigned] (FLINK-5998) Un-fat Hadoop from Flink fat jar

2017-03-08 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai reassigned FLINK-5998: - Assignee: Haohui Mai > Un-fat Hadoop from Flink fat jar > > >

[jira] [Commented] (FLINK-5995) Get a Exception when creating the ListStateDescriptor with a TypeInformation

2017-03-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902363#comment-15902363 ] sunjincheng commented on FLINK-5995: Hi, [~srichter] I would be very grateful If you can give me some

[jira] [Assigned] (FLINK-5053) Incremental / lightweight snapshots for checkpoints

2017-03-08 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaogang Shi reassigned FLINK-5053: --- Assignee: Xiaogang Shi > Incremental / lightweight snapshots for checkpoints >

[GitHub] flink issue #3497: [FLINK-6002] Documentation: 'MacOS X' section in Quicksta...

2017-03-08 Thread clarkyzl
Github user clarkyzl commented on the issue: https://github.com/apache/flink/pull/3497 +1 LGTM. Thanks @phoenixjiangnan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-6002) Documentation: 'MacOS X' under 'Download and Start Flink' in Quickstart page is not rendered correctly

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902328#comment-15902328 ] ASF GitHub Bot commented on FLINK-6002: --- Github user clarkyzl commented on the issue:

[jira] [Commented] (FLINK-5976) Refactoring duplicate Tokenizer in flink-test

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902310#comment-15902310 ] ASF GitHub Bot commented on FLINK-5976: --- Github user liuyuzhong7 commented on the issue:

[GitHub] flink issue #3485: FLINK-5976 [tests] Deduplicate Tokenizer in tests

2017-03-08 Thread liuyuzhong7
Github user liuyuzhong7 commented on the issue: https://github.com/apache/flink/pull/3485 @StephanEwen It's a good idea. We can remove many duplicate code in flink-tests in this way. But I found it also duplicate in other modules. How to solve it in other modules.

[GitHub] flink pull request #3488: [FLINK-5971] [flip-6] Add timeout for registered j...

2017-03-08 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3488#discussion_r105068068 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

2017-03-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822346#comment-15822346 ] Ted Yu edited comment on FLINK-5486 at 3/9/17 1:28 AM: --- Lock on State.bucketStates

[GitHub] flink pull request #3488: [FLINK-5971] [flip-6] Add timeout for registered j...

2017-03-08 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3488#discussion_r105068133 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -28,6 +28,10 @@ @PublicEvolving public class

[jira] [Commented] (FLINK-5971) JobLeaderIdService should time out registered jobs

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902280#comment-15902280 ] ASF GitHub Bot commented on FLINK-5971: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5971) JobLeaderIdService should time out registered jobs

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902279#comment-15902279 ] ASF GitHub Bot commented on FLINK-5971: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5971) JobLeaderIdService should time out registered jobs

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902273#comment-15902273 ] ASF GitHub Bot commented on FLINK-5971: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3488: [FLINK-5971] [flip-6] Add timeout for registered j...

2017-03-08 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3488#discussion_r105067829 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdService.java --- @@ -283,5 +302,31 @@ public void

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-08 Thread Yuhong Hong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902261#comment-15902261 ] Yuhong Hong commented on FLINK-5658: Hi [~sunjincheng121], i agree with you, i have already rewrite

[GitHub] flink pull request #3494: [FLINK-5635] [docker] Improve Docker tooling

2017-03-08 Thread jgrier
Github user jgrier commented on a diff in the pull request: https://github.com/apache/flink/pull/3494#discussion_r105065007 --- Diff: flink-contrib/docker-flink/Dockerfile --- @@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin EXPOSE 8081 EXPOSE 6123 +#

[jira] [Commented] (FLINK-5635) Improve Docker tooling to make it easier to build images and launch Flink via Docker tools

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902248#comment-15902248 ] ASF GitHub Bot commented on FLINK-5635: --- Github user jgrier commented on a diff in the pull request:

[jira] [Comment Edited] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902136#comment-15902136 ] Ismaël Mejía edited comment on FLINK-3026 at 3/8/17 10:59 PM: -- I am

[jira] [Assigned] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismaël Mejía reassigned FLINK-3026: --- Assignee: Patrick Lucas (was: Ismaël Mejía) I am reassigning this to you after the

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902132#comment-15902132 ] ASF GitHub Bot commented on FLINK-5653: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902133#comment-15902133 ] ASF GitHub Bot commented on FLINK-5653: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3443: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3443#discussion_r105045766 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala --- @@ -165,6 +165,11 @@ object FlinkRuleSets {

[GitHub] flink pull request #3443: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3443#discussion_r105046076 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamCalcRule.scala --- @@ -46,6 +52,20 @@ class

[jira] [Created] (FLINK-6003) Change docker image to be based on the openjdk one (debian+alpine)

2017-03-08 Thread JIRA
Ismaël Mejía created FLINK-6003: --- Summary: Change docker image to be based on the openjdk one (debian+alpine) Key: FLINK-6003 URL: https://issues.apache.org/jira/browse/FLINK-6003 Project: Flink

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902113#comment-15902113 ] ASF GitHub Bot commented on FLINK-5654: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3459: [FLINK-5654] Add processing time OVER RANGE BETWEEN x PRE...

2017-03-08 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3459 Hi @huawei-flink, sorry for the long delay. I focused on adding support for retraction to the new UDAGG interface (PR #3470), support for time mode functions (PR #3370, #3425), and the most simple

[GitHub] flink pull request #3493: [FLINK-3026] Publish the flink docker container to...

2017-03-08 Thread iemejia
Github user iemejia closed the pull request at: https://github.com/apache/flink/pull/3493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902108#comment-15902108 ] ASF GitHub Bot commented on FLINK-3026: --- Github user iemejia closed the pull request at:

[jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902107#comment-15902107 ] ASF GitHub Bot commented on FLINK-3026: --- Github user iemejia commented on the issue:

[GitHub] flink issue #3493: [FLINK-3026] Publish the flink docker container to the do...

2017-03-08 Thread iemejia
Github user iemejia commented on the issue: https://github.com/apache/flink/pull/3493 I am closing this to create a new one based on the new JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104730718 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -124,8 +127,26 @@ class

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902047#comment-15902047 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105014912 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -125,11 +126,25 @@ class

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104708548 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -125,11 +126,25 @@ class

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902056#comment-15902056 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902054#comment-15902054 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105029771 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902058#comment-15902058 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902049#comment-15902049 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902055#comment-15902055 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105030757 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902060#comment-15902060 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902064#comment-15902064 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104685724 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala --- @@ -46,6 +46,7 @@ trait CommonCorrelate {

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105029829 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902057#comment-15902057 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104723484 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCorrelate.scala --- @@ -97,18 +103,41 @@ class

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104706099 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902062#comment-15902062 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902051#comment-15902051 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902059#comment-15902059 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902053#comment-15902053 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105030435 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902052#comment-15902052 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902063#comment-15902063 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105023568 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -124,8 +127,26 @@ class

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104729449 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105032956 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902050#comment-15902050 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104730046 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104727584 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetJoin.scala --- @@ -199,10 +200,21 @@ class

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104727744 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetJoin.scala --- @@ -199,10 +200,21 @@ class

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104730153 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902048#comment-15902048 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r104730024 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143 @@

[jira] [Commented] (FLINK-3850) Add forward field annotations to DataSet operators generated by the Table API

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902061#comment-15902061 ] ASF GitHub Bot commented on FLINK-3850: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5942) Harden ZooKeeperStateHandleStore to deal with corrupted data

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901985#comment-15901985 ] ASF GitHub Bot commented on FLINK-5942: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5134) Aggregate ResourceSpec for chained operators when generating job graph

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901990#comment-15901990 ] ASF GitHub Bot commented on FLINK-5134: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3455: [FLINK-5134] [runtime] [FLIP-6] Aggregate ResourceSpec fo...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3455 Sounds very good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-5940) ZooKeeperCompletedCheckpointStore cannot handle broken state handles

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901987#comment-15901987 ] ASF GitHub Bot commented on FLINK-5940: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3451: [backport-1.1] [FLINK-5940] [checkpoint] Harden ZooKeeper...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3451 Fix looks good, but I have a similar comment about the test as for #3446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3447: [FLINK-5942] [checkpoint] Harden ZooKeeperStateHan...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3447#discussion_r105024493 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java --- @@ -240,7 +241,7 @@ public int

[GitHub] flink pull request #3446: [FLINK-5940] [checkpoint] Harden ZooKeeperComplete...

2017-03-08 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3446#discussion_r105021165 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java --- @@ -226,16 +200,43 @@ public

[jira] [Commented] (FLINK-5940) ZooKeeperCompletedCheckpointStore cannot handle broken state handles

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901975#comment-15901975 ] ASF GitHub Bot commented on FLINK-5940: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-6002) Documentation: 'MacOS X' under 'Download and Start Flink' in Quickstart page is not rendered correctly

2017-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901935#comment-15901935 ] ASF GitHub Bot commented on FLINK-6002: --- Github user zentol commented on the issue:

  1   2   3   4   >