[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011790#comment-16011790 ] ASF GitHub Bot commented on FLINK-6539: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011792#comment-16011792 ] ASF GitHub Bot commented on FLINK-6539: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3911#discussion_r116659661 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/Kafka010Example.java --- @@ -17,49 +17,74 @@

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011791#comment-16011791 ] ASF GitHub Bot commented on FLINK-6539: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011793#comment-16011793 ] ASF GitHub Bot commented on FLINK-6539: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3911#discussion_r116659749 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/Kafka010Example.java --- @@ -17,49 +17,74 @@

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3911#discussion_r116659709 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/Kafka010Example.java --- @@ -17,49 +17,74 @@

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011789#comment-16011789 ] ASF GitHub Bot commented on FLINK-6539: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3911#discussion_r116659435 --- Diff: .test-infa/end-to-end-test/test_streaming_kafka010.sh --- @@ -0,0 +1,102 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3911#discussion_r116659967 --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java --- @@ -1,75 +0,0 @@ -/*

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011756#comment-16011756 ] ASF GitHub Bot commented on FLINK-6288: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3901 @zjureel then I would suggest to remove the usage of ExecutorService for the timeout. In what other cases would that be required? --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-6589) ListSerializer should deserialize as ArrayList with size + 1

[ https://issues.apache.org/jira/browse/FLINK-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011678#comment-16011678 ] ASF GitHub Bot commented on FLINK-6589: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3912: [FLINK-6589] [core] Deserialize ArrayList with capacity o...

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3912 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011666#comment-16011666 ] ASF GitHub Bot commented on FLINK-6288: --- Github user zjureel commented on the issue:

[GitHub] flink issue #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3901 Yes, user can config the timeout and retry times to fetch kafka meta beyond the configuration of kafka itself. @tzulitai --- If your project is set up for it, you can reply to this email and have

[jira] [Resolved] (FLINK-5966) Document Running Flink on Kubernetes

[ https://issues.apache.org/jira/browse/FLINK-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] StephenWithPH resolved FLINK-5966. -- Resolution: Duplicate > Document Running Flink on Kubernetes >

[jira] [Commented] (FLINK-5966) Document Running Flink on Kubernetes

[ https://issues.apache.org/jira/browse/FLINK-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011609#comment-16011609 ] StephenWithPH commented on FLINK-5966: -- [~greghogan] It has indeed. I'll mark this as resolved. >

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011596#comment-16011596 ] ASF GitHub Bot commented on FLINK-6462: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3851: [FLINK-6462] [table] Add requiresOver interface for Aggre...

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3851 Hi @fhueske Thank you very much. Honestly, I need more review by myself which can saving the time of other reviewer. Best, SunJincheng --- If your project is set up for it, you

[jira] [Updated] (FLINK-6595) Nested SQL queries do not expose proctime / rowtime attributes

[ https://issues.apache.org/jira/browse/FLINK-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated FLINK-6595: -- Component/s: Table API & SQL > Nested SQL queries do not expose proctime / rowtime attributes >

[jira] [Created] (FLINK-6595) Nested SQL queries do not expose proctime / rowtime attributes

Haohui Mai created FLINK-6595: - Summary: Nested SQL queries do not expose proctime / rowtime attributes Key: FLINK-6595 URL: https://issues.apache.org/jira/browse/FLINK-6595 Project: Flink

[GitHub] flink pull request #3913: [FLINK-6574] Support nested catalogs in ExternalCa...

GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/3913 [FLINK-6574] Support nested catalogs in ExternalCatalog. This PR extends the APIs of the `ExternalCatalog` to support arbitrary nesting within external catalogs. You can merge this pull request

[jira] [Commented] (FLINK-6574) Support nested catalogs in ExternalCatalog

[ https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011528#comment-16011528 ] ASF GitHub Bot commented on FLINK-6574: --- GitHub user haohui opened a pull request:

[jira] [Updated] (FLINK-6574) Support nested catalogs in ExternalCatalog

[ https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated FLINK-6574: -- Summary: Support nested catalogs in ExternalCatalog (was: External catalog should support a single

[jira] [Updated] (FLINK-6574) External catalog should support a single level catalog

[ https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated FLINK-6574: -- Priority: Critical (was: Major) > External catalog should support a single level catalog >

[jira] [Commented] (FLINK-6574) External catalog should support a single level catalog

[ https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011516#comment-16011516 ] Haohui Mai commented on FLINK-6574: --- Raising the priority to critical as it introduces API changes of

[jira] [Created] (FLINK-6594) Implement Flink Dispatcher for Kubernetes

Larry Wu created FLINK-6594: --- Summary: Implement Flink Dispatcher for Kubernetes Key: FLINK-6594 URL: https://issues.apache.org/jira/browse/FLINK-6594 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-6589) ListSerializer should deserialize as ArrayList with size + 1

[ https://issues.apache.org/jira/browse/FLINK-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011428#comment-16011428 ] ASF GitHub Bot commented on FLINK-6589: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #3912: [FLINK-6589] [core] Deserialize ArrayList with cap...

GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3912 [FLINK-6589] [core] Deserialize ArrayList with capacity of size+1 to prevent growth. Several Table API / SQL operators hold records in a `MapState[Long, List[X]]` keyed on a timestamp. When a

[jira] [Commented] (FLINK-6552) Side outputs don't allow differing output types

[ https://issues.apache.org/jira/browse/FLINK-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011407#comment-16011407 ] ASF GitHub Bot commented on FLINK-6552: --- Github user tedyu commented on a diff in the pull request:

[GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...

Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/3885#discussion_r116611287 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -318,9 +318,10 @@ public void

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011297#comment-16011297 ] ASF GitHub Bot commented on FLINK-6462: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011298#comment-16011298 ] ASF GitHub Bot commented on FLINK-6462: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011299#comment-16011299 ] ASF GitHub Bot commented on FLINK-6462: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011296#comment-16011296 ] ASF GitHub Bot commented on FLINK-6462: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011294#comment-16011294 ] ASF GitHub Bot commented on FLINK-6462: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011295#comment-16011295 ] ASF GitHub Bot commented on FLINK-6462: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116592490 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -215,14 +215,22 @@ case class Aggregate(

[GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116593574 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -215,14 +215,22 @@ case class Aggregate(

[GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116592552 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -584,13 +592,22 @@ case class

[GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116595446 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/validation/AggregationsValidationTest.scala --- @@ -20,13

[GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116595353 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -31,6 +31,17 @@ class

[GitHub] flink pull request #3851: [FLINK-6462] [table] Add requiresOver interface fo...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3851#discussion_r116592899 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -215,14 +215,22 @@ case class Aggregate(

[jira] [Commented] (FLINK-6539) Add automated end-to-end tests

[ https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011286#comment-16011286 ] ASF GitHub Bot commented on FLINK-6539: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #3911: [FLINK-6539] Add end-to-end tests

GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/3911 [FLINK-6539] Add end-to-end tests This adds tests that exercise Flink the way a user would: * start/stop cluster using scripts * submit job * Use Flink with a user fat-jar with Kafka

[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3911 R: @rmetzger for review, please 🙂 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Closed] (FLINK-6552) Side outputs don't allow differing output types

[ https://issues.apache.org/jira/browse/FLINK-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-6552. --- Resolution: Fixed Fixed on release-1.3 in 446d651c11a6dd0f78c3b39870d192a09acbe38f Fixed on

[jira] [Commented] (FLINK-6552) Side outputs don't allow differing output types

[ https://issues.apache.org/jira/browse/FLINK-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011278#comment-16011278 ] ASF GitHub Bot commented on FLINK-6552: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-6552) Side outputs don't allow differing output types

[ https://issues.apache.org/jira/browse/FLINK-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011279#comment-16011279 ] ASF GitHub Bot commented on FLINK-6552: --- Github user aljoscha closed the pull request at:

[GitHub] flink pull request #3885: [FLINK-6552] Allow differing types for side output...

Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/3885 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3885: [FLINK-6552] Allow differing types for side outputs

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3885 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-5946) Kinesis Producer uses KPL that orphans threads that consume 100% CPU

[ https://issues.apache.org/jira/browse/FLINK-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011273#comment-16011273 ] Scott Kidder commented on FLINK-5946: - FYI: the pull-request against the Kinesis Producer Library

[jira] [Commented] (FLINK-5898) Race-Condition with Amazon Kinesis KPL

[ https://issues.apache.org/jira/browse/FLINK-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011272#comment-16011272 ] Scott Kidder commented on FLINK-5898: - FYI: the pull-request against the Kinesis Producer Library

[jira] [Commented] (FLINK-6569) flink-table KafkaJsonTableSource example doesn't work

[ https://issues.apache.org/jira/browse/FLINK-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011243#comment-16011243 ] ASF GitHub Bot commented on FLINK-6569: --- Github user haohui commented on the issue:

[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

Github user haohui commented on the issue: https://github.com/apache/flink/pull/3890 My understanding is that the snippet should only depend on the Java version of the API (`ROW_NAMED` in flink-core) instead of the one written in Scala that resides in `flink-table`. Correct? --- If

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011234#comment-16011234 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on the issue:

[GitHub] flink issue #3748: [FLINK-6225] [Cassandra Connector] add CassandraTableSink

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3748 Apart from the above this looks ok to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011231#comment-16011231 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on the issue:

[GitHub] flink issue #3748: [FLINK-6225] [Cassandra Connector] add CassandraTableSink

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3748 You will have to rebase this PR and adjust the tests. I recently modified the cassandra tests to no longer run any actual jobs. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011209#comment-16011209 ] ASF GitHub Bot commented on FLINK-6225: --- Github user haohui commented on the issue:

[GitHub] flink issue #3748: [FLINK-6225] [Cassandra Connector] add CassandraTableSink

Github user haohui commented on the issue: https://github.com/apache/flink/pull/3748 @zentol can you please take another look? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Assigned] (FLINK-6589) ListSerializer should deserialize as ArrayList with size + 1

[ https://issues.apache.org/jira/browse/FLINK-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-6589: Assignee: Fabian Hueske > ListSerializer should deserialize as ArrayList with size + 1 >

[jira] [Commented] (FLINK-5781) Generation HTML from ConfigOption

[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011090#comment-16011090 ] ASF GitHub Bot commented on FLINK-5781: --- Github user zentol commented on the issue:

[GitHub] flink issue #3495: [FLINK-5781][config] Generation HTML from ConfigOption

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3495 i will make a number of changes before merging it. - added a hack to deal with options using `System.getProperty("java.io.tmpdir")` as the default value - replace `>` and `<` in

[jira] [Updated] (FLINK-6593) Fix Bug in ProctimeAttribute or RowtimeAttribute with join UDTF

[ https://issues.apache.org/jira/browse/FLINK-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6593: -- Component/s: Table API & SQL > Fix Bug in ProctimeAttribute or RowtimeAttribute with join UDTF

[jira] [Commented] (FLINK-5340) Add a metric exposing jobs uptimes

[ https://issues.apache.org/jira/browse/FLINK-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010939#comment-16010939 ] ASF GitHub Bot commented on FLINK-5340: --- Github user zentol commented on the issue:

[GitHub] flink issue #3908: [FLINK-5340] Document job uptime/downtime/restartTime/ful...

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3908 @alpinegizmo That's better, but still a bit unambiguous. The `downtime` only measures since the last time the job went into a non-running state, whereas the description could mean "Total job downtime

[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010894#comment-16010894 ] ASF GitHub Bot commented on FLINK-6462: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3851: [FLINK-6462] [table] Add requiresOver interface for Aggre...

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3851 Thanks for the reviewing. @fhueske Move the check logic from `rule` into `Table API validation` phase make sense to me. That is `Table API validation` ensure the `Semantics` and `rule` ensure

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010856#comment-16010856 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116470594 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,225 @@ +/* +

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010871#comment-16010871 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116524126 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116526993 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010876#comment-16010876 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010877#comment-16010877 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116539089 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortITCase.scala --- @@ -0,0 +1,133 @@ +/* + *

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010843#comment-16010843 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116519208 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116468573 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116527214 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010870#comment-16010870 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116482152 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeSortProcessFunction.scala --- @@ -0,0 +1,169 @@

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116475931 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala --- @@ -0,0 +1,72 @@ +/*

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010866#comment-16010866 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010859#comment-16010859 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116478698 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeSortProcessFunction.scala --- @@ -0,0 +1,127 @@

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010834#comment-16010834 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010838#comment-16010838 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010840#comment-16010840 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116521402 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116527674 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,345 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010872#comment-16010872 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116540900 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortTest.scala --- @@ -0,0 +1,89 @@ +/* + *

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010846#comment-16010846 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116478528 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeSortProcessFunction.scala --- @@ -0,0 +1,127 @@

[GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3889#discussion_r116481878 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeSortProcessFunction.scala --- @@ -0,0 +1,169 @@

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010869#comment-16010869 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010874#comment-16010874 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in the pull

  1   2   3   4   5   >