[jira] [Commented] (FLINK-7428) avoid one additional buffer copy when receiving messages

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154848#comment-16154848 ] ASF GitHub Bot commented on FLINK-7428: --- Github user KurtYoung commented on the issu

[GitHub] flink issue #4529: [FLINK-7428][network] avoid buffer copies when receiving ...

2017-09-05 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/4529 If I remember correctly, the reason we chose to do an extra copy inside `extractFrame` is that we faced some memory problem when using `slice`. Is this no longer an issue or have taken care by anot

[jira] [Created] (FLINK-7591) Support partition by and order by of MATCH_RECOGNIZE

2017-09-05 Thread Dian Fu (JIRA)
Dian Fu created FLINK-7591: -- Summary: Support partition by and order by of MATCH_RECOGNIZE Key: FLINK-7591 URL: https://issues.apache.org/jira/browse/FLINK-7591 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-05 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154802#comment-16154802 ] Shuyi Chen commented on FLINK-7491: --- Thanks a lot, [~fhueske]. > Support COLLECT Aggreg

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154789#comment-16154789 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137168799 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/* +

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154753#comment-16154753 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137163327 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/* +

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154719#comment-16154719 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137158818 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/* +

[jira] [Commented] (FLINK-7310) always use HybridMemorySegment

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154711#comment-16154711 ] ASF GitHub Bot commented on FLINK-7310: --- Github user KurtYoung commented on the issu

[GitHub] flink issue #4445: [FLINK-7310][core] always use the HybridMemorySegment

2017-09-05 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/4445 I would bet on deserialization for it. And why sorter suffers more regression than hash join is that sorter will cause more deserializations during compare records than hash join. Despite

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154655#comment-16154655 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137150128 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala --- @@ -115,10 +118,15 @@ object WindowJoinUtil

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154622#comment-16154622 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137146303 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -184,4 +195,54 @@ class Da

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154604#comment-16154604 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137144634 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -184,4 +195,54 @@ class Da

[jira] [Commented] (FLINK-7439) Support variable arguments for UDTF in SQL

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154594#comment-16154594 ] ASF GitHub Bot commented on FLINK-7439: --- Github user sunjincheng121 commented on the

[GitHub] flink issue #4536: [FLINK-7439] [table] Support variable arguments for UDTF ...

2017-09-05 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4536 Thanks for the updating, looks good to me. +1 to merged. ---

[jira] [Commented] (FLINK-6465) support FIRST_VALUE on Table API & SQL

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154583#comment-16154583 ] ASF GitHub Bot commented on FLINK-6465: --- Github user sunjincheng121 commented on a d

[GitHub] flink pull request #4556: [FLINK-6465][table]support FIRST_VALUE on Table AP...

2017-09-05 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4556#discussion_r137142537 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/FirstValueAggFunctionWithRetract.scala --- @@ -0,0

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137137915 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala --- @@ -55,8 +55,10 @@ class

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154540#comment-16154540 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in th

[GitHub] flink issue #4625: [FLINK-6233] [table] Support time-bounded stream inner jo...

2017-09-05 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/4625 Thanks for the review, @fhueske. This PR is a little rough when I committed. I'll address your comments and submit a refined version as soon as possible. Best, Xingcan ---

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154530#comment-16154530 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on the issue:

[jira] [Updated] (FLINK-7590) Flink failed to flush and close the file system output stream for checkpointing because of s3 read timeout

2017-09-05 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7590: Summary: Flink failed to flush and close the file system output stream for checkpointing because of s3 read

[jira] [Created] (FLINK-7590) Flink failed to flush and close the file system output stream for checkpointing

2017-09-05 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7590: --- Summary: Flink failed to flush and close the file system output stream for checkpointing Key: FLINK-7590 URL: https://issues.apache.org/jira/browse/FLINK-7590 Project: Flink

[jira] [Created] (FLINK-7589) org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536)

2017-09-05 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7589: --- Summary: org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 159764230; received: 64638536) Key: FLINK-7589 URL: https://issues.apa

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154413#comment-16154413 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154417#comment-16154417 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154405#comment-16154405 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154422#comment-16154422 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154412#comment-16154412 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154424#comment-16154424 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154416#comment-16154416 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154421#comment-16154421 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154419#comment-16154419 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154393#comment-16154393 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154395#comment-16154395 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154415#comment-16154415 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154379#comment-16154379 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154404#comment-16154404 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154396#comment-16154396 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154420#comment-16154420 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154411#comment-16154411 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154400#comment-16154400 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154381#comment-16154381 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154402#comment-16154402 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154414#comment-16154414 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137110758 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154423#comment-16154423 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154418#comment-16154418 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154407#comment-16154407 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137099832 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137040219 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137095404 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137098896 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154397#comment-16154397 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137096261 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154383#comment-16154383 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154406#comment-16154406 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137112342 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154403#comment-16154403 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137039075 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154391#comment-16154391 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137040050 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137038607 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137117454 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154408#comment-16154408 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154389#comment-16154389 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154392#comment-16154392 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137031980 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala --- @@ -115,10 +118,15 @@ object WindowJoinUti

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137035608 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154380#comment-16154380 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154386#comment-16154386 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137038433 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137041142 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137037638 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154388#comment-16154388 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137013584 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -184,4 +195,54 @@ class

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154399#comment-16154399 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154394#comment-16154394 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137120634 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137108027 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137014641 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala --- @@ -184,4 +195,54 @@ class

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154387#comment-16154387 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137100691 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154410#comment-16154410 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137040311 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137113304 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154382#comment-16154382 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137010384 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala --- @@ -55,8 +55,10 @@ clas

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137020297 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala --- @@ -39,14 +39,17 @@ import scala.collectio

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154390#comment-16154390 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154409#comment-16154409 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154401#comment-16154401 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154398#comment-16154398 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154384#comment-16154384 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r137092951 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,533 @@ +/*

  1   2   3   >