[
https://issues.apache.org/jira/browse/FLINK-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178534#comment-16178534
]
ASF GitHub Bot commented on FLINK-6703:
---
Github user bowenli86 closed the pull request at:
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4684
Sorry, I realized I used the wrong jira ticket number. I'm closing this
one, and the new PR is at https://github.com/apache/flink/pull/4721
---
[
https://issues.apache.org/jira/browse/FLINK-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178533#comment-16178533
]
ASF GitHub Bot commented on FLINK-6703:
---
Github user bowenli86 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178532#comment-16178532
]
ASF GitHub Bot commented on FLINK-6703:
---
GitHub user bowenli86 opened a pull request:
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/4684
---
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4721
[FLINK-6703][savepoint/doc] Document how to take a savepoint on YARN
## What is the purpose of the change
The documentation should have a separate entry for savepoint related CLI
[
https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-7394:
Summary: Manage exclusive buffers in RemoteInputChannel (was: Implement
basic InputChannel for
[
https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-7394:
Description:
This is a part of work for credit-based network flow control.
The basic works are:
*
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178493#comment-16178493
]
mingleizhang commented on FLINK-3829:
-
[~yew1eb] Me to. You are very welcome ~
> flink-java
>
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178487#comment-16178487
]
Hai Zhou_UTC+8 commented on FLINK-3829:
---
Ha ha, [~mingleizhang] you are interesting, I am very happy
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178484#comment-16178484
]
mingleizhang commented on FLINK-3829:
-
Hey,[~yew1eb] I am also a newbie. So, that is WHY I am angry.
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178480#comment-16178480
]
Hai Zhou_UTC+8 commented on FLINK-3829:
---
[~mingleizhang], Thank you very much, can you tell me why
GitHub user yaochunnian opened a pull request:
https://github.com/apache/flink/pull/4720
Release 1.3.2 rc3
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178461#comment-16178461
]
mingleizhang commented on FLINK-3829:
-
[~yew1eb] I was not pointing to this jira. You know what jira
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178454#comment-16178454
]
Hai Zhou_UTC+8 commented on FLINK-3829:
---
[~mingleizhang], I do not know what to say:P
Long ago,
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang reassigned FLINK-3829:
---
Assignee: (was: mingleizhang)
> flink-java
> --
>
> Key:
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178437#comment-16178437
]
mingleizhang commented on FLINK-3829:
-
Hey, [~yew1eb] You can assign it to yourself now as I find you
[
https://issues.apache.org/jira/browse/FLINK-7393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178436#comment-16178436
]
ASF GitHub Bot commented on FLINK-7393:
---
Github user bowenli86 commented on the issue:
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4708
cc @tzulitai
---
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang reassigned FLINK-3829:
---
Assignee: mingleizhang
> flink-java
> --
>
> Key: FLINK-3829
>
[
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178428#comment-16178428
]
mingleizhang commented on FLINK-6444:
-
Hey, [~yew1eb]. I think you can just use reflections do it in a
[
https://issues.apache.org/jira/browse/FLINK-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178409#comment-16178409
]
Luffy Tsai edited comment on FLINK-4004 at 9/25/17 12:06 AM:
-
Hi,
Before I
[
https://issues.apache.org/jira/browse/FLINK-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178409#comment-16178409
]
Luffy Tsai edited comment on FLINK-4004 at 9/25/17 12:05 AM:
-
Hi,
Before I
[
https://issues.apache.org/jira/browse/FLINK-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178409#comment-16178409
]
Luffy Tsai commented on FLINK-4004:
---
Hi,
Before I started working, I thought the solution of the issue
[
https://issues.apache.org/jira/browse/FLINK-7488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-7488:
--
Description:
{code}
[
https://issues.apache.org/jira/browse/FLINK-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-7495:
--
Description:
{code}
recoveredStreamElements = context
.getOperatorStateStore()
[
https://issues.apache.org/jira/browse/FLINK-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated FLINK-7525:
--
Description:
In this email thread
[
https://issues.apache.org/jira/browse/FLINK-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178375#comment-16178375
]
Ted Yu commented on FLINK-7631:
---
Looking at rest of the class, the use of uniformlyDistributedScore doesn't
[
https://issues.apache.org/jira/browse/FLINK-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu resolved FLINK-6333.
---
Resolution: Later
> Utilize Bloomfilters in RocksDb
> ---
>
>
Github user heytitle commented on the pull request:
https://github.com/apache/flink/commit/9016cce503b4d471b5a49f0abccc196945ada97e#commitcomment-24529391
In
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java:
In
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Thanks @fhueske and @heytitle!
Most of the comments have been addressed. The two outstanding issues are
1. Addressing
https://github.com/apache/flink/pull/3511#discussion_r139933797
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140664772
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Oh, you are right @heytitle, thanks! Fixed in
9016cce503b4d471b5a49f0abccc196945ada97e
These `WeakReferences` are scary :)
---
Github user heytitle commented on the pull request:
https://github.com/apache/flink/commit/cce40c5cd4aaff446bb4bec8918d2fda37649e0a#commitcomment-24528598
In
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java:
In
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140664033
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663665
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663639
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java
---
@@ -0,0 +1,424 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178304#comment-16178304
]
ASF GitHub Bot commented on FLINK-3829:
---
GitHub user yew1eb opened a pull request:
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663635
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java
---
@@ -0,0 +1,424 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178302#comment-16178302
]
ASF GitHub Bot commented on FLINK-7680:
---
Github user ggevay commented on a diff in the pull request:
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4719
[FLINK-3829][build] POM Cleanup flink-java
## What is the purpose of the change
This PR changes the flink-java pom to
- not contain unused dependencies
- contain all used
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663591
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663593
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java
---
@@ -309,7 +309,7 @@ public boolean write(T
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663604
--- Diff: flink-runtime/pom.xml ---
@@ -204,6 +204,18 @@ under the License.
reflections
+
+
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663599
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/TemplateManager.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663596
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -127,6 +127,12 @@
private long autoWatermarkInterval = 0;
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663603
--- Diff: flink-runtime/pom.xml ---
@@ -204,6 +204,18 @@ under the License.
reflections
+
+
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663585
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178296#comment-16178296
]
ASF GitHub Bot commented on FLINK-3832:
---
GitHub user yew1eb opened a pull request:
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4718
[FLINK-3832][build] POM Cleanup flink-streaming-scala
## What is the purpose of the change
This PR changes the flink-streaming-scala pom to
- not contain unused dependencies
-
Gabor Gevay created FLINK-7680:
--
Summary: Add "Performance Tuning" section to docs
Key: FLINK-7680
URL: https://issues.apache.org/jira/browse/FLINK-7680
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 updated FLINK-3832:
--
Description:
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @
[
https://issues.apache.org/jira/browse/FLINK-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178295#comment-16178295
]
ASF GitHub Bot commented on FLINK-3831:
---
GitHub user yew1eb opened a pull request:
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4717
[FLINK-3831][build] POM Cleanup flink-streaming-java
## What is the purpose of the change
This PR changes the flink-streaming-java pom to
- not contain unused dependencies
- contain
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140662898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4716
[FLINK-3833][build] POM Cleanup flink-test-utils
## What is the purpose of the change
This PR changes the flink-test-utils pom to
- not contain unused dependencies
- contain all used
[
https://issues.apache.org/jira/browse/FLINK-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178292#comment-16178292
]
ASF GitHub Bot commented on FLINK-3833:
---
GitHub user yew1eb opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 updated FLINK-3833:
--
Description:
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @
[
https://issues.apache.org/jira/browse/FLINK-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178285#comment-16178285
]
ASF GitHub Bot commented on FLINK-3830:
---
GitHub user yew1eb opened a pull request:
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140662538
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4715
[FLINK-3830][build] POM Cleanup flink-scala
## What is the purpose of the change
This PR changes the flink-scala pom to
- not contain unused dependencies
- contain all used
[
https://issues.apache.org/jira/browse/FLINK-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 updated FLINK-3830:
--
Description:
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @
flink-scala_2.11
[
https://issues.apache.org/jira/browse/FLINK-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178283#comment-16178283
]
ASF GitHub Bot commented on FLINK-7577:
---
GitHub user yew1eb opened a pull request:
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4714
[FLINK-7577][build] POM Cleanup flink-core
## What is the purpose of the change
This PR changes the flink-core pom to
- not contain unused dependencies
- contain all used
[
https://issues.apache.org/jira/browse/FLINK-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178281#comment-16178281
]
ASF GitHub Bot commented on FLINK-3828:
---
GitHub user yew1eb opened a pull request:
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4713
[FLINK-3828][build] POM Cleanup flink-runtime
## What is the purpose of the change
This PR changes the flink-runtime pom to
not contain unused dependencies
contain all used
[
https://issues.apache.org/jira/browse/FLINK-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 reassigned FLINK-3834:
-
Assignee: Chesnay Schepler (was: Hai Zhou_UTC+8)
> flink-statebackend-rocksdb
>
[
https://issues.apache.org/jira/browse/FLINK-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 closed FLINK-3834.
-
Resolution: Fixed
> flink-statebackend-rocksdb
> --
>
>
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4712
fix flink-clients undeclared/unused dependencies
## What is the purpose of the change
This PR changes the flink-clients pom to
- not contain unused dependencies
- contain all used
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140660299
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140660095
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -81,6 +81,7 @@
*/
private
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140659933
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178254#comment-16178254
]
Hai Zhou_UTC+8 edited comment on FLINK-6444 at 9/24/17 3:43 PM:
[
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178254#comment-16178254
]
Hai Zhou_UTC+8 edited comment on FLINK-6444 at 9/24/17 3:42 PM:
[
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178254#comment-16178254
]
Hai Zhou_UTC+8 commented on FLINK-6444:
---
[~StephanEwen] I implemented a maven module
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140659544
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java
---
@@ -190,6 +190,7 @@ private String
[
https://issues.apache.org/jira/browse/FLINK-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-7677.
--
> Add side outputs to ProcessWindowFunction
> -
>
>
[
https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178209#comment-16178209
]
ASF GitHub Bot commented on FLINK-6233:
---
Github user xccui commented on the issue:
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4625
Hi @fhueske, the PR has been updated. Temporarily, I keep the logic for
dealing with the late data, as well as the fine-grained cache.
For the late data semantics problem, I think we need to
[
https://issues.apache.org/jira/browse/FLINK-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 reassigned FLINK-3834:
-
Assignee: Hai Zhou_UTC+8
> flink-statebackend-rocksdb
> --
>
>
[
https://issues.apache.org/jira/browse/FLINK-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 reassigned FLINK-3833:
-
Assignee: Hai Zhou_UTC+8
> flink-test-utils
>
>
> Key:
[
https://issues.apache.org/jira/browse/FLINK-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 reassigned FLINK-3830:
-
Assignee: Hai Zhou_UTC+8
> flink-scala
> ---
>
> Key: FLINK-3830
[
https://issues.apache.org/jira/browse/FLINK-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hai Zhou_UTC+8 reassigned FLINK-3832:
-
Assignee: Hai Zhou_UTC+8
> flink-streaming-scala
> -
>
>
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178152#comment-16178152
]
mingleizhang commented on FLINK-3829:
-
Hey, [~till.rohrmann] One thing that I should mention it, most
[
https://issues.apache.org/jira/browse/FLINK-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178140#comment-16178140
]
ASF GitHub Bot commented on FLINK-5944:
---
Github user mlipkovich commented on a diff in the pull
Github user mlipkovich commented on a diff in the pull request:
https://github.com/apache/flink/pull/4683#discussion_r140652438
--- Diff: flink-core/pom.xml ---
@@ -52,6 +52,12 @@ under the License.
flink-shaded-asm
+
[
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang updated FLINK-3829:
Description:
{noformat}
[WARNING] Used undeclared dependencies found:
[WARNING]
[
https://issues.apache.org/jira/browse/FLINK-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang updated FLINK-3986:
Description: The readFileStream(String filePath, long intervalMillis,
WatchType watchType) has to
[
https://issues.apache.org/jira/browse/FLINK-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178126#comment-16178126
]
mingleizhang commented on FLINK-3986:
-
I would like to work on this. Just not sure which way we choose
[
https://issues.apache.org/jira/browse/FLINK-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178113#comment-16178113
]
ASF GitHub Bot commented on FLINK-5944:
---
Github user haohui commented on a diff in the pull request:
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4683#discussion_r140649772
--- Diff: flink-core/pom.xml ---
@@ -52,6 +52,12 @@ under the License.
flink-shaded-asm
+
+
[
https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178107#comment-16178107
]
ASF GitHub Bot commented on FLINK-7446:
---
Github user haohui commented on the issue:
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/4710
LGTM overall +1.
One question: since we now cast `ROWTIME` / `PROCTIME` directly to `LONG`,
I wonder, do we want to revisit the decision that creates dedicated types for
`ROWTIME` /
93 matches
Mail list logo
