[GitHub] flink issue #4935: [Flink-7945][Metrics]Fix per partition-lag metr...

2017-11-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4935 Hi @Aitozi, sorry for the long delay in relaying back to this PR. I'm still not convinced that this is a sane solution. For example, what is a "good" setting for the `KEY_REGISTER_TIMES`

[GitHub] flink issue #5017: [FLINK-8076] Upgrade KinesisProducer to 0.10.6 to set pro...

2017-11-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5017 Merging ... ---

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270326#comment-16270326 ] ASF GitHub Bot commented on FLINK-8076: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5075: [hotfix] [docs] Fix typos in State Backends doc

2017-11-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5075 Thanks! Merging this .. ---

[jira] [Commented] (FLINK-8027) Generalize existing rest handlers to work with arbitrary RestfulGateway

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270313#comment-16270313 ] ASF GitHub Bot commented on FLINK-8027: --- Github user shuai-xu commented on a diff in the pull

[GitHub] flink pull request #4985: [FLINK-8027] Generalize existing rest handlers to ...

2017-11-28 Thread shuai-xu
Github user shuai-xu commented on a diff in the pull request: https://github.com/apache/flink/pull/4985#discussion_r153708910 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java --- @@ -0,0 +1,124 @@ +/* + * Licensed

[jira] [Closed] (FLINK-7976) bump japicmp-maven-plugin version in Flink

2017-11-28 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-7976. --- Resolution: Duplicate > bump japicmp-maven-plugin version in Flink >

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-11-28 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270227#comment-16270227 ] Bowen Li commented on FLINK-5544: - [~xiaogang.shi] [~srichter] what's the status of this story, guys? >

[jira] [Commented] (FLINK-8061) Remove trailing asterisk in QueryableStateClient javadocs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270123#comment-16270123 ] ASF GitHub Bot commented on FLINK-8061: --- Github user vetriselvan1187 closed the pull request at:

[GitHub] flink pull request #5008: [FLINK-8061] [Queryable State] removed trailing as...

2017-11-28 Thread vetriselvan1187
Github user vetriselvan1187 closed the pull request at: https://github.com/apache/flink/pull/5008 ---

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270116#comment-16270116 ] ASF GitHub Bot commented on FLINK-8158: --- Github user xccui commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-28 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5094 Hi @hequn8128, let me try to explain this. 1. In current implementation, the join process just relies on the cached rows instead of the watermarks. Specifically, when receiving a record, the

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270090#comment-16270090 ] ASF GitHub Bot commented on FLINK-8158: --- Github user hequn8128 commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-28 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5094 Hi @xccui , thanks for your reply. Feel free to take it if you wish. I still have some confusions. 1. Considering the test `testRowTimeJoinWithCommonBounds2` in `JoinHarnessTest`, do you mean

[jira] [Commented] (FLINK-7692) Support user-defined variables in Metrics

2017-11-28 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269921#comment-16269921 ] Wei-Che Wei commented on FLINK-7692: [~Zentol] This idea is much better. I would like to keep working

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269617#comment-16269617 ] ASF GitHub Bot commented on FLINK-7574: --- Github user zentol commented on the issue:

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5076 These should generally be pretty safe changes to make IMO, and well worth it. In particular the undeclared usage of transitive dependencies (that may be shaded) frequently caused headaches, and

[GitHub] flink pull request #4383: [hotfix] [optimizer] Normalize job plan operator f...

2017-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4383 ---

[jira] [Closed] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-11-28 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6864. - Resolution: Implemented master: 450b4241404055ed6638e354be421b83380827c5 > Remove confusing "invalid

[jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269526#comment-16269526 ] ASF GitHub Bot commented on FLINK-6864: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4574: [FLINK-6864] Fix confusing "invalid POJO type" mes...

2017-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4574 ---

[jira] [Commented] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2017-11-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269508#comment-16269508 ] Chesnay Schepler commented on FLINK-6053: - We can't properly subsume the existing gauge type until

[jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269491#comment-16269491 ] ASF GitHub Bot commented on FLINK-6864: --- Github user greghogan commented on the issue:

[jira] [Updated] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-11-28 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6864: -- Fix Version/s: 1.5.0 > Remove confusing "invalid POJO type" messages from TypeExtractor >

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4574 @zjureel am merging this ... thanks for the PR and edits! ---

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4383 @zentol @fhueske I am merging the change with the extra space since this looks to have been the original intent. I've looked at both forms without finding a strong preference. ---

[jira] [Updated] (FLINK-8164) JobManager's archiving does not work on S3

2017-11-28 Thread Cristian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cristian updated FLINK-8164: Description: I'm trying to configure JobManager's archiving mechanism

[jira] [Updated] (FLINK-8164) JobManager's archiving does not work on S3

2017-11-28 Thread Cristian (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cristian updated FLINK-8164: Description: I'm trying to configure JobManager's archiving mechanism

[jira] [Created] (FLINK-8164) JobManager's archiving does not work on S3

2017-11-28 Thread Cristian (JIRA)
Cristian created FLINK-8164: --- Summary: JobManager's archiving does not work on S3 Key: FLINK-8164 URL: https://issues.apache.org/jira/browse/FLINK-8164 Project: Flink Issue Type: Bug

[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-11-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4374 but honestly, the previous approach just looks wrong: adding it and in case of a conflict reverting that `put` operation. What if (and I'm walking in the dark here) something already operates on

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269114#comment-16269114 ] ASF GitHub Bot commented on FLINK-7468: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269116#comment-16269116 ] ASF GitHub Bot commented on FLINK-7468: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269115#comment-16269115 ] ASF GitHub Bot commented on FLINK-7468: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269117#comment-16269117 ] ASF GitHub Bot commented on FLINK-7468: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269118#comment-16269118 ] ASF GitHub Bot commented on FLINK-7468: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

2017-11-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r153564080 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java --- @@ -114,7 +116,7 @@ public void

[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

2017-11-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r153564859 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java --- @@ -22,32 +22,52 @@ import

[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

2017-11-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r153563915 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java --- @@ -39,13 +39,15 @@ private

[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

2017-11-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r153564111 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java --- @@ -174,19 +175,21 @@ public

[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

2017-11-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r153564062 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java --- @@ -133,7 +135,7 @@ int

[jira] [Commented] (FLINK-8151) [Table] removing map value equality check

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269092#comment-16269092 ] ASF GitHub Bot commented on FLINK-8151: --- Github user walterddr commented on a diff in the pull

[jira] [Commented] (FLINK-8151) [Table] removing map value equality check

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269090#comment-16269090 ] ASF GitHub Bot commented on FLINK-8151: --- Github user walterddr commented on a diff in the pull

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-28 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5070#discussion_r153566048 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -188,13 +188,6 @@ object

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-28 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5070#discussion_r153566038 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/MapTypeTest.scala --- @@ -139,13 +139,6 @@ class MapTypeTest

[jira] [Commented] (FLINK-8104) Fix Row value constructor

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269082#comment-16269082 ] ASF GitHub Bot commented on FLINK-8104: --- Github user walterddr commented on the issue:

[GitHub] flink issue #5040: [FLINK-8104][Table API] fixing ROW type value constructor...

2017-11-28 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5040 Thanks @twalthr for confirming, I will also add in the documentation today then. ---

[jira] [Assigned] (FLINK-8119) Cannot submit jobs to YARN Session in FLIP-6 mode

2017-11-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-8119: Assignee: Till Rohrmann > Cannot submit jobs to YARN Session in FLIP-6 mode >

[jira] [Commented] (FLINK-5789) Make Bucketing Sink independent of Hadoop's FileSystem

2017-11-28 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269041#comment-16269041 ] Stephan Ewen commented on FLINK-5789: - We may want to add further abstractions to the file system.

[GitHub] flink pull request #:

2017-11-28 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/commit/c940d5eff9897796625a696ed2989aed52c39ebd#commitcomment-25902242 In tools/releasing/create_source_release.sh: In tools/releasing/create_source_release.sh on line 60: could, but that's not

[jira] [Commented] (FLINK-7918) Run AbstractTestBase tests on Flip-6 MiniCluster

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269039#comment-16269039 ] ASF GitHub Bot commented on FLINK-7918: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5095: [FLINK-7918] Run AbstractTestBase tests on Flip-6 ...

2017-11-28 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5095 [FLINK-7918] Run AbstractTestBase tests on Flip-6 MiniCluster ## What is the purpose of the change Extend `MiniClusterResource` to instantiate a Flip-6 `MiniCluster` if the system

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268970#comment-16268970 ] ASF GitHub Bot commented on FLINK-8158: --- Github user xccui commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-28 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5094 Hi @hequn8128, thanks for looking into this. I've checked the current implementation and found that it really may emit late data. However, that was caused by the checkings below:

[jira] [Commented] (FLINK-7300) End-to-end tests are instable on Travis

2017-11-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268948#comment-16268948 ] Till Rohrmann commented on FLINK-7300: -- Another instance of instable Kafka end-to-end tests:

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268907#comment-16268907 ] ASF GitHub Bot commented on FLINK-8150: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268908#comment-16268908 ] ASF GitHub Bot commented on FLINK-8150: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5093: [FLINK-8150] [flip6] Expose TaskExecutor's ResourceID as ...

2017-11-28 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5093 Thanks for the review @GJL. ---

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153524341 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/ResourceIDSerializer.java --- @@ -29,16 +30,16 @@ /** *

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268905#comment-16268905 ] ASF GitHub Bot commented on FLINK-8150: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268903#comment-16268903 ] ASF GitHub Bot commented on FLINK-8150: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153524087 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerInfo.java --- @@ -53,8 +53,8 @@ public

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153524037 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerDetailsInfo.java --- @@ -43,7 +43,7 @@

[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4374 @RebornHuan although this change looks to be correct and makes good use of the newer API, there is a trade-off between deleting a line of code called during an error condition and the risk of such

[jira] [Commented] (FLINK-7608) LatencyGauge change to histogram metric

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268878#comment-16268878 ] ASF GitHub Bot commented on FLINK-7608: --- Github user zentol commented on the issue:

[GitHub] flink issue #4826: [FLINK-7608][metric] Refactor latency statistics metric

2017-11-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4826 So here's the thing: The port of the metric itself is good, and exactly what i want 👍 . What I'm unsatisfied with is the naming of the metric, but that isn't the fault of this PR but a limitation

[jira] [Commented] (FLINK-7692) Support user-defined variables in Metrics

2017-11-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268863#comment-16268863 ] Chesnay Schepler commented on FLINK-7692: - Let me know what you think, and whether you would like

[jira] [Commented] (FLINK-7692) Support user-defined variables in Metrics

2017-11-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268861#comment-16268861 ] Chesnay Schepler commented on FLINK-7692: - [~tonywei] Those are good points, luckily we can

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268841#comment-16268841 ] ASF GitHub Bot commented on FLINK-7574: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r153511839 --- Diff: pom.xml --- @@ -891,6 +905,41 @@ under the License. + +

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268805#comment-16268805 ] ASF GitHub Bot commented on FLINK-7574: --- Github user greghogan commented on a diff in the pull

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268804#comment-16268804 ] ASF GitHub Bot commented on FLINK-7574: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r153503257 --- Diff: pom.xml --- @@ -891,6 +905,41 @@ under the License. + +

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r153500167 --- Diff: pom.xml --- @@ -891,6 +905,41 @@ under the License. + +

[jira] [Commented] (FLINK-7652) Port CurrentJobIdsHandler to new REST endpoint

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268760#comment-16268760 ] ASF GitHub Bot commented on FLINK-7652: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4734: [FLINK-7652] [flip6] Port CurrentJobIdsHandler to new RES...

2017-11-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4734 Hi @tillrohrmann, this PR is now rebased to the latest master, and reworked to incorporate your last comments. ---

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268738#comment-16268738 ] ASF GitHub Bot commented on FLINK-7873: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153495140 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java --- @@ -0,0 +1,195 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268733#comment-16268733 ] ASF GitHub Bot commented on FLINK-7873: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153493925 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java --- @@ -0,0 +1,195 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268730#comment-16268730 ] ASF GitHub Bot commented on FLINK-7873: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153493396 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -190,6 +199,11 @@ public static

[GitHub] flink issue #4666: [FLINK-7613][Documentation] Fixed typographical error

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4666 @raymondtay are we still looking to make this change? Defining the mapper may be just as likely to confuse new Flink users. Also, when updating future PRs you want to rebase to master

[jira] [Commented] (FLINK-7613) Fix documentation error in QuickStart

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268728#comment-16268728 ] ASF GitHub Bot commented on FLINK-7613: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268727#comment-16268727 ] ASF GitHub Bot commented on FLINK-7873: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153492995 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java --- @@ -510,6 +512,13 @@ private static

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268724#comment-16268724 ] ASF GitHub Bot commented on FLINK-7873: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153492082 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java --- @@ -510,6 +512,13 @@ private static

[jira] [Assigned] (FLINK-7805) Add HA capabilities to YarnResourceManager

2017-11-28 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-7805: --- Assignee: Gary Yao > Add HA capabilities to YarnResourceManager >

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268686#comment-16268686 ] ASF GitHub Bot commented on FLINK-8150: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153483875 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/ResourceIDSerializer.java --- @@ -29,16 +30,16 @@ /** * Json

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268681#comment-16268681 ] ASF GitHub Bot commented on FLINK-8150: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153483098 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerInfo.java --- @@ -53,8 +53,8 @@ public static final

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153482920 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerDetailsInfo.java --- @@ -43,7 +43,7 @@

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268680#comment-16268680 ] ASF GitHub Bot commented on FLINK-8150: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink issue #4504: [FLINK-7395] [metrics] Count bytesIn/Out without synchron...

2017-11-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4504 @NicoK The byte counting in the ResultPartition class looks unrelated to the metric system; in fact that field isn't read anywhere. We may want to remove it, but I wouldn't do that as part of this

[jira] [Commented] (FLINK-7395) NumBytesOut metric in RecordWriter call synchronized method

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268656#comment-16268656 ] ASF GitHub Bot commented on FLINK-7395: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268653#comment-16268653 ] ASF GitHub Bot commented on FLINK-8158: --- GitHub user hequn8128 opened a pull request:

[GitHub] flink pull request #5094: [FLINK-8158] [table] Fix rowtime window inner join...

2017-11-28 Thread hequn8128
GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/5094 [FLINK-8158] [table] Fix rowtime window inner join emits late data bug ## What is the purpose of the change This pull request fixes rowtime window inner join emits late data bug.

[jira] [Commented] (FLINK-8150) WebUI in FLIP-6 mode exposes TaskManagerConnection IDs as TaskManager IDs

2017-11-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268623#comment-16268623 ] ASF GitHub Bot commented on FLINK-8150: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5093 [FLINK-8150] [flip6] Expose TaskExecutor's ResourceID as TaskExecutor id ## What is the purpose of the change Before, the TaskExecutor's InstanceID was exposed as TaskExecutor id. This

  1   2   >