[jira] [Commented] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319856#comment-16319856 ] ASF GitHub Bot commented on FLINK-8399: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #5271: [FLINK-8399] [runtime] use independent configurati...

2018-01-09 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5271 [FLINK-8399] [runtime] use independent configurations for the different timeouts in slot manager ## What is the purpose of the change *This pull request separate the timeouts for

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319846#comment-16319846 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319852#comment-16319852 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319851#comment-16319851 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319847#comment-16319847 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319854#comment-16319854 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319850#comment-16319850 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319853#comment-16319853 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319848#comment-16319848 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319844#comment-16319844 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319845#comment-16319845 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319849#comment-16319849 ] ASF GitHub Bot commented on FLINK-8276: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160608176 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java --- @@

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160607315 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer081.java --- @@ -27,6

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160608074 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowDeserializationSchema.java --- @@

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160608041 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JSONDeserializationSchema.java --- @@

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160607865 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java ---

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160607814 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkFixedPartitioner.java ---

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160607372 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java --- @@ -31,6 +32,7

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160608269 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedSerializationSchema.java --- @@

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160607359 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer082.java --- @@ -27,6

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160608223 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedDeserializationSchema.java --- @@

[GitHub] flink pull request #5173: [FLINK-8276] [kafka connector] Properly annotate A...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5173#discussion_r160608063 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JSONKeyValueDeserializationSchema.java ---

[jira] [Commented] (FLINK-8324) Expose another offsets metrics by using new metric API to specify user defined variables

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319834#comment-16319834 ] ASF GitHub Bot commented on FLINK-8324: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5214: [FLINK-8324] [kafka] Expose another offsets metrics by us...

2018-01-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5214 Good idea. I think we should also update the metrics doc to educate this addition. ---

[jira] [Created] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-09 Thread shuai.xu (JIRA)
shuai.xu created FLINK-8399: --- Summary: Use independent configurations for the different timeouts in slot manager Key: FLINK-8399 URL: https://issues.apache.org/jira/browse/FLINK-8399 Project: Flink

[jira] [Updated] (FLINK-8399) Use independent configurations for the different timeouts in slot manager

2018-01-09 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu updated FLINK-8399: Description: There are three parameter in slot manager to indicate the timeout for slot request to task

[GitHub] flink issue #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitter inter...

2018-01-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5200 Regarding the race condition you mentioned: hmm, I can't seem to exactly nail down the "and only first `successfulCommits.inc()` can be omitted because of that" case you mentioned, could you

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319816#comment-16319816 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319780#comment-16319780 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-8368) Port SubtaskExecutionAttemptDetailsHandler to new REST endpoint

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319778#comment-16319778 ] ASF GitHub Bot commented on FLINK-8368: --- GitHub user ifndef-SleePy opened a pull request:

[GitHub] flink issue #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitter inter...

2018-01-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5200 @pnowojski thanks a lot for your insightful review! regarding the choice of composition or inheritance: actually, in the end I think we should be leaning towards neither of both, and let

[GitHub] flink pull request #5270: [FLINK-8368] [REST] Migrate SubtaskExecutionAttemp...

2018-01-09 Thread ifndef-SleePy
GitHub user ifndef-SleePy opened a pull request: https://github.com/apache/flink/pull/5270 [FLINK-8368] [REST] Migrate SubtaskExecutionAttemptDetailsHandler to new a REST handler ## What is the purpose of the change * Migrate

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319766#comment-16319766 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5200#discussion_r160599433 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319763#comment-16319763 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5200#discussion_r160598939 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java --- @@

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319762#comment-16319762 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319761#comment-16319761 ] ASF GitHub Bot commented on FLINK-8306: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5200#discussion_r16059 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -559,6

[GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...

2018-01-09 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5200#discussion_r160598772 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java --- @@

[jira] [Commented] (FLINK-6004) Allow FlinkKinesisConsumer to skip corrupted messages

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319754#comment-16319754 ] ASF GitHub Bot commented on FLINK-6004: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #5269: [FLINK-6004] [kinesis] Allow FlinkKinesisConsumer ...

2018-01-09 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5269 [FLINK-6004] [kinesis] Allow FlinkKinesisConsumer to skip non-deserializable records ## What is the purpose of the change This PR is based on #5268, which includes fixes to harden Kinesis

[jira] [Commented] (FLINK-8398) Stabilize flaky KinesisDataFetcherTests

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319741#comment-16319741 ] ASF GitHub Bot commented on FLINK-8398: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #5268: [FLINK-8398] [kinesis, tests] Harden KinesisDataFe...

2018-01-09 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5268 [FLINK-8398] [kinesis, tests] Harden KinesisDataFetcherTest unit tests ## What is the purpose of the change Prior to this PR, many of the `KinesisDataFetcherTest` unit tests relied on

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319691#comment-16319691 ] ASF GitHub Bot commented on FLINK-6951: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2018-01-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4150 Merging to `release-1.3` .. ---

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319690#comment-16319690 ] ASF GitHub Bot commented on FLINK-6951: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2018-01-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4150 @casidiablo thanks for the info! I'll merge this for `release-1.3` then, and will keep an extra eye on whether the problem still occurs for 1.4 / 1.5. ---

[jira] [Created] (FLINK-8398) Stabilize flaky KinesisDataFetcherTests

2018-01-09 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-8398: -- Summary: Stabilize flaky KinesisDataFetcherTests Key: FLINK-8398 URL: https://issues.apache.org/jira/browse/FLINK-8398 Project: Flink Issue

[jira] [Comment Edited] (FLINK-7795) Utilize error-prone to discover common coding mistakes

2018-01-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299208#comment-16299208 ] Ted Yu edited comment on FLINK-7795 at 1/10/18 4:08 AM:

[jira] [Commented] (FLINK-4816) Executions failed from "DEPLOYING" should retain restored checkpoint information

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319632#comment-16319632 ] ASF GitHub Bot commented on FLINK-4816: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #4828: [FLINK-4816] [checkpoints] Executions failed from "DEPLOY...

2018-01-09 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/4828 Hi @StephanEwen Let me conclude your comment and clarify some questions in my mind. 1. The original design treated all failures in DEPLOY as restore failure. That is not fair because

[jira] [Assigned] (FLINK-6004) Allow FlinkKinesisConsumer to skip corrupted messages

2018-01-09 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-6004: -- Assignee: Tzu-Li (Gordon) Tai (was: ChungChe Lai) > Allow

[jira] [Commented] (FLINK-6004) Allow FlinkKinesisConsumer to skip corrupted messages

2018-01-09 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319572#comment-16319572 ] Tzu-Li (Gordon) Tai commented on FLINK-6004: Since there's been quite a while since this issue

[jira] [Closed] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2018-01-09 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Che Wei closed FLINK-5982. -- Resolution: Done Fix Version/s: 1.5.0 > Refactor AbstractInvokable and StatefulTask >

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319532#comment-16319532 ] ASF GitHub Bot commented on FLINK-5982: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable and Sta...

2018-01-09 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3633 Thanks a lot for doing these work. Nice to see this PR be merged. =) ---

[jira] [Created] (FLINK-8397) Support ROW type in CassandraOutputFormat

2018-01-09 Thread Shuyi Chen (JIRA)
Shuyi Chen created FLINK-8397: - Summary: Support ROW type in CassandraOutputFormat Key: FLINK-8397 URL: https://issues.apache.org/jira/browse/FLINK-8397 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319445#comment-16319445 ] ASF GitHub Bot commented on FLINK-6951: --- Github user casidiablo commented on the issue:

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2018-01-09 Thread casidiablo
Github user casidiablo commented on the issue: https://github.com/apache/flink/pull/4150 Since EMR only supports Flink 1.3 I had to checkout release-1.3 and compile the connector from there. Then I was getting this `Socket not created by this factory` error. I then patched

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319441#comment-16319441 ] ASF GitHub Bot commented on FLINK-6951: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2018-01-09 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4150 @casidiablo did you mean that without applying this PR's patch, the current master worked for you? Or you had to apply this patch in order for it to work? ---

[jira] [Updated] (FLINK-8396) Create (derived) duplicate Buffer class

2018-01-09 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8396: --- Description: In order to pass a single buffer to netty multiple times, we require a duplicate Buffer

[jira] [Created] (FLINK-8396) Create (derived) duplicate Buffer class

2018-01-09 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8396: -- Summary: Create (derived) duplicate Buffer class Key: FLINK-8396 URL: https://issues.apache.org/jira/browse/FLINK-8396 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-8395) Create (derived) sliced Buffer class

2018-01-09 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-8395: --- Description: In order to pass sub-regions of a single buffer separately, we require a sliced Buffer

[jira] [Created] (FLINK-8395) Create (derived) sliced Buffer class

2018-01-09 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8395: -- Summary: Create (derived) sliced Buffer class Key: FLINK-8395 URL: https://issues.apache.org/jira/browse/FLINK-8395 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319170#comment-16319170 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-09 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160524740 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -150,16 +126,13 @@ */ private boolean

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319158#comment-16319158 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

2018-01-09 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160523676 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the

[jira] [Updated] (FLINK-8394) Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown

2018-01-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8394: -- Issue Type: Test (was: Bug) > Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown >

[jira] [Created] (FLINK-8394) Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown

2018-01-09 Thread Ted Yu (JIRA)
Ted Yu created FLINK-8394: - Summary: Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown Key: FLINK-8394 URL: https://issues.apache.org/jira/browse/FLINK-8394 Project: Flink

[jira] [Commented] (FLINK-8393) Reconnect to last known JobMaster when connection is lost

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319051#comment-16319051 ] ASF GitHub Bot commented on FLINK-8393: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5267: [FLINK-8393] [flip6] Reconnect to last known JobMa...

2018-01-09 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5267 [FLINK-8393] [flip6] Reconnect to last known JobMaster when connection is lost ## What is the purpose of the change Reconnect to the last known location of a lost `JobMaster`

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319049#comment-16319049 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5239: [FLINK-8360] Implement task-local state recovery

2018-01-09 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5239 Thanks for going through the general design @StephanEwen ! As we discussed, I agree with your first point. For the second point about RocksDB, this PR already contains an optimized way to

[jira] [Created] (FLINK-8393) Reconnect to last known JobMaster when connection is lost

2018-01-09 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8393: Summary: Reconnect to last known JobMaster when connection is lost Key: FLINK-8393 URL: https://issues.apache.org/jira/browse/FLINK-8393 Project: Flink

[jira] [Closed] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-09 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-6951. --- Resolution: Invalid Not a problem anymore > Incompatible versions of httpcomponents jars for Flink kinesis

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319021#comment-16319021 ] ASF GitHub Bot commented on FLINK-6951: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

2018-01-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4150 Thanks for confirming. I'll close this ticket and PR ---

[jira] [Closed] (FLINK-8284) Custom metrics not being exposed for Prometheus

2018-01-09 Thread Julio Biason (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julio Biason closed FLINK-8284. --- Resolution: Invalid > Custom metrics not being exposed for Prometheus >

[jira] [Commented] (FLINK-8284) Custom metrics not being exposed for Prometheus

2018-01-09 Thread Julio Biason (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318999#comment-16318999 ] Julio Biason commented on FLINK-8284: - I swear to ${deity} that it didn't work. Restarted the project

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318974#comment-16318974 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5239: [FLINK-8360] Implement task-local state recovery

2018-01-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5239 I did a peer review and walk through the code. Overall, the design look good, +1 for that! Some comments: - I would argue to change the way that these recovery options are

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318913#comment-16318913 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-01-09 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r160492829 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStreamFactory.java --- @@ -43,9 +44,9 @@ CheckpointStateOutputStream

[jira] [Commented] (FLINK-8082) Bump version compatibility check to 1.4

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318906#comment-16318906 ] ASF GitHub Bot commented on FLINK-8082: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5262: [FLINK-8082][build] Bump flink version for japicmp plugin

2018-01-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5262 Fails only with the now fixed "duplicate entry" error in `flink-mesos`, so looks like this is fine. ---

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318879#comment-16318879 ] ASF GitHub Bot commented on FLINK-5982: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable ...

2018-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3633 ---

[jira] [Commented] (FLINK-8350) replace "taskmanager.tmp.dirs" with "env.io.tmp.dirs" for all components

2018-01-09 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318834#comment-16318834 ] Chesnay Schepler commented on FLINK-8350: - I'm not so sure about making {{taskmanager.tmp.dirs}} a

[jira] [Commented] (FLINK-4816) Executions failed from "DEPLOYING" should retain restored checkpoint information

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318827#comment-16318827 ] ASF GitHub Bot commented on FLINK-4816: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4828: [FLINK-4816] [checkpoints] Executions failed from "DEPLOY...

2018-01-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4828 I think this approach is not yet sufficient. There can be various reasons why a failure in DEPLOY happens, failed checkpoint restore is only one of the reasons. This also adds some

[jira] [Commented] (FLINK-8350) replace "taskmanager.tmp.dirs" with "env.io.tmp.dirs" for all components

2018-01-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318819#comment-16318819 ] Stephan Ewen commented on FLINK-8350: - {{io.tmp.dirs}} is fine with me. Please keep the

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318760#comment-16318760 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

2018-01-09 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4963 @StefanRRichter Thanks! I will ---

[jira] [Commented] (FLINK-8392) Simplify termination future completion

2018-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318754#comment-16318754 ] ASF GitHub Bot commented on FLINK-8392: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5266: [FLINK-8392] [rpc] Let termination future be compl...

2018-01-09 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5266 [FLINK-8392] [rpc] Let termination future be completed by AkkaRpcActor#postStop ## What is the purpose of the change Revert the changes introduced by FLINK-7754. An RpcEndpoint's

  1   2   3   >